From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964913AbdKPNyF (ORCPT ); Thu, 16 Nov 2017 08:54:05 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:53659 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933924AbdKPNx7 (ORCPT ); Thu, 16 Nov 2017 08:53:59 -0500 X-Google-Smtp-Source: AGs4zMYKTy1F1EsyT9nPRUtptpyQ0Hbafd+9iiA3qX+5ZiMF1MwVu789WTIlVyQM014D61kTsKN3bFNwjScNAsb5aak= MIME-Version: 1.0 In-Reply-To: References: <20171018164957.2270-1-carlo@caione.org> From: Carlo Caione Date: Thu, 16 Nov 2017 13:53:58 +0000 X-Google-Sender-Auth: klnqTUuO6cvcYGpmP1zyqZAYo1c Message-ID: Subject: Re: [alsa-devel] [PATCH] SoC: intel: byt: Introduce new custom IN2 map To: Pierre-Louis Bossart Cc: Carlo Caione , Linux Upstreaming Team , Liam Girdwood , Mark Brown , alsa-devel@alsa-project.org, open list , Carlo Caione Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart wrote: > On 10/18/17 11:49 AM, Carlo Caione wrote: >> >> From: Carlo Caione >> >> Introduce a new custom dapm routes map to quirk platforms with the >> internal mic connected to IN2P. > > > LGTM. If we start getting more quirks for this codec, we should think of > adding a module parameters to select them from the command line or with > modprobe (as done in other machine drivers). Hey Pierre, I'm currently working on a laptop (always with the rt5651 codec) having two separate internal mics (on IN1P and IN2P) and the headset on IN3P. I was thinking how to describe this situation in the current driver without having to add all the 6 different configuration as quirks. Any suggestion? Cheers, -- Carlo Caione From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carlo Caione Subject: Re: [PATCH] SoC: intel: byt: Introduce new custom IN2 map Date: Thu, 16 Nov 2017 13:53:58 +0000 Message-ID: References: <20171018164957.2270-1-carlo@caione.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by alsa0.perex.cz (Postfix) with ESMTP id 8C40A26710A for ; Thu, 16 Nov 2017 14:54:00 +0100 (CET) Received: by mail-pg0-f65.google.com with SMTP id u3so5489514pgn.7 for ; Thu, 16 Nov 2017 05:54:00 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Pierre-Louis Bossart Cc: alsa-devel@alsa-project.org, Liam Girdwood , open list , Mark Brown , Carlo Caione , Carlo Caione , Linux Upstreaming Team List-Id: alsa-devel@alsa-project.org On Wed, Oct 18, 2017 at 7:05 PM, Pierre-Louis Bossart wrote: > On 10/18/17 11:49 AM, Carlo Caione wrote: >> >> From: Carlo Caione >> >> Introduce a new custom dapm routes map to quirk platforms with the >> internal mic connected to IN2P. > > > LGTM. If we start getting more quirks for this codec, we should think of > adding a module parameters to select them from the command line or with > modprobe (as done in other machine drivers). Hey Pierre, I'm currently working on a laptop (always with the rt5651 codec) having two separate internal mics (on IN1P and IN2P) and the headset on IN3P. I was thinking how to describe this situation in the current driver without having to add all the 6 different configuration as quirks. Any suggestion? Cheers, -- Carlo Caione