From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72943C433F5 for ; Tue, 7 Sep 2021 14:34:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 576F6610FE for ; Tue, 7 Sep 2021 14:34:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233978AbhIGOfU (ORCPT ); Tue, 7 Sep 2021 10:35:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232105AbhIGOfU (ORCPT ); Tue, 7 Sep 2021 10:35:20 -0400 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E26FC061575 for ; Tue, 7 Sep 2021 07:34:13 -0700 (PDT) Received: by mail-lf1-x135.google.com with SMTP id k13so19981459lfv.2 for ; Tue, 07 Sep 2021 07:34:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PZ01/kVjxN4qO85F71R96OvGPb6wIX4duLA904XRBt0=; b=sUtQ7iAwFIzvOQDRef2wZa27h8+hDyTaxtEx6mARLtFnIRrPuxoUB+6w/M2nVqWpgx 3S+ciEJ8lUgYCEjN09Uwt7xfsur7rUUsHKtkHaFeS8UaXudk5cpVyCQDI3xqhty5k665 DVg7jaq3i3tqVXi+tCdWo804axaXHCQhM7wqf2aWC/6nMcpXsBufmKX3J/gL8JmtqCcC 6Hq3Qxl/hv0+oJ4GLjRcFzim1QbJdfVwOGWaLnYJ0c5Y3nTJxxhdQE4Kqh7Vyjbo1DaV 1Ea6QbV54HLRL9YpQpXP/dUNDXFN4/soZDxGveC7jnSb+4LlYb8uf6tA/Hbpz0Lf0nn2 4Mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PZ01/kVjxN4qO85F71R96OvGPb6wIX4duLA904XRBt0=; b=flNQ6Np57RT+E7WmfUKzerw5gjw+cueqpWrQaNDiRjtTcm48oDcbu3l7UGBu/YXBft Ap5Zr3qzIDBf2JOwzaB3k1EFSr8QhflSI543HC1p3YmbVDf4+gmetW/iErRENfgOYwsK pXdZofjkfcHkNZichXazbIme9zuTJiRdr3Tj8EXz+oSZoY61zcRPNORnY4S9TuhoCNt7 AdVtunHBFtWs6GpyxdUr8oIrAlgafsxitsYBQBMsakDOvo9kQXUPD70kLSfAHxPANW/S Zn3ZjBB3UH1lX8/ZtLXRgE8zXFWMrA8WRYivBEzFilb9yIoDslX1+T0Jk7Dbne67kYAg RLeA== X-Gm-Message-State: AOAM531oTa2hg/YxK8WoUJHE7/VA6oNFS2DRj6i5cl6QFVB0SZHcv7H4 cybLammVQ+qhMc2Is64wbRzezXe2aVuMXmnxe0hj0ES68tWdkw== X-Google-Smtp-Source: ABdhPJwuWNsB+X+8RleNTkUfobN0mJu2O1t+/HKXko5CgQZkOu4qHxK+7UF3rIDIOg4c0OeKfNIwiesKok3fCDh56ig= X-Received: by 2002:ac2:51a2:: with SMTP id f2mr13179229lfk.685.1631025251259; Tue, 07 Sep 2021 07:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20210903231154.25091-1-ricarkol@google.com> <20210903231154.25091-2-ricarkol@google.com> In-Reply-To: <20210903231154.25091-2-ricarkol@google.com> From: Oliver Upton Date: Tue, 7 Sep 2021 09:34:00 -0500 Message-ID: Subject: Re: [PATCH 1/2] KVM: selftests: make memslot_perf_test arch independent To: Ricardo Koller Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, drjones@redhat.com, Paolo Bonzini , maciej.szmigiero@oracle.com, maz@kernel.org, jingzhangos@google.com, pshier@google.com, rananta@google.com, reijiw@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Sep 3, 2021 at 6:12 PM Ricardo Koller wrote: > > memslot_perf_test uses ucalls for synchronization between guest and > host. Ucalls API is architecture independent: tests do not need know > what kind of exit they generate on a specific arch. More specifically, > there is no need to check whether an exit is KVM_EXIT_IO in x86 for the > host to know that the exit is ucall related, as get_ucall() already > makes that check. > > Change memslot_perf_test to not require specifying what exit does a > ucall generate. Also add a missing ucall_init. > > Signed-off-by: Ricardo Koller > --- > .../testing/selftests/kvm/memslot_perf_test.c | 56 +++++++++++-------- > 1 file changed, 34 insertions(+), 22 deletions(-) Reviewed-by: Oliver Upton From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C3E7C433EF for ; Tue, 7 Sep 2021 14:34:18 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id DB958610FE for ; Tue, 7 Sep 2021 14:34:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DB958610FE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 535684B1CF; Tue, 7 Sep 2021 10:34:17 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vk6e6uI3MVaj; Tue, 7 Sep 2021 10:34:16 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 34D254B1C9; Tue, 7 Sep 2021 10:34:16 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 2DF684B1BD for ; Tue, 7 Sep 2021 10:34:14 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VMxEJsTx9S0L for ; Tue, 7 Sep 2021 10:34:13 -0400 (EDT) Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id E43904B1AF for ; Tue, 7 Sep 2021 10:34:12 -0400 (EDT) Received: by mail-lf1-f50.google.com with SMTP id m28so19955172lfj.6 for ; Tue, 07 Sep 2021 07:34:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PZ01/kVjxN4qO85F71R96OvGPb6wIX4duLA904XRBt0=; b=sUtQ7iAwFIzvOQDRef2wZa27h8+hDyTaxtEx6mARLtFnIRrPuxoUB+6w/M2nVqWpgx 3S+ciEJ8lUgYCEjN09Uwt7xfsur7rUUsHKtkHaFeS8UaXudk5cpVyCQDI3xqhty5k665 DVg7jaq3i3tqVXi+tCdWo804axaXHCQhM7wqf2aWC/6nMcpXsBufmKX3J/gL8JmtqCcC 6Hq3Qxl/hv0+oJ4GLjRcFzim1QbJdfVwOGWaLnYJ0c5Y3nTJxxhdQE4Kqh7Vyjbo1DaV 1Ea6QbV54HLRL9YpQpXP/dUNDXFN4/soZDxGveC7jnSb+4LlYb8uf6tA/Hbpz0Lf0nn2 4Mpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PZ01/kVjxN4qO85F71R96OvGPb6wIX4duLA904XRBt0=; b=hdJnuDjhPFNeLnVGCD6TkneKRWL7X0Bm6LCeAKZmIRkmhsSr4jC9+XPidNXpv2YOFv USCACZBY0w1LXjjINga62ptffvpzgOmvZ2EYFvNZVgPwpUREiEOC0MxRqrwFYL6KEfOt DQSBPPzfBvosVvdZW/n01AHgo95Pkp381u/uyYQbbk168p8OSrfxGetCew/PD6zMMy0s xGM1pWpRjTZSGNdUd6m091tHXTcjud5IF/M/sThrVKw5S2vlLDIDDcciQUjWjHKUT7dC qE01fe5d/zBtnU9YdHEBwf0Z16akrXAXEkwv1pj7G3oMzhsNZT52KqXjCKQCZ2f7nSaP aAOw== X-Gm-Message-State: AOAM532jkGrdyWUGA2jx/ayYMgHLhOtymUCOTbjMbX9C1nX4X+xq5/pi d7ampokUcPYnc82NqF/UC36d6yXwLri+5fkgQb/Vmw== X-Google-Smtp-Source: ABdhPJwuWNsB+X+8RleNTkUfobN0mJu2O1t+/HKXko5CgQZkOu4qHxK+7UF3rIDIOg4c0OeKfNIwiesKok3fCDh56ig= X-Received: by 2002:ac2:51a2:: with SMTP id f2mr13179229lfk.685.1631025251259; Tue, 07 Sep 2021 07:34:11 -0700 (PDT) MIME-Version: 1.0 References: <20210903231154.25091-1-ricarkol@google.com> <20210903231154.25091-2-ricarkol@google.com> In-Reply-To: <20210903231154.25091-2-ricarkol@google.com> From: Oliver Upton Date: Tue, 7 Sep 2021 09:34:00 -0500 Message-ID: Subject: Re: [PATCH 1/2] KVM: selftests: make memslot_perf_test arch independent To: Ricardo Koller Cc: kvm@vger.kernel.org, maz@kernel.org, pshier@google.com, Paolo Bonzini , maciej.szmigiero@oracle.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Sep 3, 2021 at 6:12 PM Ricardo Koller wrote: > > memslot_perf_test uses ucalls for synchronization between guest and > host. Ucalls API is architecture independent: tests do not need know > what kind of exit they generate on a specific arch. More specifically, > there is no need to check whether an exit is KVM_EXIT_IO in x86 for the > host to know that the exit is ucall related, as get_ucall() already > makes that check. > > Change memslot_perf_test to not require specifying what exit does a > ucall generate. Also add a missing ucall_init. > > Signed-off-by: Ricardo Koller > --- > .../testing/selftests/kvm/memslot_perf_test.c | 56 +++++++++++-------- > 1 file changed, 34 insertions(+), 22 deletions(-) Reviewed-by: Oliver Upton _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm