From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E993C432BE for ; Wed, 4 Aug 2021 10:22:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DFB86104F for ; Wed, 4 Aug 2021 10:22:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237299AbhHDKWx (ORCPT ); Wed, 4 Aug 2021 06:22:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235522AbhHDKWw (ORCPT ); Wed, 4 Aug 2021 06:22:52 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20F95C0613D5 for ; Wed, 4 Aug 2021 03:22:39 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id f42so3565483lfv.7 for ; Wed, 04 Aug 2021 03:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeKqZfswV3Sb0AU8g0UPNhEdRtUw4ir+Xa9mBwdImhQ=; b=Sx8QK7m+vzLUPX7gwMaaMlpfLAgy9neplHDzBUyv9uNsaoqOSl1IYCGoAtYmWUIB0r mcpN8pzx3GClXZHioEL4F/x3ivqMmLOQ7BVi4CDxQ8EG3sz/yuttN1nBoQvpwG6tA6oP aB/xKpr90qG2ceJvP2f20MPyKWRYubGWo8oPlwRA7HJlUoao/JFWualIcemrFCxe6dU3 BFXrUSR6d2YsnzwCBqVQWdcnBS/FmqxfR0Ogc0ZWjzgwooQfWsl5/ElVdtCBJ/UeXjFS hENab/eFfPPxqm1KmWzM3n2DzvGvp/36TlCZAkzJadr9O4rPeZKIitcswfL+VZz/xgi7 wSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeKqZfswV3Sb0AU8g0UPNhEdRtUw4ir+Xa9mBwdImhQ=; b=h85JjhNc7grykNfkg0yiRnXtLkynxqDyIadueS/aqVtK2q72O5V1w4WIiy+tAuhup9 Al/X47CsVuXIIiUmIdoONpErdl2lP1lRXrLjc6HGbbIyOJrEjiFvTHEGzyrZEccpIu6z 8DqRmQgEK7+lhEt5OBQJ6Bk6RcYIBxY/p2vycy97tM6Tvjge9W5IsjIf+PEhf9gkqlZ7 TfYmo5bPt9CFXAtgqpRkDHRmyeHXMwSPIeu7gCsZ49YGUTtyk2mpcMSyuIUTC+GJFuN0 3t9j5Ke+z3xNhsXU0bYDIYjbN3unA0q1dgUfYmKjqcQEmYjFJjBDvUnebVzNkecx1u2Q fzIw== X-Gm-Message-State: AOAM5313ohfo2MJ6O8VPOkeVAw98x8KN98sjaRZM8NgWvQx+oiHcg75p 30HrIxSYNZ+R6eL0TNHOh9AL2Ut0CnhhPXbxycTR5w== X-Google-Smtp-Source: ABdhPJzB5JAVimicrB+LNM1WlhZujX7PYw4hx552TtO+zR1iDfLhqMpreHlla6ij7/LeLKw1/tY33IuZjyfFTZqjHcw= X-Received: by 2002:ac2:57cd:: with SMTP id k13mr2429091lfo.117.1628072557209; Wed, 04 Aug 2021 03:22:37 -0700 (PDT) MIME-Version: 1.0 References: <20210804085819.846610-1-oupton@google.com> <20210804085819.846610-18-oupton@google.com> <20210804101743.bgkggw7a3wbx7woi@gator.home> In-Reply-To: <20210804101743.bgkggw7a3wbx7woi@gator.home> From: Oliver Upton Date: Wed, 4 Aug 2021 03:22:26 -0700 Message-ID: Subject: Re: [PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset To: Andrew Jones Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Paolo Bonzini , Sean Christopherson , Marc Zyngier , Peter Shier , Jim Mattson , David Matlack , Ricardo Koller , Jing Zhang , Raghavendra Rao Anata , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, Will Deacon , Catalin Marinas Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Aug 4, 2021 at 3:17 AM Andrew Jones wrote: > > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c > > index a8815b09da3e..f15058612994 100644 > > --- a/arch/arm64/kvm/arch_timer.c > > +++ b/arch/arm64/kvm/arch_timer.c > > @@ -85,11 +85,15 @@ u64 timer_get_cval(struct arch_timer_context *ctxt) > > static u64 timer_get_offset(struct arch_timer_context *ctxt) > > { > > struct kvm_vcpu *vcpu = ctxt->vcpu; > > + struct arch_timer_cpu *timer = vcpu_timer(vcpu); > > This new timer variable doesn't appear to get used. Ooops, this is stale. Thanks for catching that. > > Reviewed-by: Andrew Jones > Thanks for the quick review! -- Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D19C1C4320E for ; Wed, 4 Aug 2021 10:22:42 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 49016610FE for ; Wed, 4 Aug 2021 10:22:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 49016610FE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C61BF4AC78; Wed, 4 Aug 2021 06:22:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4FtApmEqIh79; Wed, 4 Aug 2021 06:22:40 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id DDA2D4A500; Wed, 4 Aug 2021 06:22:40 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0F5294A4E5 for ; Wed, 4 Aug 2021 06:22:40 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZI-7cnRh4bBb for ; Wed, 4 Aug 2021 06:22:39 -0400 (EDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id DA8F44A4A4 for ; Wed, 4 Aug 2021 06:22:38 -0400 (EDT) Received: by mail-lf1-f53.google.com with SMTP id z2so3629913lft.1 for ; Wed, 04 Aug 2021 03:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeKqZfswV3Sb0AU8g0UPNhEdRtUw4ir+Xa9mBwdImhQ=; b=Sx8QK7m+vzLUPX7gwMaaMlpfLAgy9neplHDzBUyv9uNsaoqOSl1IYCGoAtYmWUIB0r mcpN8pzx3GClXZHioEL4F/x3ivqMmLOQ7BVi4CDxQ8EG3sz/yuttN1nBoQvpwG6tA6oP aB/xKpr90qG2ceJvP2f20MPyKWRYubGWo8oPlwRA7HJlUoao/JFWualIcemrFCxe6dU3 BFXrUSR6d2YsnzwCBqVQWdcnBS/FmqxfR0Ogc0ZWjzgwooQfWsl5/ElVdtCBJ/UeXjFS hENab/eFfPPxqm1KmWzM3n2DzvGvp/36TlCZAkzJadr9O4rPeZKIitcswfL+VZz/xgi7 wSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeKqZfswV3Sb0AU8g0UPNhEdRtUw4ir+Xa9mBwdImhQ=; b=m4rYF/1k/ZF8ovlndPIQx2vrzh06NgoqoaKhHaeYPCWggd7eacZUPBBfmWOgybDaJm AIA9I1yRnV3vsMOISswISTQiABB8mK46zM8JnKM7yTZ8zKzYagVyIGPP2F/TNYmCXcMd 0r0W/ktnrlsC1lC9IfzkiseJVh7Eosw6s4o+DRSLC+h6M2cquYURkroHQRXOyW5XN6kl k7oYmSa2+APmE6IOsHGjA7M3KmGxVf5gndO5p7XsWGEOf/DwRv6Bi38dSDHY+YtOPkKA FEUpZFkuuFdsyyGDFjq0t1BuC8lI4E44L1hQe/sAAFPt4oFFgqYlePENj4zIVEA329Ic B4oA== X-Gm-Message-State: AOAM5335mnxV6W6duM6X9Jj7P1wMr1mOY4bgFnLSkoXGl3vLtfmhcJEz qqzcJ8AuiP7dUFg2/uuS+HvKfjpFHMIqkAOKSpVtpg== X-Google-Smtp-Source: ABdhPJzB5JAVimicrB+LNM1WlhZujX7PYw4hx552TtO+zR1iDfLhqMpreHlla6ij7/LeLKw1/tY33IuZjyfFTZqjHcw= X-Received: by 2002:ac2:57cd:: with SMTP id k13mr2429091lfo.117.1628072557209; Wed, 04 Aug 2021 03:22:37 -0700 (PDT) MIME-Version: 1.0 References: <20210804085819.846610-1-oupton@google.com> <20210804085819.846610-18-oupton@google.com> <20210804101743.bgkggw7a3wbx7woi@gator.home> In-Reply-To: <20210804101743.bgkggw7a3wbx7woi@gator.home> From: Oliver Upton Date: Wed, 4 Aug 2021 03:22:26 -0700 Message-ID: Subject: Re: [PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset To: Andrew Jones Cc: Catalin Marinas , kvm@vger.kernel.org, Will Deacon , Marc Zyngier , Raghavendra Rao Anata , Peter Shier , Sean Christopherson , David Matlack , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Aug 4, 2021 at 3:17 AM Andrew Jones wrote: > > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c > > index a8815b09da3e..f15058612994 100644 > > --- a/arch/arm64/kvm/arch_timer.c > > +++ b/arch/arm64/kvm/arch_timer.c > > @@ -85,11 +85,15 @@ u64 timer_get_cval(struct arch_timer_context *ctxt) > > static u64 timer_get_offset(struct arch_timer_context *ctxt) > > { > > struct kvm_vcpu *vcpu = ctxt->vcpu; > > + struct arch_timer_cpu *timer = vcpu_timer(vcpu); > > This new timer variable doesn't appear to get used. Ooops, this is stale. Thanks for catching that. > > Reviewed-by: Andrew Jones > Thanks for the quick review! -- Oliver _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8ABC4338F for ; Wed, 4 Aug 2021 10:24:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C5C8B60FC3 for ; Wed, 4 Aug 2021 10:24:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C5C8B60FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/4G246hpAr+INpaaqgfLpc45ytggII5KJyZPzh0i69o=; b=hgj2m2wg4jE6ah oXRJgOnKX+rgGM/d+uLYFx1KS5A1klOY435sYRSo/7fh/dXZPkP9u5z7Igm8io6ccJe08kX+7mv6j tYLgO9nOWRxcxj33XlLJSYxSiChmZ46NAxiSPrn6fWYj9OrWhc0flIhTtgB61TyRpGOtWqXBcRmc0 E0ZfHnVf9jmjMK9r5MyJqBRbj38xGTwjJ91wUzDRUkUVfGdlzAXVhJuNsPochLCA8Lf1rn4bNkOCv p0OqjihZp73uj4aDDQn9LKfzcZxrAR/4hXLOnjyCqBzoKZijcRqo9dYrD7MgKWkwEOkxZFy+RKl61 CJDMS0ySm1rKZ4ziVESA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBE31-005iFP-QM; Wed, 04 Aug 2021 10:22:53 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBE2p-005iCr-6o for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 10:22:42 +0000 Received: by mail-lf1-x130.google.com with SMTP id g13so3535076lfj.12 for ; Wed, 04 Aug 2021 03:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KeKqZfswV3Sb0AU8g0UPNhEdRtUw4ir+Xa9mBwdImhQ=; b=Sx8QK7m+vzLUPX7gwMaaMlpfLAgy9neplHDzBUyv9uNsaoqOSl1IYCGoAtYmWUIB0r mcpN8pzx3GClXZHioEL4F/x3ivqMmLOQ7BVi4CDxQ8EG3sz/yuttN1nBoQvpwG6tA6oP aB/xKpr90qG2ceJvP2f20MPyKWRYubGWo8oPlwRA7HJlUoao/JFWualIcemrFCxe6dU3 BFXrUSR6d2YsnzwCBqVQWdcnBS/FmqxfR0Ogc0ZWjzgwooQfWsl5/ElVdtCBJ/UeXjFS hENab/eFfPPxqm1KmWzM3n2DzvGvp/36TlCZAkzJadr9O4rPeZKIitcswfL+VZz/xgi7 wSfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KeKqZfswV3Sb0AU8g0UPNhEdRtUw4ir+Xa9mBwdImhQ=; b=IbP9ROka8JX/NaYIgM05vGK7vFF7jMsHMzSSBPvF16miHXJWtu5NONms4FauQuffAn c1ItSNmJd88qbF540NLWDChv+3m0vW56c8kgk/sv639/4dPN/tCBefeYPmB8ucPuDXli 4Axy7gEW5ni+2cTHq7s5DR53sk4ZB/g5Etg9I+4dRlyK5481Ry09Qpx/yJ3Dn8wEgLpx DveS9P2CZrLR4AcAolMR1m+LwLCh2AhU2RCvyVUBlSDZncD3lRX75xfLAHDX4J69zeRi hKoWyt9iCNu86Bvfr8L5DvZbzAEp9wBknz0XwO5xAM71izU6dURkpRYo3l1kumtwAXkS +pPA== X-Gm-Message-State: AOAM531olq82mxXZzjOYsOLhz1hL3HbERM068+5bzQdx9spv3byfslrt hPxL9rwgNV2SWQHGNKV3I9Apanf7kTYgoEIkwK82XA== X-Google-Smtp-Source: ABdhPJzB5JAVimicrB+LNM1WlhZujX7PYw4hx552TtO+zR1iDfLhqMpreHlla6ij7/LeLKw1/tY33IuZjyfFTZqjHcw= X-Received: by 2002:ac2:57cd:: with SMTP id k13mr2429091lfo.117.1628072557209; Wed, 04 Aug 2021 03:22:37 -0700 (PDT) MIME-Version: 1.0 References: <20210804085819.846610-1-oupton@google.com> <20210804085819.846610-18-oupton@google.com> <20210804101743.bgkggw7a3wbx7woi@gator.home> In-Reply-To: <20210804101743.bgkggw7a3wbx7woi@gator.home> From: Oliver Upton Date: Wed, 4 Aug 2021 03:22:26 -0700 Message-ID: Subject: Re: [PATCH v6 17/21] KVM: arm64: Allow userspace to configure a guest's counter-timer offset To: Andrew Jones Cc: kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, Paolo Bonzini , Sean Christopherson , Marc Zyngier , Peter Shier , Jim Mattson , David Matlack , Ricardo Koller , Jing Zhang , Raghavendra Rao Anata , James Morse , Alexandru Elisei , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, Will Deacon , Catalin Marinas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_032239_366989_37EA4752 X-CRM114-Status: GOOD ( 13.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 4, 2021 at 3:17 AM Andrew Jones wrote: > > diff --git a/arch/arm64/kvm/arch_timer.c b/arch/arm64/kvm/arch_timer.c > > index a8815b09da3e..f15058612994 100644 > > --- a/arch/arm64/kvm/arch_timer.c > > +++ b/arch/arm64/kvm/arch_timer.c > > @@ -85,11 +85,15 @@ u64 timer_get_cval(struct arch_timer_context *ctxt) > > static u64 timer_get_offset(struct arch_timer_context *ctxt) > > { > > struct kvm_vcpu *vcpu = ctxt->vcpu; > > + struct arch_timer_cpu *timer = vcpu_timer(vcpu); > > This new timer variable doesn't appear to get used. Ooops, this is stale. Thanks for catching that. > > Reviewed-by: Andrew Jones > Thanks for the quick review! -- Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel