From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABA8C4320A for ; Wed, 18 Aug 2021 21:34:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E6220610E8 for ; Wed, 18 Aug 2021 21:34:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234031AbhHRVe7 (ORCPT ); Wed, 18 Aug 2021 17:34:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234218AbhHRVey (ORCPT ); Wed, 18 Aug 2021 17:34:54 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE0A0C061764 for ; Wed, 18 Aug 2021 14:34:16 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id n7so7756644ljq.0 for ; Wed, 18 Aug 2021 14:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIJMBP+oNGnAAKwmFqWtXv81MB4wkUEraz55M0YB7rs=; b=foqb7b1M4tTMZr+19gT0KatyK3YWAxVGmDQTr25cXFLF0MNddFFoCuyzPU0hKkbF5a L529T14lULjeLlBYc/lRwonH7BG1vdlrvQ76+jec+Jmwslwl/bx33sJk1a80NEkgWDJS HM5nvMVR4Y0+7o7t6UkBRIJbb2oaEXr9QC0e9AJtm/n3qgnTfaeFWklKZ58KnlbhfU1S LdXrfUwhrrXFFMf9PAFN3C5/y92KRFtOqrgDf6Tx8HSnt7CRihSzYyrODXSIxppqerAv Yi/lSAFuOYtEDMuVLEtd4fGzXfFWKV4CywjxWbuMW62mfWceZEi4UwRF6WZoBAoGXnVr 2qyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIJMBP+oNGnAAKwmFqWtXv81MB4wkUEraz55M0YB7rs=; b=W0+qgMz4Czd0cYuebh0EqbWtbgSIfT7IPPhwIyhdRvRr6NuwXFAuj0y0CjUwK3zMJU 60VgqZo/tvpXS4wMIGr2W8hLeac+gpKr0DiKh6GG242BrHKpqbCcFmJFFv/oXKjhewPG upWLwBoTwFsVJ/fQjxmHrg2MwaB/hkEDzgiSjR4TgAQ2ZXGeNLYdJZOaZe2jlcWKXTvU Po8T2lxr3dcns5jNnldkaDWUHBWc/K7M9w4eB7FZqO6eQaP2yTUxrUBrfeU2YaDNg1Cg 70REye2cpwTdguTkolCTVSYiDMUz2B64gqyUAzVSp/tZkg/nonDeodRh9Ho3ULjVX4HI ThLQ== X-Gm-Message-State: AOAM532iOEq9irN2rs2GOroG7FBhLwJrxYqLelB1Ps5wGpts2D5VmO7q bgE2IzG8yr21OoZBeh3+a8R//Ecg1ktqMj8VFtuC+g== X-Google-Smtp-Source: ABdhPJzdkFHv/DoVrFmnB5SXoPKGwHxKK4vShunyvprddeq1JJO2GNWpXj1AvWJsXXOV9c+ZzuVZMpwPaSIXCFPJT5Q= X-Received: by 2002:a2e:a782:: with SMTP id c2mr9537367ljf.388.1629322454756; Wed, 18 Aug 2021 14:34:14 -0700 (PDT) MIME-Version: 1.0 References: <20210818213205.598471-1-ricarkol@google.com> In-Reply-To: <20210818213205.598471-1-ricarkol@google.com> From: Oliver Upton Date: Wed, 18 Aug 2021 14:34:03 -0700 Message-ID: Subject: Re: [PATCH] KVM: arm64: vgic: drop WARN from vgic_get_irq To: Ricardo Koller Cc: kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, maz@kernel.org, james.morse@arm.com, Alexandru.Elisei@arm.com, drjones@redhat.com, catalin.marinas@arm.com, suzuki.poulose@arm.com, jingzhangos@google.com, pshier@google.com, rananta@google.com, reijiw@google.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi Ricardo, On Wed, Aug 18, 2021 at 2:32 PM Ricardo Koller wrote: > > vgic_get_irq(intid) is used all over the vgic code in order to get a > reference to a struct irq. It warns whenever intid is not a valid number > (like when it's a reserved IRQ number). The issue is that this warning > can be triggered from userspace (e.g., KVM_IRQ_LINE for intid 1020). > > Drop the WARN call from vgic_get_irq. > > Signed-off-by: Ricardo Koller > --- > arch/arm64/kvm/vgic/vgic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c > index 111bff47e471..81cec508d413 100644 > --- a/arch/arm64/kvm/vgic/vgic.c > +++ b/arch/arm64/kvm/vgic/vgic.c > @@ -106,7 +106,6 @@ struct vgic_irq *vgic_get_irq(struct kvm *kvm, struct kvm_vcpu *vcpu, > if (intid >= VGIC_MIN_LPI) > return vgic_get_lpi(kvm, intid); > > - WARN(1, "Looking up struct vgic_irq for reserved INTID"); Could we maybe downgrade the message to WARN_ONCE() (to get a stack) or pr_warn_ratelimited()? I agree it is problematic that userspace can cause this WARN to fire, but it'd be helpful for debugging too. -- Thanks, Oliver > return NULL; > } > > -- > 2.33.0.rc2.250.ged5fa647cd-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A00B0C4338F for ; Wed, 18 Aug 2021 21:34:24 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 14FCD610FF for ; Wed, 18 Aug 2021 21:34:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 14FCD610FF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 81EBD4086D; Wed, 18 Aug 2021 17:34:23 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WMaNAdZeocpA; Wed, 18 Aug 2021 17:34:19 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8C4C44B0AD; Wed, 18 Aug 2021 17:34:19 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4007C49E57 for ; Wed, 18 Aug 2021 17:34:18 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yGEe-9951cKp for ; Wed, 18 Aug 2021 17:34:16 -0400 (EDT) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id B076F4086D for ; Wed, 18 Aug 2021 17:34:16 -0400 (EDT) Received: by mail-lj1-f171.google.com with SMTP id d16so7671381ljq.4 for ; Wed, 18 Aug 2021 14:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fIJMBP+oNGnAAKwmFqWtXv81MB4wkUEraz55M0YB7rs=; b=foqb7b1M4tTMZr+19gT0KatyK3YWAxVGmDQTr25cXFLF0MNddFFoCuyzPU0hKkbF5a L529T14lULjeLlBYc/lRwonH7BG1vdlrvQ76+jec+Jmwslwl/bx33sJk1a80NEkgWDJS HM5nvMVR4Y0+7o7t6UkBRIJbb2oaEXr9QC0e9AJtm/n3qgnTfaeFWklKZ58KnlbhfU1S LdXrfUwhrrXFFMf9PAFN3C5/y92KRFtOqrgDf6Tx8HSnt7CRihSzYyrODXSIxppqerAv Yi/lSAFuOYtEDMuVLEtd4fGzXfFWKV4CywjxWbuMW62mfWceZEi4UwRF6WZoBAoGXnVr 2qyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fIJMBP+oNGnAAKwmFqWtXv81MB4wkUEraz55M0YB7rs=; b=ijKsZTfJzL67y3bF3dAK9lX2ba//xeRDnsxFrSmA38wd2JHmlkSuyjsasf9a5E4pGb YLYpkmAeQ48vayuQ9AZ6GlmZF5sEXJi466+ucXha6qNQVGU5YktQRPQ60dG6lYfqVlf/ uSN0lP0SsHjoJE3P8YX46cYUd5+4ooDDJHF2+7SkP03vqGctgyzvzDdzofrrJQ1/Cxh9 Z2qVNo8I+sgWvcRAoJmELaWyM3YPd2t8erTcvcCcCprR8677GigAdHGocEdxC/J+BlNZ b+OGl+qFUZeMJbjkkBr7ZQ8B8iSumrusrS33BCHG9TpDXg5ufRTjNUdtJuiPcMYAr/Zv wyUw== X-Gm-Message-State: AOAM530WlxHELvdlelPuqmg/sMG6Vc/OXY6++1AqhySAO1FqIgvnhOgo DwQ64Ej/MgInlcqe00uPySpFfZNqeHRB/waAxgTWpQ== X-Google-Smtp-Source: ABdhPJzdkFHv/DoVrFmnB5SXoPKGwHxKK4vShunyvprddeq1JJO2GNWpXj1AvWJsXXOV9c+ZzuVZMpwPaSIXCFPJT5Q= X-Received: by 2002:a2e:a782:: with SMTP id c2mr9537367ljf.388.1629322454756; Wed, 18 Aug 2021 14:34:14 -0700 (PDT) MIME-Version: 1.0 References: <20210818213205.598471-1-ricarkol@google.com> In-Reply-To: <20210818213205.598471-1-ricarkol@google.com> From: Oliver Upton Date: Wed, 18 Aug 2021 14:34:03 -0700 Message-ID: Subject: Re: [PATCH] KVM: arm64: vgic: drop WARN from vgic_get_irq To: Ricardo Koller Cc: kvm@vger.kernel.org, maz@kernel.org, rananta@google.com, pshier@google.com, catalin.marinas@arm.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Hi Ricardo, On Wed, Aug 18, 2021 at 2:32 PM Ricardo Koller wrote: > > vgic_get_irq(intid) is used all over the vgic code in order to get a > reference to a struct irq. It warns whenever intid is not a valid number > (like when it's a reserved IRQ number). The issue is that this warning > can be triggered from userspace (e.g., KVM_IRQ_LINE for intid 1020). > > Drop the WARN call from vgic_get_irq. > > Signed-off-by: Ricardo Koller > --- > arch/arm64/kvm/vgic/vgic.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/kvm/vgic/vgic.c b/arch/arm64/kvm/vgic/vgic.c > index 111bff47e471..81cec508d413 100644 > --- a/arch/arm64/kvm/vgic/vgic.c > +++ b/arch/arm64/kvm/vgic/vgic.c > @@ -106,7 +106,6 @@ struct vgic_irq *vgic_get_irq(struct kvm *kvm, struct kvm_vcpu *vcpu, > if (intid >= VGIC_MIN_LPI) > return vgic_get_lpi(kvm, intid); > > - WARN(1, "Looking up struct vgic_irq for reserved INTID"); Could we maybe downgrade the message to WARN_ONCE() (to get a stack) or pr_warn_ratelimited()? I agree it is problematic that userspace can cause this WARN to fire, but it'd be helpful for debugging too. -- Thanks, Oliver > return NULL; > } > > -- > 2.33.0.rc2.250.ged5fa647cd-goog > _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm