From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean Pihet Subject: Re: [PATCH 07/13] OMAP PM: early init of the pwrdms states Date: Tue, 2 Aug 2011 10:57:31 +0200 Message-ID: References: <1311841821-10252-1-git-send-email-j-pihet@ti.com> <1311841821-10252-8-git-send-email-j-pihet@ti.com> <20110729080820.GB26959@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:54918 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752330Ab1HBI5c convert rfc822-to-8bit (ORCPT ); Tue, 2 Aug 2011 04:57:32 -0400 Received: by qwk3 with SMTP id 3so3199371qwk.19 for ; Tue, 02 Aug 2011 01:57:31 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Todd Poynor Cc: "Rafael J. Wysocki" , Paul Walmsley , Kevin Hilman , Magnus Damm , Linux PM mailing list , linux-omap@vger.kernel.org, markgross@thegnar.org, broonie@opensource.wolfsonmicro.com, Jean Pihet , rnayak@ti.com Todd, On Fri, Jul 29, 2011 at 10:50 AM, Jean Pihet wrote: > On Fri, Jul 29, 2011 at 10:08 AM, Todd Poynor = wrote: >> On Thu, Jul 28, 2011 at 10:30:14AM +0200, jean.pihet@newoldbits.com = wrote: =2E.. >>> diff --git a/arch/arm/mach-omap2/powerdomain.c b/arch/arm/mach-omap= 2/powerdomain.c >>> index 9af0847..63c3e7a 100644 >>> --- a/arch/arm/mach-omap2/powerdomain.c >>> +++ b/arch/arm/mach-omap2/powerdomain.c >>> @@ -108,6 +108,9 @@ static int _pwrdm_register(struct powerdomain *= pwrdm) >>> =A0 =A0 =A0 pwrdm->state =3D pwrdm_read_pwrst(pwrdm); >>> =A0 =A0 =A0 pwrdm->state_counter[pwrdm->state] =3D 1; >>> >>> + =A0 =A0 /* Early init of the next power state */ >>> + =A0 =A0 pwrdm_set_next_pwrst(pwrdm, PWRDM_POWER_RET); >>> + >> >> Wanted to check that it's OK to initialize the next state of a power >> domain to RETENTION early in the boot sequence. =A0I believe patches >> have been previously discussed that set the state to ON to ensure th= e >> domain doesn't go to a lower state, and possibly lose context, befor= e >> the PM subsystem is setup to handle it? =A0Not sure, thought maybe w= orth >> a doublecheck. > Indeed I need to check the behavior for OMAP3 & 4 which seem to > initialize the pwrdm states differently. > BTW the patch that inits all pwrdms to ON is not yet in l-o master > that is why I (lazily) submitted this one for now. Ok I will update the patch to make it compliant with [1]. v4 will include this change. Thanks, Jean [1] http://marc.info/?l=3Dlinux-arm-kernel&m=3D131052762623823&w=3D2 > >> >> >> Todd -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html