From: Curtis Malainey <cujomalainey@google.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
ALSA development <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Dominik Brodowski <linux@dominikbrodowski.net>,
Takashi Iwai <tiwai@suse.com>,
Hans de Goede <hdegoede@redhat.com>,
vkoul@kernel.org, Mark Brown <broonie@kernel.org>,
Ben Zhang <benzh@google.com>
Subject: Re: [PATCH 3/4] ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link
Date: Thu, 19 Mar 2020 15:43:51 -0700 [thread overview]
Message-ID: <CAOReqxj=DBO2FyL466jWHDUG6_A4uU_o0cSyVPHbH8mjWs=JTg@mail.gmail.com> (raw)
In-Reply-To: <dea20cf7-f324-a933-8f8e-e70a4dffa249@linux.intel.com>
On Thu, Mar 19, 2020 at 3:15 PM Pierre-Louis Bossart
<pierre-louis.bossart@linux.intel.com> wrote:
>
>
>
> On 3/19/20 3:49 PM, Cezary Rojewski wrote:
> > As of commit:
> > ASoC: soc-core: care .ignore_suspend for Component suspend
> >
> > function soc-core::snd_soc_suspend no longer ignores 'ignore_suspend'
> > flag for dai links. While BE dai link for System Pin is
> > supposed to follow standard suspend-resume flow, appended
> > 'ignore_suspend' flag disturbs that flow and causes audio to break
> > right after resume. Remove the flag to address this.
> >
> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Cc: Dominik Brodowski <linux@dominikbrodowski.net>
> > Cc: Mark Brown <broonie@kernel.org>
> > Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>
> we should ask Ben and Curtis @ Google if the changes related to suspend
> interfere with the wake-on-voice support?
I have a samus with me so I can test it but my backlog is definitely
growing due to WFH slowness. I will see if I can take a look tomorrow.
next prev parent reply other threads:[~2020-03-19 22:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 20:49 [PATCH 0/4] ASoC: Intel: boards: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-19 20:49 ` [PATCH 1/4] ASoC: Intel: broadwell: " Cezary Rojewski
2020-03-30 17:23 ` Applied "ASoC: Intel: broadwell: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-19 20:49 ` [PATCH 2/4] ASoC: Intel: haswell: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-30 17:23 ` Applied "ASoC: Intel: haswell: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-19 20:49 ` [PATCH 3/4] ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-19 22:14 ` Pierre-Louis Bossart
2020-03-19 22:43 ` Curtis Malainey [this message]
2020-03-25 13:28 ` Cezary Rojewski
2020-03-25 14:42 ` Pierre-Louis Bossart
2020-03-30 21:39 ` Hans de Goede
2020-03-30 23:49 ` Pierre-Louis Bossart
2020-03-31 12:15 ` Hans de Goede
2020-03-31 10:28 ` Cezary Rojewski
2020-03-31 10:54 ` Pierre-Louis Bossart
2020-03-31 12:12 ` Hans de Goede
2020-03-31 12:15 ` Pierre-Louis Bossart
2020-04-05 18:10 ` Hans de Goede
2020-04-05 23:11 ` Pierre-Louis Bossart
2020-03-30 17:23 ` Applied "ASoC: Intel: bdw-rt5677: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-19 20:49 ` [PATCH 4/4] ASoC: Intel: bdw-rt5650: Remove ignore_suspend flag from SSP0 dai link Cezary Rojewski
2020-03-30 17:23 ` Applied "ASoC: Intel: bdw-rt5650: Remove ignore_suspend flag from SSP0 dai link" to the asoc tree Mark Brown
2020-03-30 15:40 ` [PATCH 0/4] ASoC: Intel: boards: Remove ignore_suspend flag from SSP0 dai link Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOReqxj=DBO2FyL466jWHDUG6_A4uU_o0cSyVPHbH8mjWs=JTg@mail.gmail.com' \
--to=cujomalainey@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=benzh@google.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux@dominikbrodowski.net \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.