All of lore.kernel.org
 help / color / mirror / Atom feed
From: Curtis Malainey <cujomalainey@google.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Oder Chiou" <oder_chiou@realtek.com>,
	"Jack Yu" <jack.yu@realtek.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"Takashi Iwai" <tiwai@suse.de>, "Takashi Iwai" <tiwai@suse.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Derek [方德義]" <derek.fang@realtek.com>,
	"Shuming [范書銘]" <shumingf@realtek.com>,
	"Curtis Malainey" <cujomalainey@chromium.org>,
	"Bard liao" <yung-chuan.liao@linux.intel.com>,
	"Flove(HsinFu)" <flove@realtek.com>
Subject: Re: [PATCH] ASoC: rt5682: remove jack detect delay
Date: Tue, 23 Feb 2021 10:50:18 -0800	[thread overview]
Message-ID: <CAOReqxjhWD5V7UtH5-fYpiK-h5cF7fC2WqmtnYz1qdn3yt7+LQ@mail.gmail.com> (raw)
In-Reply-To: <20210223124230.GA5116@sirena.org.uk>

>
> Are you sure that *zero* debounce is needed for the button presses?
> 250ms does look like a lot of time but zero might be going from one
> extreme to the other.


Fair point, I was looking at some other codecs and why they respond so
quickly, it appears they have no fixed delay and just call schedule
work. That being said, I can easily double tap <100ms. So Ideally i
would like to keep this on the order of ~50ms at most. I am guessing
Realtek will want to keep the 250ms for jack detect still.

Would queueing two separate jobs with two different delays be the
simple way to go? Realtek does this sound fine to you?

Curtis

  reply	other threads:[~2021-02-23 18:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 21:49 [PATCH] ASoC: rt5682: remove jack detect delay Curtis Malainey
2021-02-17 21:51 ` Curtis Malainey
     [not found] ` <5b90530b77744937b87bbbd35901e320@realtek.com>
2021-02-18  8:44   ` Takashi Iwai
2021-02-18 21:06     ` Curtis Malainey
2021-02-22 13:45       ` Mark Brown
2021-02-22 18:59         ` Curtis Malainey
2021-02-23 12:42           ` Mark Brown
2021-02-23 18:50             ` Curtis Malainey [this message]
2021-02-23 19:04               ` Mark Brown
2021-02-23 20:07                 ` Curtis Malainey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOReqxjhWD5V7UtH5-fYpiK-h5cF7fC2WqmtnYz1qdn3yt7+LQ@mail.gmail.com \
    --to=cujomalainey@google.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cujomalainey@chromium.org \
    --cc=derek.fang@realtek.com \
    --cc=flove@realtek.com \
    --cc=jack.yu@realtek.com \
    --cc=lgirdwood@gmail.com \
    --cc=oder_chiou@realtek.com \
    --cc=shumingf@realtek.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.