All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Waiman Long <longman@redhat.com>
Cc: "Phil Auld" <pauld@redhat.com>,
	lkml <linux-kernel@vger.kernel.org>,
	"Michal Koutný" <mkoutny@suse.com>
Subject: Re: [PATCH] kselftest/cgroup: fix test_stress.sh to use OUTPUT dir
Date: Fri, 13 May 2022 06:20:25 -1000	[thread overview]
Message-ID: <CAOS58YNYoFQy9gv9qiUX-PDkhEJ0CAwKeNibUghrT68vSSckYQ@mail.gmail.com> (raw)
In-Reply-To: <f819f288-7f67-77d1-5d92-f0a5545c1c48@redhat.com>

Can you send a quick patch?

Thanks.

On Fri, May 13, 2022 at 6:19 AM Waiman Long <longman@redhat.com> wrote:
>
>
> On 5/12/22 10:34, Phil Auld wrote:
> > Running cgroup kselftest with O= fails to run the with_stress test due
> > to hardcoded ./test_core. Find test_core binary using the OUTPUT directory.
> >
> > Fixes: 1a99fcc035fb ("selftests: cgroup: Run test_core under interfering stress")
> > Signed-off-by: Phil Auld <pauld@redhat.com>
> > ---
> >   tools/testing/selftests/cgroup/test_stress.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/cgroup/test_stress.sh b/tools/testing/selftests/cgroup/test_stress.sh
> > index 15d9d5896394..109c044f715f 100755
> > --- a/tools/testing/selftests/cgroup/test_stress.sh
> > +++ b/tools/testing/selftests/cgroup/test_stress.sh
> > @@ -1,4 +1,4 @@
> >   #!/bin/bash
> >   # SPDX-License-Identifier: GPL-2.0
> >
> > -./with_stress.sh -s subsys -s fork ./test_core
> > +./with_stress.sh -s subsys -s fork ${OUTPUT}/test_core
>
>
> I would suggest using "${OUTPUT:-.}" as the variable OUTPUT may not be
> defined if test_stress.sh is run interactively.
>
> Cheers,
> Longman
>


-- 
tejun

  reply	other threads:[~2022-05-13 16:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-12 14:34 [PATCH] kselftest/cgroup: fix test_stress.sh to use OUTPUT dir Phil Auld
2022-05-12 17:31 ` Tejun Heo
2022-05-13 16:19 ` Waiman Long
2022-05-13 16:20   ` Tejun Heo [this message]
2022-05-13 16:50     ` Waiman Long
2022-05-13 16:32   ` Phil Auld
2022-05-13 16:35     ` Phil Auld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOS58YNYoFQy9gv9qiUX-PDkhEJ0CAwKeNibUghrT68vSSckYQ@mail.gmail.com \
    --to=tj@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=mkoutny@suse.com \
    --cc=pauld@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.