From mboxrd@z Thu Jan 1 00:00:00 1970 From: keith.busch@gmail.com (Keith Busch) Date: Fri, 16 Aug 2019 06:46:41 -0600 Subject: [PATCH] Revert "nvme-pci: use host managed power state for suspend" In-Reply-To: <20190816123850.GA22923@lst.de> References: <20190816121549.8754-1-chris@chris-wilson.co.uk> <20190816122644.GA21797@lst.de> <156595862897.11610.6852982219615959799@skylake-alporthouse-com> <20190816123850.GA22923@lst.de> Message-ID: On Fri, Aug 16, 2019@6:38 AM Christoph Hellwig wrote: > On Fri, Aug 16, 2019@01:30:29PM +0100, Chris Wilson wrote: > > Quoting Christoph Hellwig (2019-08-16 13:26:44) > > > Please, report the actual problem. Blindly reverting a patch without > > > even an explanation of your regressions is not the way to do it. > > > > As stated, the system doesn't suspend. > > > > If you would like to wait, you will get test results from our CI > > giving the current failed state and the outcome of the patch. > > Platform type, SSD vendor and type, firmware version? Also not a fan of knee-jerk reverts. Even if it may turn out to be necessary, let's at least start with a bug report for an opportunity to fix first! Could you please try Rafael's solution? These two commits here: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=xps13-9380-20190812&id=accd2dd72c8f087441d725dd916688171519e4e6 https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=xps13-9380-20190812&id=4eaefe8c621c6195c91044396ed8060c179f7aae From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keith Busch Subject: Re: [PATCH] Revert "nvme-pci: use host managed power state for suspend" Date: Fri, 16 Aug 2019 06:46:41 -0600 Message-ID: References: <20190816121549.8754-1-chris@chris-wilson.co.uk> <20190816122644.GA21797@lst.de> <156595862897.11610.6852982219615959799@skylake-alporthouse-com> <20190816123850.GA22923@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C5F96E33F for ; Fri, 16 Aug 2019 12:46:54 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id 10so3952455wmp.3 for ; Fri, 16 Aug 2019 05:46:54 -0700 (PDT) In-Reply-To: <20190816123850.GA22923@lst.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Christoph Hellwig Cc: Jens Axboe , Sagi Grimberg , intel-gfx@lists.freedesktop.org, "Rafael J . Wysocki" , linux-nvme , Keith Busch , Keith Busch List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBdWcgMTYsIDIwMTkgYXQgNjozOCBBTSBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxz dC5kZT4gd3JvdGU6Cj4gT24gRnJpLCBBdWcgMTYsIDIwMTkgYXQgMDE6MzA6MjlQTSArMDEwMCwg Q2hyaXMgV2lsc29uIHdyb3RlOgo+ID4gUXVvdGluZyBDaHJpc3RvcGggSGVsbHdpZyAoMjAxOS0w OC0xNiAxMzoyNjo0NCkKPiA+ID4gUGxlYXNlLCByZXBvcnQgdGhlIGFjdHVhbCBwcm9ibGVtLiAg QmxpbmRseSByZXZlcnRpbmcgYSBwYXRjaCB3aXRob3V0Cj4gPiA+IGV2ZW4gYW4gZXhwbGFuYXRp b24gb2YgeW91ciByZWdyZXNzaW9ucyBpcyBub3QgdGhlIHdheSB0byBkbyBpdC4KPiA+Cj4gPiBB cyBzdGF0ZWQsIHRoZSBzeXN0ZW0gZG9lc24ndCBzdXNwZW5kLgo+ID4KPiA+IElmIHlvdSB3b3Vs ZCBsaWtlIHRvIHdhaXQsIHlvdSB3aWxsIGdldCB0ZXN0IHJlc3VsdHMgZnJvbSBvdXIgQ0kKPiA+ IGdpdmluZyB0aGUgY3VycmVudCBmYWlsZWQgc3RhdGUgYW5kIHRoZSBvdXRjb21lIG9mIHRoZSBw YXRjaC4KPgo+IFBsYXRmb3JtIHR5cGUsIFNTRCB2ZW5kb3IgYW5kIHR5cGUsIGZpcm13YXJlIHZl cnNpb24/CgpBbHNvIG5vdCBhIGZhbiBvZiBrbmVlLWplcmsgcmV2ZXJ0cy4gRXZlbiBpZiBpdCBt YXkgdHVybiBvdXQgdG8gYmUKbmVjZXNzYXJ5LCBsZXQncyBhdCBsZWFzdCBzdGFydCB3aXRoIGEg YnVnIHJlcG9ydCBmb3IgYW4gb3Bwb3J0dW5pdHkKdG8gZml4IGZpcnN0IQoKQ291bGQgeW91IHBs ZWFzZSB0cnkgUmFmYWVsJ3Mgc29sdXRpb24/IFRoZXNlIHR3byBjb21taXRzIGhlcmU6CgpodHRw czovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9yYWZhZWwvbGludXgt cG0uZ2l0L2NvbW1pdC8/aD14cHMxMy05MzgwLTIwMTkwODEyJmlkPWFjY2QyZGQ3MmM4ZjA4NzQ0 MWQ3MjVkZDkxNjY4ODE3MTUxOWU0ZTYKaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xp bnV4L2tlcm5lbC9naXQvcmFmYWVsL2xpbnV4LXBtLmdpdC9jb21taXQvP2g9eHBzMTMtOTM4MC0y MDE5MDgxMiZpZD00ZWFlZmU4YzYyMWM2MTk1YzkxMDQ0Mzk2ZWQ4MDYwYzE3OWY3YWFlCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWls aW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeA==