Re: [oe] [bitbake-devel] Backport changes for _PYTHON_SYSCONFIGDATA_NAME to Gatesgarth and Dunfell

["Steve Sakoman" <steve@sakoman.com>]

On Tue, Feb 9, 2021 at 4:11 AM Steve Sakoman <sakoman@gmail.com> wrote:
>
> On Mon, Feb 8, 2021 at 1:45 PM Peter Kjellerstedt
> <peter.kjellerstedt@axis.com> wrote:
> >
> > As agreed upon on the Yocto Project Technical Team Meeting a week ago, I have created branches for both Gatesgarth and Dunfell in openembedded-core-contrib and meta-openembedded-contrib with the required patches. The branches are called pkj/_PYTHON_SYSCONFIGDATA_NAME-gatesgarth and pkj/_PYTHON_SYSCONFIGDATA_NAME-dunfell (ok, horrible names, but they should be easy to spot). There is one additional patch for bitbake, but I forgot to ask for access to bitbake-contrib, so you will have to cherry-pick it from commit 47b64cfa (it is not strictly necessary as it is just clean up made possible after the changes in OE-Core).
> >
> >
> >
> > @jansa, @akuster: I have included the two extra patches in meta-openembedded that Martin mentioned, which were lacking from my original mail. There were other patches mentioned, which fixed missing spaces related to the use of _append. However, as they were not necessary (they changed other variables than DEPENDS for target), I did not include them.
> >
> >
> >
> > I have not done any excessive testing of these branches. I have verified that I can run `devtool modify libxml2`, which I could not do before, and I have run `bitbake core-image-minimal`.
>
> Thanks Peter!  I'll start testing with dunfell this morning.

I did an autobuilder run with your meta-openembedded branch, my
stable/dunfell-nut branch with the 6 patches, and my bitbake
stable/1.46-nut branch with the single patch:

https://autobuilder.yoctoproject.org/typhoon/#/builders/88/builds/921

All was fine except for an error in sysdig: do_compile, which doesn't
appear to be related:

https://errors.yoctoproject.org/Errors/Details/570303/

Unless someone has an objection I'll add the oe-core and bitbake
patches to my next set of review patches.

Steve


> > From: Martin Jansa <martin.jansa@gmail.com>
> > Sent: den 7 februari 2021 12:15
> > To: Martin Jansa <Martin.Jansa@gmail.com>
> > Cc: akuster808 <akuster808@gmail.com>; Peter Kjellerstedt <peter.kjellerstedt@axis.com>; Steve Sakoman <steve@sakoman.com>; Mittal, Anuj <anuj.mittal@intel.com>; OE Core (openembedded-core@lists.openembedded.org) <openembedded-core@lists.openembedded.org>; OE Development (openembedded-devel@lists.openembedded.org) <openembedded-devel@lists.openembedded.org>; BitBake Development (bitbake-devel@lists.openembedded.org) <bitbake-devel@lists.openembedded.org>
> > Subject: Re: [oe] [bitbake-devel] Backport changes for _PYTHON_SYSCONFIGDATA_NAME to Gatesgarth and Dunfell
> >
> >
> >
> > On Sun, Feb 7, 2021 at 12:15 AM Martin Jansa via lists.openembedded.org <Martin.Jansa=gmail.com@lists.openembedded.org> wrote:
> >
> > On Sat, Jan 16, 2021 at 6:52 PM akuster808 <akuster808@gmail.com> wrote:
> >
> >
> >
> > On 1/16/21 9:44 AM, Martin Jansa wrote:
> > > Aren't the missing spaces in appends fixes also needed for meta-oe
> > > recipes?
> >
> >
> > >
> > > I think at least top 5 commits from:
> > > https://git.openembedded.org/meta-openembedded/log/?qt=grep&q=space.*append
> > > were also follow-up from these changes in oe-core.
> > >
> > Do you mean something beyond the meta-openembedded commits mentioned
> > near the bottom of the email?
> >
> >
> >
> > Yes I mean these 5 commits at least.
> >
> >
> >
> > 50bbf80abf python3-pykwalify: Do not unset _PYTHON_SYSCONFIGDATA_NAME
> >
> > 6b3e3bdaf8 python-grpcio-tools: Add missing space for append
> >
> >
> >
> > The first one is just an additional cleanup, but without the 2nd one and with the cherry-picks from the first e-mail applied you would get:
> >
> > ERROR: Nothing PROVIDES 'python3python3-grpcio' (but meta-oe/meta-python/recipes-devtools/python/python3-grpcio-tools_1.14.1.bb DEPENDS on or otherwise requires it). Close matches:
> >   python-grpcio
> >   python3-grpcio
> >
> >
> >
> > my world build is still running..
> >
> >
> >
> >
> >
> > with c99bb790 DEPENDS variable doesn't end with a space, so the missing leading space in these appends (which was fine until now because of trailing space from DEPENDS set in bbclass) is now causing wrong dependency (should be easily reproducible with the patches backported, just by parsing the recipes).
> >
> >
> >
> > I need clarity so I can open an issue in gitlab for tracking purposes as
> > I am sure I will forget this
> >
> >
> >
> > we're using gitlab?
> >
> >
> >
> >
> >
>
> 
>