From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83E5DC433FE for ; Mon, 18 Oct 2021 22:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B3EE6113D for ; Mon, 18 Oct 2021 22:29:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232709AbhJRWbY (ORCPT ); Mon, 18 Oct 2021 18:31:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229524AbhJRWbT (ORCPT ); Mon, 18 Oct 2021 18:31:19 -0400 Received: from mail-ua1-x92e.google.com (mail-ua1-x92e.google.com [IPv6:2607:f8b0:4864:20::92e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B370C06161C for ; Mon, 18 Oct 2021 15:29:08 -0700 (PDT) Received: by mail-ua1-x92e.google.com with SMTP id f3so10955500uap.6 for ; Mon, 18 Oct 2021 15:29:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XMD63kGqlNMIm2FKXXcH/6opQFRwCGdWT3zmw0bkJrA=; b=aKYJXtCHjg2UnpSBovbegHvrjQiiX3aR+c/HFkMZBU2WdysI4FgFgIb+VhXYJYJ/Fk iK2oY2LGnIt902esFd+ID+e7zq5LkydVbKsiV4NsYawJaxuGHILadEQxbrVslmZAQjAK E2cMzdN7w4+72V9KvpnzfS4jOQdQZLDL/EtYaMUX94zllgePPaTFyNfUCcbFw82PS8tL OD/1GlZNj69MvquEwQKhJCmDayJDO0iAiNvrTUvFtdIP71EaESI0iqsw2SLpdb2UUqTW oeulcO37ldGjq5//rxfNwSv8k4TZV8QovvZM7JioV9JGWuk9f4unkLNtw/36UY/R3CQQ 5cPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XMD63kGqlNMIm2FKXXcH/6opQFRwCGdWT3zmw0bkJrA=; b=srgrEASGb9w5guGUj4poTFXMlHMsSdCHQiLsJ25oZCwqvMhidU1ncRd3ccdrUY9Taq TB4DrinRlgNcueczAu/y1b1CwrT4gYB6yuNX2nF3Tngf52gQ71UwgpUfl51OpNpzRAYt qoLB/NdPQFngVBdi2wVrpxxHe8ZcBcSB4xASgrWqx4vW8mFfXCMvsp5Fx44QDTitmMRK 8Gb75PuDuYlldo+G+wb+Dk6mHAVxvm97DdXnbHI71wZAGLF0oAfVXxXjhFGHs5yKR7Xl nSA70+BcQO2e1+0XuHY/W7/sgqbtp+IP7+RD1n6Vc4Ra0DB0bXWcodi1qs29PPvV1tHZ kOZA== X-Gm-Message-State: AOAM530jSdHb08cPiuoydxY3Lef38aIRjo0yc4UMAyZSvvUMHf4yNcjf Njd9Y67QGWLDzGBiMP+7aUr63Mfq/EUlDaKX4vVb6A== X-Google-Smtp-Source: ABdhPJzo0CfetTCPrXkMaZh15zQ32H+Uc/w23A3wWlFLZgyQ214JKsoGDlpvpzAuhdk/f2lsqyFwk935WRE9e4LzKoc= X-Received: by 2002:a9f:23d0:: with SMTP id 74mr28388250uao.131.1634596147043; Mon, 18 Oct 2021 15:29:07 -0700 (PDT) MIME-Version: 1.0 References: <1M9_d6wrcu6rdPe1ON0_k0lOxJMyyot3KAb1gdyuwzDPC777XVUWPHoTCEVmcK3fYfgu7sIo3PSaLe9KulUdm4TWVuqlbKyYGxRAjsf_Cpk=@protonmail.ch> <87ee9pa6xw.fsf@disp2133> <878rzw77i3.fsf@disp2133> <20210929173611.fo5traia77o63gpw@example.org> <20210930130640.wudkpmn3cmah2cjz@example.org> <878rz8wwb6.fsf@disp2133> <87v92cvhbf.fsf@disp2133> <87mtnavszx.fsf_-_@disp2133> <87fssytizw.fsf_-_@disp2133> <871r4itfjw.fsf_-_@disp2133> In-Reply-To: <871r4itfjw.fsf_-_@disp2133> From: Yu Zhao Date: Mon, 18 Oct 2021 16:28:56 -0600 Message-ID: Subject: Re: [PATCH 0/3] ucounts: misc fixes To: "Eric W. Biederman" Cc: Alexey Gladkov , Rune Kleveland , Jordan Glover , LKML , Linux-MM , "containers\\@lists.linux-foundation.org" , Hillf Danton , David Howells , Jarkko Sakkinen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 18, 2021 at 11:21 AM Eric W. Biederman wrote: > > > While digging into the previous ucount kernel crashes I found some minor > bugs in the ucount code. When hit these bugs all result in a ucount > either being counted in the wrong location or leak of a struct ucounts. > > Nothing particularly serious but certainly things that should be fixed. > > Eric W. Biederman (3): > ucounts: Pair inc_rlimit_ucounts with dec_rlimit_ucoutns in commit_creds > ucounts: Proper error handling in set_cred_ucounts > ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring > > kernel/cred.c | 9 ++++----- > security/keys/process_keys.c | 8 ++++++++ > 2 files changed, 12 insertions(+), 5 deletions(-) Thanks for the fixes. Tested the whole series on the latest 5.15-rc6. Tested-by: Yu Zhao