From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA5CBC433F5 for ; Wed, 20 Apr 2022 00:51:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358606AbiDTAxv (ORCPT ); Tue, 19 Apr 2022 20:53:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357203AbiDTAxt (ORCPT ); Tue, 19 Apr 2022 20:53:49 -0400 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [IPv6:2607:f8b0:4864:20::e32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7ACAD28E2E for ; Tue, 19 Apr 2022 17:51:05 -0700 (PDT) Received: by mail-vs1-xe32.google.com with SMTP id m14so145499vsp.11 for ; Tue, 19 Apr 2022 17:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h7H+ruNwzO0FOIHU2htbNl3Kgc9iK+Bls9V1N1i8rMc=; b=OnOMTCYq6051btEbQdA/SW6lBMQiN41PdkjZlZG9x+F5Z2Fp5ZPf9z3O5FGQD5I3Bt Aqu7Ir9V4PuJOLUX9+z0nt4ZBEu7ggItdDaVZUwN89XoqjYFb6VBywYIUchsvFvvv1rI bzHI8BCjqL8SdtnES04F7vRBggnpY9MAgIO8xVKkizf12bGKssGMk4bSgP8B4IH1yS/E zfYNJ3dwvbrKbqzRglxjYZA35Q1DlfsX8LSRzy0XMy7bChgH6VA+85s9R9/TGye6bm4a jnN+Ldnj+yMwk7NhkcyubqFwa4NQNmZS+LtzcgI5ImpG+dVAsJIIVacqu1rkoYOv3lfv mT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h7H+ruNwzO0FOIHU2htbNl3Kgc9iK+Bls9V1N1i8rMc=; b=WSmsqh0jXP4SRXdnyycsG6kf3U2cFacAZtEqJrmaz8/rTNImkg3sWL9jiO0fjdNHS0 VhUZ/YST1uFFJnaXj1lZq6trKcU2ce9J67BMntaN9mjyYbbxOYlmrwbEJqYnkfqnYW9M vmvtEk12rHTlAPE1tvBLSgatuA13xdIdN5aOcbQf6WKJHYZemnTvtv1RW0yXG2L4bvCG NWpKuXNGCiYOuwvO/z2kES52S4NvZ/rlPiPIL1wEbP2Yrhrpm/0/ZyC1N0onegoJnID1 igU3koMXUU+HoEMgmsMPEh33zSnzMZQYuQxdo/kzQV5IKxiaNTDOC1nENWJ+0WngxH2m +9HQ== X-Gm-Message-State: AOAM5324UHZldQ2xl2yvAQl91lCCPwmdCgqEl7mociwAtjCK+xI1X+yN QPdXtGUhTo5jnikIW33IpT/uAYsmA/AA1cX8wNcApQ== X-Google-Smtp-Source: ABdhPJwuEo0eOW39/zOg7eYcPPJSP/xsmVyuFfGg9nS0PhO8HBJcxJV/zMegVDXjYoxfbeDFOkSb45wsppx48DRHipM= X-Received: by 2002:a05:6102:5cc:b0:320:9bd2:3823 with SMTP id v12-20020a05610205cc00b003209bd23823mr5664333vsf.81.1650415864537; Tue, 19 Apr 2022 17:51:04 -0700 (PDT) MIME-Version: 1.0 References: <20220407031525.2368067-1-yuzhao@google.com> <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> In-Reply-To: <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> From: Yu Zhao Date: Tue, 19 Apr 2022 18:50:28 -0600 Message-ID: Subject: Re: [PATCH v10 00/14] Multi-Gen LRU Framework To: Andrew Morton Cc: Stephen Rothwell , Linux-MM , Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , Linux ARM , "open list:DOCUMENTATION" , linux-kernel , Kernel Page Reclaim v2 , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 13, 2022 at 11:06 PM Andrew Morton wrote: > > The code uses > > struct lru_gen_mm_walk *walk > > in some places and > > struct mm_walk *walk > > in others. This is already driving me nuts. Can we please use > different identifiers for different types? Sorry. Going with "struct lru_gen_mm_walk *args", unless there are objections. ("struct mm_walk *walk" is an existing convention so I don't think I should change that.) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEB6DC433EF for ; Wed, 20 Apr 2022 00:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5qa+o+Q2yHMA9ZkMKwQCEskX6UODlcMB6Zii7IYPATs=; b=A+TkhPfUSpS+ZK /ZBgiGfLT7oPIFacAkla0RrmrF8o1uFrPw2oX2L2H8a57QJu8hBGbaqWS0LAVxCglnr52+MIYJ/ku Y1AHeRoLLLqyuNOnh6HWAAyFLB4pWrx5uQd3Nf8d/CN6M09uLUront2uX7sScVRZfuhH7x4bJnshK q/kDPD0icWPi92XPtG93SAZRAq1z3WyHJomB1fGrYldimb7Dok3ZYq1YWUkjcT6V3byZ3CYWvtoCl iaprngt0nvc1klKQtwPUMSe97VK0VGrUrR1JX+fDzh1IFXriOq0w1BNeIU8Ol/p2E24h7hPa52pfQ PFkM+nY5EZyT5GJPpMPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngyYo-006jo4-1b; Wed, 20 Apr 2022 00:51:10 +0000 Received: from mail-vs1-xe34.google.com ([2607:f8b0:4864:20::e34]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngyYk-006jmS-76 for linux-arm-kernel@lists.infradead.org; Wed, 20 Apr 2022 00:51:08 +0000 Received: by mail-vs1-xe34.google.com with SMTP id v133so156943vsv.7 for ; Tue, 19 Apr 2022 17:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h7H+ruNwzO0FOIHU2htbNl3Kgc9iK+Bls9V1N1i8rMc=; b=OnOMTCYq6051btEbQdA/SW6lBMQiN41PdkjZlZG9x+F5Z2Fp5ZPf9z3O5FGQD5I3Bt Aqu7Ir9V4PuJOLUX9+z0nt4ZBEu7ggItdDaVZUwN89XoqjYFb6VBywYIUchsvFvvv1rI bzHI8BCjqL8SdtnES04F7vRBggnpY9MAgIO8xVKkizf12bGKssGMk4bSgP8B4IH1yS/E zfYNJ3dwvbrKbqzRglxjYZA35Q1DlfsX8LSRzy0XMy7bChgH6VA+85s9R9/TGye6bm4a jnN+Ldnj+yMwk7NhkcyubqFwa4NQNmZS+LtzcgI5ImpG+dVAsJIIVacqu1rkoYOv3lfv mT6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h7H+ruNwzO0FOIHU2htbNl3Kgc9iK+Bls9V1N1i8rMc=; b=tsGzD9tKrNbhnz1WHc8VAvPZq5JB8wTAUGnFdraefqNd3G5iYl510Gg5cWA4QxhaVX PMpPtmLe6AFAx7itSJNpMHX8F6hOuBtEJCH0Bh05pSxgoeldAe1gW8gRW6jlxDaptKeW N6FX3ZbKSrAXwhxVZ5k+nJFKCUTNwAYK6aaVfCLVrTW7XENw9i6UbyuPhi+JWvWvSniP 4qaJWLurC6OlTUrXmpAUo/Bpk6i3xiZalKxOSIWDB/6pbskpfw4wK4Ps646qyM1EHe3E FDCXpIH9BUb7jMNk0bTmoRpgIQQauXfJ3nzZCyjbT9G05lrv9mn+Fl3oC0EWoHF1e6gQ R1RA== X-Gm-Message-State: AOAM530S9QPxZ4VniH5gUcUrx/mfEmX8d5ddwYusnnCVKZ5x1Vo0IARf MV14QoteOXuMs3F6jsTQxn7etBkW4aUB2cu6Eudx+A== X-Google-Smtp-Source: ABdhPJwuEo0eOW39/zOg7eYcPPJSP/xsmVyuFfGg9nS0PhO8HBJcxJV/zMegVDXjYoxfbeDFOkSb45wsppx48DRHipM= X-Received: by 2002:a05:6102:5cc:b0:320:9bd2:3823 with SMTP id v12-20020a05610205cc00b003209bd23823mr5664333vsf.81.1650415864537; Tue, 19 Apr 2022 17:51:04 -0700 (PDT) MIME-Version: 1.0 References: <20220407031525.2368067-1-yuzhao@google.com> <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> In-Reply-To: <20220413220636.dd33898d36156bc7339f04e9@linux-foundation.org> From: Yu Zhao Date: Tue, 19 Apr 2022 18:50:28 -0600 Message-ID: Subject: Re: [PATCH v10 00/14] Multi-Gen LRU Framework To: Andrew Morton Cc: Stephen Rothwell , Linux-MM , Andi Kleen , Aneesh Kumar , Barry Song <21cnbao@gmail.com>, Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Jesse Barnes , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Rik van Riel , Vlastimil Babka , Will Deacon , Ying Huang , Linux ARM , "open list:DOCUMENTATION" , linux-kernel , Kernel Page Reclaim v2 , "the arch/x86 maintainers" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220419_175106_281456_15B19257 X-CRM114-Status: GOOD ( 13.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 13, 2022 at 11:06 PM Andrew Morton wrote: > > The code uses > > struct lru_gen_mm_walk *walk > > in some places and > > struct mm_walk *walk > > in others. This is already driving me nuts. Can we please use > different identifiers for different types? Sorry. Going with "struct lru_gen_mm_walk *args", unless there are objections. ("struct mm_walk *walk" is an existing convention so I don't think I should change that.) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel