From: Robert Marko <robimarko@gmail.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: angelo@amarulasolutions.com, yann.morin.1998@free.fr,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v3] package/mdio-tools: new package
Date: Thu, 27 Oct 2022 11:58:02 +0200 [thread overview]
Message-ID: <CAOX2RU5mJ5bD76Qu8KMR8LgS2sYzGCNER41cMvXNpfJtpZhVng@mail.gmail.com> (raw)
In-Reply-To: <20221027115529.0ac5cb5d@windsurf>
On Thu, 27 Oct 2022 at 11:55, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello Robert,
>
> On Thu, 27 Oct 2022 10:56:28 +0200
> Robert Marko <robimarko@gmail.com> wrote:
>
> > mdio-tools are kernel module and accompanying tools for low-level
> > debugging of devices attached on MDIO bus like PHY-s, switches etc.
> >
> > Userspace tools provide C22 or C45 reads and writes, benchmarking
> > and even dedicated Marvell Link Street tools via the included
> > kernel module.
> >
> > Signed-off-by: Robert Marko <robimarko@gmail.com>
>
> Thanks, I have applied your patch, with two small changes. See below.
>
> > package/Config.in | 1 +
> > package/mdio-tools/Config.in | 10 ++++++++++
> > package/mdio-tools/mdio-tools.hash | 3 +++
> > package/mdio-tools/mdio-tools.mk | 20 ++++++++++++++++++++
> > 4 files changed, 34 insertions(+)
>
> The entry in the DEVELOPERS file was missing, so I've added it.
>
> > diff --git a/package/mdio-tools/Config.in b/package/mdio-tools/Config.in
> > new file mode 100644
> > index 0000000000..8a09bf19a7
> > --- /dev/null
> > +++ b/package/mdio-tools/Config.in
> > @@ -0,0 +1,10 @@
> > +comment "mdio-tools needs a Linux kernel to be built"
> > + depends on !BR2_LINUX_KERNEL
> > +
> > +config BR2_PACKAGE_MDIO_TOOLS
> > + bool "mdio-tools"
> > + depends on BR2_LINUX_KERNEL
> > + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
>
> We like to have a Config.in comment corresponding to this dependency,
> so I've added it:
>
> +comment "mdio-tools needs a toolchain w/ headers >= 5.1"
> + depends on !BR2_LINUX_KERNEL
> + depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_1
>
> And I know I realize that the depends on !BR2_LINUX_KERNEL should have
> been a depends on BR2_LINUX_KERNEL. I will fix that up.
Thanks for fixing it up, it is my first time contributing to Buildroot
so its all a bit
new to me.
Regards,
Robert
>
> Thanks for the contribution!
>
> Thomas
> --
> Thomas Petazzoni, co-owner and CEO, Bootlin
> Embedded Linux and Kernel engineering and training
> https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-10-27 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 8:56 [Buildroot] [PATCH v3] package/mdio-tools: new package Robert Marko
2022-10-27 9:55 ` Thomas Petazzoni via buildroot
2022-10-27 9:58 ` Robert Marko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOX2RU5mJ5bD76Qu8KMR8LgS2sYzGCNER41cMvXNpfJtpZhVng@mail.gmail.com \
--to=robimarko@gmail.com \
--cc=angelo@amarulasolutions.com \
--cc=buildroot@buildroot.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.