All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Marko <robimarko@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	krzysztof.kozlowski+dt@linaro.org,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Devicetree List <devicetree@vger.kernel.org>,
	linux-clk@vger.kernel.org, dmitry.baryshkov@linaro.org
Subject: Re: [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells
Date: Sat, 7 May 2022 22:37:58 +0200	[thread overview]
Message-ID: <CAOX2RU6DCueDU02Qmx9xLNVP0uWX2z+3ia5Oem30gj-jdWdcQw@mail.gmail.com> (raw)
In-Reply-To: <7316927c-3068-90b6-3500-bf759bb46493@linaro.org>

On Thu, 5 May 2022 at 10:37, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 03/05/2022 21:56, Robert Marko wrote:
> > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > index 3b5ba7ecc19d..1f803925867e 100644
> > --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> > @@ -50,7 +50,7 @@ properties:
> >      const: 1
> >
> >    '#clock-cells':
> > -    const: 0
> > +    enum: [0, 1]
> >
> >    clock-names:
> >      minItems: 2
> > @@ -96,6 +96,22 @@ allOf:
> >        properties:
> >          clocks:
> >            maxItems: 3
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - qcom,ipq6018-apcs-apps-global
> > +            - qcom,ipq8074-apcs-apps-global
> > +    then:
> > +      properties:
> > +        '#clock-cells':
> > +          const: 1
> > +
>
> If there is a respin, please drop this blank line.

Done as part of v3, thanks.

Regards,
Robert
>
> > +    else:
> > +      properties:
> > +        '#clock-cells':
> > +          const: 0
> > +
> >  examples:
> >
> >    # Example apcs with msm8996
>
>
> Best regards,
> Krzysztof

  reply	other threads:[~2022-05-07 20:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-03 19:56 [PATCH v2 1/6] clk: qcom: clk-alpha-pll: add support for APSS PLL Robert Marko
2022-05-03 19:56 ` [PATCH v2 2/6] dt-bindings: clock: Add support for IPQ8074 APSS clock controller Robert Marko
2022-05-04 20:08   ` Rob Herring
2022-05-04 20:45     ` Robert Marko
2022-05-09 21:12       ` Rob Herring
2022-05-10 15:58         ` Robert Marko
2022-05-03 19:56 ` [PATCH v2 3/6] clk: qcom: Add " Robert Marko
2022-05-03 19:56 ` [PATCH v2 4/6] mailbox: qcom-apcs-ipc: add IPQ8074 APSS clock controller support Robert Marko
2022-05-03 19:56 ` [PATCH v2 5/6] dt-bindings: mailbox: qcom: set correct #clock-cells Robert Marko
2022-05-05  8:37   ` Krzysztof Kozlowski
2022-05-07 20:37     ` Robert Marko [this message]
2022-05-03 19:56 ` [PATCH v2 6/6] arm64: dts: ipq8074: update APCS node due to clock support Robert Marko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOX2RU6DCueDU02Qmx9xLNVP0uWX2z+3ia5Oem30gj-jdWdcQw@mail.gmail.com \
    --to=robimarko@gmail.com \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=jassisinghbrar@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.