All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Schake <stschake@gmail.com>
To: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>,
	linux-rpi-kernel@lists.infradead.org,
	dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/vc4: Add support for plane alpha
Date: Sat, 21 Apr 2018 02:07:21 +0200	[thread overview]
Message-ID: <CAOZHkRwOxUwfpDuu=XOGwT-mwy_U7_b7N4xQS0XYXjQrcpykEQ@mail.gmail.com> (raw)
In-Reply-To: <87zi1xa1dg.fsf@anholt.net>

On Sat, Apr 21, 2018 at 1:45 AM, Eric Anholt <eric@anholt.net> wrote:
> Stefan Schake <stschake@gmail.com> writes:
>
>> The HVS supports mixing fixed alpha with per-pixel alpha or
>> setting a fixed plane alpha in case there is no per-pixel information.
>> This allows us to support the generic DRM plane alpha property.
>
> Don't we need to set needs_bg_fill based on alpha != OPAQUE, as well?
>
> Other than that, looks good to me.

I did forget about the whole background situation, and a quick test
shows you are right: anything less than opaque has the funky
repeating pattern artifact.

Thanks, I'll send a new version.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-04-21  0:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 23:05 [PATCH] drm/vc4: Add support for plane alpha Stefan Schake
2018-04-20 23:45 ` Eric Anholt
2018-04-21  0:07   ` Stefan Schake [this message]
2018-04-22 18:56 ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOZHkRwOxUwfpDuu=XOGwT-mwy_U7_b7N4xQS0XYXjQrcpykEQ@mail.gmail.com' \
    --to=stschake@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-rpi-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.