From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE81CC43331 for ; Tue, 12 Nov 2019 05:18:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0D4721783 for ; Tue, 12 Nov 2019 05:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573535880; bh=+sjdYVv8CDJT89mCUOL1IQ+FuBUStP5YIxV+BRhizMI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=RA0QbSgvUcBL4U/WsZIyDq61xj/SGV4+cnZa0y73i9zQ7a9t0voT4z3Q2lnmPSvdr GYzAbz+cOMczz5AHBCZtLkOuK0Dd+DM8q/eVLLJPshMA1MJdAZEVt8SJD4uvANDV+T 1ikuQgP2W4Ad3amr68JtbtXvgyd9KVAy6LtzDHzU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726008AbfKLFR7 (ORCPT ); Tue, 12 Nov 2019 00:17:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:58012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725283AbfKLFR7 (ORCPT ); Tue, 12 Nov 2019 00:17:59 -0500 Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 629E021783 for ; Tue, 12 Nov 2019 05:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573535878; bh=+sjdYVv8CDJT89mCUOL1IQ+FuBUStP5YIxV+BRhizMI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AwabfAw/3h3DTKe7ptAw21A+aiLqSS9Yxtb7Av60cvCyaX4JpmVRVRr8OsqAf4lNV QEz7Mq+KHshF2+zP6/N541Gce1O1w8RSqjiJso4xEz746D4OsJ0PWU9AL+EsC4yve/ 7mPCYSMKbwQdGzxYkXiLnR/LlvpOcRHS0co25vjo= Received: by mail-qv1-f45.google.com with SMTP id c9so5884916qvz.9 for ; Mon, 11 Nov 2019 21:17:58 -0800 (PST) X-Gm-Message-State: APjAAAVseOsIPduV6i6hCBBs0xyEEIT4ucxkABRnbEzRk2j9+IKvdMA0 mG/I2Ye2ibj8EwUqqZ7zEuLqsWCzJQy6SNu9ba4= X-Google-Smtp-Source: APXvYqyRMq8MPHBbv10LcomZfNYFYesotjA4C4S3ZUC/cErDRyyFxBF01/9DX6UFwCBG6keYQ/6e7NX4CI4hPzjyXJo= X-Received: by 2002:ad4:462d:: with SMTP id x13mr7948364qvv.105.1573535877525; Mon, 11 Nov 2019 21:17:57 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-5-linux@rasmusvillemoes.dk> In-Reply-To: <20191108130123.6839-5-linux@rasmusvillemoes.dk> From: Timur Tabi Date: Mon, 11 Nov 2019 23:17:19 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 04/47] soc: fsl: qe: introduce qe_io{read,write}* wrappers To: Rasmus Villemoes Cc: Qiang Zhao , Li Yang , Christophe Leroy , Scott Wood , linuxppc-dev@lists.ozlabs.org, lkml , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes wrote: > > The QUICC engine drivers use the powerpc-specific out_be32() etc. In > order to allow those drivers to build for other architectures, those > must be replaced by iowrite32be(). However, on powerpc, out_be32() is > a simple inline function while iowrite32be() is out-of-line. So in > order not to introduce a performance regression on powerpc when making > the drivers work on other architectures, introduce qe_io* helpers. Isn't it also true that iowrite32be() assumes a little-endian platform and always does a byte swap? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C6AC43331 for ; Tue, 12 Nov 2019 05:20:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EE8A214E0 for ; Tue, 12 Nov 2019 05:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AwabfAw/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EE8A214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47Bwzx5Vq9zF3tb for ; Tue, 12 Nov 2019 16:20:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=timur@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="AwabfAw/"; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47BwxP51M3zDrJ5 for ; Tue, 12 Nov 2019 16:18:00 +1100 (AEDT) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61D1A214E0 for ; Tue, 12 Nov 2019 05:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573535878; bh=+sjdYVv8CDJT89mCUOL1IQ+FuBUStP5YIxV+BRhizMI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AwabfAw/3h3DTKe7ptAw21A+aiLqSS9Yxtb7Av60cvCyaX4JpmVRVRr8OsqAf4lNV QEz7Mq+KHshF2+zP6/N541Gce1O1w8RSqjiJso4xEz746D4OsJ0PWU9AL+EsC4yve/ 7mPCYSMKbwQdGzxYkXiLnR/LlvpOcRHS0co25vjo= Received: by mail-qv1-f45.google.com with SMTP id f12so5909228qvu.3 for ; Mon, 11 Nov 2019 21:17:58 -0800 (PST) X-Gm-Message-State: APjAAAXXtzOAz9Fiv+CgFvitl5g5CfBqD4mkIbvIGuiq0V90OoLwqV+b 3BylTtiP80FGq+B/t5oyL9wKW3kgQ4iMTb8Xscg= X-Google-Smtp-Source: APXvYqyRMq8MPHBbv10LcomZfNYFYesotjA4C4S3ZUC/cErDRyyFxBF01/9DX6UFwCBG6keYQ/6e7NX4CI4hPzjyXJo= X-Received: by 2002:ad4:462d:: with SMTP id x13mr7948364qvv.105.1573535877525; Mon, 11 Nov 2019 21:17:57 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-5-linux@rasmusvillemoes.dk> In-Reply-To: <20191108130123.6839-5-linux@rasmusvillemoes.dk> From: Timur Tabi Date: Mon, 11 Nov 2019 23:17:19 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 04/47] soc: fsl: qe: introduce qe_io{read, write}* wrappers To: Rasmus Villemoes Content-Type: text/plain; charset="UTF-8" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lkml , Li Yang , Scott Wood , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes wrote: > > The QUICC engine drivers use the powerpc-specific out_be32() etc. In > order to allow those drivers to build for other architectures, those > must be replaced by iowrite32be(). However, on powerpc, out_be32() is > a simple inline function while iowrite32be() is out-of-line. So in > order not to introduce a performance regression on powerpc when making > the drivers work on other architectures, introduce qe_io* helpers. Isn't it also true that iowrite32be() assumes a little-endian platform and always does a byte swap? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66ADBC43331 for ; Tue, 12 Nov 2019 05:18:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2B186214E0 for ; Tue, 12 Nov 2019 05:18:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NbdW7z3C"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="AwabfAw/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B186214E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7rmYbmgtA/sFoVHGjkOQPdYXsGAaVjwC+q6wwOSw+ko=; b=NbdW7z3CqT/LIK NUZ6qsJ5PRK1EyzNOh7lnn1lJWloihblqoLx1nGwGpsS8tB8GfQgnFSbXcW2qkpjLW9S9cImFE4jH hQAME4z9ZuTL5i2VqA7vyqScNrrD3apG7ZkOwq46Xm8ZF0ZTZ4OsZ+M5Dv89AGcbzlis6qTjI5nJa +CtVJhVT2aJWZPJckVcueI9Ne37f8tfriQznNVxW3Kh323RheccAQQLaexzoDGM3tjufAeyQDSR3K hwxcDDS/sfPv6mGUsvFlEePcdJLpeYKkGeNU7AiduGLrgQo7FPkc8sxxMFFMuT/So752IprKVXJe2 IA2jxX5rYXmKV8Y6Sa8w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOZ3-000892-BE; Tue, 12 Nov 2019 05:18:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iUOZ0-00088S-8j for linux-arm-kernel@lists.infradead.org; Tue, 12 Nov 2019 05:18:03 +0000 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 732FF21D7F for ; Tue, 12 Nov 2019 05:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573535878; bh=+sjdYVv8CDJT89mCUOL1IQ+FuBUStP5YIxV+BRhizMI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=AwabfAw/3h3DTKe7ptAw21A+aiLqSS9Yxtb7Av60cvCyaX4JpmVRVRr8OsqAf4lNV QEz7Mq+KHshF2+zP6/N541Gce1O1w8RSqjiJso4xEz746D4OsJ0PWU9AL+EsC4yve/ 7mPCYSMKbwQdGzxYkXiLnR/LlvpOcRHS0co25vjo= Received: by mail-qv1-f43.google.com with SMTP id v16so5896484qvq.6 for ; Mon, 11 Nov 2019 21:17:58 -0800 (PST) X-Gm-Message-State: APjAAAVh1i+JZORCqXE7TO3/asyb9tyNiJgHPCxxCyEA2L6YF/tge3l3 LR/5etGjUi1psEtDyIVWbIA8hTLMk6ev/+9LDOY= X-Google-Smtp-Source: APXvYqyRMq8MPHBbv10LcomZfNYFYesotjA4C4S3ZUC/cErDRyyFxBF01/9DX6UFwCBG6keYQ/6e7NX4CI4hPzjyXJo= X-Received: by 2002:ad4:462d:: with SMTP id x13mr7948364qvv.105.1573535877525; Mon, 11 Nov 2019 21:17:57 -0800 (PST) MIME-Version: 1.0 References: <20191108130123.6839-1-linux@rasmusvillemoes.dk> <20191108130123.6839-5-linux@rasmusvillemoes.dk> In-Reply-To: <20191108130123.6839-5-linux@rasmusvillemoes.dk> From: Timur Tabi Date: Mon, 11 Nov 2019 23:17:19 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 04/47] soc: fsl: qe: introduce qe_io{read, write}* wrappers To: Rasmus Villemoes X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191111_211802_330090_736BCB14 X-CRM114-Status: GOOD ( 10.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christophe Leroy , lkml , Li Yang , Scott Wood , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel , Qiang Zhao Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 8, 2019 at 7:03 AM Rasmus Villemoes wrote: > > The QUICC engine drivers use the powerpc-specific out_be32() etc. In > order to allow those drivers to build for other architectures, those > must be replaced by iowrite32be(). However, on powerpc, out_be32() is > a simple inline function while iowrite32be() is out-of-line. So in > order not to introduce a performance regression on powerpc when making > the drivers work on other architectures, introduce qe_io* helpers. Isn't it also true that iowrite32be() assumes a little-endian platform and always does a byte swap? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel