From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH v4 1/4] ACPI: parse SPCR and enable matching console Date: Thu, 17 Mar 2016 12:20:05 -0500 Message-ID: References: <1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org> <1456747355-15692-2-git-send-email-aleksey.makarov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:53411 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965483AbcCQRUO (ORCPT ); Thu, 17 Mar 2016 13:20:14 -0400 In-Reply-To: <1456747355-15692-2-git-send-email-aleksey.makarov@linaro.org> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Aleksey Makarov Cc: linux-acpi@vger.kernel.org, linux-serial@vger.kernel.org, lkml , "linux-arm-kernel@lists.infradead.org" , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm , Graeme Gregory , Al Stone , Christopher Covington , Yury Norov , Peter Hurley , "Zheng, Lv" , Len Brown , Jiri Slaby On Mon, Feb 29, 2016 at 6:02 AM, Aleksey Makarov wrote: > 'ARM Server Base Boot Requiremets' [1] mentions SPCR (Serial Port > Console Redirection Table) [2] as a mandatory ACPI table that > specifies the configuration of serial console. > > Parse this table and check if any registered console match the > description. If it does, enable that console. > > Introduce a new function acpi_console_check(). At the uart port > registration, this function checks if the ACPI SPCR table specifies > its argument of type struct uart_port to be a console > and if so calls add_preferred_console(). > > [1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html > [2] http://msdn.microsoft.com/en-us/library/windows/hardware/dn639131(v=vs.85).aspx > > Signed-off-by: Aleksey Makarov Tested-by: Timur Tabi I know another version of patch is coming, but I tested this version and it works. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967272AbcCQRUT (ORCPT ); Thu, 17 Mar 2016 13:20:19 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53411 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965483AbcCQRUO (ORCPT ); Thu, 17 Mar 2016 13:20:14 -0400 MIME-Version: 1.0 In-Reply-To: <1456747355-15692-2-git-send-email-aleksey.makarov@linaro.org> References: <1456747355-15692-1-git-send-email-aleksey.makarov@linaro.org> <1456747355-15692-2-git-send-email-aleksey.makarov@linaro.org> Date: Thu, 17 Mar 2016 12:20:05 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 1/4] ACPI: parse SPCR and enable matching console From: Timur Tabi To: Aleksey Makarov Cc: linux-acpi@vger.kernel.org, linux-serial@vger.kernel.org, lkml , "linux-arm-kernel@lists.infradead.org" , Russell King , Greg Kroah-Hartman , "Rafael J . Wysocki" , Leif Lindholm , Graeme Gregory , Al Stone , Christopher Covington , Yury Norov , Peter Hurley , "Zheng, Lv" , Len Brown , Jiri Slaby Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 29, 2016 at 6:02 AM, Aleksey Makarov wrote: > 'ARM Server Base Boot Requiremets' [1] mentions SPCR (Serial Port > Console Redirection Table) [2] as a mandatory ACPI table that > specifies the configuration of serial console. > > Parse this table and check if any registered console match the > description. If it does, enable that console. > > Introduce a new function acpi_console_check(). At the uart port > registration, this function checks if the ACPI SPCR table specifies > its argument of type struct uart_port to be a console > and if so calls add_preferred_console(). > > [1] http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.den0044a/index.html > [2] http://msdn.microsoft.com/en-us/library/windows/hardware/dn639131(v=vs.85).aspx > > Signed-off-by: Aleksey Makarov Tested-by: Timur Tabi I know another version of patch is coming, but I tested this version and it works. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.