From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sumit Semwal Subject: Re: [PATCH 3/3] dma-fence: Introduce drm_fence_set_error() helper Date: Mon, 9 Jan 2017 20:13:11 +0530 Message-ID: References: <20170104141222.6992-1-chris@chris-wilson.co.uk> <20170104141222.6992-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170104141222.6992-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: Intel Graphics Development , DRI mailing list List-Id: dri-devel@lists.freedesktop.org SGkgQ2hyaXMsCgpPbiA0IEphbnVhcnkgMjAxNyBhdCAxOTo0MiwgQ2hyaXMgV2lsc29uIDxjaHJp c0BjaHJpcy13aWxzb24uY28udWs+IHdyb3RlOgo+IFRoZSBkbWFfZmVuY2UuZXJyb3IgZmllbGQg KGZvcm1lcmx5IGtub3duIGFzIGRtYV9mZW5jZS5zdGF0dXMpIGlzIGFuCj4gb3B0aW9uYWwgZmll bGQgdGhhdCBtYXkgYmUgc2V0IGJ5IGRyaXZlcnMgYmVmb3JlIGNhbGxpbmcKPiBkbWFfZmVuY2Vf c2lnbmFsKCkuIFRoZSBmaWVsZCBjYW4gYmUgdXNlZCB0byBpbmRpY2F0ZSB0aGF0IHRoZSBmZW5j ZSB3YXMKPiBjb21wbGV0ZWQgaW4gZXJyIHJhdGhlciB0aGFuIHdpdGggc3VjY2VzcywgYW5kIGlz IHZpc2libGUgdG8gb3RoZXIKPiBjb25zdW1lcnMgb2YgdGhlIGZlbmNlIGFuZCB0byB1c2Vyc3Bh Y2UgdmlhIHN5bmNfZmlsZS4KPgo+IFRoaXMgcGF0Y2ggcmVuYW1lcyB0aGUgZmllbGQgZnJvbSBz dGF0dXMgdG8gZXJyb3Igc28gdGhhdCBpdHMgbWVhbmluZyBpcwo+IGhvcGVmdWxseSBtb3JlIGNs ZWFyIChhbmQgZGlzdGluY3QgZnJvbSBkbWFfZmVuY2VfZ2V0X3N0YXR1cygpIHdoaWNoIGlzCj4g YSBjb21wb3NpdGUgYmV0d2VlbiB0aGUgZXJyb3Igc3RhdGUgYW5kIHNpZ25hbCBzdGF0ZSkgYW5k IGFkZHMgYSBoZWxwZXIKPiB0aGF0IHZhbGlkYXRlcyB0aGUgcHJlY29uZGl0aW9ucyBvZiB3aGVu IGl0IGlzIHN1aXRhYmxlIHRvIGFkanVzdCB0aGUKPiBlcnJvciBmaWVsZC4KPgo+IFNpZ25lZC1v ZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBk cml2ZXJzL2RtYS1idWYvZG1hLWZlbmNlLmMgfCAgMiArLQo+ICBpbmNsdWRlL2xpbnV4L2RtYS1m ZW5jZS5oICAgfCAzMCArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0KPiAgMiBmaWxlcyBj aGFuZ2VkLCAyNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZG1hLWJ1Zi9kbWEtZmVuY2UuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtZmVuY2Uu Ywo+IGluZGV4IDdkOTM2ZDE5ZTY1OS4uZWU4MmYzNmNiMjVlIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZG1hLWJ1Zi9kbWEtZmVuY2UuYwo+ICsrKyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtZmVuY2Uu Ywo+IEBAIC01NTksNyArNTU5LDcgQEAgZG1hX2ZlbmNlX2luaXQoc3RydWN0IGRtYV9mZW5jZSAq ZmVuY2UsIGNvbnN0IHN0cnVjdCBkbWFfZmVuY2Vfb3BzICpvcHMsCj4gICAgICAgICBmZW5jZS0+ Y29udGV4dCA9IGNvbnRleHQ7Cj4gICAgICAgICBmZW5jZS0+c2Vxbm8gPSBzZXFubzsKPiAgICAg ICAgIGZlbmNlLT5mbGFncyA9IDBVTDsKPiAtICAgICAgIGZlbmNlLT5zdGF0dXMgPSAwOwo+ICsg ICAgICAgZmVuY2UtPmVycm9yID0gMDsKPgo+ICAgICAgICAgdHJhY2VfZG1hX2ZlbmNlX2luaXQo ZmVuY2UpOwo+ICB9Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvZG1hLWZlbmNlLmggYi9p bmNsdWRlL2xpbnV4L2RtYS1mZW5jZS5oCj4gaW5kZXggMTlmN2FmOTA1MTgyLi42MDQ4ZmE0MDRl NTcgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9kbWEtZmVuY2UuaAo+ICsrKyBiL2luY2x1 ZGUvbGludXgvZG1hLWZlbmNlLmgKPiBAQCAtNDcsNyArNDcsNyBAQCBzdHJ1Y3QgZG1hX2ZlbmNl X2NiOwo+ICAgKiBjYW4gYmUgY29tcGFyZWQgdG8gZGVjaWRlIHdoaWNoIGZlbmNlIHdvdWxkIGJl IHNpZ25hbGVkIGxhdGVyLgo+ICAgKiBAZmxhZ3M6IEEgbWFzayBvZiBETUFfRkVOQ0VfRkxBR18q IGRlZmluZWQgYmVsb3cKPiAgICogQHRpbWVzdGFtcDogVGltZXN0YW1wIHdoZW4gdGhlIGZlbmNl IHdhcyBzaWduYWxlZC4KPiAtICogQHN0YXR1czogT3B0aW9uYWwsIG9ubHkgdmFsaWQgaWYgPCAw LCBtdXN0IGJlIHNldCBiZWZvcmUgY2FsbGluZwo+ICsgKiBAZXJyb3I6IE9wdGlvbmFsLCBvbmx5 IHZhbGlkIGlmIDwgMCwgbXVzdCBiZSBzZXQgYmVmb3JlIGNhbGxpbmcKPiAgICogZG1hX2ZlbmNl X3NpZ25hbCwgaW5kaWNhdGVzIHRoYXQgdGhlIGZlbmNlIGhhcyBjb21wbGV0ZWQgd2l0aCBhbiBl cnJvci4KPiAgICoKPiAgICogdGhlIGZsYWdzIG1lbWJlciBtdXN0IGJlIG1hbmlwdWxhdGVkIGFu ZCByZWFkIHVzaW5nIHRoZSBhcHByb3ByaWF0ZQo+IEBAIC03OSw3ICs3OSw3IEBAIHN0cnVjdCBk bWFfZmVuY2Ugewo+ICAgICAgICAgdW5zaWduZWQgc2Vxbm87Cj4gICAgICAgICB1bnNpZ25lZCBs b25nIGZsYWdzOwo+ICAgICAgICAga3RpbWVfdCB0aW1lc3RhbXA7Cj4gLSAgICAgICBpbnQgc3Rh dHVzOwo+ICsgICAgICAgaW50IGVycm9yOwo+ICB9Owo+Cj4gIGVudW0gZG1hX2ZlbmNlX2ZsYWdf Yml0cyB7Cj4gQEAgLTEzMyw3ICsxMzMsNyBAQCBzdHJ1Y3QgZG1hX2ZlbmNlX2NiIHsKPiAgICog b3Igc29tZSBmYWlsdXJlIG9jY3VycmVkIHRoYXQgbWFkZSBpdCBpbXBvc3NpYmxlIHRvIGVuYWJs ZQo+ICAgKiBzaWduYWxpbmcuIFRydWUgaW5kaWNhdGVzIHN1Y2Nlc3NmdWwgZW5hYmxpbmcuCj4g ICAqCj4gLSAqIGZlbmNlLT5zdGF0dXMgbWF5IGJlIHNldCBpbiBlbmFibGVfc2lnbmFsaW5nLCBi dXQgb25seSB3aGVuIGZhbHNlIGlzCj4gKyAqIGZlbmNlLT5lcnJvciBtYXkgYmUgc2V0IGluIGVu YWJsZV9zaWduYWxpbmcsIGJ1dCBvbmx5IHdoZW4gZmFsc2UgaXMKPiAgICogcmV0dXJuZWQuCj4g ICAqCj4gICAqIENhbGxpbmcgZG1hX2ZlbmNlX3NpZ25hbCBiZWZvcmUgZW5hYmxlX3NpZ25hbGlu ZyBpcyBjYWxsZWQgYWxsb3dzCj4gQEAgLTE0NSw3ICsxNDUsNyBAQCBzdHJ1Y3QgZG1hX2ZlbmNl X2NiIHsKPiAgICogdGhlIHNlY29uZCB0aW1lIHdpbGwgYmUgYSBub29wIHNpbmNlIGl0IHdhcyBh bHJlYWR5IHNpZ25hbGVkLgo+ICAgKgo+ICAgKiBOb3RlcyBvbiBzaWduYWxlZDoKPiAtICogTWF5 IHNldCBmZW5jZS0+c3RhdHVzIGlmIHJldHVybmluZyB0cnVlLgo+ICsgKiBNYXkgc2V0IGZlbmNl LT5lcnJvciBpZiByZXR1cm5pbmcgdHJ1ZS4KPiAgICoKPiAgICogTm90ZXMgb24gd2FpdDoKPiAg ICogTXVzdCBub3QgYmUgTlVMTCwgc2V0IHRvIGRtYV9mZW5jZV9kZWZhdWx0X3dhaXQgZm9yIGRl ZmF1bHQgaW1wbGVtZW50YXRpb24uCj4gQEAgLTM5NSwxMyArMzk1LDMzIEBAIHN0YXRpYyBpbmxp bmUgc3RydWN0IGRtYV9mZW5jZSAqZG1hX2ZlbmNlX2xhdGVyKHN0cnVjdCBkbWFfZmVuY2UgKmYx LAo+ICBzdGF0aWMgaW5saW5lIGludCBkbWFfZmVuY2VfZ2V0X3N0YXR1c19sb2NrZWQoc3RydWN0 IGRtYV9mZW5jZSAqZmVuY2UpCj4gIHsKPiAgICAgICAgIGlmIChkbWFfZmVuY2VfaXNfc2lnbmFs ZWRfbG9ja2VkKGZlbmNlKSkKPiAtICAgICAgICAgICAgICAgcmV0dXJuIGZlbmNlLT5zdGF0dXMg PCAwID8gZmVuY2UtPnN0YXR1cyA6IDE7Cj4gKyAgICAgICAgICAgICAgIHJldHVybiBmZW5jZS0+ ZXJyb3IgPzogMTsKPiAgICAgICAgIGVsc2UKPiAgICAgICAgICAgICAgICAgcmV0dXJuIDA7Cj4g IH0KPgo+ICBpbnQgZG1hX2ZlbmNlX2dldF9zdGF0dXMoc3RydWN0IGRtYV9mZW5jZSAqZmVuY2Up Owo+Cj4gKy8qKgo+ICsgKiBkbWFfZmVuY2Vfc2V0X2Vycm9yIC0gZmxhZyBhbiBlcnJvciBjb25k aXRpb24gb24gdGhlIGZlbmNlCj4gKyAqIEBmZW5jZTogW2luXSAgICAgICAgdGhlIGRtYV9mZW5j ZQo+ICsgKiBAZXJyb3I6IFtpbl0gICAgICAgIHRoZSBlcnJvciB0byBzdG9yZQo+ICsgKgo+ICsg KiBEcml2ZXJzIGNhbiBzdXBwbHkgYW4gb3B0aW9uYWwgZXJyb3Igc3RhdHVzIGNvbmRpdGlvbiBi ZWZvcmUgdGhleSBzaWduYWwKPiArICogdGhlIGZlbmNlLCB0byBpbmRpY2F0ZSB0aGF0IHRoZSBm ZW5jZSB3YXMgY29tcGxldGVkIGR1ZSB0byBhbiBlcnJvcgo+ICsgKiByYXRoZXIgdGhhbiBzdWNj ZXNzLiBUaGlzIG11c3QgYmUgc2V0IGJlZm9yZSBzaWduYWxpbmcgKHNvIHRoYXQgdGhlIHZhbHVl Cj4gKyAqIGlzIHZpc2libGUgYmVmb3JlIGFueSB3YWl0ZXJzIG9uIHRoZSBzaWduYWwgY2FsbGJh Y2sgYXJlIHdva2VuKS4gVGhpcwo+ICsgKiBoZWxwZXIgZXhpc3RzIHRvIGhlbHAgY2F0Y2hpbmcg ZXJyb25lb3VzIHNldHRpbmcgb2YgI2RtYV9mZW5jZS5lcnJvci4KPiArICovCj4gK3N0YXRpYyBp bmxpbmUgdm9pZCBkbWFfZmVuY2Vfc2V0X2Vycm9yKHN0cnVjdCBkbWFfZmVuY2UgKmZlbmNlLAo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGludCBlcnJvcikKPiArewo+ ICsgICAgICAgQlVHX09OKHRlc3RfYml0KERNQV9GRU5DRV9GTEFHX1NJR05BTEVEX0JJVCwgJmZl bmNlLT5mbGFncykpOwo+ICsgICAgICAgQlVHX09OKGVycm9yID49IDAgfHwgZXJyb3IgPCAtTUFY X0VSUk5PKTsKPiArCj4gKyAgICAgICBmZW5jZS0+ZXJyb3IgPSBlcnJvcjsKPiArfQpTb3JyeSBJ IG1pc3NlZCB0aGlzIGVhcmxpZXIsIGJ1dCBhcmUgeW91IHN1cmUgeW91IHdhbnQgdG8gdXNlIGEg QlVHX09OCmhlcmUsIGFuZCBub3QgYSBXQVJOX09OPwo+ICsKPiAgc2lnbmVkIGxvbmcgZG1hX2Zl bmNlX3dhaXRfdGltZW91dChzdHJ1Y3QgZG1hX2ZlbmNlICosCj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBib29sIGludHIsIHNpZ25lZCBsb25nIHRpbWVvdXQpOwo+ICBzaWdu ZWQgbG9uZyBkbWFfZmVuY2Vfd2FpdF9hbnlfdGltZW91dChzdHJ1Y3QgZG1hX2ZlbmNlICoqZmVu Y2VzLAo+IC0tCj4gMi4xMS4wCj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9s aXN0aW5mby9kcmktZGV2ZWwKCkJlc3QsClN1bWl0LgpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK