From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42244C43334 for ; Wed, 29 Jun 2022 10:31:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233393AbiF2Ka7 (ORCPT ); Wed, 29 Jun 2022 06:30:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233309AbiF2Kax (ORCPT ); Wed, 29 Jun 2022 06:30:53 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 474DE3DDDA for ; Wed, 29 Jun 2022 03:30:52 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id g4so15586789ybg.9 for ; Wed, 29 Jun 2022 03:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=INE3jM6i4CeBqiu3iP4gMcpfjuGPLjLxHaF42Uyh3HU=; b=gme5wrsat75qWp+Pcx6ZLUMXoFWSPo8SFk5+xY2sKMY14XML7lv7BZvDJ1XsF+R4pF H3XtfFAN7qI5e9jmkPQabM9C1cZvrazFcxkGWUN8u49ugGN5ZgE4uLnkUYNhQuPi4lCZ +uzhBRF2JTFseNh2HTIIBQ8WHh/1cppxJ6VLgcPGolWvn3oakRGqpYgHlWaZQI7qYur6 WKhVL3asnCkiK66XXK9hKxBW+Kr8EDh4QueImd3KWxHYLj7f6FJC0FyCJ9Aoq3/krPPC PboTmDlG9/DJbi0qt+VVk0f7YCRqyYql31Z/lg1k67WVKQeRTUrOmIk8udCKjik37KcD Ojvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=INE3jM6i4CeBqiu3iP4gMcpfjuGPLjLxHaF42Uyh3HU=; b=qrgC5YpGu8gw8W+Js01o6x9kwqjvwFT3EMyj3efpiweoPTVGMEBxzqkhs/dkJ+ALXP lUZp8p1sHO+Fr3QPvzBK0Csl2v1kz2oYitDjEo3oL9Zh6hrb13kgLMhIJOxCMy0jD3x9 xmbMlBXRODRttvh6OAWING4ULSd0NpuLA1ZSsFCl123xuWR7Hg6WIA/9Lj4FpK0R3aKq EOQQ+TmLVvms/Mhi2en9I3Pj20Y1NLwqQyD7ZktZ5yJdDMwO+qXO9W276LO3gQK5MD6z 7d9yu7ySEeLNACEnLprG4eGcUTCBxS1s5QuT0CeTap9NQnGeaXv0NEpNizJ1r51JfeZr JnqA== X-Gm-Message-State: AJIora+iHQqxuDtmR9CDsxRWnVIVpOfBV1M6Ow0CKv7RoEaO81AV8gk9 Yc8G3IWAU1MtjLvV4h93Wezke2FSQmLsMT5rbCAEVQ== X-Google-Smtp-Source: AGRyM1u0k0MWRsbjlhZ+2t5dOIIfgGJepBD4oMisQfYbCc9kMnwW7juStqFdeNdnecD+2jq2Tx/943q3+X6LctTtJdA= X-Received: by 2002:a25:b9c7:0:b0:66c:e02d:9749 with SMTP id y7-20020a25b9c7000000b0066ce02d9749mr2693651ybj.494.1656498651378; Wed, 29 Jun 2022 03:30:51 -0700 (PDT) MIME-Version: 1.0 References: <20220625110115.39956-1-Jason@zx2c4.com> <20220625110115.39956-8-Jason@zx2c4.com> In-Reply-To: From: Sumit Semwal Date: Wed, 29 Jun 2022 16:00:39 +0530 Message-ID: Subject: Re: [PATCH v2 7/8] dma-buf: remove useless FMODE_LSEEK flag To: "Jason A. Donenfeld" , linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, Jens Axboe , linux-fsdevel@vger.kernel.org, Sumit Semwal , dri-devel@lists.freedesktop.org, =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jun 2022 at 14:38, Daniel Vetter wrote: > > On Sat, Jun 25, 2022 at 01:01:14PM +0200, Jason A. Donenfeld wrote: > > This is already set by anon_inode_getfile(), since dma_buf_fops has > > non-NULL ->llseek, so we don't need to set it here too. > > > > Suggested-by: Al Viro > > Cc: Sumit Semwal > > Cc: Christian K=C3=B6nig > > Cc: dri-devel@lists.freedesktop.org > > Signed-off-by: Jason A. Donenfeld > > I'm assuming this is part of a vfs cleanup and lands through that tree? > For that: > > Acked-by: Daniel Vetter FWIW, please feel free to add Acked-by: Sumit Semwal > > > --- > > drivers/dma-buf/dma-buf.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > > index 32f55640890c..3f08e0b960ec 100644 > > --- a/drivers/dma-buf/dma-buf.c > > +++ b/drivers/dma-buf/dma-buf.c > > @@ -549,7 +549,6 @@ struct dma_buf *dma_buf_export(const struct dma_buf= _export_info *exp_info) > > goto err_dmabuf; > > } > > > > - file->f_mode |=3D FMODE_LSEEK; > > dmabuf->file =3D file; > > > > mutex_init(&dmabuf->lock); > > -- > > 2.35.1 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch Best, Sumit.