From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sumit Semwal Subject: Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible Date: Wed, 28 Jan 2015 17:57:28 +0530 Message-ID: References: <1422424845-14906-1-git-send-email-sumit.semwal@linaro.org> <54C8C612.1030701@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <54C8C612.1030701@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Thompson Cc: Linaro Kernel Mailman List , Pawel Osciak , Mauro Carvalho Chehab , Dave Airlie , Greg Kroah-Hartman , intel-gfx@lists.freedesktop.org, LKML , DRI mailing list , Linaro MM SIG Mailman List , kgene@kernel.org, Thierry Reding , daniel.vetter@intel.com, linux-tegra@vger.kernel.org, rmk+kernel@arm.linux.org.uk, Marek Szyprowski , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" List-Id: linux-tegra@vger.kernel.org T24gMjggSmFudWFyeSAyMDE1IGF0IDE2OjUwLCBEYW5pZWwgVGhvbXBzb24gPGRhbmllbC50aG9t cHNvbkBsaW5hcm8ub3JnPiB3cm90ZToKPiBPbiAyOC8wMS8xNSAwNjowMCwgU3VtaXQgU2Vtd2Fs IHdyb3RlOgo8c25pcD4KPj4gKy8qKgo+PiArICogaGVscGVyIG1hY3JvIGZvciBleHBvcnRlcnM7 IHplcm9zIGFuZCBmaWxscyBpbiBtb3N0IGNvbW1vbiB2YWx1ZXMKPj4gKyAqLwo+PiArI2RlZmlu ZSBERUZJTkVfRE1BX0JVRl9FWFBPUlRfSU5GTyhhKSAgICAgICAgICAgICAgICAgICAgICAgIFwK Pj4gKyAgICAgc3RydWN0IGRtYV9idWZfZXhwb3J0X2luZm8gYSA9IHswfTsgICAgICAgICAgICAg XAo+PiArICAgICBleHBfaW5mby5leHBfbmFtZSA9IEtCVUlMRF9NT0ROQU1FCj4+ICsKPgo+IFRo aXMgcmlza3MgZ2VuZXJhdGluZyBDOTkgd2FybmluZ3MgdW5sZXNzIHVzZWQgd2l0aCBjYXJlIChh bmQgb25seSBvbmNlCj4gcGVyIGZ1bmN0aW9uKS4gU2hvdWxkbid0IHRoaXMgYmUgbW9yZSBsaWtl Ogo+Cj4gI2RlZmluZSBERUZJTkVfRE1BX0JVRl9FWFBPUlRfSU5GTyhhKSBcCj4gICAgIHN0cnVj dCBkbWFfYnVmX2V4cG9ydF9pbmZvIGEgPSB7IC5leHBfbmFtZSA9IEtCVUlMRF9NT0ROQU1FIH0K PgoKQWghIE15IGJhZDsgdGhhbmtzIGZvciBjYXRjaGluZyB0aGlzLCBEYW5pZWw7IEknbGwgc2Vu ZCBvdXQgdGhlCnVwZGF0ZWQgcGF0Y2ggaW4gYSBtaW51dGUhCj4gRGFuaWVsLgo+CgoKCi0tIApU aGFua3MgYW5kIHJlZ2FyZHMsCgpTdW1pdCBTZW13YWwKS2VybmVsIFRlYW0gTGVhZCAtIExpbmFy byBNb2JpbGUgR3JvdXAKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFS TSBTb0NzCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932872AbbA2CVJ (ORCPT ); Wed, 28 Jan 2015 21:21:09 -0500 Received: from mail-oi0-f51.google.com ([209.85.218.51]:43887 "EHLO mail-oi0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761521AbbA2CVF convert rfc822-to-8bit (ORCPT ); Wed, 28 Jan 2015 21:21:05 -0500 MIME-Version: 1.0 In-Reply-To: <54C8C612.1030701@linaro.org> References: <1422424845-14906-1-git-send-email-sumit.semwal@linaro.org> <54C8C612.1030701@linaro.org> From: Sumit Semwal Date: Wed, 28 Jan 2015 17:57:28 +0530 Message-ID: Subject: Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible To: Daniel Thompson Cc: LKML , "linux-media@vger.kernel.org" , DRI mailing list , Linaro MM SIG Mailman List , "linux-arm-kernel@lists.infradead.org" , rmk+kernel@arm.linux.org.uk, Dave Airlie , kgene@kernel.org, daniel.vetter@intel.com, Thierry Reding , Pawel Osciak , Marek Szyprowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linaro Kernel Mailman List , intel-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28 January 2015 at 16:50, Daniel Thompson wrote: > On 28/01/15 06:00, Sumit Semwal wrote: >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \ >> + struct dma_buf_export_info a = {0}; \ >> + exp_info.exp_name = KBUILD_MODNAME >> + > > This risks generating C99 warnings unless used with care (and only once > per function). Shouldn't this be more like: > > #define DEFINE_DMA_BUF_EXPORT_INFO(a) \ > struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME } > Ah! My bad; thanks for catching this, Daniel; I'll send out the updated patch in a minute! > Daniel. > -- Thanks and regards, Sumit Semwal Kernel Team Lead - Linaro Mobile Group Linaro.org │ Open source software for ARM SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-oi0-f41.google.com ([209.85.218.41]:56249 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755163AbbA2Bj4 convert rfc822-to-8bit (ORCPT ); Wed, 28 Jan 2015 20:39:56 -0500 Received: by mail-oi0-f41.google.com with SMTP id z81so22196685oif.0 for ; Wed, 28 Jan 2015 17:39:55 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <54C8C612.1030701@linaro.org> References: <1422424845-14906-1-git-send-email-sumit.semwal@linaro.org> <54C8C612.1030701@linaro.org> From: Sumit Semwal Date: Wed, 28 Jan 2015 17:57:28 +0530 Message-ID: Subject: Re: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible To: Daniel Thompson Cc: LKML , "linux-media@vger.kernel.org" , DRI mailing list , Linaro MM SIG Mailman List , "linux-arm-kernel@lists.infradead.org" , rmk+kernel@arm.linux.org.uk, Dave Airlie , kgene@kernel.org, daniel.vetter@intel.com, Thierry Reding , Pawel Osciak , Marek Szyprowski , Mauro Carvalho Chehab , Greg Kroah-Hartman , Linaro Kernel Mailman List , intel-gfx@lists.freedesktop.org, linux-tegra@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-media-owner@vger.kernel.org List-ID: On 28 January 2015 at 16:50, Daniel Thompson wrote: > On 28/01/15 06:00, Sumit Semwal wrote: >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \ >> + struct dma_buf_export_info a = {0}; \ >> + exp_info.exp_name = KBUILD_MODNAME >> + > > This risks generating C99 warnings unless used with care (and only once > per function). Shouldn't this be more like: > > #define DEFINE_DMA_BUF_EXPORT_INFO(a) \ > struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME } > Ah! My bad; thanks for catching this, Daniel; I'll send out the updated patch in a minute! > Daniel. > -- Thanks and regards, Sumit Semwal Kernel Team Lead - Linaro Mobile Group Linaro.org │ Open source software for ARM SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 From: sumit.semwal@linaro.org (Sumit Semwal) Date: Wed, 28 Jan 2015 17:57:28 +0530 Subject: [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible In-Reply-To: <54C8C612.1030701@linaro.org> References: <1422424845-14906-1-git-send-email-sumit.semwal@linaro.org> <54C8C612.1030701@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 28 January 2015 at 16:50, Daniel Thompson wrote: > On 28/01/15 06:00, Sumit Semwal wrote: >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT_INFO(a) \ >> + struct dma_buf_export_info a = {0}; \ >> + exp_info.exp_name = KBUILD_MODNAME >> + > > This risks generating C99 warnings unless used with care (and only once > per function). Shouldn't this be more like: > > #define DEFINE_DMA_BUF_EXPORT_INFO(a) \ > struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME } > Ah! My bad; thanks for catching this, Daniel; I'll send out the updated patch in a minute! > Daniel. > -- Thanks and regards, Sumit Semwal Kernel Team Lead - Linaro Mobile Group Linaro.org ? Open source software for ARM SoCs