From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1608AC6FA90 for ; Tue, 20 Sep 2022 14:14:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 20AFF10E6CD; Tue, 20 Sep 2022 14:14:06 +0000 (UTC) Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 034CA10E6CD for ; Tue, 20 Sep 2022 14:14:02 +0000 (UTC) Received: by mail-yb1-xb2f.google.com with SMTP id 130so3549043ybz.9 for ; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=I0YUoX79VzdB1su5c8YsyhJqRmH5BNT4YqtIql7uMHjv4tNfOgHifd92qluReG4d/X i+jYW3HyitXzOX4IonS8R0ZONlFkR1k7gzgwSfoZiyoaclz0ttvaXwLoZb7ZtxANBu5Y 3z526ei+ptSUlr9B43I+BPqd8EpQylJ4cBJQM2NB3es8UnHI+rMDDmASlishpV745ZiR FmF+Tn/kij0Q3tHjPuP7PPUW7rGa0WojF+SdtI5DCR6jLM2zwity5aoAXKaUhJv2tGwk A1NAE6VKh7Q2gKgry+vltVNnOPdcodRj2m1ez7wQy3SuDN63Pt0F5Dl77GROsIrV6LU3 c7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=bSt/r15HgnXWZwWRFvrNv1c9Am6SgEyAuo4BRg72BsBQukdZlSxW9Yze/k6kyDWCFc 5DRJv00Q4+fw6vU9VkxhfMHNQgmXOerGciOp4EcptjkxMr4REkN/7wssf7gMCgDxkdgd Wy3JLDvY/Db/tksu/eVNiD3RtEb8R7JW0Dx11IW7GurvVM6UvXnIbGOzzZoKU41oWE1C n2q+ZS+CVvmgusu63DsjvgSL+ZTsrAFMga5UsXGLTe+cM7419dF/X4Ks0UGQelCmPoJb 0QNLttldwHFpM2K6cSLamfxgJmNQ1lG/PuzaNHotN+SImAhOwNucg+DXjiFKZLvEP1l4 xr0A== X-Gm-Message-State: ACrzQf2QRdnhkYT8Xdz1YxzYwphpvrC9Gq1DQnD5gUcCU2ZyK9FWlZKU ql3CABgnf+rzJtZ01/VsrymII8Ro4bIPdN1qUUz8wA== X-Google-Smtp-Source: AMsMyM5ptp/xJcYbBs/zLcmhTWf9yaT5sYYL81f6HBIkVW4YVsWA9kHYXFc60Kp909nkSHb5MmXRrVuHNeF6LJJFSRY= X-Received: by 2002:a25:af52:0:b0:6b3:de78:452a with SMTP id c18-20020a25af52000000b006b3de78452amr10092889ybj.157.1663683242012; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) MIME-Version: 1.0 References: <20220913192757.37727-1-dmitry.osipenko@collabora.com> <20220913192757.37727-16-dmitry.osipenko@collabora.com> In-Reply-To: <20220913192757.37727-16-dmitry.osipenko@collabora.com> From: Sumit Semwal Date: Tue, 20 Sep 2022 19:43:49 +0530 Message-ID: Subject: Re: [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification To: Dmitry Osipenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Gurchetan Singh , Ruhl Michael J , Thierry Reding , Srinivas Kandagatla , Gerd Hoffmann , Dmitry Osipenko , kernel@collabora.com, Marek Szyprowski , Stefano Stabellini , Leon Romanovsky , Jason Gunthorpe , linux-rdma@vger.kernel.org, =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Russell King , Gustavo Padovan , virtualization@lists.linux-foundation.org, linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Rodrigo Vivi , Mauro Carvalho Chehab , Juergen Gross , Tvrtko Ursulin , Daniel Almeida , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Tomeu Vizoso , Gert Wollny , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Tomasz Figa , Oleksandr Tyshchenko , Qiang Yu , Thomas Zimmermann , Alex Deucher , Amol Maheshwari , =?UTF-8?Q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Dmitry, Thanks very much for the series. On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko wrote: > > Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking > specification by asserting that the reservation lock is held. Thanks for the patch; just a minor nit - I think you mean dma_buf_vmap / vunmap() here, and not _unlocked? Best, Sumit. > > Acked-by: Christian K=C3=B6nig > Signed-off-by: Dmitry Osipenko > --- > drivers/dma-buf/dma-buf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 50db7571dc4b..80fd6ccc88c6 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -1450,6 +1450,8 @@ int dma_buf_vmap(struct dma_buf *dmabuf, struct ios= ys_map *map) > if (WARN_ON(!dmabuf)) > return -EINVAL; > > + dma_resv_assert_held(dmabuf->resv); > + > if (!dmabuf->ops->vmap) > return -EINVAL; > > @@ -1510,6 +1512,8 @@ void dma_buf_vunmap(struct dma_buf *dmabuf, struct = iosys_map *map) > if (WARN_ON(!dmabuf)) > return; > > + dma_resv_assert_held(dmabuf->resv); > + > BUG_ON(iosys_map_is_null(&dmabuf->vmap_ptr)); > BUG_ON(dmabuf->vmapping_counter =3D=3D 0); > BUG_ON(!iosys_map_is_equal(&dmabuf->vmap_ptr, map)); > -- > 2.37.3 > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org =E2=94=82 Open source software for ARM SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5658ECAAD8 for ; Tue, 20 Sep 2022 14:14:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3077A10E6CB; Tue, 20 Sep 2022 14:14:08 +0000 (UTC) Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2FFED10E6CE for ; Tue, 20 Sep 2022 14:14:03 +0000 (UTC) Received: by mail-yb1-xb33.google.com with SMTP id e81so3515501ybb.13 for ; Tue, 20 Sep 2022 07:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=I0YUoX79VzdB1su5c8YsyhJqRmH5BNT4YqtIql7uMHjv4tNfOgHifd92qluReG4d/X i+jYW3HyitXzOX4IonS8R0ZONlFkR1k7gzgwSfoZiyoaclz0ttvaXwLoZb7ZtxANBu5Y 3z526ei+ptSUlr9B43I+BPqd8EpQylJ4cBJQM2NB3es8UnHI+rMDDmASlishpV745ZiR FmF+Tn/kij0Q3tHjPuP7PPUW7rGa0WojF+SdtI5DCR6jLM2zwity5aoAXKaUhJv2tGwk A1NAE6VKh7Q2gKgry+vltVNnOPdcodRj2m1ez7wQy3SuDN63Pt0F5Dl77GROsIrV6LU3 c7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=oMmP0q6Gnl7ky9ogw1uxe4/3cczmH34vEBetg+pp+0mQgetceSqWhVFtAAnmodG55L 7G0NxoNR65IbNWVOUQi4GeDMB1MmR6cOA+4zJvOcaEimHYIPwcM+9G99PQfFTqL9Oh3m 5pwch4WeA7YJOlRfBzrKjLHFLoHOP8PUBxep99mYYLwpwuDgTmtzI4kh23lfQMOkRfZ4 y+q3uLeQa8by0gaUyiw9h0GGhBXIzi4Eh1XL7yDeG5rSQkVVCxLB+gcuzRon1JzQtcm+ 25x2nYamJkSU4omk783DtALB1DlzJVAU6br4MPriUFD19l3bCBpS4TJpioM2cS9BTQN7 4Iig== X-Gm-Message-State: ACrzQf2dqudCTcxs0Lisl6pGTBWQtnSW+u5nRkhPOfjFvtDYUwSCErZi wG4FlqI9UxSmxiebxMpgpPtndSlPglnsTqge7PVcyw== X-Google-Smtp-Source: AMsMyM5ptp/xJcYbBs/zLcmhTWf9yaT5sYYL81f6HBIkVW4YVsWA9kHYXFc60Kp909nkSHb5MmXRrVuHNeF6LJJFSRY= X-Received: by 2002:a25:af52:0:b0:6b3:de78:452a with SMTP id c18-20020a25af52000000b006b3de78452amr10092889ybj.157.1663683242012; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) MIME-Version: 1.0 References: <20220913192757.37727-1-dmitry.osipenko@collabora.com> <20220913192757.37727-16-dmitry.osipenko@collabora.com> In-Reply-To: <20220913192757.37727-16-dmitry.osipenko@collabora.com> From: Sumit Semwal Date: Tue, 20 Sep 2022 19:43:49 +0530 Message-ID: To: Dmitry Osipenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Gurchetan Singh , Srinivas Kandagatla , Gerd Hoffmann , Dmitry Osipenko , kernel@collabora.com, Marek Szyprowski , Stefano Stabellini , Leon Romanovsky , Jason Gunthorpe , linux-rdma@vger.kernel.org, Russell King , Daniel Stone , Gustavo Padovan , virtualization@lists.linux-foundation.org, Chia-I Wu , linux-media@vger.kernel.org, Daniel Vetter , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Maxime Ripard , linaro-mm-sig@lists.linaro.org, Christian Gmeiner , Rodrigo Vivi , Mauro Carvalho Chehab , Juergen Gross , Daniel Almeida , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Tomeu Vizoso , Gert Wollny , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Tomasz Figa , Oleksandr Tyshchenko , Qiang Yu , Thomas Zimmermann , Alex Deucher , Amol Maheshwari , =?UTF-8?Q?Christian_K=C3=B6nig?= , Lucas Stach Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Dmitry, Thanks very much for the series. On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko wrote: > > Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking > specification by asserting that the reservation lock is held. Thanks for the patch; just a minor nit - I think you mean dma_buf_vmap / vunmap() here, and not _unlocked? Best, Sumit. > > Acked-by: Christian K=C3=B6nig > Signed-off-by: Dmitry Osipenko > --- > drivers/dma-buf/dma-buf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 50db7571dc4b..80fd6ccc88c6 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -1450,6 +1450,8 @@ int dma_buf_vmap(struct dma_buf *dmabuf, struct ios= ys_map *map) > if (WARN_ON(!dmabuf)) > return -EINVAL; > > + dma_resv_assert_held(dmabuf->resv); > + > if (!dmabuf->ops->vmap) > return -EINVAL; > > @@ -1510,6 +1512,8 @@ void dma_buf_vunmap(struct dma_buf *dmabuf, struct = iosys_map *map) > if (WARN_ON(!dmabuf)) > return; > > + dma_resv_assert_held(dmabuf->resv); > + > BUG_ON(iosys_map_is_null(&dmabuf->vmap_ptr)); > BUG_ON(dmabuf->vmapping_counter =3D=3D 0); > BUG_ON(!iosys_map_is_equal(&dmabuf->vmap_ptr, map)); > -- > 2.37.3 > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org =E2=94=82 Open source software for ARM SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E0B9C6FA90 for ; Tue, 20 Sep 2022 14:16:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231545AbiITOQj (ORCPT ); Tue, 20 Sep 2022 10:16:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230185AbiITOQT (ORCPT ); Tue, 20 Sep 2022 10:16:19 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DED1A32067 for ; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id a67so3589499ybb.3 for ; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=I0YUoX79VzdB1su5c8YsyhJqRmH5BNT4YqtIql7uMHjv4tNfOgHifd92qluReG4d/X i+jYW3HyitXzOX4IonS8R0ZONlFkR1k7gzgwSfoZiyoaclz0ttvaXwLoZb7ZtxANBu5Y 3z526ei+ptSUlr9B43I+BPqd8EpQylJ4cBJQM2NB3es8UnHI+rMDDmASlishpV745ZiR FmF+Tn/kij0Q3tHjPuP7PPUW7rGa0WojF+SdtI5DCR6jLM2zwity5aoAXKaUhJv2tGwk A1NAE6VKh7Q2gKgry+vltVNnOPdcodRj2m1ez7wQy3SuDN63Pt0F5Dl77GROsIrV6LU3 c7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=2EIK6ZWFr9lg1d01IfRwS7d4AmVRB6VNpEIvnlAtjXEtW6LmOxSVqUKQ252TSAhXhc G2CvxtkiEApjTtU1BrcAPIpAhm6I9jGktsFgLfwqJks1UuLUhQzqRjKo/Iipa01kZFCr 6LPFU03v+ko8J95maA+sYvh9GBr9PXQ8QIZ/8o0TB9zhDEXdYqfgCK+10o2D9EPiJuz2 cGui2npnAphCRJH67ZTY/IdytZ37S7IL1EakXDswl6rX4qo5KeiC0DOfY4CSVIZGGv5U NJaLsVe/mQYdwx9+N/9dTxMvL2P/hnHb7jZ5bZSvlseoqiqynxIz+8WlocDbdk+nyVx5 hhpw== X-Gm-Message-State: ACrzQf3tUoHP57gskCbYILIIdMy/4Qq3qHrlLS2yuHQbOVIWXvMZLV+t NWggJmOL4o7RHhJOeFNeD8mnhtBDJsQf9JFaZhF7BQ== X-Google-Smtp-Source: AMsMyM5ptp/xJcYbBs/zLcmhTWf9yaT5sYYL81f6HBIkVW4YVsWA9kHYXFc60Kp909nkSHb5MmXRrVuHNeF6LJJFSRY= X-Received: by 2002:a25:af52:0:b0:6b3:de78:452a with SMTP id c18-20020a25af52000000b006b3de78452amr10092889ybj.157.1663683242012; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) MIME-Version: 1.0 References: <20220913192757.37727-1-dmitry.osipenko@collabora.com> <20220913192757.37727-16-dmitry.osipenko@collabora.com> In-Reply-To: <20220913192757.37727-16-dmitry.osipenko@collabora.com> From: Sumit Semwal Date: Tue, 20 Sep 2022 19:43:49 +0530 Message-ID: Subject: Re: [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification To: Dmitry Osipenko Cc: David Airlie , Gerd Hoffmann , Gurchetan Singh , Chia-I Wu , Daniel Vetter , Daniel Almeida , Gert Wollny , Gustavo Padovan , Daniel Stone , Tomeu Vizoso , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , =?UTF-8?Q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , Thierry Reding , Tomasz Figa , Marek Szyprowski , Mauro Carvalho Chehab , Alex Deucher , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Qiang Yu , Srinivas Kandagatla , Amol Maheshwari , Jason Gunthorpe , Leon Romanovsky , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Tomi Valkeinen , Russell King , Lucas Stach , Christian Gmeiner , Ruhl Michael J , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dmitry Osipenko , linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, kernel@collabora.com, virtualization@lists.linux-foundation.org, linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Dmitry, Thanks very much for the series. On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko wrote: > > Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking > specification by asserting that the reservation lock is held. Thanks for the patch; just a minor nit - I think you mean dma_buf_vmap / vunmap() here, and not _unlocked? Best, Sumit. > > Acked-by: Christian K=C3=B6nig > Signed-off-by: Dmitry Osipenko > --- > drivers/dma-buf/dma-buf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 50db7571dc4b..80fd6ccc88c6 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -1450,6 +1450,8 @@ int dma_buf_vmap(struct dma_buf *dmabuf, struct ios= ys_map *map) > if (WARN_ON(!dmabuf)) > return -EINVAL; > > + dma_resv_assert_held(dmabuf->resv); > + > if (!dmabuf->ops->vmap) > return -EINVAL; > > @@ -1510,6 +1512,8 @@ void dma_buf_vunmap(struct dma_buf *dmabuf, struct = iosys_map *map) > if (WARN_ON(!dmabuf)) > return; > > + dma_resv_assert_held(dmabuf->resv); > + > BUG_ON(iosys_map_is_null(&dmabuf->vmap_ptr)); > BUG_ON(dmabuf->vmapping_counter =3D=3D 0); > BUG_ON(!iosys_map_is_equal(&dmabuf->vmap_ptr, map)); > -- > 2.37.3 > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org =E2=94=82 Open source software for ARM SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5110AECAAD8 for ; Tue, 20 Sep 2022 14:41:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 47D2E10E4AB; Tue, 20 Sep 2022 14:41:33 +0000 (UTC) Received: from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com [IPv6:2607:f8b0:4864:20::b33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 015AA10E6CB for ; Tue, 20 Sep 2022 14:14:02 +0000 (UTC) Received: by mail-yb1-xb33.google.com with SMTP id y82so3578520yby.6 for ; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=I0YUoX79VzdB1su5c8YsyhJqRmH5BNT4YqtIql7uMHjv4tNfOgHifd92qluReG4d/X i+jYW3HyitXzOX4IonS8R0ZONlFkR1k7gzgwSfoZiyoaclz0ttvaXwLoZb7ZtxANBu5Y 3z526ei+ptSUlr9B43I+BPqd8EpQylJ4cBJQM2NB3es8UnHI+rMDDmASlishpV745ZiR FmF+Tn/kij0Q3tHjPuP7PPUW7rGa0WojF+SdtI5DCR6jLM2zwity5aoAXKaUhJv2tGwk A1NAE6VKh7Q2gKgry+vltVNnOPdcodRj2m1ez7wQy3SuDN63Pt0F5Dl77GROsIrV6LU3 c7sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=A5SHHtL7QW2l54muzkKKvK4LNnKVv9lnQOHGxIBuRuE=; b=XKxVejuCdYvl/vuDzF9nsd6pRklyg9dvMWcSzWchT1UiUrNTkRC5MEyMGXhH3yCa6V MvBUeuuH66pX1/sIDDSuQwJWF+mP7WRfJ7PbWeIhANHYSWX8q4wBAnTmi+EPYNjChdcL sUqmfsKAgwVdVDgGdvjh/81mU5AriS+fQtKcmTVE6EzHvSEinFCA4tk5u9aZjAQ8NG3m 2M9/wiljr8EdGDV7Czffv1WilRcBzJFs7rW0xuCkwqvelXI6jJ8RkX0OeGiZM55Tg64x Hk8qtWq94maYP+E+GRiIN1F7xI+2H+Sq1fJLv8k2ym4L8tblKm7k/kiEZr2h2Ntnx7eS TPwA== X-Gm-Message-State: ACrzQf0EPLZuwX3j1XjXYhkw/0sFr/p7hFHUY/aWlfxiI55JHVvqpOmC cSR166qyvGJfePBCUz7u1YvjwFYjtemX6eaJJjmrLw== X-Google-Smtp-Source: AMsMyM5ptp/xJcYbBs/zLcmhTWf9yaT5sYYL81f6HBIkVW4YVsWA9kHYXFc60Kp909nkSHb5MmXRrVuHNeF6LJJFSRY= X-Received: by 2002:a25:af52:0:b0:6b3:de78:452a with SMTP id c18-20020a25af52000000b006b3de78452amr10092889ybj.157.1663683242012; Tue, 20 Sep 2022 07:14:02 -0700 (PDT) MIME-Version: 1.0 References: <20220913192757.37727-1-dmitry.osipenko@collabora.com> <20220913192757.37727-16-dmitry.osipenko@collabora.com> In-Reply-To: <20220913192757.37727-16-dmitry.osipenko@collabora.com> From: Sumit Semwal Date: Tue, 20 Sep 2022 19:43:49 +0530 Message-ID: Subject: Re: [PATCH v5 15/21] dma-buf: Move dma_buf_vmap() to dynamic locking specification To: Dmitry Osipenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Tue, 20 Sep 2022 14:41:29 +0000 X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Joonas Lahtinen , dri-devel@lists.freedesktop.org, Gurchetan Singh , Ruhl Michael J , Thierry Reding , Srinivas Kandagatla , Gerd Hoffmann , Dmitry Osipenko , kernel@collabora.com, Marek Szyprowski , Stefano Stabellini , Leon Romanovsky , Jason Gunthorpe , linux-rdma@vger.kernel.org, =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Russell King , Daniel Stone , Gustavo Padovan , virtualization@lists.linux-foundation.org, Chia-I Wu , linux-media@vger.kernel.org, Daniel Vetter , linux-arm-msm@vger.kernel.org, intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , linaro-mm-sig@lists.linaro.org, Christian Gmeiner , Jani Nikula , Rodrigo Vivi , Mauro Carvalho Chehab , Juergen Gross , Tvrtko Ursulin , Daniel Almeida , amd-gfx@lists.freedesktop.org, Tomi Valkeinen , Tomeu Vizoso , Gert Wollny , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Tomasz Figa , Oleksandr Tyshchenko , Rob Clark , Qiang Yu , Thomas Zimmermann , Alex Deucher , Amol Maheshwari , =?UTF-8?Q?Christian_K=C3=B6nig?= , Lucas Stach Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Hi Dmitry, Thanks very much for the series. On Wed, 14 Sept 2022 at 00:59, Dmitry Osipenko wrote: > > Move dma_buf_vmap/vunmap_unlocked() functions to the dynamic locking > specification by asserting that the reservation lock is held. Thanks for the patch; just a minor nit - I think you mean dma_buf_vmap / vunmap() here, and not _unlocked? Best, Sumit. > > Acked-by: Christian K=C3=B6nig > Signed-off-by: Dmitry Osipenko > --- > drivers/dma-buf/dma-buf.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c > index 50db7571dc4b..80fd6ccc88c6 100644 > --- a/drivers/dma-buf/dma-buf.c > +++ b/drivers/dma-buf/dma-buf.c > @@ -1450,6 +1450,8 @@ int dma_buf_vmap(struct dma_buf *dmabuf, struct ios= ys_map *map) > if (WARN_ON(!dmabuf)) > return -EINVAL; > > + dma_resv_assert_held(dmabuf->resv); > + > if (!dmabuf->ops->vmap) > return -EINVAL; > > @@ -1510,6 +1512,8 @@ void dma_buf_vunmap(struct dma_buf *dmabuf, struct = iosys_map *map) > if (WARN_ON(!dmabuf)) > return; > > + dma_resv_assert_held(dmabuf->resv); > + > BUG_ON(iosys_map_is_null(&dmabuf->vmap_ptr)); > BUG_ON(dmabuf->vmapping_counter =3D=3D 0); > BUG_ON(!iosys_map_is_equal(&dmabuf->vmap_ptr, map)); > -- > 2.37.3 > -- Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org =E2=94=82 Open source software for ARM SoCs