From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C388C433FE for ; Wed, 1 Dec 2021 10:09:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348536AbhLAKMz (ORCPT ); Wed, 1 Dec 2021 05:12:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348512AbhLAKMw (ORCPT ); Wed, 1 Dec 2021 05:12:52 -0500 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44746C061756 for ; Wed, 1 Dec 2021 02:09:31 -0800 (PST) Received: by mail-lj1-x230.google.com with SMTP id e11so46968271ljo.13 for ; Wed, 01 Dec 2021 02:09:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=h0Fitg9dKp6Gl/4ZI0YCCzy6luvo1s9aJSiGf6y033HzRqpc5bZcL22MlRCxP3mbCw qaFmDSHUWkmclJFd6Gfp/IFpPuiU7sHzEXpo7ODUC+M3ObKQBAze5n0u8m5zdnSf40pd rWicWAkANUpI3/KhOCbjO6u0XEmS6Zjz6t6xbahAOXpcxxGSwPHx2ZvT9rC83GjQ/Jyi Zs4Tb/H/YaHN/WStBxRlcFz1073veJYxBn+ifRYQ4WrGuao/yfclD+EQY65wwJ1LSDgT t35ruCeNnZ7SL3r0UrUHhEBHvQHgn/B3WNXWOVMGwWma20ykKSLR2Leaqfo+hPq4XYAq HpsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=rkef7/l1puXDBBv8GBqZ3QUBsMImRMQdKzfO3QWgS+SZBXg4dIdD6SLLAPFLEeUu/u ekXWtjQAwfik3gwuP4JrkfXwpXj/hY+N8CgGDdLVcBba5yYqmI8JsRzoYdrF1MD/yrDz I8usRaM8NAEnA7rHraIV2eiuoIqu/f6sh+n87vbMkmgWuVX9kXojRlgiW8sxsfhZtnlq qkDvUa/bPFAxkOpVyz9hTaUjpcLWpfyl64qnGYCuaZSRHnFdvstILJHOpNgCayQ+ip1v 2gc8KhPVT5Ox153c0eTmkbooCxYt64zCVfoPPVoeXOtC1xt8an2eUJx37qdJwjN5NQ4y tCWw== X-Gm-Message-State: AOAM532bejZ8lpPxlDssYHD8uv/CIo9+HaHkn+wR4bwkNckWFxXeRhe5 b2GmJPJLCxxW/yDiV3Ewqfnh4AqKkZQScMc+2x0MoJ1gC4h+eA== X-Google-Smtp-Source: ABdhPJzDsJHqm+aHiy+lkIXP5Ar3k9o7SMl/nP/3Xx3p2ShJFSukJaXUE1CMRVgy9JAkWUv59xYkYWSvKKpQZ+pGyjE= X-Received: by 2002:a2e:5850:: with SMTP id x16mr4763005ljd.122.1638353369362; Wed, 01 Dec 2021 02:09:29 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: From: Sumit Semwal Date: Wed, 1 Dec 2021 15:39:17 +0530 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: John Stultz Cc: guangming.cao@mediatek.com, greg@kroah.com, brian.starkey@arm.com, benjamin.gaignard@linaro.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, labbott@redhat.com, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, matthias.bgg@gmail.com, robin.murphy@arm.com, stable@vger.kernel.org, wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Guangming, On Mon, 29 Nov 2021 at 23:35, John Stultz wrote: > > On Thu, Nov 25, 2021 at 11:48 PM wrote: > > > > From: Guangming > > > > For previous version, it uses 'sg_table.nent's to traverse sg_table in = pages > > free flow. > > However, 'sg_table.nents' is reassigned in 'dma_map_sg', it means the n= umber of > > created entries in the DMA adderess space. > > So, use 'sg_table.nents' in pages free flow will case some pages can't = be freed. > > > > Here we should use sg_table.orig_nents to free pages memory, but use th= e > > sgtable helper 'for each_sgtable_sg'(, instead of the previous rather c= ommon > > helper 'for_each_sg' which maybe cause memory leak) is much better. Thanks for catching this and the patch; applied to drm-misc-fixes. > > > > Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order page= s if available") > > Signed-off-by: Guangming > > Reviewed-by: Robin Murphy > > Cc: # 5.11.* > > Thanks so much for catching this and sending in all the revisions! > > Reviewed-by: John Stultz Best, Sumit. --=20 Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org =E2=94=82 Open source software for ARM SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83100C433F5 for ; Wed, 1 Dec 2021 10:09:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6AoLaJMpMqW8WcreaDlGyghYGAq949n2rjdHx4f5tVQ=; b=g9Vh8VJdUkMJvv hI0ZhHyvxTv2G40UcwRdrYpFTEkAMRDEBGogkv5RoaRi2xoOeCgGwDLFbCI/2pAKOPDfOnzlw8uUz Q3IpNcXV/yEQt8zr6dxLkMN2ShrrajTQu5BizZOxgCUaWIAeVAkK2W6b8hJ/kPQ+5x/9K5bCN0f+m 3uXMmAKMDyMPwtdsSDpxyAgzlgGUT+9wDPkutT3hpeAQyfYBCZfMcLfB9lQe1ay+g+MYlWe65cYhW EgUWROs7v0joUaYSoZBAVf+JuYhTPsxgSb1RmDdwF8EE3lKNu8cb9oC4D7zs4Y3NnZyv33p/3Witc nswutpy5VcNZWIQXlldQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msMYR-0083P1-CA; Wed, 01 Dec 2021 10:09:35 +0000 Received: from mail-lj1-x22c.google.com ([2a00:1450:4864:20::22c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msMYO-0083MR-1u for linux-mediatek@lists.infradead.org; Wed, 01 Dec 2021 10:09:34 +0000 Received: by mail-lj1-x22c.google.com with SMTP id j18so33856464ljc.12 for ; Wed, 01 Dec 2021 02:09:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=h0Fitg9dKp6Gl/4ZI0YCCzy6luvo1s9aJSiGf6y033HzRqpc5bZcL22MlRCxP3mbCw qaFmDSHUWkmclJFd6Gfp/IFpPuiU7sHzEXpo7ODUC+M3ObKQBAze5n0u8m5zdnSf40pd rWicWAkANUpI3/KhOCbjO6u0XEmS6Zjz6t6xbahAOXpcxxGSwPHx2ZvT9rC83GjQ/Jyi Zs4Tb/H/YaHN/WStBxRlcFz1073veJYxBn+ifRYQ4WrGuao/yfclD+EQY65wwJ1LSDgT t35ruCeNnZ7SL3r0UrUHhEBHvQHgn/B3WNXWOVMGwWma20ykKSLR2Leaqfo+hPq4XYAq HpsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=10nC51jQUDpPwGBhqARxNlaKLmF5dT6mWkMtdVhuiq2ROFKxRG+BKPhPRteQ/E96qr 3zMCk4mTC4zt83Kys+mE/WIhHp11SXpUpmdSvlFw/enHrN9Vd7z9FDzLYtxWZSp+uXa3 Ou2Z3qLqOlM/+KjYjD8Z41YEIgBEl5Gd1e7i1cBBn43tSA+kfSO8O5T4lJ35yGsSk8fS yRE9tpw6VrALWE7uckbYM9HLBjjmnsuCIj6RRwTXqmD1rPA4t4Jf+8+fVDa69zC0wSJm plQf2+7AVkf7QC3g+VtcPfKfmamdZXJTMsHjJRrpR4vPT5pP7xdmvdNF/joXe+z077ZL TLeg== X-Gm-Message-State: AOAM531hUvjQLipPaWxaQ9HgKw5jwrvNOwuGnwNBl7QVbUrIiugZG8i4 akrcn4PhvV/SnvcKrUjJO8xpE1Ip2swHH30U9Q2llA== X-Google-Smtp-Source: ABdhPJzDsJHqm+aHiy+lkIXP5Ar3k9o7SMl/nP/3Xx3p2ShJFSukJaXUE1CMRVgy9JAkWUv59xYkYWSvKKpQZ+pGyjE= X-Received: by 2002:a2e:5850:: with SMTP id x16mr4763005ljd.122.1638353369362; Wed, 01 Dec 2021 02:09:29 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: From: Sumit Semwal Date: Wed, 1 Dec 2021 15:39:17 +0530 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: John Stultz Cc: guangming.cao@mediatek.com, greg@kroah.com, brian.starkey@arm.com, benjamin.gaignard@linaro.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, labbott@redhat.com, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, matthias.bgg@gmail.com, robin.murphy@arm.com, stable@vger.kernel.org, wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_020932_143309_F3A44777 X-CRM114-Status: GOOD ( 14.75 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org SGVsbG8gR3VhbmdtaW5nLAoKT24gTW9uLCAyOSBOb3YgMjAyMSBhdCAyMzozNSwgSm9obiBTdHVs dHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+IHdyb3RlOgo+Cj4gT24gVGh1LCBOb3YgMjUsIDIw MjEgYXQgMTE6NDggUE0gPGd1YW5nbWluZy5jYW9AbWVkaWF0ZWsuY29tPiB3cm90ZToKPiA+Cj4g PiBGcm9tOiBHdWFuZ21pbmcgPEd1YW5nbWluZy5DYW9AbWVkaWF0ZWsuY29tPgo+ID4KPiA+IEZv ciBwcmV2aW91cyB2ZXJzaW9uLCBpdCB1c2VzICdzZ190YWJsZS5uZW50J3MgdG8gdHJhdmVyc2Ug c2dfdGFibGUgaW4gcGFnZXMKPiA+IGZyZWUgZmxvdy4KPiA+IEhvd2V2ZXIsICdzZ190YWJsZS5u ZW50cycgaXMgcmVhc3NpZ25lZCBpbiAnZG1hX21hcF9zZycsIGl0IG1lYW5zIHRoZSBudW1iZXIg b2YKPiA+IGNyZWF0ZWQgZW50cmllcyBpbiB0aGUgRE1BIGFkZGVyZXNzIHNwYWNlLgo+ID4gU28s IHVzZSAnc2dfdGFibGUubmVudHMnIGluIHBhZ2VzIGZyZWUgZmxvdyB3aWxsIGNhc2Ugc29tZSBw YWdlcyBjYW4ndCBiZSBmcmVlZC4KPiA+Cj4gPiBIZXJlIHdlIHNob3VsZCB1c2Ugc2dfdGFibGUu b3JpZ19uZW50cyB0byBmcmVlIHBhZ2VzIG1lbW9yeSwgYnV0IHVzZSB0aGUKPiA+IHNndGFibGUg aGVscGVyICdmb3IgZWFjaF9zZ3RhYmxlX3NnJygsIGluc3RlYWQgb2YgdGhlIHByZXZpb3VzIHJh dGhlciBjb21tb24KPiA+IGhlbHBlciAnZm9yX2VhY2hfc2cnIHdoaWNoIG1heWJlIGNhdXNlIG1l bW9yeSBsZWFrKSBpcyBtdWNoIGJldHRlci4KClRoYW5rcyBmb3IgY2F0Y2hpbmcgdGhpcyBhbmQg dGhlIHBhdGNoOyBhcHBsaWVkIHRvIGRybS1taXNjLWZpeGVzLgo+ID4KPiA+IEZpeGVzOiBkOTYz YWIwZjE1ZmIwICgiZG1hLWJ1Zjogc3lzdGVtX2hlYXA6IEFsbG9jYXRlIGhpZ2hlciBvcmRlciBw YWdlcyBpZiBhdmFpbGFibGUiKQo+ID4gU2lnbmVkLW9mZi1ieTogR3VhbmdtaW5nIDxHdWFuZ21p bmcuQ2FvQG1lZGlhdGVrLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBSb2JpbiBNdXJwaHkgPHJvYmlu Lm11cnBoeUBhcm0uY29tPgo+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIDUuMTEu Kgo+Cj4gVGhhbmtzIHNvIG11Y2ggZm9yIGNhdGNoaW5nIHRoaXMgYW5kIHNlbmRpbmcgaW4gYWxs IHRoZSByZXZpc2lvbnMhCj4KPiBSZXZpZXdlZC1ieTogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6 QGxpbmFyby5vcmc+CgoKQmVzdCwKU3VtaXQuCgotLSAKVGhhbmtzIGFuZCByZWdhcmRzLAoKU3Vt aXQgU2Vtd2FsIChoZSAvIGhpbSkKVGVjaCBMZWFkIC0gTENHLCBWZXJ0aWNhbCBUZWNobm9sb2dp ZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1tZWRpYXRl ayBtYWlsaW5nIGxpc3QKTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 017AFC433EF for ; Wed, 1 Dec 2021 10:09:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2FF9A6EAC6; Wed, 1 Dec 2021 10:09:32 +0000 (UTC) Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3656F6EAC6 for ; Wed, 1 Dec 2021 10:09:31 +0000 (UTC) Received: by mail-lj1-x231.google.com with SMTP id 13so46977973ljj.11 for ; Wed, 01 Dec 2021 02:09:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=h0Fitg9dKp6Gl/4ZI0YCCzy6luvo1s9aJSiGf6y033HzRqpc5bZcL22MlRCxP3mbCw qaFmDSHUWkmclJFd6Gfp/IFpPuiU7sHzEXpo7ODUC+M3ObKQBAze5n0u8m5zdnSf40pd rWicWAkANUpI3/KhOCbjO6u0XEmS6Zjz6t6xbahAOXpcxxGSwPHx2ZvT9rC83GjQ/Jyi Zs4Tb/H/YaHN/WStBxRlcFz1073veJYxBn+ifRYQ4WrGuao/yfclD+EQY65wwJ1LSDgT t35ruCeNnZ7SL3r0UrUHhEBHvQHgn/B3WNXWOVMGwWma20ykKSLR2Leaqfo+hPq4XYAq HpsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=smXfYzBb4Pmiah+HLFAc+bTmQtKeV4tXv3L4TwE+nJWAfxn8ziAhL9VVkjboUYep4/ G9Zu295THykf6mJhsEWgfw+BInJ3H5vWQ2rGIiOIZuifRPlH56VNFa4NEzpBezIJMc+2 eMiRHaLJATrLa0MGEeTMp7NF4mnLWe1+7WXDVW3ZRtzQ8vsrRXT5V+Vw6pE5yFmiM4Uf TJ8h/rzBKKuKra/C+4p4SqJARqRM4gLgT2RrnLg+osAqKJeqj7WEZJSf/qqufr3rmqXi 87ye5617hmpZ1PRn3815HRmqGtK7+84x1LDTuzPFzm4J60NRTzXIq2boC7KOp7oOR3Kk fEDw== X-Gm-Message-State: AOAM532bO0c7UgE1l/pj/bmtnG2b+6QbrQyPNvQcSGcBfguHQ0o3EN9d yljkenF5Zjh/F2QCdyyNPHjizdafxTF9FeGBq5VGqw== X-Google-Smtp-Source: ABdhPJzDsJHqm+aHiy+lkIXP5Ar3k9o7SMl/nP/3Xx3p2ShJFSukJaXUE1CMRVgy9JAkWUv59xYkYWSvKKpQZ+pGyjE= X-Received: by 2002:a2e:5850:: with SMTP id x16mr4763005ljd.122.1638353369362; Wed, 01 Dec 2021 02:09:29 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: From: Sumit Semwal Date: Wed, 1 Dec 2021 15:39:17 +0530 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: John Stultz Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: guangming.cao@mediatek.com, wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com, greg@kroah.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, benjamin.gaignard@linaro.org, matthias.bgg@gmail.com, stable@vger.kernel.org, labbott@redhat.com, robin.murphy@arm.com, christian.koenig@amd.com, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hello Guangming, On Mon, 29 Nov 2021 at 23:35, John Stultz wrote: > > On Thu, Nov 25, 2021 at 11:48 PM wrote: > > > > From: Guangming > > > > For previous version, it uses 'sg_table.nent's to traverse sg_table in = pages > > free flow. > > However, 'sg_table.nents' is reassigned in 'dma_map_sg', it means the n= umber of > > created entries in the DMA adderess space. > > So, use 'sg_table.nents' in pages free flow will case some pages can't = be freed. > > > > Here we should use sg_table.orig_nents to free pages memory, but use th= e > > sgtable helper 'for each_sgtable_sg'(, instead of the previous rather c= ommon > > helper 'for_each_sg' which maybe cause memory leak) is much better. Thanks for catching this and the patch; applied to drm-misc-fixes. > > > > Fixes: d963ab0f15fb0 ("dma-buf: system_heap: Allocate higher order page= s if available") > > Signed-off-by: Guangming > > Reviewed-by: Robin Murphy > > Cc: # 5.11.* > > Thanks so much for catching this and sending in all the revisions! > > Reviewed-by: John Stultz Best, Sumit. --=20 Thanks and regards, Sumit Semwal (he / him) Tech Lead - LCG, Vertical Technologies Linaro.org =E2=94=82 Open source software for ARM SoCs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15FE5C433F5 for ; Wed, 1 Dec 2021 10:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qmmOt8y1xxWdqDx8B8Bk5fNtvnHvrblURhi+VXzTdq4=; b=gau4XFETwOTOBW 57KDKvCyQDxPKIzPXX1iefsXyC4Yr0hwiUxIyEzJQaHpklZv7Ay6fH2FcGzKD/2JnEZ3XXcLPJhJC Ysrzl2V4qE++mkpQMcJkAKA9zkfv63VltussVvzwowOIXtiso/nNEY6s32NsEBqYpgXN+N6gKCW7Y zqcTdICOk/8KUke2BDcjFigFnyMsJUNUrlY7275fpahFHGi2m7qmznyreURnfJYbgYjpuD8sSfSur uBNDKW+e7+2mmiv8EBaiOGBwnLCVuQUNe/gQnouetVZY+Vz44nV2Ac3RHEBulo0YDx5Grb0tzpLWh D32QF0LjsAsqOCDyqY8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msMYT-0083PV-Lj; Wed, 01 Dec 2021 10:09:37 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msMYO-0083Ma-61 for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 10:09:34 +0000 Received: by mail-lj1-x22f.google.com with SMTP id v15so47171578ljc.0 for ; Wed, 01 Dec 2021 02:09:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=h0Fitg9dKp6Gl/4ZI0YCCzy6luvo1s9aJSiGf6y033HzRqpc5bZcL22MlRCxP3mbCw qaFmDSHUWkmclJFd6Gfp/IFpPuiU7sHzEXpo7ODUC+M3ObKQBAze5n0u8m5zdnSf40pd rWicWAkANUpI3/KhOCbjO6u0XEmS6Zjz6t6xbahAOXpcxxGSwPHx2ZvT9rC83GjQ/Jyi Zs4Tb/H/YaHN/WStBxRlcFz1073veJYxBn+ifRYQ4WrGuao/yfclD+EQY65wwJ1LSDgT t35ruCeNnZ7SL3r0UrUHhEBHvQHgn/B3WNXWOVMGwWma20ykKSLR2Leaqfo+hPq4XYAq HpsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=OUz5GIJwWhsCyqmvdwiSMp+8PenKcEyq20yCWjGw6oo=; b=1hKy0WGPyX3ilGtu2QXxy7KucXisxr7gUV1txdrAlSWRb5GJPfFv8PAPYZf5Zdavhz tbuwoXxrIC/Dt/vaNodm3gmrsiZ5ovkcqhQkCVzNGh3D8zZwNEKWZP/Ad4DrO+3fCgWo EXR+6/GAiUi4euvxoVlH4J71zIkMUbUwSuzdIuEFaVMgLUE17xvrx9G13677LxWFa4gV UwJE8Dci9tDVKRm0XoiYT9fN4SargI3gzPS+GfaorVBjMxitx2Pa70YF9RijXpLHGshl zZg08t86ahkE2qsQzxR3aMxuQ2RGIuVfD11th70sTv+c+Gdpbjf0yD1OW7fjageZDRM6 j0lA== X-Gm-Message-State: AOAM530fHlaEIsp9lL2fRmEqqrjTL0gXUPnbSl467xfJYEkNv73gkkzr Ntfvk/UmcX/+89Risp3J/+Ez+y9y8pKdGdwFLysFZQ== X-Google-Smtp-Source: ABdhPJzDsJHqm+aHiy+lkIXP5Ar3k9o7SMl/nP/3Xx3p2ShJFSukJaXUE1CMRVgy9JAkWUv59xYkYWSvKKpQZ+pGyjE= X-Received: by 2002:a2e:5850:: with SMTP id x16mr4763005ljd.122.1638353369362; Wed, 01 Dec 2021 02:09:29 -0800 (PST) MIME-Version: 1.0 References: <20211126074904.88388-1-guangming.cao@mediatek.com> In-Reply-To: From: Sumit Semwal Date: Wed, 1 Dec 2021 15:39:17 +0530 Message-ID: Subject: Re: [PATCH v4] dma-buf: system_heap: Use 'for_each_sgtable_sg' in pages free flow To: John Stultz Cc: guangming.cao@mediatek.com, greg@kroah.com, brian.starkey@arm.com, benjamin.gaignard@linaro.org, christian.koenig@amd.com, dri-devel@lists.freedesktop.org, labbott@redhat.com, linaro-mm-sig@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org, lmark@codeaurora.org, matthias.bgg@gmail.com, robin.murphy@arm.com, stable@vger.kernel.org, wsd_upstream@mediatek.com, kuan-ying.lee@mediatek.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_020932_232733_DEAD4CF8 X-CRM114-Status: GOOD ( 16.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gR3VhbmdtaW5nLAoKT24gTW9uLCAyOSBOb3YgMjAyMSBhdCAyMzozNSwgSm9obiBTdHVs dHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+IHdyb3RlOgo+Cj4gT24gVGh1LCBOb3YgMjUsIDIw MjEgYXQgMTE6NDggUE0gPGd1YW5nbWluZy5jYW9AbWVkaWF0ZWsuY29tPiB3cm90ZToKPiA+Cj4g PiBGcm9tOiBHdWFuZ21pbmcgPEd1YW5nbWluZy5DYW9AbWVkaWF0ZWsuY29tPgo+ID4KPiA+IEZv ciBwcmV2aW91cyB2ZXJzaW9uLCBpdCB1c2VzICdzZ190YWJsZS5uZW50J3MgdG8gdHJhdmVyc2Ug c2dfdGFibGUgaW4gcGFnZXMKPiA+IGZyZWUgZmxvdy4KPiA+IEhvd2V2ZXIsICdzZ190YWJsZS5u ZW50cycgaXMgcmVhc3NpZ25lZCBpbiAnZG1hX21hcF9zZycsIGl0IG1lYW5zIHRoZSBudW1iZXIg b2YKPiA+IGNyZWF0ZWQgZW50cmllcyBpbiB0aGUgRE1BIGFkZGVyZXNzIHNwYWNlLgo+ID4gU28s IHVzZSAnc2dfdGFibGUubmVudHMnIGluIHBhZ2VzIGZyZWUgZmxvdyB3aWxsIGNhc2Ugc29tZSBw YWdlcyBjYW4ndCBiZSBmcmVlZC4KPiA+Cj4gPiBIZXJlIHdlIHNob3VsZCB1c2Ugc2dfdGFibGUu b3JpZ19uZW50cyB0byBmcmVlIHBhZ2VzIG1lbW9yeSwgYnV0IHVzZSB0aGUKPiA+IHNndGFibGUg aGVscGVyICdmb3IgZWFjaF9zZ3RhYmxlX3NnJygsIGluc3RlYWQgb2YgdGhlIHByZXZpb3VzIHJh dGhlciBjb21tb24KPiA+IGhlbHBlciAnZm9yX2VhY2hfc2cnIHdoaWNoIG1heWJlIGNhdXNlIG1l bW9yeSBsZWFrKSBpcyBtdWNoIGJldHRlci4KClRoYW5rcyBmb3IgY2F0Y2hpbmcgdGhpcyBhbmQg dGhlIHBhdGNoOyBhcHBsaWVkIHRvIGRybS1taXNjLWZpeGVzLgo+ID4KPiA+IEZpeGVzOiBkOTYz YWIwZjE1ZmIwICgiZG1hLWJ1Zjogc3lzdGVtX2hlYXA6IEFsbG9jYXRlIGhpZ2hlciBvcmRlciBw YWdlcyBpZiBhdmFpbGFibGUiKQo+ID4gU2lnbmVkLW9mZi1ieTogR3VhbmdtaW5nIDxHdWFuZ21p bmcuQ2FvQG1lZGlhdGVrLmNvbT4KPiA+IFJldmlld2VkLWJ5OiBSb2JpbiBNdXJwaHkgPHJvYmlu Lm11cnBoeUBhcm0uY29tPgo+ID4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIDUuMTEu Kgo+Cj4gVGhhbmtzIHNvIG11Y2ggZm9yIGNhdGNoaW5nIHRoaXMgYW5kIHNlbmRpbmcgaW4gYWxs IHRoZSByZXZpc2lvbnMhCj4KPiBSZXZpZXdlZC1ieTogSm9obiBTdHVsdHogPGpvaG4uc3R1bHR6 QGxpbmFyby5vcmc+CgoKQmVzdCwKU3VtaXQuCgotLSAKVGhhbmtzIGFuZCByZWdhcmRzLAoKU3Vt aXQgU2Vtd2FsIChoZSAvIGhpbSkKVGVjaCBMZWFkIC0gTENHLCBWZXJ0aWNhbCBUZWNobm9sb2dp ZXMKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==