From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hiroyuki MIKITA <h.mikita89@gmail.com>
Subject: Re: [PATCH] mbuf: decrease refcnt when detaching
Date: Tue, 17 May 2016 01:24:34 +0900
Message-ID: <CAO_n4D1oMjxMFAfDJrOWi1i=yPqbVUXjoDQjicbQLU6CqvoazQ@mail.gmail.com>
References: <1463327436-6863-1-git-send-email-h.mikita89@gmail.com>
 <2601191342CEEE43887BDE71AB97725836B50F15@irsmsx105.ger.corp.intel.com>
 <CAO_n4D11aSBKpkV8v0S4g84K=QDyUjnqAYhXoZiR+u8BnUrfzQ@mail.gmail.com>
 <2574937.kpQRctJEWQ@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 Olivier Matz <olivier.matz@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-yw0-f195.google.com (mail-yw0-f195.google.com
 [209.85.161.195]) by dpdk.org (Postfix) with ESMTP id 51B018D28
 for <dev@dpdk.org>; Mon, 16 May 2016 18:24:54 +0200 (CEST)
Received: by mail-yw0-f195.google.com with SMTP id i22so20125648ywc.1
 for <dev@dpdk.org>; Mon, 16 May 2016 09:24:54 -0700 (PDT)
In-Reply-To: <2574937.kpQRctJEWQ@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi all,

Thanks for suggestions.
I think the Oliver's first option is good.
I introduce the new function and will replace rte_pktmbuf_detach()
with it in a future release.


2016-05-16 18:13 GMT+09:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> 2016-05-16 11:46, Hiroyuki MIKITA:
>> Now, the attach operation increases refcnt, but the detach does not decrease it.
>> I think both operations should affect refcnt or not.
>> Which design is intended?
>>
>> In "6.7. Direct and Indirect Buffers" of Programmer's Guide,
>> it is mentioned that "...whenever an indirect buffer is attached to
>> the direct buffer,
>> the reference counter on the direct buffer is incremented.
>> Similarly, whenever the indirect buffer is detached,
>> the reference counter on the direct buffer is decremented."
>
> The doc is the reference. The doxygen comment should explicit every
> details of the behaviour.
> And the unit tests must validate every parts of the behaviour.
> Probably there is a bug which is not (yet) tested.
> Please see the function testclone_testupdate_testdetach. Thanks
>