From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment with new IRQ function Date: Tue, 12 Sep 2017 08:01:25 -0700 Message-ID: References: <1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-1-git-send-email-markus.theil@tu-ilmenau.de> <1504613046-7259-3-git-send-email-markus.theil@tu-ilmenau.de> <20170912081451.GA40060@bricha3-MOBL3.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Ferruh Yigit , Markus Theil , dev@dpdk.org, nicolas.dichtel@6wind.com To: Bruce Richardson Return-path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 60EF91041 for ; Tue, 12 Sep 2017 17:01:26 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id k20so23361567wre.4 for ; Tue, 12 Sep 2017 08:01:26 -0700 (PDT) In-Reply-To: <20170912081451.GA40060@bricha3-MOBL3.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Why not have an ongoing sliding window policy? So each release it is set On Sep 12, 2017 1:14 AM, "Bruce Richardson" wrote: > On Mon, Sep 11, 2017 at 03:04:01PM -0700, Stephen Hemminger wrote: > > I wonder if it is time to move the bar forward to oldest LTS which is > > 3.2.92 > > > > That seems reasonable. Probably best to do a deprecation notice for it > in 17.11 and move the bar in 18.02. > > /Bruce > > > > > On Sep 11, 2017 10:56 AM, "Ferruh Yigit" wrote: > > > > > On 9/5/2017 1:04 PM, Markus Theil wrote: > > > > The patch which introduced the usage of pci_alloc_irq_vectors > > > > came after the patch which switched to non-threaded ISR (f0d1896fa1), > > > > but did not use non-threaded ISR, if pci_alloc_irq_vectors > > > > is used. > > > > > > > > Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for > > > > MSI-X") > > > > Cc: nicolas.dichtel@6wind.com > > > > > > > > Signed-off-by: Markus Theil > > > > --- > > > > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > > index 93bb71d..6885e72 100644 > > > > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > > > > @@ -331,6 +331,7 @@ igbuio_pci_enable_interrupts(struct > rte_uio_pci_dev > > > *udev) > > > > #else > > > > if (pci_alloc_irq_vectors(udev->pdev, 1, 1, > PCI_IRQ_MSIX) > > > == 1) { > > > > dev_dbg(&udev->pdev->dev, "using MSI-X"); > > > > + udev->info.irq_flags = IRQF_NO_THREAD; > > > > > > IRQF_NO_THREAD seems has been introduced in 2.6.39, so using this flag > > > causing build error for kernel versions < 2.6.39. > > > > > > btw, the flag is already in use, so issue is not related to this patch. > > > > > > In DPDK documentation supported Linux kernel version is >= 2.6.34 [1]. > > > > > > We should either increase supported version to 2.6.39, or update > igb_uio > > > code. > > > > > > I am for increasing minimum supported kernel version to 2.6.39, any > > > objection / comment? > > > > > > 2.6.39 released on May 2011 > > > 2.6.34 released on May 2010 > > > > > > > > > [1] > > > http://dpdk.org/doc/guides/linux_gsg/sys_reqs.html#system-software > > > > > > > udev->info.irq = pci_irq_vector(udev->pdev, 0); > > > > udev->mode = RTE_INTR_MODE_MSIX; > > > > break; > > > > > > > > > > >