From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEAA9C4338F for ; Wed, 18 Aug 2021 07:43:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98CD56054E for ; Wed, 18 Aug 2021 07:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238235AbhHRHo3 (ORCPT ); Wed, 18 Aug 2021 03:44:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238310AbhHRHo1 (ORCPT ); Wed, 18 Aug 2021 03:44:27 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B72EBC061764 for ; Wed, 18 Aug 2021 00:43:52 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id t9so2720857lfc.6 for ; Wed, 18 Aug 2021 00:43:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Pb+i4XV4pD9hHVrCfu2OguYuvXddQz4i1EZeyLXlSA=; b=gU6KmWZ2VTtGU6MiqbJsuaCgeM+rsgd3JJa00KF9rgd6K9cenC2G4J0H6wZB5SCAqf 6Bo7La+IoqM78I2iW9kvnfoDUEdChf27ygxHLn8lkctJjJ2XKY28XcqOepRC3GrG/Iv9 cU1jo2AKfe+0ty10qvt5sCVfPTdG5UopO0ZaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Pb+i4XV4pD9hHVrCfu2OguYuvXddQz4i1EZeyLXlSA=; b=GgaNmDcJNJ2+eSekTEuTgLEWzck+9wAORyJoiozsUT0boU3C1wG+GPO0JK5fMAhUwS wKc7pRPqtAhl4QEDd+2E9MCzJx+GD5+beV1CAd2+UOT6QKdWiInlw2x3ai6UhKfXn0w/ nGdp/K68jUUi8yMco8elmZ0RsYCmbO5Or7EXF3MHdYathuSTaGupiAH1ojm6nIktn2pX KfiPyJIDShKamdYIFBKUtXeOxuCtGOAsb56YaeJ8EZbrUvEaD3DdYhgeUFUi/OH1wq1M XJF10sm8NRE/JpGFBp3anss7Fayge/1Dxv2E1dc9Hp/6WAGNGKOT6f0i10w/sLOUYnLc a/GQ== X-Gm-Message-State: AOAM532kw6boDC1rj8pVewpo/S463aO00gJmHjmLnXr99aUFT/SGUeyb nq4qqHkR44D+3tM9r0BgXughk4LWuoMpHg== X-Google-Smtp-Source: ABdhPJzY6MRpuYfymRx1P0leG8adSYZLgE64yuhqn9vxGFOixqpIqAtz/+HxAgC8OlU6mk9hnUQXxQ== X-Received: by 2002:ac2:50c6:: with SMTP id h6mr5380158lfm.343.1629272631199; Wed, 18 Aug 2021 00:43:51 -0700 (PDT) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com. [209.85.167.54]) by smtp.gmail.com with ESMTPSA id k16sm496127ljo.37.2021.08.18.00.43.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 00:43:51 -0700 (PDT) Received: by mail-lf1-f54.google.com with SMTP id i28so2760457lfl.2 for ; Wed, 18 Aug 2021 00:43:50 -0700 (PDT) X-Received: by 2002:a19:2d4e:: with SMTP id t14mr5421824lft.30.1629272630297; Wed, 18 Aug 2021 00:43:50 -0700 (PDT) MIME-Version: 1.0 References: <20210802121215.703023-1-eizan@chromium.org> <20210802220943.v6.7.I2049e180dca12e0d1b3178bfc7292dcf9e05ac28@changeid> In-Reply-To: From: Eizan Miyamoto Date: Wed, 18 Aug 2021 17:43:33 +1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master To: houlong wei Cc: "linux-kernel@vger.kernel.org" , "wenst@chromium.org" , =?UTF-8?B?WW9uZyBXdSAo5ZC05YuHKQ==?= , "enric.balletbo@collabora.com" , "devicetree@vger.kernel.org" , "chunkuang.hu@kernel.org" , =?UTF-8?B?QW5kcmV3LUNUIENoZW4gKOmZs+aZuui/qik=?= , Matthias Brugger , Mauro Carvalho Chehab , =?UTF-8?B?TWluZ2hzaXUgVHNhaSAo6JSh5piO5L+uKQ==?= , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Houlong, On Mon, Aug 16, 2021 at 1:00 PM houlong wei wrote: > Hi Eizan, > > "mdp-rdma0" may be not the only one master device node. In fact, there > are 2 "mdp-rdma" in mt8173. You can see "mdp_rdma1" via below link. > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.13.11#n1016 > If we add "mediatek,mt8173-mdp" to "mdp_rdma1" like below, we will have > one more V4L2 video devie node. > > mdp_rdma1: rdma@14002000 { > compatible = "mediatek,mt8173-mdp-rdma", > "mediatek,mt8173-mdp"; > ... > } > > We should consider the case that there are more than one "MDP_RDMA" > components. Would it be okay with you if we added support for multiple MDP master device nodes in follow-up changes? My rationale is this: - As far as I can tell, the mediatek integration with V4L2 currently only handles a single MDP master device node. It's not clear to me the scope of changes that will be needed to make things work properly with multiple nodes. - The patch series makes video decode work (admittedly, in light of your comments not optimally) upstream, which is better than not landing these changes at all. I'd like to say that I'm very open to (and excited about) discussing further work to support multiple MDP master nodes, perhaps we can work together on this so I can understand what needs to be done. Please let me know your thoughts, Eizan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA68EC4338F for ; Wed, 18 Aug 2021 07:44:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 631266108D for ; Wed, 18 Aug 2021 07:44:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 631266108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5WH66OTpvwX5EZvaDcLqBPu3Jt9AqG4pYU708Gal0v4=; b=Va/AkV0Svx9j2Q ekU77hN8NO56dtvg/ast0WT6BrklWYqqvORcBWVl8/0yBDkNorX9QQcse2sGTF5ctSvyx73L6tsaC gNQ4Od+5R9+klk3NtY2dPjmDSvolMXfmzNUL/G1ebNZimkHYNrG0HPpgeXiA1XXenyDvWXeTcqdy5 2pwjY2TsS1xTm8UYPD5m5x5dODCj+eJu6pWixVbeuINGwrcnkZdQiHF4ltkFjcAeYh2O2pYzV5xzt +aUTDmb+JbSxV+8m05Ba7EHPOJ/IswZl77y3jnM1Eh34YvInNclcDi5S+7IbfR7QDYf0Ye9UZxg29 6TdMgFsuGO5gCHqR9P1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGGFA-004Wmy-9o; Wed, 18 Aug 2021 07:44:12 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGGEv-004Wjb-2T for linux-mediatek@lists.infradead.org; Wed, 18 Aug 2021 07:44:02 +0000 Received: by mail-lf1-x132.google.com with SMTP id t9so2720990lfc.6 for ; Wed, 18 Aug 2021 00:43:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Pb+i4XV4pD9hHVrCfu2OguYuvXddQz4i1EZeyLXlSA=; b=gU6KmWZ2VTtGU6MiqbJsuaCgeM+rsgd3JJa00KF9rgd6K9cenC2G4J0H6wZB5SCAqf 6Bo7La+IoqM78I2iW9kvnfoDUEdChf27ygxHLn8lkctJjJ2XKY28XcqOepRC3GrG/Iv9 cU1jo2AKfe+0ty10qvt5sCVfPTdG5UopO0ZaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Pb+i4XV4pD9hHVrCfu2OguYuvXddQz4i1EZeyLXlSA=; b=SlId82rcWR/LuwNc2Dqbuc/rmZ7Ah7atwZHTFFbt+P4FS4z96RbH7ULd9RaYWYkxPV E+wPmYbMb9ox62H//Z20WiJOK0esyNW+Hm4PTmWcvm8OJzxKwEWQ7Jx6b1svvE8Yht6k xjWQFEARle3DLoE+4qDz60YzircoebT0XsZ32/jmHM0YWtlnLH328LYRp7acFaKG4zFL akPFEe5nc9uYSES+GVb5P3SckWHnHwq8oyMQawM7RU4W934KXjxLdqmyQVwZ/cg9dxG7 jlrJln9aTAWVaN8L6u1sYS89OAkBJF3T7M8PCY+HZj5xEpb859BPJn6FI820qcuEptyg 7RyQ== X-Gm-Message-State: AOAM530A+QJudVEgcFDLcjNKVqPlOEWRVsqpPqOldSlmIMB2rukzNgu+ 8AEL5tWc5Ne28EamB3bnk5CbmpLOFWtoDA== X-Google-Smtp-Source: ABdhPJw5R3diGOYwOGCpPyqkiOatrDogT7IPv/6drw1VS5cWbx9rbkU02iIaJvjbNilsyXzL5durAQ== X-Received: by 2002:a19:a40b:: with SMTP id q11mr5627688lfc.541.1629272632675; Wed, 18 Aug 2021 00:43:52 -0700 (PDT) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com. [209.85.167.53]) by smtp.gmail.com with ESMTPSA id m28sm489273ljc.46.2021.08.18.00.43.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 00:43:51 -0700 (PDT) Received: by mail-lf1-f53.google.com with SMTP id z2so2784411lft.1 for ; Wed, 18 Aug 2021 00:43:50 -0700 (PDT) X-Received: by 2002:a19:2d4e:: with SMTP id t14mr5421824lft.30.1629272630297; Wed, 18 Aug 2021 00:43:50 -0700 (PDT) MIME-Version: 1.0 References: <20210802121215.703023-1-eizan@chromium.org> <20210802220943.v6.7.I2049e180dca12e0d1b3178bfc7292dcf9e05ac28@changeid> In-Reply-To: From: Eizan Miyamoto Date: Wed, 18 Aug 2021 17:43:33 +1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master To: houlong wei Cc: "linux-kernel@vger.kernel.org" , "wenst@chromium.org" , =?UTF-8?B?WW9uZyBXdSAo5ZC05YuHKQ==?= , "enric.balletbo@collabora.com" , "devicetree@vger.kernel.org" , "chunkuang.hu@kernel.org" , =?UTF-8?B?QW5kcmV3LUNUIENoZW4gKOmZs+aZuui/qik=?= , Matthias Brugger , Mauro Carvalho Chehab , =?UTF-8?B?TWluZ2hzaXUgVHNhaSAo6JSh5piO5L+uKQ==?= , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_004357_127904_A5CC1B95 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Houlong, On Mon, Aug 16, 2021 at 1:00 PM houlong wei wrote: > Hi Eizan, > > "mdp-rdma0" may be not the only one master device node. In fact, there > are 2 "mdp-rdma" in mt8173. You can see "mdp_rdma1" via below link. > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.13.11#n1016 > If we add "mediatek,mt8173-mdp" to "mdp_rdma1" like below, we will have > one more V4L2 video devie node. > > mdp_rdma1: rdma@14002000 { > compatible = "mediatek,mt8173-mdp-rdma", > "mediatek,mt8173-mdp"; > ... > } > > We should consider the case that there are more than one "MDP_RDMA" > components. Would it be okay with you if we added support for multiple MDP master device nodes in follow-up changes? My rationale is this: - As far as I can tell, the mediatek integration with V4L2 currently only handles a single MDP master device node. It's not clear to me the scope of changes that will be needed to make things work properly with multiple nodes. - The patch series makes video decode work (admittedly, in light of your comments not optimally) upstream, which is better than not landing these changes at all. I'd like to say that I'm very open to (and excited about) discussing further work to support multiple MDP master nodes, perhaps we can work together on this so I can understand what needs to be done. Please let me know your thoughts, Eizan _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78932C4338F for ; Wed, 18 Aug 2021 07:46:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 489156108B for ; Wed, 18 Aug 2021 07:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 489156108B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4AsUhH5Idb1rWf8z1YOmlhVrWsXP68RZDsqtsiA4fwg=; b=O3ehjern8qZNBR sRAQaaACeiVtDIEgoF10hPSzH06atpJGZmncbo675635KMKrEw/sWt71T0ZbHrT7eoaBt7shop4b+ YVEoe6Vy2rFf12tPD7TQ1TEYD4L8jnYHSXU7yJ8pD/Me5T26+pCbOyzjSlNDjcONms5qp2s/PMHhd hMiFUEsVPyInardTjKum0dayCT58c7/kASNx718g/hDpEJicWKW6nBZMOH9eSULYLsPr3TCF0/ssu dW95NnBWJZOBeqKLFNXiAkwfMlpkrhim1wxQfRiIrzsfNtpSfUkeS6L/Iv5HSWvIkGIC87UhzgAiV jtC5/dJTIFAG/R4hzNYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGGF0-004WlM-LN; Wed, 18 Aug 2021 07:44:02 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGGEu-004WjY-LD for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 07:44:00 +0000 Received: by mail-lf1-x12f.google.com with SMTP id o10so2678682lfr.11 for ; Wed, 18 Aug 2021 00:43:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Pb+i4XV4pD9hHVrCfu2OguYuvXddQz4i1EZeyLXlSA=; b=gU6KmWZ2VTtGU6MiqbJsuaCgeM+rsgd3JJa00KF9rgd6K9cenC2G4J0H6wZB5SCAqf 6Bo7La+IoqM78I2iW9kvnfoDUEdChf27ygxHLn8lkctJjJ2XKY28XcqOepRC3GrG/Iv9 cU1jo2AKfe+0ty10qvt5sCVfPTdG5UopO0ZaY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Pb+i4XV4pD9hHVrCfu2OguYuvXddQz4i1EZeyLXlSA=; b=kzbebr9PBrnssFNRd70mg2dCk+KQLxzn2IPv9gxFlAfQpXF0YlW+knXPvBmueR6w7z r34e6sA+ZMB2QUDtp7DB/rJFSHysqynvO2kfjeO6yvPTlHUR8acD9vljwMK3SCF72dbu tLVw+Ez1RsmHwVFA9QGmbC67pVrSpfUuux7lwExtnCRf5TMbV2dT6T+yFBdnwZ4FbNGx xXzfQlnk7RHfUdCPIz7qc1wpRs/8Bq3teUVcpsvBwDQIiwPG64eYhFFUXnBQps8ZhBTP JvgPsED2FdszDzW1IzExNGCm9PzJO/Xe5OWuKWD8YNjeL+y6wVQIbIAQKmYYEJRi1wIC hHLg== X-Gm-Message-State: AOAM532ZHy2mKZe628/IWQ2AhFjENcECRlDxzpBSI9AbIB6h9zMDg6Xq bMRUYzJI4chjW75J9N3EfZdqeoQZxVnG9g== X-Google-Smtp-Source: ABdhPJz2jc/2OF05gh9kDU7+XE8neUGXJnobq0C2u1tj3ef4ubHO4uyVx9RQHcew25UH/f27LCS3UA== X-Received: by 2002:a05:6512:360d:: with SMTP id f13mr5643123lfs.581.1629272632305; Wed, 18 Aug 2021 00:43:52 -0700 (PDT) Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com. [209.85.167.49]) by smtp.gmail.com with ESMTPSA id n3sm419116lft.63.2021.08.18.00.43.50 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 00:43:51 -0700 (PDT) Received: by mail-lf1-f49.google.com with SMTP id i9so2679043lfg.10 for ; Wed, 18 Aug 2021 00:43:50 -0700 (PDT) X-Received: by 2002:a19:2d4e:: with SMTP id t14mr5421824lft.30.1629272630297; Wed, 18 Aug 2021 00:43:50 -0700 (PDT) MIME-Version: 1.0 References: <20210802121215.703023-1-eizan@chromium.org> <20210802220943.v6.7.I2049e180dca12e0d1b3178bfc7292dcf9e05ac28@changeid> In-Reply-To: From: Eizan Miyamoto Date: Wed, 18 Aug 2021 17:43:33 +1000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 7/9] media: mtk-mdp: use mdp-rdma0 alias to point to MDP master To: houlong wei Cc: "linux-kernel@vger.kernel.org" , "wenst@chromium.org" , =?UTF-8?B?WW9uZyBXdSAo5ZC05YuHKQ==?= , "enric.balletbo@collabora.com" , "devicetree@vger.kernel.org" , "chunkuang.hu@kernel.org" , =?UTF-8?B?QW5kcmV3LUNUIENoZW4gKOmZs+aZuui/qik=?= , Matthias Brugger , Mauro Carvalho Chehab , =?UTF-8?B?TWluZ2hzaXUgVHNhaSAo6JSh5piO5L+uKQ==?= , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" , "linux-mediatek@lists.infradead.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_004356_730102_DD82CCC0 X-CRM114-Status: GOOD ( 18.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Houlong, On Mon, Aug 16, 2021 at 1:00 PM houlong wei wrote: > Hi Eizan, > > "mdp-rdma0" may be not the only one master device node. In fact, there > are 2 "mdp-rdma" in mt8173. You can see "mdp_rdma1" via below link. > > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/arch/arm64/boot/dts/mediatek/mt8173.dtsi?h=v5.13.11#n1016 > If we add "mediatek,mt8173-mdp" to "mdp_rdma1" like below, we will have > one more V4L2 video devie node. > > mdp_rdma1: rdma@14002000 { > compatible = "mediatek,mt8173-mdp-rdma", > "mediatek,mt8173-mdp"; > ... > } > > We should consider the case that there are more than one "MDP_RDMA" > components. Would it be okay with you if we added support for multiple MDP master device nodes in follow-up changes? My rationale is this: - As far as I can tell, the mediatek integration with V4L2 currently only handles a single MDP master device node. It's not clear to me the scope of changes that will be needed to make things work properly with multiple nodes. - The patch series makes video decode work (admittedly, in light of your comments not optimally) upstream, which is better than not landing these changes at all. I'd like to say that I'm very open to (and excited about) discussing further work to support multiple MDP master nodes, perhaps we can work together on this so I can understand what needs to be done. Please let me know your thoughts, Eizan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel