From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Lutomirski <luto@mit.edu>
Subject: Re: [PATCH 1/2] drm/i915: Dumb down the semaphore logic
Date: Wed, 7 Sep 2011 18:22:30 -0700
Message-ID: <CAObL_7Fdu7=Y5LogBHnEcHfB3n6u101+jRqhQaxVrp0hFmj+Rg@mail.gmail.com>
References: <1315437162-14312-1-git-send-email-ben@bwidawsk.net>
	<CAObL_7FdATx1ga-j1wn5jYvuHPajqLgo1DMW=NVWD7-73aRmFw@mail.gmail.com>
	<A46ACFD7-245D-4202-A381-C859BCEF230F@bwidawsk.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-pz0-f44.google.com (mail-pz0-f44.google.com
	[209.85.210.44])
	by gabe.freedesktop.org (Postfix) with ESMTP id 57827A2484
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  7 Sep 2011 18:22:50 -0700 (PDT)
Received: by pzk36 with SMTP id 36so386600pzk.3
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 07 Sep 2011 18:22:50 -0700 (PDT)
In-Reply-To: <A46ACFD7-245D-4202-A381-C859BCEF230F@bwidawsk.net>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Sep 7, 2011 at 6:19 PM, Ben Widawsky <ben@bwidawsk.net> wrote:
>
>
> On Sep 7, 2011, at 5:30 PM, Andrew Lutomirski <luto@mit.edu> wrote:
>
>> On Wed, Sep 7, 2011 at 4:12 PM, Ben Widawsky <ben@bwidawsk.net> wrote:
>>> While I think the previous code is correct, it was hard to follow and
>>> hard to debug. Since we already have a ring abstraction, might as well
>>> use it to handle the semaphore updates and compares.
>>>
>>> I don't expect this code to make semaphores better or worse, but you
>>> never know...
>>>
>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>>> Cc: Eric Anholt <eric@anholt.net>
>>> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
>>> ---
>>> =A0drivers/gpu/drm/i915/i915_gem_execbuffer.c | =A0 =A03 +-
>>> =A0drivers/gpu/drm/i915/i915_reg.h =A0 =A0 =A0 =A0 =A0 =A0| =A0 =A07 +
>>> =A0drivers/gpu/drm/i915/intel_ringbuffer.c =A0 =A0| =A0176 ++++++++++++=
+++++++++-------
>>> =A0drivers/gpu/drm/i915/intel_ringbuffer.h =A0 =A0| =A0 =A07 +-
>>> =A04 files changed, 145 insertions(+), 48 deletions(-)
>>>
>>
>> Sadly, it still instantly crashes.
>>
>> --Andy
>
> Remind me again... Does ssh still work?

I haven't tried, but I'd be surprised.  The *reset* button (the
hardware one that's attached to the motherboard) doesn't work.

--Andy