From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gcvzD-0004kP-BL for qemu-devel@nongnu.org; Fri, 28 Dec 2018 12:31:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gcvnX-00028W-Lo for qemu-devel@nongnu.org; Fri, 28 Dec 2018 12:19:49 -0500 Received: from mail-yw1-xc35.google.com ([2607:f8b0:4864:20::c35]:44367) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gcvnX-000256-Gu for qemu-devel@nongnu.org; Fri, 28 Dec 2018 12:19:47 -0500 Received: by mail-yw1-xc35.google.com with SMTP id b63so7273064ywc.11 for ; Fri, 28 Dec 2018 09:19:46 -0800 (PST) MIME-Version: 1.0 References: <945511ac-d99a-d483-12a2-e6ad4dda09c2@linaro.org> In-Reply-To: From: Nick Renieris Date: Fri, 28 Dec 2018 19:19:18 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] AVX support for TCG List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Richard Henderson , QEMU Developers =CE=A3=CF=84=CE=B9=CF=82 =CE=A0=CE=B1=CF=81, 28 =CE=94=CE=B5=CE=BA 2018 =CF= =83=CF=84=CE=B9=CF=82 4:39 =CE=BC.=CE=BC., =CE=BF/=CE=B7 Peter Maydell =CE=AD=CE=B3=CF=81=CE=B1=CF=88=CE=B5: > If your editor can't show multiple views onto one file with > the same simplicity and UI as it has for multiple different > files then I would suggest getting a better editor :-) Apparently I just didn't know how to use my editor :) In my defense, I've never had to do this before. > Unless you want to restrict all your files to 100 lines or > shorter then you need to be able to see multiple parts of them > at once -- one 10,000 line file is no worse than 4 2500 line > files for this. As you mention below, logical separation is key here, I definitely didn't mean that there should be arbitrary LoC limits for each file. > There are definitely improvements that could be made to > the x86 code, and where splitting of files makes conceptual > sense it's certainly worthwhile. The trick is finding the > right logical splitting points. Agreed, though it's not something I can personally help on, unless I spend quite a long time getting acquainted with _this_ code first. I'd like to get some answers to my previous question about estimates of the total amount of work required before considering diving into it.