From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Kristian_H=C3=B8gsberg?= Subject: Re: [PATCH v2 2/6] drm/i915: Add NV12 as supported format for primary plane Date: Fri, 13 Apr 2018 16:15:01 +0000 Message-ID: References: <1523621644-32363-1-git-send-email-vidya.srinivas@intel.com> <1523621644-32363-3-git-send-email-vidya.srinivas@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x244.google.com (mail-wr0-x244.google.com [IPv6:2a00:1450:400c:c0c::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 870FB6EB13 for ; Fri, 13 Apr 2018 16:15:13 +0000 (UTC) Received: by mail-wr0-x244.google.com with SMTP id s18so9519016wrg.9 for ; Fri, 13 Apr 2018 09:15:13 -0700 (PDT) In-Reply-To: <1523621644-32363-3-git-send-email-vidya.srinivas@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Vidya Srinivas Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBBcHIgMTMsIDIwMTggYXQgNToxNyBBTSBWaWR5YSBTcmluaXZhcyA8dmlkeWEuc3Jp bml2YXNAaW50ZWwuY29tPgp3cm90ZToKCj4gRnJvbTogQ2hhbmRyYSBLb25kdXJ1IDxjaGFuZHJh LmtvbmR1cnVAaW50ZWwuY29tPgoKPiBUaGlzIHBhdGNoIGFkZHMgTlYxMiB0byBsaXN0IG9mIHN1 cHBvcnRlZCBmb3JtYXRzIGZvcgo+IHByaW1hcnkgcGxhbmUKClJldmlld2VkLWJ5OiBLcmlzdGlh biBILiBLcmlzdGVuc2VuIDxob2Vnc2JlcmdAZ29vZ2xlLmNvbT4KCj4gdjI6IFJlYmFzZWQgKENo YW5kcmEgS29uZHVydSkKCj4gdjM6IFJlYmFzZWQgKG1lKQoKPiB2NDogUmV2aWV3IGNvbW1lbnRz IGJ5IFZpbGxlIGFkZHJlc3NlZAo+IFJlbW92ZWQgdGhlIHNrbF9wcmltYXJ5X2Zvcm1hdHNfd2l0 aF9udjEyIGFuZAo+IGFkZGVkIE5WMTIgY2FzZSBpbiBleGlzdGluZyBza2xfcHJpbWFyeV9mb3Jt YXRzCgo+IHY1OiBSZWJhc2VkIChtZSkKCj4gdjY6IE1pc3NlZCB0aGUgVGVzdGVkLWJ5L1Jldmll d2VkLWJ5IGluIHRoZSBwcmV2aW91cyBzZXJpZXMKPiBBZGRpbmcgdGhlIHNhbWUgdG8gY29tbWl0 IG1lc3NhZ2UgaW4gdGhpcyB2ZXJzaW9uLgoKPiB2NzogUmV2aWV3IGNvbW1lbnRzIGJ5IFZpbGxl IGFkZHJlc3NlZAo+ICAgICAgICAgIFJlc3RyaWN0aW5nIHRoZSBOVjEyIGZvciBCWFQgYW5kIG9u IFBJUEUgQSBhbmQgQgo+IFJlYmFzZWQgKG1lKQoKPiB2ODogUmViYXNlZCAobWUpCj4gTW9kaWZp ZWQgcmVzdHJpY3RpbmcgdGhlIE5WMTIgc3VwcG9ydCBmb3IgYm90aCBCWFQgYW5kIEtCTC4KCj4g djk6IFJlYmFzZWQgKG1lKQoKPiB2MTA6IEFkZHJlc3NlZCByZXZpZXcgY29tbWVudHMgZnJvbSBN YWFydGVuLgo+ICAgICAgICAgIEFkZGluZyBOVjEyIGluc2lkZSBza2xfcHJpbWFyeV9mb3JtYXRz IGl0c2VsZi4KCj4gdjExOiBBZGRpbmcgUmV2aWV3ZWQgQnkgdGFnIGZyb20gU2hhc2hhbmsgU2hh cm1hCgo+IHYxMjogQWRkcmVzc2VkIHJldmlldyBjb21tZW50cyBmcm9tIEp1aGEtUGVra2EgSGVp a2tpbGEKPiAiTlYxMiBub3QgdG8gYmUgc3VwcG9ydGVkIGJ5IFNLTCIKCj4gdjEzOiBBZGRyZXNz ZWQgcmV2aWV3IGNvbW1lbnRzIGZyb20gVmlsbGUKPiBBZGRlZCBza2xfcHJpX3BsYW5hcl9mb3Jt YXRzIHRvIGluY2x1ZGUgTlYxMgo+IGFuZCBza2xfcGxhbmVfaGFzX3BsYW5hciBmdW5jdGlvbiB0 byBjaGVjayBmb3IKPiBOVjEyIHN1cHBvcnQgb24gcGxhbmUuIEFkZGVkIE5WMTIgZm9ybWF0IHRv Cj4gc2tsX21vZF9zdXBwb3J0ZWQuIFRoZXNlIHdlcmUgcmV2aWV3IGNvbW1lbnRzCj4gZnJvbSBL cmlzdGlhbiBIw7hnc2JlcmcgPGhvZWdzYmVyZ0BnbWFpbC5jb20+Cgo+IHYxNDogQWRkZWQgcmV2 aWV3ZWQgYnkgZnJvbSBKdWhhLVBla2thIEhlaWtraWxhCgo+IHYxNTogUmViYXNlZCB0aGUgc2Vy aWVzCgo+IHYxNjogQWRkZWQgYWxsIHRpbGluZyBzdXBwb3J0IHVuZGVyIG1vZCBzdXBwb3J0ZWQK PiBmb3IgTlYxMi4gQ3JlZGl0cyB0byBNZWdoYSBBZ2dhcndhbAoKPiBDcmVkaXRzLXRvOiBNZWdo YSBBZ2dhcndhbCBtZWdoYS5hZ2dhcndhbEBpbnRlbC5jb20KPiBUZXN0ZWQtYnk6IENsaW50b24g VGF5bG9yIDxjbGludG9uLmEudGF5bG9yQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogSnVoYS1Q ZWtrYSBIZWlra2lsYSA8anVoYXBla2thLmhlaWtraWxhQGdtYWlsLmNvbT4KPiBSZXZpZXdlZC1i eTogQ2xpbnRvbiBUYXlsb3IgPGNsaW50b24uYS50YXlsb3JAaW50ZWwuY29tPgo+IFJldmlld2Vk LWJ5OiBTaGFzaGFuayBTaGFybWEgPHNoYXNoYW5rLnNoYXJtYUBpbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogQ2hhbmRyYSBLb25kdXJ1IDxjaGFuZHJhLmtvbmR1cnVAaW50ZWwuY29tPgo+IFNp Z25lZC1vZmYtYnk6IE5hYmVuZHUgTWFpdGkgPG5hYmVuZHUuYmlrYXNoLm1haXRpQGludGVsLmNv bT4KPiBTaWduZWQtb2ZmLWJ5OiBWaWR5YSBTcmluaXZhcyA8dmlkeWEuc3Jpbml2YXNAaW50ZWwu Y29tPgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgNTUK KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tCj4gICBkcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCAgICAgfCAgMiArKwo+ICAgMiBmaWxlcyBjaGFuZ2VkLCA1NSBpbnNl cnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCmIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gaW5kZXggMjJjOGE3ZC4uMWEwZmFlOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9kaXNwbGF5LmMKPiBAQCAtODgsNiArODgsMjIgQEAgc3RhdGljIGNvbnN0IHVpbnQzMl90IHNr bF9wcmltYXJ5X2Zvcm1hdHNbXSA9IHsKPiAgICAgICAgICBEUk1fRk9STUFUX1ZZVVksCj4gICB9 OwoKPiArc3RhdGljIGNvbnN0IHVpbnQzMl90IHNrbF9wcmlfcGxhbmFyX2Zvcm1hdHNbXSA9IHsK PiArICAgICAgIERSTV9GT1JNQVRfQzgsCj4gKyAgICAgICBEUk1fRk9STUFUX1JHQjU2NSwKPiAr ICAgICAgIERSTV9GT1JNQVRfWFJHQjg4ODgsCj4gKyAgICAgICBEUk1fRk9STUFUX1hCR1I4ODg4 LAo+ICsgICAgICAgRFJNX0ZPUk1BVF9BUkdCODg4OCwKPiArICAgICAgIERSTV9GT1JNQVRfQUJH Ujg4ODgsCj4gKyAgICAgICBEUk1fRk9STUFUX1hSR0IyMTAxMDEwLAo+ICsgICAgICAgRFJNX0ZP Uk1BVF9YQkdSMjEwMTAxMCwKPiArICAgICAgIERSTV9GT1JNQVRfWVVZViwKPiArICAgICAgIERS TV9GT1JNQVRfWVZZVSwKPiArICAgICAgIERSTV9GT1JNQVRfVVlWWSwKPiArICAgICAgIERSTV9G T1JNQVRfVllVWSwKPiArICAgICAgIERSTV9GT1JNQVRfTlYxMiwKPiArfTsKPiArCj4gICBzdGF0 aWMgY29uc3QgdWludDY0X3Qgc2tsX2Zvcm1hdF9tb2RpZmllcnNfbm9jY3NbXSA9IHsKPiAgICAg ICAgICBJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQsCj4gICAgICAgICAgSTkxNV9GT1JNQVRfTU9E X1lfVElMRUQsCj4gQEAgLTEzMTI0LDYgKzEzMTQwLDEyIEBAIHN0YXRpYyBib29sIHNrbF9tb2Rf c3VwcG9ydGVkKHVpbnQzMl90IGZvcm1hdCwKdWludDY0X3QgbW9kaWZpZXIpCj4gICAgICAgICAg ICAgICAgICBpZiAobW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEKQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPiAgICAgICAgICAgICAgICAgIC8qIGZh bGwgdGhyb3VnaCAqLwo+ICsgICAgICAgY2FzZSBEUk1fRk9STUFUX05WMTI6Cj4gKyAgICAgICAg ICAgICAgIGlmIChtb2RpZmllciA9PSBEUk1fRk9STUFUX01PRF9MSU5FQVIgfHwKPiArICAgICAg ICAgICAgICAgICAgIG1vZGlmaWVyID09IEk5MTVfRk9STUFUX01PRF9YX1RJTEVEIHx8Cj4gKyAg ICAgICAgICAgICAgICAgICBtb2RpZmllciA9PSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRCB8fAo+ ICsgICAgICAgICAgICAgICAgICAgbW9kaWZpZXIgPT0gSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVE KQo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVlOwo+ICAgICAgICAgIGNhc2Ug RFJNX0ZPUk1BVF9DODoKPiAgICAgICAgICAgICAgICAgIGlmIChtb2RpZmllciA9PSBEUk1fRk9S TUFUX01PRF9MSU5FQVIgfHwKPiAgICAgICAgICAgICAgICAgICAgICBtb2RpZmllciA9PSBJOTE1 X0ZPUk1BVF9NT0RfWF9USUxFRCB8fAo+IEBAIC0xMzMyOCw2ICsxMzM1MCwzMCBAQCBzdGF0aWMg Ym9vbCBza2xfcGxhbmVfaGFzX2ZiYyhzdHJ1Y3QKZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gICAgICAgICAgcmV0dXJuIHBpcGUgPT0gUElQRV9BICYmIHBsYW5lX2lkID09IFBMQU5FX1BS SU1BUlk7Cj4gICB9Cgo+ICtib29sIHNrbF9wbGFuZV9oYXNfcGxhbmFyKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgIGVudW0gcGlw ZSBwaXBlLCBlbnVtIHBsYW5lX2lkIHBsYW5lX2lkKQo+ICt7Cj4gKyAgICAgICBpZiAocGxhbmVf aWQgPT0gUExBTkVfUFJJTUFSWSkgewo+ICsgICAgICAgICAgICAgICBpZiAoSVNfU0tZTEFLRShk ZXZfcHJpdikpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ICsgICAg ICAgICAgICAgICBlbHNlIGlmICgoSU5URUxfR0VOKGRldl9wcml2KSA9PSA5ICYmIHBpcGUgPT0g UElQRV9DKSAmJgo+ICsgICAgICAgICAgICAgICAgICAgICAgICAhSVNfR0VNSU5JTEFLRShkZXZf cHJpdikpCj4gKyAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ICsgICAgICAg fSBlbHNlIGlmIChwbGFuZV9pZCA+PSBQTEFORV9TUFJJVEUwKSB7Cj4gKyAgICAgICAgICAgICAg IGlmIChwbGFuZV9pZCA9PSBQTEFORV9DVVJTT1IpCj4gKyAgICAgICAgICAgICAgICAgICAgICAg cmV0dXJuIGZhbHNlOwo+ICsgICAgICAgICAgICAgICBpZiAoSVNfR0VNSU5JTEFLRShkZXZfcHJp dikgfHwgSU5URUxfR0VOKGRldl9wcml2KSA9PSAxMCkKewo+ICsgICAgICAgICAgICAgICAgICAg ICAgIGlmIChwbGFuZV9pZCAhPSBQTEFORV9TUFJJVEUwKQo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwo+ICsgICAgICAgICAgICAgICB9IGVsc2Ugewo+ICsg ICAgICAgICAgICAgICAgICAgICAgIGlmIChwbGFuZV9pZCAhPSBQTEFORV9TUFJJVEUwIHx8IHBp cGUgPT0gUElQRV9DIHx8Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIElTX1NLWUxBS0Uo ZGV2X3ByaXYpKQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNl Owo+ICsgICAgICAgICAgICAgICB9Cj4gKyAgICAgICB9Cj4gKyAgICAgICByZXR1cm4gdHJ1ZTsK PiArfQo+ICsKPiAgIHN0YXRpYyBzdHJ1Y3QgaW50ZWxfcGxhbmUgKgo+ICAgaW50ZWxfcHJpbWFy eV9wbGFuZV9jcmVhdGUoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtIHBp cGUKcGlwZSkKPiAgIHsKPiBAQCAtMTMzODgsOCArMTM0MzQsMTMgQEAgaW50ZWxfcHJpbWFyeV9w bGFuZV9jcmVhdGUoc3RydWN0CmRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtIHBpcGUg cGlwZSkKPiAgICAgICAgICBwcmltYXJ5LT5jaGVja19wbGFuZSA9IGludGVsX2NoZWNrX3ByaW1h cnlfcGxhbmU7Cgo+ICAgICAgICAgIGlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpIHsKPiAt ICAgICAgICAgICAgICAgaW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gc2tsX3ByaW1hcnlfZm9ybWF0 czsKPiAtICAgICAgICAgICAgICAgbnVtX2Zvcm1hdHMgPSBBUlJBWV9TSVpFKHNrbF9wcmltYXJ5 X2Zvcm1hdHMpOwo+ICsgICAgICAgICAgICAgICBpZiAoc2tsX3BsYW5lX2hhc19wbGFuYXIoZGV2 X3ByaXYsIHBpcGUsIFBMQU5FX1BSSU1BUlkpKSB7Cj4gKyAgICAgICAgICAgICAgICAgICAgICAg aW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gc2tsX3ByaV9wbGFuYXJfZm9ybWF0czsKPiArICAgICAg ICAgICAgICAgICAgICAgICBudW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3ByaV9wbGFuYXJf Zm9ybWF0cyk7Cj4gKyAgICAgICAgICAgICAgIH0gZWxzZSB7Cj4gKyAgICAgICAgICAgICAgICAg ICAgICAgaW50ZWxfcHJpbWFyeV9mb3JtYXRzID0gc2tsX3ByaW1hcnlfZm9ybWF0czsKPiArICAg ICAgICAgICAgICAgICAgICAgICBudW1fZm9ybWF0cyA9IEFSUkFZX1NJWkUoc2tsX3ByaW1hcnlf Zm9ybWF0cyk7Cj4gKyAgICAgICAgICAgICAgIH0KCj4gICAgICAgICAgICAgICAgICBpZiAoc2ts X3BsYW5lX2hhc19jY3MoZGV2X3ByaXYsIHBpcGUsIFBMQU5FX1BSSU1BUlkpKQo+ICAgICAgICAg ICAgICAgICAgICAgICAgICBtb2RpZmllcnMgPSBza2xfZm9ybWF0X21vZGlmaWVyc19jY3M7Cj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCmIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCBkODkzMDY3Ni4uMDEzNTJlZiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTIwNjMsNiArMjA2Myw4IEBAIGJvb2wgc2ts X3BsYW5lX2dldF9od19zdGF0ZShzdHJ1Y3QgaW50ZWxfcGxhbmUKKnBsYW5lKTsKPiAgIGJvb2wg c2tsX3BsYW5lX2hhc19jY3Moc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAg ICAgICAgICAgICAgICAgICAgICAgIGVudW0gcGlwZSBwaXBlLCBlbnVtIHBsYW5lX2lkIHBsYW5l X2lkKTsKPiAgIGJvb2wgaW50ZWxfZm9ybWF0X2lzX3l1dih1aW50MzJfdCBmb3JtYXQpOwo+ICti b29sIHNrbF9wbGFuZV9oYXNfcGxhbmFyKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diwKPiArICAgICAgICAgICAgICAgICAgICAgICAgIGVudW0gcGlwZSBwaXBlLCBlbnVtIHBsYW5l X2lkIHBsYW5lX2lkKTsKCj4gICAvKiBpbnRlbF90di5jICovCj4gICB2b2lkIGludGVsX3R2X2lu aXQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KTsKPiAtLQo+IDIuNy40Cgo+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeApfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGlu ZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK