From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 8A1D1BE7 for ; Tue, 16 Jul 2019 21:58:01 +0000 (UTC) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id 7E9CE63D for ; Tue, 16 Jul 2019 21:58:00 +0000 (UTC) Received: by mail-io1-f42.google.com with SMTP id m24so42545536ioo.2 for ; Tue, 16 Jul 2019 14:58:00 -0700 (PDT) MIME-Version: 1.0 References: <20190706142738.GA6893@kunai> <20190714103509.2dd72c90@archlinux> <20190716211636.GA6679@kunai> In-Reply-To: <20190716211636.GA6679@kunai> From: Olof Johansson Date: Tue, 16 Jul 2019 14:57:48 -0700 Message-ID: To: Wolfram Sang Content-Type: text/plain; charset="UTF-8" Cc: ksummit Subject: Re: [Ksummit-discuss] [MAINTAINERS SUMMIT] Keeping reviews meaningful List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jul 16, 2019 at 2:16 PM Wolfram Sang wrote: > > > > Even if we agree on a set of new tags the usage will still be based on > > individual interpretation, which brings us back to square one. > > I agree. New tags won't help us much. > > > So no, let's just accept that these things are subjective and apply common > > sense to make the best use of them. > > I meanwhile do think, though, that for "best use" it will be helpful to > add my Rev-by to my SoB when I really did a full review (and not just > trusted other reviewers). To properly document the process of a patch. I don't see how this is bringing much value. You picked up the patch, and if you did so without looking closely at it, the end result is the same: You're likely to be on the line for dealing with issues. The only thing a "S-o-b" without "R-b" would bring is "It's not my fault that stuff broke" -- but it still is since your name is on it, and that's not something that adds value for the project as a whole. -Olof