From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933621AbbIDTBn (ORCPT ); Fri, 4 Sep 2015 15:01:43 -0400 Received: from mail-yk0-f169.google.com ([209.85.160.169]:33834 "EHLO mail-yk0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932892AbbIDTBl (ORCPT ); Fri, 4 Sep 2015 15:01:41 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:157d:3940:ec5d:2eca:137f] In-Reply-To: <20150903155029.GB5332@linux> References: <1441293658-18199-1-git-send-email-linux@roeck-us.net> <20150903155029.GB5332@linux> Date: Fri, 4 Sep 2015 12:01:40 -0700 Message-ID: Subject: Re: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL From: Olof Johansson To: Viresh Kumar Cc: Guenter Roeck , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "moderated list:ARM/Mediatek SoC..." , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 3, 2015 at 8:50 AM, Viresh Kumar wrote: > On 03-09-15, 08:20, Guenter Roeck wrote: >> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module, >> the following build error is seen for arm:allmodconfig and >> arm64:allmodconfig. >> >> drivers/built-in.o: In function `mtk_cpufreq_ready': >> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register' >> drivers/built-in.o: In function `mtk_cpufreq_exit': >> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister' >> >> The fix is similar to CPUFREQ_DT, but more restrictive since >> ARM_MT8173_CPUFREQ can not be built as module. >> >> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver") >> Signed-off-by: Guenter Roeck >> --- >> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate >> and relax the conditions, but I don't know if that is feasible. >> >> drivers/cpufreq/Kconfig.arm | 1 + >> 1 file changed, 1 insertion(+) > > Acked-by: Viresh Kumar Who's applying and sending this up to avoid extended period of build breakage? -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL Date: Fri, 4 Sep 2015 12:01:40 -0700 Message-ID: References: <1441293658-18199-1-git-send-email-linux@roeck-us.net> <20150903155029.GB5332@linux> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-yk0-f170.google.com ([209.85.160.170]:33103 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933073AbbIDTBl (ORCPT ); Fri, 4 Sep 2015 15:01:41 -0400 Received: by ykei199 with SMTP id i199so30059421yke.0 for ; Fri, 04 Sep 2015 12:01:40 -0700 (PDT) In-Reply-To: <20150903155029.GB5332@linux> Sender: linux-pm-owner@vger.kernel.org List-Id: linux-pm@vger.kernel.org To: Viresh Kumar Cc: Guenter Roeck , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , "moderated list:ARM/Mediatek SoC..." , Matthias Brugger , "linux-arm-kernel@lists.infradead.org" On Thu, Sep 3, 2015 at 8:50 AM, Viresh Kumar wrote: > On 03-09-15, 08:20, Guenter Roeck wrote: >> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module, >> the following build error is seen for arm:allmodconfig and >> arm64:allmodconfig. >> >> drivers/built-in.o: In function `mtk_cpufreq_ready': >> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register' >> drivers/built-in.o: In function `mtk_cpufreq_exit': >> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister' >> >> The fix is similar to CPUFREQ_DT, but more restrictive since >> ARM_MT8173_CPUFREQ can not be built as module. >> >> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver") >> Signed-off-by: Guenter Roeck >> --- >> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate >> and relax the conditions, but I don't know if that is feasible. >> >> drivers/cpufreq/Kconfig.arm | 1 + >> 1 file changed, 1 insertion(+) > > Acked-by: Viresh Kumar Who's applying and sending this up to avoid extended period of build breakage? -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Fri, 4 Sep 2015 12:01:40 -0700 Subject: [PATCH] cpufreq: Add ARM_MT8173_CPUFREQ dependencyon THERMAL In-Reply-To: <20150903155029.GB5332@linux> References: <1441293658-18199-1-git-send-email-linux@roeck-us.net> <20150903155029.GB5332@linux> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Sep 3, 2015 at 8:50 AM, Viresh Kumar wrote: > On 03-09-15, 08:20, Guenter Roeck wrote: >> If ARM_MT8173_CPUFREQ is configured, and THERMAL is configured as module, >> the following build error is seen for arm:allmodconfig and >> arm64:allmodconfig. >> >> drivers/built-in.o: In function `mtk_cpufreq_ready': >> :(.text+0x32a20c): undefined reference to `of_cpufreq_cooling_register' >> drivers/built-in.o: In function `mtk_cpufreq_exit': >> :(.text+0x32a420): undefined reference to `cpufreq_cooling_unregister' >> >> The fix is similar to CPUFREQ_DT, but more restrictive since >> ARM_MT8173_CPUFREQ can not be built as module. >> >> Fixes: 1453863fb02a ("cpufreq: mediatek: Add MT8173 cpufreq driver") >> Signed-off-by: Guenter Roeck >> --- >> It might also make sense to declare ARM_MT8173_CPUFREQ as tristate >> and relax the conditions, but I don't know if that is feasible. >> >> drivers/cpufreq/Kconfig.arm | 1 + >> 1 file changed, 1 insertion(+) > > Acked-by: Viresh Kumar Who's applying and sending this up to avoid extended period of build breakage? -Olof