All of lore.kernel.org
 help / color / mirror / Atom feed
* Add Apple M1 support to PASemi i2c driver
@ 2021-09-26 14:55 ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-26 14:55 UTC (permalink / raw)
  To: sven
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, arnd, marcan, mohamed.mediouni, stan,
	mark.kettenis, linux-arm-kernel, alyssa, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Sven,

Thanks a lot for your nice explanation of the history of the PASemi i2c 
driver.

We are using Nemo boards with 64-bit dual-core PWRficient PA6T-1682M 
CPUs (A-EON AmigaOne X1000). [1]

The RC2 of kernel 5.15 works without any problems on our Nemo boards. [2]

Could you please post all your patches merged in one patch? It's easier 
for me to apply one patch.

Thanks,
Christian

[1] https://en.wikipedia.org/wiki/AmigaOne_X1000
[2] https://forum.hyperion-entertainment.com/viewtopic.php?p=54056#p54056

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Add Apple M1 support to PASemi i2c driver
@ 2021-09-26 14:55 ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-26 14:55 UTC (permalink / raw)
  To: sven
  Cc: Darren Stevens, arnd, marcan, Linux Kernel Mailing List,
	linux-i2c, Paul Mackerras, alyssa, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, mark.kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, stan

Hi Sven,

Thanks a lot for your nice explanation of the history of the PASemi i2c 
driver.

We are using Nemo boards with 64-bit dual-core PWRficient PA6T-1682M 
CPUs (A-EON AmigaOne X1000). [1]

The RC2 of kernel 5.15 works without any problems on our Nemo boards. [2]

Could you please post all your patches merged in one patch? It's easier 
for me to apply one patch.

Thanks,
Christian

[1] https://en.wikipedia.org/wiki/AmigaOne_X1000
[2] https://forum.hyperion-entertainment.com/viewtopic.php?p=54056#p54056

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Add Apple M1 support to PASemi i2c driver
@ 2021-09-26 14:55 ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-26 14:55 UTC (permalink / raw)
  To: sven
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, arnd, marcan, mohamed.mediouni, stan,
	mark.kettenis, linux-arm-kernel, alyssa, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Sven,

Thanks a lot for your nice explanation of the history of the PASemi i2c 
driver.

We are using Nemo boards with 64-bit dual-core PWRficient PA6T-1682M 
CPUs (A-EON AmigaOne X1000). [1]

The RC2 of kernel 5.15 works without any problems on our Nemo boards. [2]

Could you please post all your patches merged in one patch? It's easier 
for me to apply one patch.

Thanks,
Christian

[1] https://en.wikipedia.org/wiki/AmigaOne_X1000
[2] https://forum.hyperion-entertainment.com/viewtopic.php?p=54056#p54056

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-09-26 14:55 ` Christian Zigotzky
  (?)
@ 2021-09-26 20:27   ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-26 20:27 UTC (permalink / raw)
  To: sven
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, arnd, marcan, mohamed.mediouni, stan,
	mark.kettenis, linux-arm-kernel, alyssa, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Sven,

I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own 
file). [1]

Error message:

patching file b/drivers/i2c/busses/i2c-pasemi-core.c (renamed from 
a/drivers/i2c/busses/i2c-pasemi.c)
Hunk #3 FAILED at 344.
1 out of 3 hunks FAILED -- saving rejects to file 
b/drivers/i2c/busses/i2c-pasemi-core.c.rej
patching file b/drivers/i2c/busses/i2c-pasemi-core.h
patching file b/drivers/i2c/busses/i2c-pasemi-pci.c

Please post one patch with all your modifications.

Thanks,
Christian

[1] 
https://lists.ozlabs.org/pipermail/linuxppc-dev/2021-September/234636.html


On 26 September 2021 at 04:55 pm, Christian Zigotzky wrote:
> Hi Sven,
>
> Thanks a lot for your nice explanation of the history of the PASemi 
> i2c driver.
>
> We are using Nemo boards with 64-bit dual-core PWRficient PA6T-1682M 
> CPUs (A-EON AmigaOne X1000). [1]
>
> The RC2 of kernel 5.15 works without any problems on our Nemo boards. [2]
>
> Could you please post all your patches merged in one patch? It's 
> easier for me to apply one patch.
>
> Thanks,
> Christian
>
> [1] https://en.wikipedia.org/wiki/AmigaOne_X1000
> [2] https://forum.hyperion-entertainment.com/viewtopic.php?p=54056#p54056


^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-26 20:27   ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-26 20:27 UTC (permalink / raw)
  To: sven
  Cc: Darren Stevens, arnd, marcan, Linux Kernel Mailing List,
	linux-i2c, Paul Mackerras, alyssa, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, mark.kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, stan

Hi Sven,

I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own 
file). [1]

Error message:

patching file b/drivers/i2c/busses/i2c-pasemi-core.c (renamed from 
a/drivers/i2c/busses/i2c-pasemi.c)
Hunk #3 FAILED at 344.
1 out of 3 hunks FAILED -- saving rejects to file 
b/drivers/i2c/busses/i2c-pasemi-core.c.rej
patching file b/drivers/i2c/busses/i2c-pasemi-core.h
patching file b/drivers/i2c/busses/i2c-pasemi-pci.c

Please post one patch with all your modifications.

Thanks,
Christian

[1] 
https://lists.ozlabs.org/pipermail/linuxppc-dev/2021-September/234636.html


On 26 September 2021 at 04:55 pm, Christian Zigotzky wrote:
> Hi Sven,
>
> Thanks a lot for your nice explanation of the history of the PASemi 
> i2c driver.
>
> We are using Nemo boards with 64-bit dual-core PWRficient PA6T-1682M 
> CPUs (A-EON AmigaOne X1000). [1]
>
> The RC2 of kernel 5.15 works without any problems on our Nemo boards. [2]
>
> Could you please post all your patches merged in one patch? It's 
> easier for me to apply one patch.
>
> Thanks,
> Christian
>
> [1] https://en.wikipedia.org/wiki/AmigaOne_X1000
> [2] https://forum.hyperion-entertainment.com/viewtopic.php?p=54056#p54056


^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-26 20:27   ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-26 20:27 UTC (permalink / raw)
  To: sven
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, arnd, marcan, mohamed.mediouni, stan,
	mark.kettenis, linux-arm-kernel, alyssa, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Sven,

I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own 
file). [1]

Error message:

patching file b/drivers/i2c/busses/i2c-pasemi-core.c (renamed from 
a/drivers/i2c/busses/i2c-pasemi.c)
Hunk #3 FAILED at 344.
1 out of 3 hunks FAILED -- saving rejects to file 
b/drivers/i2c/busses/i2c-pasemi-core.c.rej
patching file b/drivers/i2c/busses/i2c-pasemi-core.h
patching file b/drivers/i2c/busses/i2c-pasemi-pci.c

Please post one patch with all your modifications.

Thanks,
Christian

[1] 
https://lists.ozlabs.org/pipermail/linuxppc-dev/2021-September/234636.html


On 26 September 2021 at 04:55 pm, Christian Zigotzky wrote:
> Hi Sven,
>
> Thanks a lot for your nice explanation of the history of the PASemi 
> i2c driver.
>
> We are using Nemo boards with 64-bit dual-core PWRficient PA6T-1682M 
> CPUs (A-EON AmigaOne X1000). [1]
>
> The RC2 of kernel 5.15 works without any problems on our Nemo boards. [2]
>
> Could you please post all your patches merged in one patch? It's 
> easier for me to apply one patch.
>
> Thanks,
> Christian
>
> [1] https://en.wikipedia.org/wiki/AmigaOne_X1000
> [2] https://forum.hyperion-entertainment.com/viewtopic.php?p=54056#p54056


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-09-26 20:27   ` Christian Zigotzky
  (?)
@ 2021-09-27  5:39     ` Sven Peter
  -1 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-09-27  5:39 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Christian,

Thanks already for volunteering to test this!

On Sun, Sep 26, 2021, at 22:27, Christian Zigotzky wrote:
> Hi Sven,
>
> I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own 
> file). [1]

That's strange because it should apply cleanly. I'll double check
after to work today to see if I messed up while sending this.

>
> Error message:
>
> patching file b/drivers/i2c/busses/i2c-pasemi-core.c (renamed from 
> a/drivers/i2c/busses/i2c-pasemi.c)
> Hunk #3 FAILED at 344.
> 1 out of 3 hunks FAILED -- saving rejects to file 
> b/drivers/i2c/busses/i2c-pasemi-core.c.rej
> patching file b/drivers/i2c/busses/i2c-pasemi-core.h
> patching file b/drivers/i2c/busses/i2c-pasemi-pci.c
>
> Please post one patch with all your modifications.
>

Sure, will do that later as well!


Best,


Sven

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27  5:39     ` Sven Peter
  0 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-09-27  5:39 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

Hi Christian,

Thanks already for volunteering to test this!

On Sun, Sep 26, 2021, at 22:27, Christian Zigotzky wrote:
> Hi Sven,
>
> I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own 
> file). [1]

That's strange because it should apply cleanly. I'll double check
after to work today to see if I messed up while sending this.

>
> Error message:
>
> patching file b/drivers/i2c/busses/i2c-pasemi-core.c (renamed from 
> a/drivers/i2c/busses/i2c-pasemi.c)
> Hunk #3 FAILED at 344.
> 1 out of 3 hunks FAILED -- saving rejects to file 
> b/drivers/i2c/busses/i2c-pasemi-core.c.rej
> patching file b/drivers/i2c/busses/i2c-pasemi-core.h
> patching file b/drivers/i2c/busses/i2c-pasemi-pci.c
>
> Please post one patch with all your modifications.
>

Sure, will do that later as well!


Best,


Sven

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27  5:39     ` Sven Peter
  0 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-09-27  5:39 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Christian,

Thanks already for volunteering to test this!

On Sun, Sep 26, 2021, at 22:27, Christian Zigotzky wrote:
> Hi Sven,
>
> I can't apply your patch 5 (i2c: pasemi: Split pci driver to its own 
> file). [1]

That's strange because it should apply cleanly. I'll double check
after to work today to see if I messed up while sending this.

>
> Error message:
>
> patching file b/drivers/i2c/busses/i2c-pasemi-core.c (renamed from 
> a/drivers/i2c/busses/i2c-pasemi.c)
> Hunk #3 FAILED at 344.
> 1 out of 3 hunks FAILED -- saving rejects to file 
> b/drivers/i2c/busses/i2c-pasemi-core.c.rej
> patching file b/drivers/i2c/busses/i2c-pasemi-core.h
> patching file b/drivers/i2c/busses/i2c-pasemi-pci.c
>
> Please post one patch with all your modifications.
>

Sure, will do that later as well!


Best,


Sven

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-09-27  5:39     ` Sven Peter
  (?)
@ 2021-09-27  7:07       ` Wolfram Sang
  -1 siblings, 0 replies; 51+ messages in thread
From: Wolfram Sang @ 2021-09-27  7:07 UTC (permalink / raw)
  To: Sven Peter
  Cc: Christian Zigotzky, Michael Ellerman, Benjamin Herrenschmidt,
	Paul Mackerras, Olof Johansson, Arnd Bergmann, Hector Martin,
	mohamed.mediouni, Stan Skowronek, Mark Kettenis,
	linux-arm-kernel, Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]


> Sure, will do that later as well!

But please do it privately. For upstreaming, the patch series you sent
is way better than a single patch.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27  7:07       ` Wolfram Sang
  0 siblings, 0 replies; 51+ messages in thread
From: Wolfram Sang @ 2021-09-27  7:07 UTC (permalink / raw)
  To: Sven Peter
  Cc: Hector Martin, Arnd Bergmann, Christian Zigotzky,
	Linux Kernel Mailing List, linux-i2c, Darren Stevens,
	Paul Mackerras, Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

[-- Attachment #1: Type: text/plain, Size: 145 bytes --]


> Sure, will do that later as well!

But please do it privately. For upstreaming, the patch series you sent
is way better than a single patch.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27  7:07       ` Wolfram Sang
  0 siblings, 0 replies; 51+ messages in thread
From: Wolfram Sang @ 2021-09-27  7:07 UTC (permalink / raw)
  To: Sven Peter
  Cc: Christian Zigotzky, Michael Ellerman, Benjamin Herrenschmidt,
	Paul Mackerras, Olof Johansson, Arnd Bergmann, Hector Martin,
	mohamed.mediouni, Stan Skowronek, Mark Kettenis,
	linux-arm-kernel, Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson


[-- Attachment #1.1: Type: text/plain, Size: 145 bytes --]


> Sure, will do that later as well!

But please do it privately. For upstreaming, the patch series you sent
is way better than a single patch.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-09-27  7:07       ` Wolfram Sang
  (?)
@ 2021-09-27  7:58         ` Michael Ellerman
  -1 siblings, 0 replies; 51+ messages in thread
From: Michael Ellerman @ 2021-09-27  7:58 UTC (permalink / raw)
  To: Wolfram Sang, Sven Peter
  Cc: Christian Zigotzky, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Wolfram Sang <wsa@kernel.org> writes:
>> Sure, will do that later as well!
>
> But please do it privately. For upstreaming, the patch series you sent
> is way better than a single patch.

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

 $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
 $ git am mbox

It applies cleanly on v5.15-rc3.

cheers

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27  7:58         ` Michael Ellerman
  0 siblings, 0 replies; 51+ messages in thread
From: Michael Ellerman @ 2021-09-27  7:58 UTC (permalink / raw)
  To: Wolfram Sang, Sven Peter
  Cc: Christian Zigotzky, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Wolfram Sang <wsa@kernel.org> writes:
>> Sure, will do that later as well!
>
> But please do it privately. For upstreaming, the patch series you sent
> is way better than a single patch.

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

 $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
 $ git am mbox

It applies cleanly on v5.15-rc3.

cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27  7:58         ` Michael Ellerman
  0 siblings, 0 replies; 51+ messages in thread
From: Michael Ellerman @ 2021-09-27  7:58 UTC (permalink / raw)
  To: Wolfram Sang, Sven Peter
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Christian Zigotzky,
	Olof Johansson, mohamed.mediouni, Matthew Leaman, Mark Kettenis,
	linuxppc-dev, R.T.Dickinson, linux-arm-kernel, Stan Skowronek

Wolfram Sang <wsa@kernel.org> writes:
>> Sure, will do that later as well!
>
> But please do it privately. For upstreaming, the patch series you sent
> is way better than a single patch.

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

 $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
 $ git am mbox

It applies cleanly on v5.15-rc3.

cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-09-27  7:58         ` Michael Ellerman
  (?)
@ 2021-09-27 14:46           ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-27 14:46 UTC (permalink / raw)
  To: Michael Ellerman, Wolfram Sang, Sven Peter
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Olof Johansson,
	Arnd Bergmann, Hector Martin, mohamed.mediouni, Stan Skowronek,
	Mark Kettenis, linux-arm-kernel, Alyssa Rosenzweig, linuxppc-dev,
	linux-i2c, Linux Kernel Mailing List, R.T.Dickinson,
	Darren Stevens, Matthew Leaman, R.T.Dickinson

On 27 September 2021 at 09:58 am, Michael Ellerman wrote:
> Wolfram Sang <wsa@kernel.org> writes:
>>> Sure, will do that later as well!
>> But please do it privately. For upstreaming, the patch series you sent
>> is way better than a single patch.
> Christian, the whole series is downloadable as a single mbox here:
>
> https://patchwork.ozlabs.org/series/264134/mbox/
>
> Save that to a file and apply with `git am`.
>
> eg:
>
>   $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
>   $ git am mbox
>
> It applies cleanly on v5.15-rc3.
>
> cheers
I was able to patch it with the instructions above. Thanks! I will 
compile and test the RC3 as soon as possible.

-- Christian

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27 14:46           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-27 14:46 UTC (permalink / raw)
  To: Michael Ellerman, Wolfram Sang, Sven Peter
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

On 27 September 2021 at 09:58 am, Michael Ellerman wrote:
> Wolfram Sang <wsa@kernel.org> writes:
>>> Sure, will do that later as well!
>> But please do it privately. For upstreaming, the patch series you sent
>> is way better than a single patch.
> Christian, the whole series is downloadable as a single mbox here:
>
> https://patchwork.ozlabs.org/series/264134/mbox/
>
> Save that to a file and apply with `git am`.
>
> eg:
>
>   $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
>   $ git am mbox
>
> It applies cleanly on v5.15-rc3.
>
> cheers
I was able to patch it with the instructions above. Thanks! I will 
compile and test the RC3 as soon as possible.

-- Christian

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-09-27 14:46           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-09-27 14:46 UTC (permalink / raw)
  To: Michael Ellerman, Wolfram Sang, Sven Peter
  Cc: Benjamin Herrenschmidt, Paul Mackerras, Olof Johansson,
	Arnd Bergmann, Hector Martin, mohamed.mediouni, Stan Skowronek,
	Mark Kettenis, linux-arm-kernel, Alyssa Rosenzweig, linuxppc-dev,
	linux-i2c, Linux Kernel Mailing List, R.T.Dickinson,
	Darren Stevens, Matthew Leaman, R.T.Dickinson

On 27 September 2021 at 09:58 am, Michael Ellerman wrote:
> Wolfram Sang <wsa@kernel.org> writes:
>>> Sure, will do that later as well!
>> But please do it privately. For upstreaming, the patch series you sent
>> is way better than a single patch.
> Christian, the whole series is downloadable as a single mbox here:
>
> https://patchwork.ozlabs.org/series/264134/mbox/
>
> Save that to a file and apply with `git am`.
>
> eg:
>
>   $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
>   $ git am mbox
>
> It applies cleanly on v5.15-rc3.
>
> cheers
I was able to patch it with the instructions above. Thanks! I will 
compile and test the RC3 as soon as possible.

-- Christian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-09-27  5:39     ` Sven Peter
  (?)
@ 2021-10-01  4:47       ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-01  4:47 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

On 27 September 2021 at 07:39 am, Sven Peter wrote:
 > Hi Christian,
 >
 > Thanks already for volunteering to test this!
 >
Hello Sven,

Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your 
modified i2c driver on his Nemo board yesterday. [1]

@Darren
Could you also please check Sven's i2c modifications? He has also 
modified your source code a little bit. [2]

@Olof
Are these i2c modifications OK? Do these work on your P.A. Semi board?

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54098#p54098
[2] https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html
[3] Further information about the Nemo board: 
https://en.wikipedia.org/wiki/AmigaOne_X1000
[4] Kernel patches for the Nemo board: 
https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-January/167288.html

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-01  4:47       ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-01  4:47 UTC (permalink / raw)
  To: Sven Peter
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

On 27 September 2021 at 07:39 am, Sven Peter wrote:
 > Hi Christian,
 >
 > Thanks already for volunteering to test this!
 >
Hello Sven,

Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your 
modified i2c driver on his Nemo board yesterday. [1]

@Darren
Could you also please check Sven's i2c modifications? He has also 
modified your source code a little bit. [2]

@Olof
Are these i2c modifications OK? Do these work on your P.A. Semi board?

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54098#p54098
[2] https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html
[3] Further information about the Nemo board: 
https://en.wikipedia.org/wiki/AmigaOne_X1000
[4] Kernel patches for the Nemo board: 
https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-January/167288.html

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-01  4:47       ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-01  4:47 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

On 27 September 2021 at 07:39 am, Sven Peter wrote:
 > Hi Christian,
 >
 > Thanks already for volunteering to test this!
 >
Hello Sven,

Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your 
modified i2c driver on his Nemo board yesterday. [1]

@Darren
Could you also please check Sven's i2c modifications? He has also 
modified your source code a little bit. [2]

@Olof
Are these i2c modifications OK? Do these work on your P.A. Semi board?

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54098#p54098
[2] https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html
[3] Further information about the Nemo board: 
https://en.wikipedia.org/wiki/AmigaOne_X1000
[4] Kernel patches for the Nemo board: 
https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-January/167288.html

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-01  4:47       ` Christian Zigotzky
  (?)
@ 2021-10-01  5:49         ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-01  5:49 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Typo: Damian

Correct: Damien

On 01 October 2021 at 06:47 am, Christian Zigotzky wrote:
> On 27 September 2021 at 07:39 am, Sven Peter wrote:
> > Hi Christian,
> >
> > Thanks already for volunteering to test this!
> >
> Hello Sven,
>
> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with 
> your modified i2c driver on his Nemo board yesterday. [1]
>
> @Darren
> Could you also please check Sven's i2c modifications? He has also 
> modified your source code a little bit. [2]
>
> @Olof
> Are these i2c modifications OK? Do these work on your P.A. Semi board?
>
> Thanks,
> Christian
>
> [1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54098#p54098
> [2] 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html
> [3] Further information about the Nemo board: 
> https://en.wikipedia.org/wiki/AmigaOne_X1000
> [4] Kernel patches for the Nemo board: 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-January/167288.html


^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-01  5:49         ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-01  5:49 UTC (permalink / raw)
  To: Sven Peter
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

Typo: Damian

Correct: Damien

On 01 October 2021 at 06:47 am, Christian Zigotzky wrote:
> On 27 September 2021 at 07:39 am, Sven Peter wrote:
> > Hi Christian,
> >
> > Thanks already for volunteering to test this!
> >
> Hello Sven,
>
> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with 
> your modified i2c driver on his Nemo board yesterday. [1]
>
> @Darren
> Could you also please check Sven's i2c modifications? He has also 
> modified your source code a little bit. [2]
>
> @Olof
> Are these i2c modifications OK? Do these work on your P.A. Semi board?
>
> Thanks,
> Christian
>
> [1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54098#p54098
> [2] 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html
> [3] Further information about the Nemo board: 
> https://en.wikipedia.org/wiki/AmigaOne_X1000
> [4] Kernel patches for the Nemo board: 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-January/167288.html


^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-01  5:49         ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-01  5:49 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Typo: Damian

Correct: Damien

On 01 October 2021 at 06:47 am, Christian Zigotzky wrote:
> On 27 September 2021 at 07:39 am, Sven Peter wrote:
> > Hi Christian,
> >
> > Thanks already for volunteering to test this!
> >
> Hello Sven,
>
> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with 
> your modified i2c driver on his Nemo board yesterday. [1]
>
> @Darren
> Could you also please check Sven's i2c modifications? He has also 
> modified your source code a little bit. [2]
>
> @Olof
> Are these i2c modifications OK? Do these work on your P.A. Semi board?
>
> Thanks,
> Christian
>
> [1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54098#p54098
> [2] 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html
> [3] Further information about the Nemo board: 
> https://en.wikipedia.org/wiki/AmigaOne_X1000
> [4] Kernel patches for the Nemo board: 
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2018-January/167288.html


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-01  4:47       ` Christian Zigotzky
  (?)
@ 2021-10-03 14:36         ` Sven Peter
  -1 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-10-03 14:36 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi,


On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
> On 27 September 2021 at 07:39 am, Sven Peter wrote:
>  > Hi Christian,
>  >
>  > Thanks already for volunteering to test this!
>  >
> Hello Sven,
>
> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your 
> modified i2c driver on his Nemo board yesterday. [1]

Thanks a lot, that's great to hear!
If he wants to I can credit him with a Tested-by tag in the commit message,
see e.g. https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.


Best,


Sven

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-03 14:36         ` Sven Peter
  0 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-10-03 14:36 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

Hi,


On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
> On 27 September 2021 at 07:39 am, Sven Peter wrote:
>  > Hi Christian,
>  >
>  > Thanks already for volunteering to test this!
>  >
> Hello Sven,
>
> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your 
> modified i2c driver on his Nemo board yesterday. [1]

Thanks a lot, that's great to hear!
If he wants to I can credit him with a Tested-by tag in the commit message,
see e.g. https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.


Best,


Sven

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-03 14:36         ` Sven Peter
  0 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-10-03 14:36 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi,


On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
> On 27 September 2021 at 07:39 am, Sven Peter wrote:
>  > Hi Christian,
>  >
>  > Thanks already for volunteering to test this!
>  >
> Hello Sven,
>
> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your 
> modified i2c driver on his Nemo board yesterday. [1]

Thanks a lot, that's great to hear!
If he wants to I can credit him with a Tested-by tag in the commit message,
see e.g. https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.


Best,


Sven

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-03 14:36         ` Sven Peter
  (?)
@ 2021-10-03 15:45           ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-03 15:45 UTC (permalink / raw)
  To: Sven Peter
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

On 03 October 2021 at 04:36 pm, Sven Peter wrote:
 > Hi,
 >
 >
 > On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
 >> On 27 September 2021 at 07:39 am, Sven Peter wrote:
 >>  > Hi Christian,
 >>  >
 >>  > Thanks already for volunteering to test this!
 >>  >
 >> Hello Sven,
 >>
 >> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your
 >> modified i2c driver on his Nemo board yesterday. [1]
 >
 > Thanks a lot, that's great to hear!
 > If he wants to I can credit him with a Tested-by tag in the commit 
message,
 > see e.g. 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.
 >
 >
 > Best,
 >
 >
 > Sven

Hello Sven,

We are still testing your i2c modifications. [1]
Please wait a litte bit till we finished our tests.

@Darren
Could you also please check Sven's i2c modifications? He has also 
modified your source code a little bit. [2]

@Olof
Are these i2c modifications OK? Do these work on your P.A. Semi board?

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54138#p54138
[2] https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-03 15:45           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-03 15:45 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

On 03 October 2021 at 04:36 pm, Sven Peter wrote:
 > Hi,
 >
 >
 > On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
 >> On 27 September 2021 at 07:39 am, Sven Peter wrote:
 >>  > Hi Christian,
 >>  >
 >>  > Thanks already for volunteering to test this!
 >>  >
 >> Hello Sven,
 >>
 >> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your
 >> modified i2c driver on his Nemo board yesterday. [1]
 >
 > Thanks a lot, that's great to hear!
 > If he wants to I can credit him with a Tested-by tag in the commit 
message,
 > see e.g. 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.
 >
 >
 > Best,
 >
 >
 > Sven

Hello Sven,

We are still testing your i2c modifications. [1]
Please wait a litte bit till we finished our tests.

@Darren
Could you also please check Sven's i2c modifications? He has also 
modified your source code a little bit. [2]

@Olof
Are these i2c modifications OK? Do these work on your P.A. Semi board?

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54138#p54138
[2] https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-03 15:45           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-03 15:45 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

On 03 October 2021 at 04:36 pm, Sven Peter wrote:
 > Hi,
 >
 >
 > On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
 >> On 27 September 2021 at 07:39 am, Sven Peter wrote:
 >>  > Hi Christian,
 >>  >
 >>  > Thanks already for volunteering to test this!
 >>  >
 >> Hello Sven,
 >>
 >> Damian (Hypex) has successfully tested the RC3 of kernel 5.15 with your
 >> modified i2c driver on his Nemo board yesterday. [1]
 >
 > Thanks a lot, that's great to hear!
 > If he wants to I can credit him with a Tested-by tag in the commit 
message,
 > see e.g. 
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.
 >
 >
 > Best,
 >
 >
 > Sven

Hello Sven,

We are still testing your i2c modifications. [1]
Please wait a litte bit till we finished our tests.

@Darren
Could you also please check Sven's i2c modifications? He has also 
modified your source code a little bit. [2]

@Olof
Are these i2c modifications OK? Do these work on your P.A. Semi board?

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54138#p54138
[2] https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-January/153195.html

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-03 14:36         ` Sven Peter
                           ` (2 preceding siblings ...)
  (?)
@ 2021-10-04  9:22         ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-04  9:22 UTC (permalink / raw)
  To: Sven Peter
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

[-- Attachment #1: Type: text/plain, Size: 2505 bytes --]



> On 3. Oct 2021, at 16:36, Sven Peter <sven@svenpeter.dev> wrote:
> 
> Hi,
> 
> 
>> On Fri, Oct 1, 2021, at 06:47, Christian Zigotzky wrote:
>>> On 27 September 2021 at 07:39 am, Sven Peter wrote:
>>> Hi Christian,
>>> 
>>> Thanks already for volunteering to test this!
>>> 
>> Hello Sven,
>> 
>> Damien (Hypex) has successfully tested the RC3 of kernel 5.15 with your 
>> modified i2c driver on his Nemo board yesterday. [1]
> 
> Thanks a lot, that's great to hear!
> If he wants to I can credit him with a Tested-by tag in the commit message,
> see e.g. https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes.
> 
> 
> Best,
> 
> 
> Sven

Hi Sven,

Unfortunately Damien has found an issue. [1]

Output of i2cdetect -l with the default RC3 of kernel 5.15 without your modifications:

2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x800200	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x800240	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x800280	I2C adapter

Output of i2cdetect -l with your modifications:

i2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

Please check the outputs.

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54165#p54165

[-- Attachment #2: Type: text/html, Size: 8612 bytes --]

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-03 14:36         ` Sven Peter
  (?)
@ 2021-10-04  9:47           ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-04  9:47 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Sven,

Unfortunately Damien has found an issue. [1]

Output of i2cdetect -l with the default RC3 of kernel 5.15 without your modifications:

2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x800200	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x800240	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x800280	I2C adapter

Output of i2cdetect -l with your modifications:

i2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

Please check the outputs.

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54165#p54165

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-04  9:47           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-04  9:47 UTC (permalink / raw)
  To: Sven Peter
  Cc: Darren Stevens, Arnd Bergmann, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

Hi Sven,

Unfortunately Damien has found an issue. [1]

Output of i2cdetect -l with the default RC3 of kernel 5.15 without your modifications:

2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x800200	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x800240	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x800280	I2C adapter

Output of i2cdetect -l with your modifications:

i2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

Please check the outputs.

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54165#p54165

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-04  9:47           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-04  9:47 UTC (permalink / raw)
  To: Sven Peter
  Cc: Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Sven,

Unfortunately Damien has found an issue. [1]

Output of i2cdetect -l with the default RC3 of kernel 5.15 without your modifications:

2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x800200	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x800240	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x800280	I2C adapter

Output of i2cdetect -l with your modifications:

i2c-0	i2c       	Radeon i2c bit bus 0x90         	I2C adapter
i2c-1	i2c       	Radeon i2c bit bus 0x91         	I2C adapter
i2c-2	i2c       	Radeon i2c bit bus 0x92         	I2C adapter
i2c-3	i2c       	Radeon i2c bit bus 0x93         	I2C adapter
i2c-4	i2c       	Radeon i2c bit bus 0x94         	I2C adapter
i2c-5	i2c       	Radeon i2c bit bus 0x95         	I2C adapter
i2c-6	i2c       	Radeon i2c bit bus 0x96         	I2C adapter
i2c-7	i2c       	Radeon i2c bit bus 0x97         	I2C adapter
i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

Please check the outputs.

Thanks,
Christian

[1] https://forum.hyperion-entertainment.com/viewtopic.php?p=54165#p54165

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-04  9:47           ` Christian Zigotzky
  (?)
@ 2021-10-04  9:55             ` Wolfram Sang
  -1 siblings, 0 replies; 51+ messages in thread
From: Wolfram Sang @ 2021-10-04  9:55 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Sven Peter, Michael Ellerman, Benjamin Herrenschmidt,
	Paul Mackerras, Olof Johansson, Arnd Bergmann, Hector Martin,
	mohamed.mediouni, Stan Skowronek, Mark Kettenis,
	linux-arm-kernel, Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]


> i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
> i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
> i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

As Sven correctly switched from %lx to %p, this is intended behaviour.
Run 'i2cdetect' as root to see the values again.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-04  9:55             ` Wolfram Sang
  0 siblings, 0 replies; 51+ messages in thread
From: Wolfram Sang @ 2021-10-04  9:55 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Darren Stevens, Arnd Bergmann, Sven Peter, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Paul Mackerras,
	Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]


> i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
> i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
> i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

As Sven correctly switched from %lx to %p, this is intended behaviour.
Run 'i2cdetect' as root to see the values again.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-04  9:55             ` Wolfram Sang
  0 siblings, 0 replies; 51+ messages in thread
From: Wolfram Sang @ 2021-10-04  9:55 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Sven Peter, Michael Ellerman, Benjamin Herrenschmidt,
	Paul Mackerras, Olof Johansson, Arnd Bergmann, Hector Martin,
	mohamed.mediouni, Stan Skowronek, Mark Kettenis,
	linux-arm-kernel, Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson


[-- Attachment #1.1: Type: text/plain, Size: 349 bytes --]


> i2c-8	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
> i2c-9	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter
> i2c-10	i2c       	PA Semi SMBus adapter at 0x(____ptrval____)	I2C adapter

As Sven correctly switched from %lx to %p, this is intended behaviour.
Run 'i2cdetect' as root to see the values again.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-04  9:55             ` Wolfram Sang
  (?)
@ 2021-10-04 11:20               ` Arnd Bergmann
  -1 siblings, 0 replies; 51+ messages in thread
From: Arnd Bergmann @ 2021-10-04 11:20 UTC (permalink / raw)
  To: Wolfram Sang, Christian Zigotzky, Sven Peter, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, Olof Johansson,
	Arnd Bergmann, Hector Martin, Mohamed Mediouni, Stan Skowronek,
	Mark Kettenis, Linux ARM, Alyssa Rosenzweig, linuxppc-dev,
	Linux I2C, Linux Kernel Mailing List, R.T.Dickinson,
	Darren Stevens, Matthew Leaman, R.T.Dickinson

On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang <wsa@kernel.org> wrote:
>
>
> > i2c-8 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-9 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-10        i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>
> As Sven correctly switched from %lx to %p, this is intended behaviour.
> Run 'i2cdetect' as root to see the values again.

I think the address could just get removed here, as this is clearly not helpful.
port number, which is somewhat useful for identifying the device, now
it's either the pointless string, or the virtual address that the
device is mapped
to, which is not helpful either and potentially leaks information about kernel
internal structures.

       Arnd

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-04 11:20               ` Arnd Bergmann
  0 siblings, 0 replies; 51+ messages in thread
From: Arnd Bergmann @ 2021-10-04 11:20 UTC (permalink / raw)
  To: Wolfram Sang, Christian Zigotzky, Sven Peter, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, Olof Johansson,
	Arnd Bergmann, Hector Martin, Mohamed Mediouni, Stan Skowronek,
	Mark Kettenis, Linux ARM, Alyssa Rosenzweig, linuxppc-dev,
	Linux I2C, Linux Kernel Mailing List, R.T.Dickinson,
	Darren Stevens, Matthew Leaman, R.T.Dickinson

On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang <wsa@kernel.org> wrote:
>
>
> > i2c-8 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-9 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-10        i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>
> As Sven correctly switched from %lx to %p, this is intended behaviour.
> Run 'i2cdetect' as root to see the values again.

I think the address could just get removed here, as this is clearly not helpful.
port number, which is somewhat useful for identifying the device, now
it's either the pointless string, or the virtual address that the
device is mapped
to, which is not helpful either and potentially leaks information about kernel
internal structures.

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-04 11:20               ` Arnd Bergmann
  0 siblings, 0 replies; 51+ messages in thread
From: Arnd Bergmann @ 2021-10-04 11:20 UTC (permalink / raw)
  To: Wolfram Sang, Christian Zigotzky, Sven Peter, Michael Ellerman,
	Benjamin Herrenschmidt, Paul Mackerras, Olof Johansson,
	Arnd Bergmann, Hector Martin, Mohamed Mediouni, Stan Skowronek,
	Mark Kettenis, Linux ARM, Alyssa Rosenzweig, linuxppc-dev,
	Linux I2C, Linux Kernel Mailing List, R.T.Dickinson,
	Darren Stevens, Matthew Leaman, R.T.Dickinson

On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang <wsa@kernel.org> wrote:
>
>
> > i2c-8 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-9 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
> > i2c-10        i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>
> As Sven correctly switched from %lx to %p, this is intended behaviour.
> Run 'i2cdetect' as root to see the values again.

I think the address could just get removed here, as this is clearly not helpful.
port number, which is somewhat useful for identifying the device, now
it's either the pointless string, or the virtual address that the
device is mapped
to, which is not helpful either and potentially leaks information about kernel
internal structures.

       Arnd

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-04 11:20               ` Arnd Bergmann
@ 2021-10-04 11:22                 ` Sven Peter
  -1 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-10-04 11:22 UTC (permalink / raw)
  To: Arnd Bergmann, Wolfram Sang, Christian Zigotzky,
	Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Hector Martin, Mohamed Mediouni, Stan Skowronek,
	Mark Kettenis, Linux ARM, Alyssa Rosenzweig, linuxppc-dev,
	Linux I2C, Linux Kernel Mailing List, R.T.Dickinson,
	Darren Stevens, Matthew Leaman, R.T.Dickinson



On Mon, Oct 4, 2021, at 13:20, Arnd Bergmann wrote:
> On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang <wsa@kernel.org> wrote:
>>
>>
>> > i2c-8 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>> > i2c-9 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>> > i2c-10        i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>>
>> As Sven correctly switched from %lx to %p, this is intended behaviour.
>> Run 'i2cdetect' as root to see the values again.
>
> I think the address could just get removed here, as this is clearly not helpful.
> port number, which is somewhat useful for identifying the device, now
> it's either the pointless string, or the virtual address that the
> device is mapped
> to, which is not helpful either and potentially leaks information about kernel
> internal structures.

Yeah, now that I'm looking at it again it doesn't make much sense to
include it there. Maybe just dev_name(smbus->dev) instead of the address?


Sven

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-04 11:22                 ` Sven Peter
  0 siblings, 0 replies; 51+ messages in thread
From: Sven Peter @ 2021-10-04 11:22 UTC (permalink / raw)
  To: Arnd Bergmann, Wolfram Sang, Christian Zigotzky,
	Michael Ellerman, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Hector Martin, Mohamed Mediouni, Stan Skowronek,
	Mark Kettenis, Linux ARM, Alyssa Rosenzweig, linuxppc-dev,
	Linux I2C, Linux Kernel Mailing List, R.T.Dickinson,
	Darren Stevens, Matthew Leaman, R.T.Dickinson



On Mon, Oct 4, 2021, at 13:20, Arnd Bergmann wrote:
> On Mon, Oct 4, 2021 at 11:55 AM Wolfram Sang <wsa@kernel.org> wrote:
>>
>>
>> > i2c-8 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>> > i2c-9 i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>> > i2c-10        i2c             PA Semi SMBus adapter at 0x(____ptrval____)     I2C adapter
>>
>> As Sven correctly switched from %lx to %p, this is intended behaviour.
>> Run 'i2cdetect' as root to see the values again.
>
> I think the address could just get removed here, as this is clearly not helpful.
> port number, which is somewhat useful for identifying the device, now
> it's either the pointless string, or the virtual address that the
> device is mapped
> to, which is not helpful either and potentially leaks information about kernel
> internal structures.

Yeah, now that I'm looking at it again it doesn't make much sense to
include it there. Maybe just dev_name(smbus->dev) instead of the address?


Sven

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-09-27  7:58         ` Michael Ellerman
  (?)
@ 2021-10-08 20:19           ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-08 20:19 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Darren Stevens, Arnd Bergmann, Sven Peter, Hector Martin,
	Linux Kernel Mailing List, linux-i2c, Wolfram Sang,
	Paul Mackerras, Alyssa Rosenzweig, R.T.Dickinson, Olof Johansson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, linux-arm-kernel, Stan Skowronek

Hi Michael,

Do you have a mbox link for the v2 changes?

I would like to test them on my AmigaOne X1000.

Thanks,
Christian

On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

$ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
$ git am mbox

It applies cleanly on v5.15-rc3.

cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-08 20:19           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-08 20:19 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Wolfram Sang, Sven Peter, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Michael,

Do you have a mbox link for the v2 changes?

I would like to test them on my AmigaOne X1000.

Thanks,
Christian

On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

$ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
$ git am mbox

It applies cleanly on v5.15-rc3.

cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-08 20:19           ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-08 20:19 UTC (permalink / raw)
  To: Michael Ellerman
  Cc: Wolfram Sang, Sven Peter, Benjamin Herrenschmidt, Paul Mackerras,
	Olof Johansson, Arnd Bergmann, Hector Martin, mohamed.mediouni,
	Stan Skowronek, Mark Kettenis, linux-arm-kernel,
	Alyssa Rosenzweig, linuxppc-dev, linux-i2c,
	Linux Kernel Mailing List, R.T.Dickinson, Darren Stevens,
	Matthew Leaman, R.T.Dickinson

Hi Michael,

Do you have a mbox link for the v2 changes?

I would like to test them on my AmigaOne X1000.

Thanks,
Christian

On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

$ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
$ git am mbox

It applies cleanly on v5.15-rc3.

cheers

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-08 20:19           ` Christian Zigotzky
  (?)
@ 2021-10-08 20:47             ` Olof Johansson
  -1 siblings, 0 replies; 51+ messages in thread
From: Olof Johansson @ 2021-10-08 20:47 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Michael Ellerman, Darren Stevens, Arnd Bergmann, Sven Peter,
	Hector Martin, Linux Kernel Mailing List, linux-i2c,
	Wolfram Sang, Paul Mackerras, Alyssa Rosenzweig, R.T.Dickinson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, Linux ARM Mailing List, Stan Skowronek

Christian,

Self-service available on lore:
https://lore.kernel.org/all/20211008163532.75569-1-sven@svenpeter.dev/

There are links on there to download a whole thread as an mbox if needed.


-Olof

On Fri, Oct 8, 2021 at 1:20 PM Christian Zigotzky
<chzigotzky@xenosoft.de> wrote:
>
> Hi Michael,
>
> Do you have a mbox link for the v2 changes?
>
> I would like to test them on my AmigaOne X1000.
>
> Thanks,
> Christian
>
> On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Christian, the whole series is downloadable as a single mbox here:
>
> https://patchwork.ozlabs.org/series/264134/mbox/
>
> Save that to a file and apply with `git am`.
>
> eg:
>
> $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
> $ git am mbox
>
> It applies cleanly on v5.15-rc3.
>
> cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-08 20:47             ` Olof Johansson
  0 siblings, 0 replies; 51+ messages in thread
From: Olof Johansson @ 2021-10-08 20:47 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Linux ARM Mailing List, Darren Stevens, Arnd Bergmann,
	Sven Peter, Hector Martin, Linux Kernel Mailing List,
	Wolfram Sang, Paul Mackerras, linux-i2c, R.T.Dickinson,
	mohamed.mediouni, Matthew Leaman, Stan Skowronek, linuxppc-dev,
	R.T.Dickinson, Alyssa Rosenzweig, Mark Kettenis

Christian,

Self-service available on lore:
https://lore.kernel.org/all/20211008163532.75569-1-sven@svenpeter.dev/

There are links on there to download a whole thread as an mbox if needed.


-Olof

On Fri, Oct 8, 2021 at 1:20 PM Christian Zigotzky
<chzigotzky@xenosoft.de> wrote:
>
> Hi Michael,
>
> Do you have a mbox link for the v2 changes?
>
> I would like to test them on my AmigaOne X1000.
>
> Thanks,
> Christian
>
> On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Christian, the whole series is downloadable as a single mbox here:
>
> https://patchwork.ozlabs.org/series/264134/mbox/
>
> Save that to a file and apply with `git am`.
>
> eg:
>
> $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
> $ git am mbox
>
> It applies cleanly on v5.15-rc3.
>
> cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-08 20:47             ` Olof Johansson
  0 siblings, 0 replies; 51+ messages in thread
From: Olof Johansson @ 2021-10-08 20:47 UTC (permalink / raw)
  To: Christian Zigotzky
  Cc: Michael Ellerman, Darren Stevens, Arnd Bergmann, Sven Peter,
	Hector Martin, Linux Kernel Mailing List, linux-i2c,
	Wolfram Sang, Paul Mackerras, Alyssa Rosenzweig, R.T.Dickinson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, Linux ARM Mailing List, Stan Skowronek

Christian,

Self-service available on lore:
https://lore.kernel.org/all/20211008163532.75569-1-sven@svenpeter.dev/

There are links on there to download a whole thread as an mbox if needed.


-Olof

On Fri, Oct 8, 2021 at 1:20 PM Christian Zigotzky
<chzigotzky@xenosoft.de> wrote:
>
> Hi Michael,
>
> Do you have a mbox link for the v2 changes?
>
> I would like to test them on my AmigaOne X1000.
>
> Thanks,
> Christian
>
> On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:
>
> Christian, the whole series is downloadable as a single mbox here:
>
> https://patchwork.ozlabs.org/series/264134/mbox/
>
> Save that to a file and apply with `git am`.
>
> eg:
>
> $ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
> $ git am mbox
>
> It applies cleanly on v5.15-rc3.
>
> cheers

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
  2021-10-08 20:47             ` Olof Johansson
  (?)
@ 2021-10-09  6:10               ` Christian Zigotzky
  -1 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-09  6:10 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Michael Ellerman, Darren Stevens, Arnd Bergmann, Sven Peter,
	Hector Martin, Linux Kernel Mailing List, linux-i2c,
	Wolfram Sang, Paul Mackerras, Alyssa Rosenzweig, R.T.Dickinson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, Linux ARM Mailing List, Stan Skowronek

Olof,

Thank you for the hint.

I think I have found them.

Link: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=266104

Mbox: https://patchwork.ozlabs.org/series/266104/mbox/

$ wget -O mbox https://patchwork.ozlabs.org/series/266104/mbox/
$ git am mbox

Thanks,
Christian

On 8. Oct 2021, at 22:47, Olof Johansson <olof@lixom.net> wrote:

Christian,

Self-service available on lore:
https://lore.kernel.org/all/20211008163532.75569-1-sven@svenpeter.dev/

There are links on there to download a whole thread as an mbox if needed.


-Olof

On Fri, Oct 8, 2021 at 1:20 PM Christian Zigotzky
<chzigotzky@xenosoft.de> wrote:

Hi Michael,

Do you have a mbox link for the v2 changes?

I would like to test them on my AmigaOne X1000.

Thanks,
Christian

On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

$ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
$ git am mbox

It applies cleanly on v5.15-rc3.

cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-09  6:10               ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-09  6:10 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Linux ARM Mailing List, Darren Stevens, Arnd Bergmann,
	Sven Peter, Hector Martin, Linux Kernel Mailing List,
	Wolfram Sang, Paul Mackerras, linux-i2c, R.T.Dickinson,
	mohamed.mediouni, Matthew Leaman, Stan Skowronek, linuxppc-dev,
	R.T.Dickinson, Alyssa Rosenzweig, Mark Kettenis

Olof,

Thank you for the hint.

I think I have found them.

Link: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=266104

Mbox: https://patchwork.ozlabs.org/series/266104/mbox/

$ wget -O mbox https://patchwork.ozlabs.org/series/266104/mbox/
$ git am mbox

Thanks,
Christian

On 8. Oct 2021, at 22:47, Olof Johansson <olof@lixom.net> wrote:

Christian,

Self-service available on lore:
https://lore.kernel.org/all/20211008163532.75569-1-sven@svenpeter.dev/

There are links on there to download a whole thread as an mbox if needed.


-Olof

On Fri, Oct 8, 2021 at 1:20 PM Christian Zigotzky
<chzigotzky@xenosoft.de> wrote:

Hi Michael,

Do you have a mbox link for the v2 changes?

I would like to test them on my AmigaOne X1000.

Thanks,
Christian

On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

$ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
$ git am mbox

It applies cleanly on v5.15-rc3.

cheers

^ permalink raw reply	[flat|nested] 51+ messages in thread
* Re: Add Apple M1 support to PASemi i2c driver
@ 2021-10-09  6:10               ` Christian Zigotzky
  0 siblings, 0 replies; 51+ messages in thread
From: Christian Zigotzky @ 2021-10-09  6:10 UTC (permalink / raw)
  To: Olof Johansson
  Cc: Michael Ellerman, Darren Stevens, Arnd Bergmann, Sven Peter,
	Hector Martin, Linux Kernel Mailing List, linux-i2c,
	Wolfram Sang, Paul Mackerras, Alyssa Rosenzweig, R.T.Dickinson,
	mohamed.mediouni, Matthew Leaman, Mark Kettenis, linuxppc-dev,
	R.T.Dickinson, Linux ARM Mailing List, Stan Skowronek

Olof,

Thank you for the hint.

I think I have found them.

Link: https://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=266104

Mbox: https://patchwork.ozlabs.org/series/266104/mbox/

$ wget -O mbox https://patchwork.ozlabs.org/series/266104/mbox/
$ git am mbox

Thanks,
Christian

On 8. Oct 2021, at 22:47, Olof Johansson <olof@lixom.net> wrote:

Christian,

Self-service available on lore:
https://lore.kernel.org/all/20211008163532.75569-1-sven@svenpeter.dev/

There are links on there to download a whole thread as an mbox if needed.


-Olof

On Fri, Oct 8, 2021 at 1:20 PM Christian Zigotzky
<chzigotzky@xenosoft.de> wrote:

Hi Michael,

Do you have a mbox link for the v2 changes?

I would like to test them on my AmigaOne X1000.

Thanks,
Christian

On 27. Sep 2021, at 09:58, Michael Ellerman <mpe@ellerman.id.au> wrote:

Christian, the whole series is downloadable as a single mbox here:

https://patchwork.ozlabs.org/series/264134/mbox/

Save that to a file and apply with `git am`.

eg:

$ wget -O mbox https://patchwork.ozlabs.org/series/264134/mbox/
$ git am mbox

It applies cleanly on v5.15-rc3.

cheers

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 51+ messages in thread
end of thread, other threads:[~2021-10-09  6:13 UTC | newest]

Thread overview: 51+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-26 14:55 Add Apple M1 support to PASemi i2c driver Christian Zigotzky
2021-09-26 14:55 ` Christian Zigotzky
2021-09-26 14:55 ` Christian Zigotzky
2021-09-26 20:27 ` Christian Zigotzky
2021-09-26 20:27   ` Christian Zigotzky
2021-09-26 20:27   ` Christian Zigotzky
2021-09-27  5:39   ` Sven Peter
2021-09-27  5:39     ` Sven Peter
2021-09-27  5:39     ` Sven Peter
2021-09-27  7:07     ` Wolfram Sang
2021-09-27  7:07       ` Wolfram Sang
2021-09-27  7:07       ` Wolfram Sang
2021-09-27  7:58       ` Michael Ellerman
2021-09-27  7:58         ` Michael Ellerman
2021-09-27  7:58         ` Michael Ellerman
2021-09-27 14:46         ` Christian Zigotzky
2021-09-27 14:46           ` Christian Zigotzky
2021-09-27 14:46           ` Christian Zigotzky
2021-10-08 20:19         ` Christian Zigotzky
2021-10-08 20:19           ` Christian Zigotzky
2021-10-08 20:19           ` Christian Zigotzky
2021-10-08 20:47           ` Olof Johansson
2021-10-08 20:47             ` Olof Johansson
2021-10-08 20:47             ` Olof Johansson
2021-10-09  6:10             ` Christian Zigotzky
2021-10-09  6:10               ` Christian Zigotzky
2021-10-09  6:10               ` Christian Zigotzky
2021-10-01  4:47     ` Christian Zigotzky
2021-10-01  4:47       ` Christian Zigotzky
2021-10-01  4:47       ` Christian Zigotzky
2021-10-01  5:49       ` Christian Zigotzky
2021-10-01  5:49         ` Christian Zigotzky
2021-10-01  5:49         ` Christian Zigotzky
2021-10-03 14:36       ` Sven Peter
2021-10-03 14:36         ` Sven Peter
2021-10-03 14:36         ` Sven Peter
2021-10-03 15:45         ` Christian Zigotzky
2021-10-03 15:45           ` Christian Zigotzky
2021-10-03 15:45           ` Christian Zigotzky
2021-10-04  9:22         ` Christian Zigotzky
2021-10-04  9:47         ` Christian Zigotzky
2021-10-04  9:47           ` Christian Zigotzky
2021-10-04  9:47           ` Christian Zigotzky
2021-10-04  9:55           ` Wolfram Sang
2021-10-04  9:55             ` Wolfram Sang
2021-10-04  9:55             ` Wolfram Sang
2021-10-04 11:20             ` Arnd Bergmann
2021-10-04 11:20               ` Arnd Bergmann
2021-10-04 11:20               ` Arnd Bergmann
2021-10-04 11:22               ` Sven Peter
2021-10-04 11:22                 ` Sven Peter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.