From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752304AbaA2Uu4 (ORCPT ); Wed, 29 Jan 2014 15:50:56 -0500 Received: from mail-qc0-f178.google.com ([209.85.216.178]:46302 "EHLO mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbaA2Uux (ORCPT ); Wed, 29 Jan 2014 15:50:53 -0500 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:1b02:b13b:1c47:4c90:eb03] In-Reply-To: <1391016574-25237-4-git-send-email-k.debski@samsung.com> References: <1391016574-25237-1-git-send-email-k.debski@samsung.com> <1391016574-25237-4-git-send-email-k.debski@samsung.com> Date: Wed, 29 Jan 2014 12:50:53 -0800 Message-ID: Subject: Re: [PATCH v6 3/8] dts: Add usb2phy to Exynos 4 From: Olof Johansson To: Kamil Debski Cc: "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyungmin Park , Kishon Vijay Abraham I , Tomasz Figa , Sylwester Nawrocki , Marek Szyprowski , Vivek Gautam , mat.krawczuk@gmail.com, yulgon.kim@samsung.com, p.paneri@samsung.com, av.tikhomirov@samsung.com, Jingoo Han , Kumar Gala , Matt Porter , tjakobi@math.uni-bielefeld.de, Alan Stern Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski wrote: > Add support to PHY of USB2 of the Exynos 4 SoC. > > Signed-off-by: Kamil Debski > --- > .../devicetree/bindings/arm/samsung/pmu.txt | 2 ++ > arch/arm/boot/dts/exynos4.dtsi | 31 ++++++++++++++++++++ > arch/arm/boot/dts/exynos4210.dtsi | 17 +++++++++++ > arch/arm/boot/dts/exynos4x12.dtsi | 17 +++++++++++ > 4 files changed, 67 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > index 307e727..a76f91d 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > @@ -3,6 +3,8 @@ SAMSUNG Exynos SoC series PMU Registers > Properties: > - name : should be 'syscon'; > - compatible : should contain two values. First value must be one from following list: > + - "samsung,exynos4210-pmu" - for Exynos4210 SoC, > + - "samsung,exynos4x12-pmu" - for Exynos4212 SoC, > - "samsung,exynos5250-pmu" - for Exynos5250 SoC, > - "samsung,exynos5420-pmu" - for Exynos5420 SoC. > second value must be always "syscon". This and other PMU related bindings/dts changes should probably go in separate patch(es) instead of being snuck in with USB changes. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH v6 3/8] dts: Add usb2phy to Exynos 4 Date: Wed, 29 Jan 2014 12:50:53 -0800 Message-ID: References: <1391016574-25237-1-git-send-email-k.debski@samsung.com> <1391016574-25237-4-git-send-email-k.debski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1391016574-25237-4-git-send-email-k.debski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Kamil Debski Cc: "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , Kyungmin Park , Kishon Vijay Abraham I , Tomasz Figa , Sylwester Nawrocki , Marek Szyprowski , Vivek Gautam , mat.krawczuk@gmail.com, yulgon.kim@samsung.com, p.paneri@samsung.com, av.tikhomirov@samsung.com, Jingoo Han , Kumar Gala , Matt Porter , tjakobi@math.uni-bielefeld.de, Alan Stern List-Id: devicetree@vger.kernel.org On Wed, Jan 29, 2014 at 9:29 AM, Kamil Debski wrote: > Add support to PHY of USB2 of the Exynos 4 SoC. > > Signed-off-by: Kamil Debski > --- > .../devicetree/bindings/arm/samsung/pmu.txt | 2 ++ > arch/arm/boot/dts/exynos4.dtsi | 31 ++++++++++++++++++++ > arch/arm/boot/dts/exynos4210.dtsi | 17 +++++++++++ > arch/arm/boot/dts/exynos4x12.dtsi | 17 +++++++++++ > 4 files changed, 67 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > index 307e727..a76f91d 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.txt > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > @@ -3,6 +3,8 @@ SAMSUNG Exynos SoC series PMU Registers > Properties: > - name : should be 'syscon'; > - compatible : should contain two values. First value must be one from following list: > + - "samsung,exynos4210-pmu" - for Exynos4210 SoC, > + - "samsung,exynos4x12-pmu" - for Exynos4212 SoC, > - "samsung,exynos5250-pmu" - for Exynos5250 SoC, > - "samsung,exynos5420-pmu" - for Exynos5420 SoC. > second value must be always "syscon". This and other PMU related bindings/dts changes should probably go in separate patch(es) instead of being snuck in with USB changes. -Olof