From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E488C433E0 for ; Wed, 15 Jul 2020 03:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBA092074B for ; Wed, 15 Jul 2020 03:49:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="IAhNc2PE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728683AbgGODtg (ORCPT ); Tue, 14 Jul 2020 23:49:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726710AbgGODtf (ORCPT ); Tue, 14 Jul 2020 23:49:35 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCB42C061755 for ; Tue, 14 Jul 2020 20:49:35 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id i4so758314iov.11 for ; Tue, 14 Jul 2020 20:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f1CRBSIEJDuFB8dog5jdvBQmdtw3EAxf2Oj6BzpDQQw=; b=IAhNc2PEOhArE+GcYrmBe/3NxGeuZx3JCuvw8ORdWaNpd8YNvHPLjFq+HAH3MRMP5S oOxyBK2u/zYrAOOjd2SxmZlRdg52TimjplCGTE4uqPKuozcM1fiFENkeKCPQ9TnAqGmC qDzl2Wwr+U15OcOwRP1fOnEZpCsaQlWf0zLOAuwadhfEdNRJAzc51eKROOxgfx8Ojn9p T23rKIIJKsm16XdyBmajMpVc4HFjxz2XrsVtLUH+3NCWbaIRrG6ISCGQMbYo3oB6eg8Y VXr6eeEnaLcVnulcplV88lhEe/D2ixCJV4Udc5gLfEIJqGRTME27xPjf75uimLjop3CO simA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f1CRBSIEJDuFB8dog5jdvBQmdtw3EAxf2Oj6BzpDQQw=; b=qrb3+k5B6bnpmEbpuGZSawbDDi0S4M5UZtc7kN0mmRd/3gLa7/+1NIBhFqoPGrofw1 218mrApT7qU5OL+LKuGTY8d5k778mpmV2qhxuuMsLYkAFfXMcHcq89XcEdfUDH+KgN80 lJ05tV8CPKLvbyMQvaxEtwSmZp8kmL1wC8SG6gNEa0+UyO/usxRoDTW+MsTpZgKgeBms 3f6b+eJay/K/894YbIkjxetS1hBmIJZ+Rv1wqIOtSasfWNx37TzAfo7kAI4G6bSgK+6i IIRkWWw7WEQh3AM/DbzrMbwgBGZ7hXgSsKVYpvA5N3aXndYaKBYR2fHjzNxvyLEMviJ1 JUiw== X-Gm-Message-State: AOAM531yHMrmrGTrDuPDYxO8yFaE9KleIpWl0vIXOlWO3Tzon/+2XpZd +LEd3iDGbquRnp3hwMS2kQKZ0ujJoWU/B6Ja6IlxBg== X-Google-Smtp-Source: ABdhPJxIX1Rz1uy6qYWtVhSNi58vBkltN0nc+Y74TsUfZKS2AQDMN6wsabdJmmRCmC3OuMNUYpqM8OhcnmPuarpFxhU= X-Received: by 2002:a6b:8e56:: with SMTP id q83mr8239025iod.61.1594784975129; Tue, 14 Jul 2020 20:49:35 -0700 (PDT) MIME-Version: 1.0 References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715030706.prxya7fyylscoy25@vireshk-i7> In-Reply-To: <20200715030706.prxya7fyylscoy25@vireshk-i7> From: Olof Johansson Date: Tue, 14 Jul 2020 20:49:24 -0700 Message-ID: Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header To: Viresh Kumar Cc: Lee Jones , "Rafael J. Wysocki" , Linux ARM Mailing List , Linux Kernel Mailing List , linux-pm@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 8:07 PM Viresh Kumar wrot= e: > > On 14-07-20, 15:50, Lee Jones wrote: > > If function callers and providers do not share the same prototypes the > > compiler complains of missing prototypes. Fix this by moving the > > already existing prototypes out to a mutually convenient location. > > > > Fixes the following W=3D1 kernel build warning(s): > > > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype= for =E2=80=98check_astate=E2=80=99 [-Wmissing-prototypes] > > 109 | int check_astate(void) > > | ^~~~~~~~~~~~ > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype= for =E2=80=98restore_astate=E2=80=99 [-Wmissing-prototypes] > > 114 | void restore_astate(int cpu) > > | ^~~~~~~~~~~~~~ > > > > Cc: Olof Johansson > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Lee Jones > > --- > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ > > Is there no sane way we can include this file directly to the cpufreq > file ? Yep. arch/powerpc seems to be in the search path for modules on powerpc, so= : diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpuf= req.c index c66f566a854cb..815645170c4de 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -22,6 +22,8 @@ #include #include +#include + #define SDCASR_REG 0x0100 #define SDCASR_REG_STRIDE 0x1000 #define SDCPWR_CFGA0_REG 0x0100 -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF759C433E1 for ; Wed, 15 Jul 2020 03:51:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 457622065D for ; Wed, 15 Jul 2020 03:51:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="IAhNc2PE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 457622065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lixom.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4B63N12Q77zDqNV for ; Wed, 15 Jul 2020 13:51:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lixom.net (client-ip=2607:f8b0:4864:20::d44; helo=mail-io1-xd44.google.com; envelope-from=olof@lixom.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lixom.net Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=IAhNc2PE; dkim-atps=neutral Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B63Kv1ZWdzDqJR for ; Wed, 15 Jul 2020 13:49:36 +1000 (AEST) Received: by mail-io1-xd44.google.com with SMTP id a12so744407ion.13 for ; Tue, 14 Jul 2020 20:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f1CRBSIEJDuFB8dog5jdvBQmdtw3EAxf2Oj6BzpDQQw=; b=IAhNc2PEOhArE+GcYrmBe/3NxGeuZx3JCuvw8ORdWaNpd8YNvHPLjFq+HAH3MRMP5S oOxyBK2u/zYrAOOjd2SxmZlRdg52TimjplCGTE4uqPKuozcM1fiFENkeKCPQ9TnAqGmC qDzl2Wwr+U15OcOwRP1fOnEZpCsaQlWf0zLOAuwadhfEdNRJAzc51eKROOxgfx8Ojn9p T23rKIIJKsm16XdyBmajMpVc4HFjxz2XrsVtLUH+3NCWbaIRrG6ISCGQMbYo3oB6eg8Y VXr6eeEnaLcVnulcplV88lhEe/D2ixCJV4Udc5gLfEIJqGRTME27xPjf75uimLjop3CO simA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f1CRBSIEJDuFB8dog5jdvBQmdtw3EAxf2Oj6BzpDQQw=; b=WN72IVqef5v8g6IESNAAI/VlEmvSNYHRhFw5rG5+rKGPIJU5sHtUofJYUJhlnsIPRq rzc5Xwz59yWVijnKiAw3m5/s1Sp1qKbQSmeqHcs7JeFS/63i+V/Gb0lK4FcdwIadw2B4 F9HNRmJpl6jXRoh9A3LgaXJ7psLGZj3jJ4bE1QZPXIcr+hhDpoAa0kNAWJV0fZmYJVy0 hamgYNWRiisbH24u15t9XLK92NRdeXxWL31CZAQKLPhX9ulgzSLl8/klVkdEqwUyA2Xs jiPPkQxY27aGLjOUVV02mRoD+8plsna5748BFXejRgZht8t802/ir+Gjgz6l0D0ehByy ODeA== X-Gm-Message-State: AOAM532KPCWdQ3BtLf4RKNhnGCxcU6qXfhwUdbCyam1it1SCyLUWjvLv NpoxhFIWO15aay+9vEeLKWRYzO/4/0iMTuOjScaXwg== X-Google-Smtp-Source: ABdhPJxIX1Rz1uy6qYWtVhSNi58vBkltN0nc+Y74TsUfZKS2AQDMN6wsabdJmmRCmC3OuMNUYpqM8OhcnmPuarpFxhU= X-Received: by 2002:a6b:8e56:: with SMTP id q83mr8239025iod.61.1594784975129; Tue, 14 Jul 2020 20:49:35 -0700 (PDT) MIME-Version: 1.0 References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715030706.prxya7fyylscoy25@vireshk-i7> In-Reply-To: <20200715030706.prxya7fyylscoy25@vireshk-i7> From: Olof Johansson Date: Tue, 14 Jul 2020 20:49:24 -0700 Message-ID: Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header To: Viresh Kumar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, linuxppc-dev , "Rafael J. Wysocki" , Linux Kernel Mailing List , Paul Mackerras , Lee Jones , Linux ARM Mailing List Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 14, 2020 at 8:07 PM Viresh Kumar wrot= e: > > On 14-07-20, 15:50, Lee Jones wrote: > > If function callers and providers do not share the same prototypes the > > compiler complains of missing prototypes. Fix this by moving the > > already existing prototypes out to a mutually convenient location. > > > > Fixes the following W=3D1 kernel build warning(s): > > > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype= for =E2=80=98check_astate=E2=80=99 [-Wmissing-prototypes] > > 109 | int check_astate(void) > > | ^~~~~~~~~~~~ > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype= for =E2=80=98restore_astate=E2=80=99 [-Wmissing-prototypes] > > 114 | void restore_astate(int cpu) > > | ^~~~~~~~~~~~~~ > > > > Cc: Olof Johansson > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Lee Jones > > --- > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ > > Is there no sane way we can include this file directly to the cpufreq > file ? Yep. arch/powerpc seems to be in the search path for modules on powerpc, so= : diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpuf= req.c index c66f566a854cb..815645170c4de 100644 --- a/drivers/cpufreq/pasemi-cpufreq.c +++ b/drivers/cpufreq/pasemi-cpufreq.c @@ -22,6 +22,8 @@ #include #include +#include + #define SDCASR_REG 0x0100 #define SDCASR_REG_STRIDE 0x1000 #define SDCPWR_CFGA0_REG 0x0100 -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ABADC433DF for ; Wed, 15 Jul 2020 03:51:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5474F2065D for ; Wed, 15 Jul 2020 03:51:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TgDdtQSq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="IAhNc2PE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5474F2065D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lixom.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fhi02BUJX9/ZQmRsj2xqsjjid9ydaP/opBzGRxr7QGs=; b=TgDdtQSqlCOsHGaswPuWgW7eq o155LoBQ8FYfm5pTcTySrutwuVilmlAIQ3Ay4NUKcen069YXXeH74EDFcfDUvubgHaVMnWw0J1IX+ QCJmy6/4Z9klyv7jTNBV/IcHKsntta9FOTuel8NNtCXrHKxVB1bUkCSykTjSgobq5IBCNuKqbZJzG L7y22YvUws+52CXtnzot3QD2hFKZpiCFterIoP8qL9CSLM3iGTG6VchkZBCaoIlAWE8vvp3qFHkWD jglMBuDVggrGge/ClQcNSy8bTu4ADq3tQtfv1ZPoSR6jJmdphSkmZrXQX11RMngU91Nmkkl/Fd0T1 ZB6F5+fhA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvYQO-0000gC-9F; Wed, 15 Jul 2020 03:49:40 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvYQL-0000fV-Cc for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 03:49:38 +0000 Received: by mail-io1-xd43.google.com with SMTP id l1so792025ioh.5 for ; Tue, 14 Jul 2020 20:49:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f1CRBSIEJDuFB8dog5jdvBQmdtw3EAxf2Oj6BzpDQQw=; b=IAhNc2PEOhArE+GcYrmBe/3NxGeuZx3JCuvw8ORdWaNpd8YNvHPLjFq+HAH3MRMP5S oOxyBK2u/zYrAOOjd2SxmZlRdg52TimjplCGTE4uqPKuozcM1fiFENkeKCPQ9TnAqGmC qDzl2Wwr+U15OcOwRP1fOnEZpCsaQlWf0zLOAuwadhfEdNRJAzc51eKROOxgfx8Ojn9p T23rKIIJKsm16XdyBmajMpVc4HFjxz2XrsVtLUH+3NCWbaIRrG6ISCGQMbYo3oB6eg8Y VXr6eeEnaLcVnulcplV88lhEe/D2ixCJV4Udc5gLfEIJqGRTME27xPjf75uimLjop3CO simA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f1CRBSIEJDuFB8dog5jdvBQmdtw3EAxf2Oj6BzpDQQw=; b=Ia4HOLs/p0gatS552/2Gjhm3PnG/0zC+Uhz51ck0hFi/ThiL6cXYJ5WiA+n6HG3NC7 NTNLVNBX1Fjhmpnvwe/gk6CWLYf/ZaWB+0Keyb1i1hGpbrLBufTRJpG4e3XeaPAZOCP4 AI79AJoVBe6hEisjiwCRfAhuChelEl/wzIdBfHaE5duQBmmijWqo1FVtzroJHby7seBY 7lUeNwdHoG5AeNqCH8L3QX8vbc9TwFVIuF7HyGvbQw4BYssb6BT5F5v+sLgcHMIUnP7S cHceOIP/ITfoiRk55u+30/XKBaq/lxf+r1gUmeNdkuiU0IJWa1Xm0oRtNU7Q6+YwzN2D zVRw== X-Gm-Message-State: AOAM532lm3YZJVh1x0+/dVih2UeaZw/iuR7CTzW7M5kpCgLtI2irH7nS +q5X0cARulYejd15r4wubS03oWuaVJ3wfqcaJZBiZg== X-Google-Smtp-Source: ABdhPJxIX1Rz1uy6qYWtVhSNi58vBkltN0nc+Y74TsUfZKS2AQDMN6wsabdJmmRCmC3OuMNUYpqM8OhcnmPuarpFxhU= X-Received: by 2002:a6b:8e56:: with SMTP id q83mr8239025iod.61.1594784975129; Tue, 14 Jul 2020 20:49:35 -0700 (PDT) MIME-Version: 1.0 References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715030706.prxya7fyylscoy25@vireshk-i7> In-Reply-To: <20200715030706.prxya7fyylscoy25@vireshk-i7> From: Olof Johansson Date: Tue, 14 Jul 2020 20:49:24 -0700 Message-ID: Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header To: Viresh Kumar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200714_234937_460240_00B719C4 X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, Michael Ellerman , linuxppc-dev , "Rafael J. Wysocki" , Linux Kernel Mailing List , Paul Mackerras , Benjamin Herrenschmidt , Lee Jones , Linux ARM Mailing List Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdWwgMTQsIDIwMjAgYXQgODowNyBQTSBWaXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1h ckBsaW5hcm8ub3JnPiB3cm90ZToKPgo+IE9uIDE0LTA3LTIwLCAxNTo1MCwgTGVlIEpvbmVzIHdy b3RlOgo+ID4gSWYgZnVuY3Rpb24gY2FsbGVycyBhbmQgcHJvdmlkZXJzIGRvIG5vdCBzaGFyZSB0 aGUgc2FtZSBwcm90b3R5cGVzIHRoZQo+ID4gY29tcGlsZXIgY29tcGxhaW5zIG9mIG1pc3Npbmcg cHJvdG90eXBlcy4gIEZpeCB0aGlzIGJ5IG1vdmluZyB0aGUKPiA+IGFscmVhZHkgZXhpc3Rpbmcg cHJvdG90eXBlcyBvdXQgdG8gYSBtdXR1YWxseSBjb252ZW5pZW50IGxvY2F0aW9uLgo+ID4KPiA+ IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+ID4KPiA+ ICBkcml2ZXJzL2NwdWZyZXEvcGFzZW1pLWNwdWZyZXEuYzoxMDk6NTogd2FybmluZzogbm8gcHJl dmlvdXMgcHJvdG90eXBlIGZvciDigJhjaGVja19hc3RhdGXigJkgWy1XbWlzc2luZy1wcm90b3R5 cGVzXQo+ID4gIDEwOSB8IGludCBjaGVja19hc3RhdGUodm9pZCkKPiA+ICB8IF5+fn5+fn5+fn5+ fgo+ID4gIGRyaXZlcnMvY3B1ZnJlcS9wYXNlbWktY3B1ZnJlcS5jOjExNDo2OiB3YXJuaW5nOiBu byBwcmV2aW91cyBwcm90b3R5cGUgZm9yIOKAmHJlc3RvcmVfYXN0YXRl4oCZIFstV21pc3Npbmct cHJvdG90eXBlc10KPiA+ICAxMTQgfCB2b2lkIHJlc3RvcmVfYXN0YXRlKGludCBjcHUpCj4gPiAg fCBefn5+fn5+fn5+fn5+fgo+ID4KPiA+IENjOiBPbG9mIEpvaGFuc3NvbiA8b2xvZkBsaXhvbS5u ZXQ+Cj4gPiBDYzogTWljaGFlbCBFbGxlcm1hbiA8bXBlQGVsbGVybWFuLmlkLmF1Pgo+ID4gQ2M6 IEJlbmphbWluIEhlcnJlbnNjaG1pZHQgPGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZz4KPiA+IENj OiBQYXVsIE1hY2tlcnJhcyA8cGF1bHVzQHNhbWJhLm9yZz4KPiA+IENjOiBsaW51eHBwYy1kZXZA bGlzdHMub3psYWJzLm9yZwo+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNA bGluYXJvLm9yZz4KPiA+IC0tLQo+ID4gIGFyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcGFzZW1pL3Bh c2VtaS5oICAgIHwgMTUgLS0tLS0tLS0tLS0tCj4KPiBJcyB0aGVyZSBubyBzYW5lIHdheSB3ZSBj YW4gaW5jbHVkZSB0aGlzIGZpbGUgZGlyZWN0bHkgdG8gdGhlIGNwdWZyZXEKPiBmaWxlID8KClll cC4gYXJjaC9wb3dlcnBjIHNlZW1zIHRvIGJlIGluIHRoZSBzZWFyY2ggcGF0aCBmb3IgbW9kdWxl cyBvbiBwb3dlcnBjLCBzbzoKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2NwdWZyZXEvcGFzZW1pLWNw dWZyZXEuYyBiL2RyaXZlcnMvY3B1ZnJlcS9wYXNlbWktY3B1ZnJlcS5jCmluZGV4IGM2NmY1NjZh ODU0Y2IuLjgxNTY0NTE3MGM0ZGUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvY3B1ZnJlcS9wYXNlbWkt Y3B1ZnJlcS5jCisrKyBiL2RyaXZlcnMvY3B1ZnJlcS9wYXNlbWktY3B1ZnJlcS5jCkBAIC0yMiw2 ICsyMiw4IEBACiAjaW5jbHVkZSA8YXNtL3RpbWUuaD4KICNpbmNsdWRlIDxhc20vc21wLmg+Cgor I2luY2x1ZGUgPHBsYXRmb3Jtcy9wYXNlbWkvcGFzZW1pLmg+CisKICNkZWZpbmUgU0RDQVNSX1JF RyAgICAgICAgICAgICAweDAxMDAKICNkZWZpbmUgU0RDQVNSX1JFR19TVFJJREUgICAgICAweDEw MDAKICNkZWZpbmUgU0RDUFdSX0NGR0EwX1JFRyAgICAgICAweDAxMDAKCgotT2xvZgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=