From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH 2/4] ARM: dt: tegra20.dtsi: Add Memory Controller(MC) nodes Date: Tue, 15 May 2012 23:35:02 -0700 Message-ID: References: <1336635764-30597-1-git-send-email-hdoyu@nvidia.com> <1336635764-30597-2-git-send-email-hdoyu@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1336635764-30597-2-git-send-email-hdoyu-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Hiroshi DOYU Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Stephen Warren , Grant Likely , Simon Glass , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org Hi, Tiny drive-by nit pick. On Thu, May 10, 2012 at 12:42 AM, Hiroshi DOYU wrote= : > Add Tegra MC(Memory Controller) nodes for tegra20.dtsi. > > Signed-off-by: Hiroshi DOYU > --- > =A0arch/arm/boot/dts/tegra20.dtsi | =A0 =A07 +++++++ > =A01 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra= 20.dtsi > index 24129fb..548b42e 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -211,5 +211,12 @@ > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0compatible =3D "nvidia,tegra20-ahb"; > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0reg =3D <0x6000c004 0x10c>; /* AHB Arb= itration + Gizmo Controller */ > =A0 =A0 =A0 =A0}; > + > + =A0 =A0 =A0 mc { It's common to use a more plain english name here, so "memory-controller" would be a good name. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759164Ab2EPGfH (ORCPT ); Wed, 16 May 2012 02:35:07 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:46827 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758564Ab2EPGfD convert rfc822-to-8bit (ORCPT ); Wed, 16 May 2012 02:35:03 -0400 MIME-Version: 1.0 X-Originating-IP: [173.13.129.225] In-Reply-To: <1336635764-30597-2-git-send-email-hdoyu@nvidia.com> References: <1336635764-30597-1-git-send-email-hdoyu@nvidia.com> <1336635764-30597-2-git-send-email-hdoyu@nvidia.com> Date: Tue, 15 May 2012 23:35:02 -0700 Message-ID: Subject: Re: [PATCH 2/4] ARM: dt: tegra20.dtsi: Add Memory Controller(MC) nodes From: Olof Johansson To: Hiroshi DOYU Cc: linux-tegra@vger.kernel.org, Russell King , Stephen Warren , Grant Likely , Simon Glass , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Tiny drive-by nit pick. On Thu, May 10, 2012 at 12:42 AM, Hiroshi DOYU wrote: > Add Tegra MC(Memory Controller) nodes for tegra20.dtsi. > > Signed-off-by: Hiroshi DOYU > --- >  arch/arm/boot/dts/tegra20.dtsi |    7 +++++++ >  1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > index 24129fb..548b42e 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -211,5 +211,12 @@ >                compatible = "nvidia,tegra20-ahb"; >                reg = <0x6000c004 0x10c>; /* AHB Arbitration + Gizmo Controller */ >        }; > + > +       mc { It's common to use a more plain english name here, so "memory-controller" would be a good name. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Tue, 15 May 2012 23:35:02 -0700 Subject: [PATCH 2/4] ARM: dt: tegra20.dtsi: Add Memory Controller(MC) nodes In-Reply-To: <1336635764-30597-2-git-send-email-hdoyu@nvidia.com> References: <1336635764-30597-1-git-send-email-hdoyu@nvidia.com> <1336635764-30597-2-git-send-email-hdoyu@nvidia.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Tiny drive-by nit pick. On Thu, May 10, 2012 at 12:42 AM, Hiroshi DOYU wrote: > Add Tegra MC(Memory Controller) nodes for tegra20.dtsi. > > Signed-off-by: Hiroshi DOYU > --- > ?arch/arm/boot/dts/tegra20.dtsi | ? ?7 +++++++ > ?1 files changed, 7 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi > index 24129fb..548b42e 100644 > --- a/arch/arm/boot/dts/tegra20.dtsi > +++ b/arch/arm/boot/dts/tegra20.dtsi > @@ -211,5 +211,12 @@ > ? ? ? ? ? ? ? ?compatible = "nvidia,tegra20-ahb"; > ? ? ? ? ? ? ? ?reg = <0x6000c004 0x10c>; /* AHB Arbitration + Gizmo Controller */ > ? ? ? ?}; > + > + ? ? ? mc { It's common to use a more plain english name here, so "memory-controller" would be a good name. -Olof