From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29949C6FA82 for ; Wed, 14 Sep 2022 16:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbiINQZD (ORCPT ); Wed, 14 Sep 2022 12:25:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229937AbiINQY6 (ORCPT ); Wed, 14 Sep 2022 12:24:58 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12A7B52DFD for ; Wed, 14 Sep 2022 09:24:52 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a26so7236376ejc.4 for ; Wed, 14 Sep 2022 09:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=iPvcRKQ3/RqRnb/KNOcwBsKTik/oM2E9btzJlJ3xtbw=; b=UUW/XmCV1JYV8LfgqC/Yi2kUbkZfzbWyffYAPE5XdIdCMrNxQAvlr3wOP2Hzc6uACl syl37yzz3CubUgn6U+5UnhQzmJf1voYR7fFNBFzhXNrWdK4xzmesc8AKheuoYDgus+3c TqcxYBb4kdjzOcQxxc1kuSBpVrJkfGghOrocYl257Fw4moSaEviRq2ROpoHYe5OALvDL jhZUWCKC32/Iutw6ZOZDZoACEINekhhh0ba8ayJSAilnYa7+YKqvr5tpKVyzrfPNdklL eX/cwh0SaOCan4rKJ4OGUR0CecYOzwB0sWRYEHxSVzD+Dm7E4ujlAGJ3JJ+QiaRouMUU wCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=iPvcRKQ3/RqRnb/KNOcwBsKTik/oM2E9btzJlJ3xtbw=; b=71bYgpakN9uDGxyvOnRyu0JzNXVI7ONq1t+43t99ihk0dH5dBVPaq2J6ksYJ7K+F7h hBtDJgfVCXUjWM4uBijlfK4P0c/lx3FvzbW5HTUi8Wq2BD5rHUnOEoIyK9p9j8b3wjEn q8FqrQA7BX6OvBPmmuKrO9biO+NQqMwvQL/rZiLedau3CxMYFO5who2/7BQMpYl7mqfY f9mhFOrGBKrrAiOZvlXDF6YHzjB42BDcPDO0Zaf7DlHcqOpBycXKIWhWFrDaqzKXJJm0 4tVai0KQSNvj+r0IDcbUEwThSY6aF9rueP4YtAAdGaVauWpv2Drkv87orCVd/ke0kj2b CxCQ== X-Gm-Message-State: ACgBeo2Qi2wQTz8X7er+MktZdvrRsPxczMDx0JQO7eCoLjDAOcxoXjDO OdgobksjSRkZnAAVte65PLtadGUQVUTjA6k9xG6BMA== X-Google-Smtp-Source: AA6agR7BqJBqsWKt2M6q7i2A14Fsfv98BBM2NQBaW6bfjVBNdJDDAfqKYlb+MIOrQnSw7kuWVO3vrb/BkPMPvM0Nst4= X-Received: by 2002:a17:907:a0c7:b0:77f:a9d2:9be2 with SMTP id hw7-20020a170907a0c700b0077fa9d29be2mr7773678ejc.352.1663172690708; Wed, 14 Sep 2022 09:24:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Olof Johansson Date: Wed, 14 Sep 2022 09:24:39 -0700 Message-ID: Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 To: Greg KH Cc: Saravana Kannan , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Linux ARM Mailing List , Shawn Guo , Li Yang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Sep 14, 2022 at 7:00 AM Greg KH wrote: > > On Tue, Sep 13, 2022 at 09:28:27AM -0700, Olof Johansson wrote: > > On Tue, Sep 13, 2022 at 8:15 AM Greg KH wrote: > > > > > > On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > > > > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > > > > > > > Hi, > > > > > > > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > > > > > > > Saravana Kannan (11): > > > > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > > > > driver core: Add wait_for_init_devices_probe helper function > > > > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > > > > driver core: Set fw_devlink.strict=1 by default > > > > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > > > > driver core: Delete driver_deferred_probe_check_state() > > > > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > > > > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > > > > the machine I do maintainer work on). It stops PCIe from probing, but > > > > > without a single message indicating why. > > > > > > > > > > The reason seems to be that the iommu-maps property doesn't get > > > > > patched up by my (older) u-boot, and thus isn't a valid reference. > > > > > System works fine without IOMMU, which is how I've ran it for a couple > > > > > of years. > > > > > > > > > > It's also extremely hard to diagnose out of the box because there are > > > > > *no error messages*. And there were no warnings leading up to this > > > > > strict enforcement. > > > > > > > > > > This "feature" seems to have been done backwards. The checks should > > > > > have been running (and not skipped due to the "optional" flag), but > > > > > also not causing errors, just warnings. That would have given users a > > > > > chance to know that this is something that needs to be fixed. > > > > > > > > > > And when you flip the switch, at least report what failed so that > > > > > people don't need to spend a whole night bisecting kernels, please. > > > > > > > > > > Greg, mind reverting just the last one? If I hit this, I presume > > > > > others would too. > > > > > > > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > > > > fw_devlink.strict=1 by default", 71066545b48e42. > > > > > > Is this still an issue in -rc5? A number of patches in the above series > > > was just reverted and hopefully should have resolved the issue you are > > > seeing. > > > > Unfortunately, I discovered this regression with -rc5 in the first > > place, so it's still there. > > Ick, ok, Saravana, any thoughts? I know you're at the conference this > week with me, maybe you can give Olof a hint as to what to look for > here? I'm not sure what you want me to look for. The patch turns on enforcement of DT contents that never used to be enforced, so now my computer no longer boots. And it does it in a way that makes it impossible for someone not rebuilding kernels to debug to figure out what happened. The patch needs to be reverted. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8E5DECAAD3 for ; Wed, 14 Sep 2022 16:26:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SRe1+Bj4Rr4XFsth2VJq8rCxadzWsDHIaOJbncNDbB8=; b=PiI6c/7BDZsjtQ 8uJ9FAW7g9lzKUMnR9Tt5Wt4icw19QMzMBpVc1lZJP1s+UNkxg4I7MfftJWgh8pKZpS7VAjUM1G0n oVyRqNRJmd1qRlL3ENYKi0t5pRgGP8VreG5EUvEo18OHPmv4J2n+v960B/Ki3brpv1b9E8zLpO494 WoNs9NEdKX/fKCyQ8E644FYDzxck/rX2+fWzupOobKY8r56rUepGL5DrhMRFmymQKLCPhN946AzH8 /E3aqWWWkxCW0dPu2OTKhtPRuPmy2YBvln+lojA4+W8HjKIEsqif7WK731HdqI2Wbs4v1nMTh7f5i mMukUcF3J5isUbzx2uHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYVC6-0051ba-Je; Wed, 14 Sep 2022 16:24:58 +0000 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oYVC3-0051Sr-8F for linux-arm-kernel@lists.infradead.org; Wed, 14 Sep 2022 16:24:57 +0000 Received: by mail-ej1-x62e.google.com with SMTP id go34so35973966ejc.2 for ; Wed, 14 Sep 2022 09:24:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=iPvcRKQ3/RqRnb/KNOcwBsKTik/oM2E9btzJlJ3xtbw=; b=UUW/XmCV1JYV8LfgqC/Yi2kUbkZfzbWyffYAPE5XdIdCMrNxQAvlr3wOP2Hzc6uACl syl37yzz3CubUgn6U+5UnhQzmJf1voYR7fFNBFzhXNrWdK4xzmesc8AKheuoYDgus+3c TqcxYBb4kdjzOcQxxc1kuSBpVrJkfGghOrocYl257Fw4moSaEviRq2ROpoHYe5OALvDL jhZUWCKC32/Iutw6ZOZDZoACEINekhhh0ba8ayJSAilnYa7+YKqvr5tpKVyzrfPNdklL eX/cwh0SaOCan4rKJ4OGUR0CecYOzwB0sWRYEHxSVzD+Dm7E4ujlAGJ3JJ+QiaRouMUU wCcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=iPvcRKQ3/RqRnb/KNOcwBsKTik/oM2E9btzJlJ3xtbw=; b=rNu/ejAOW0ETCj1oxRE01zUPB+IP1V26SnHLB+SLRxDt90NE8G7mp6UvAXXejC+Zor WoI1fQBwo3sFiCnwwK2tN61kvuujDy2kANMx6i0aqljh+7TFNJ5Tc10XX1he+Xk+XV3k 0st7OHVJERTj97ubmNd+Nhtk4HoZGGWpNzxkTAir8YnULEpq3U9ftHldPtRxT5zdgzj1 Okn9OT6ZzhGLwAsBL9wORTci83tk0Y/jdxVG7fiupcdz87V0pkJ5Wa5xniEXXeegJ9rB 9apjEkUTRBHcs0aNZ6ebsfl+4j6PDj+aXUGEbGyxbPLJkRF53t3m9q4pKYGAbgPMgE1K giPQ== X-Gm-Message-State: ACgBeo3KV2GiifhwwuYjx5sXt3hHeSyNa7Vx/oATe+/4Xcshx1L3mZj8 F7wV4OwF9SCG+LdyzqPsscgQ9yfrI2uta2kcNZokdQ== X-Google-Smtp-Source: AA6agR7BqJBqsWKt2M6q7i2A14Fsfv98BBM2NQBaW6bfjVBNdJDDAfqKYlb+MIOrQnSw7kuWVO3vrb/BkPMPvM0Nst4= X-Received: by 2002:a17:907:a0c7:b0:77f:a9d2:9be2 with SMTP id hw7-20020a170907a0c700b0077fa9d29be2mr7773678ejc.352.1663172690708; Wed, 14 Sep 2022 09:24:50 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Olof Johansson Date: Wed, 14 Sep 2022 09:24:39 -0700 Message-ID: Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 To: Greg KH Cc: Saravana Kannan , Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Linux ARM Mailing List , Shawn Guo , Li Yang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220914_092455_507873_5535543F X-CRM114-Status: GOOD ( 38.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Sep 14, 2022 at 7:00 AM Greg KH wrote: > > On Tue, Sep 13, 2022 at 09:28:27AM -0700, Olof Johansson wrote: > > On Tue, Sep 13, 2022 at 8:15 AM Greg KH wrote: > > > > > > On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > > > > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > > > > > > > Hi, > > > > > > > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > > > > > > > Saravana Kannan (11): > > > > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > > > > driver core: Add wait_for_init_devices_probe helper function > > > > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > > > > driver core: Set fw_devlink.strict=1 by default > > > > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > > > > driver core: Delete driver_deferred_probe_check_state() > > > > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > > > > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > > > > the machine I do maintainer work on). It stops PCIe from probing, but > > > > > without a single message indicating why. > > > > > > > > > > The reason seems to be that the iommu-maps property doesn't get > > > > > patched up by my (older) u-boot, and thus isn't a valid reference. > > > > > System works fine without IOMMU, which is how I've ran it for a couple > > > > > of years. > > > > > > > > > > It's also extremely hard to diagnose out of the box because there are > > > > > *no error messages*. And there were no warnings leading up to this > > > > > strict enforcement. > > > > > > > > > > This "feature" seems to have been done backwards. The checks should > > > > > have been running (and not skipped due to the "optional" flag), but > > > > > also not causing errors, just warnings. That would have given users a > > > > > chance to know that this is something that needs to be fixed. > > > > > > > > > > And when you flip the switch, at least report what failed so that > > > > > people don't need to spend a whole night bisecting kernels, please. > > > > > > > > > > Greg, mind reverting just the last one? If I hit this, I presume > > > > > others would too. > > > > > > > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > > > > fw_devlink.strict=1 by default", 71066545b48e42. > > > > > > Is this still an issue in -rc5? A number of patches in the above series > > > was just reverted and hopefully should have resolved the issue you are > > > seeing. > > > > Unfortunately, I discovered this regression with -rc5 in the first > > place, so it's still there. > > Ick, ok, Saravana, any thoughts? I know you're at the conference this > week with me, maybe you can give Olof a hint as to what to look for > here? I'm not sure what you want me to look for. The patch turns on enforcement of DT contents that never used to be enforced, so now my computer no longer boots. And it does it in a way that makes it impossible for someone not rebuilding kernels to debug to figure out what happened. The patch needs to be reverted. -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel