From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2C5EC43603 for ; Tue, 10 Dec 2019 21:01:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FDCF2073D for ; Tue, 10 Dec 2019 21:01:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="jsdqNPAH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725999AbfLJVBC (ORCPT ); Tue, 10 Dec 2019 16:01:02 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:41220 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbfLJVBC (ORCPT ); Tue, 10 Dec 2019 16:01:02 -0500 Received: by mail-io1-f67.google.com with SMTP id z26so20325131iot.8 for ; Tue, 10 Dec 2019 13:01:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VF0gTV9qdWB6cnJyQqzS/oysI3Ok/hp0ujuFEUT1g/4=; b=jsdqNPAHXsElTW1fJAS379zuHUGC1oFc2lHyUu72dO6VkV1JVCClw9ZN+rn6bAUJGB C82zcTIw8LQuDXCPKAu2QqRxsfmkZbxzScIxSv63J4vse3xkMpl7akVJoOM/Sd4Mc5iN Ghgbbj5j7YjYddfLWXRZh/smuPdg9k6YThKhn70z+FpSA79pHqjAnD4yPe709xBI7nzK l85Viv4xHrS0XF4lrF7bvcRqsrBDj0Kh/UQ9RI+03wjHkMr4VnfZ+IRVcVGuv1WvkuRg qCYpdnBbLS268d5ap1C1ge+a9210siLx0F0SkQ1txAQX5ydc17l9GW2gWasCZvdIuimj vX2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VF0gTV9qdWB6cnJyQqzS/oysI3Ok/hp0ujuFEUT1g/4=; b=VvfWRBFqRW9dpYUqeEvcI6EI2prf90zunjyxfdgcFWWoFGtmN9RbtXOAElV6xG3Mt2 Dt4bF7IcfHvNFyX5mdIM6MM2Gkj6+NE5rs6M0E0J+moqhlfn60xNYcSGLz9zDmGUUlQU U0Y8T7zwXkp4Nk85psHVqTXWKhltz6HFExlJfgg7O/afWWAcrixyWXtgdNF20/ZUyoVx AWlq6bg+plzYlFPtl+mgbACNPNqqhxg0NjY3SohJOAUC5WJBJd5aiR1PMhhZGoxJRWOY Xbr5KhEyGq8DDF66x9R37Vhk1UYWCXkHgxpR1tQ+z3VplTStHNI0/0bhixX6wop3tXFC Halw== X-Gm-Message-State: APjAAAVzMdA0R4bBhioR2CnfmCBslrP0FUloJlZqqQSklscbX25Mbh96 rK65OcXDB+4tv/cipQYCIygxUHtl3ejB2YH3HdsT2rA9XZ0= X-Google-Smtp-Source: APXvYqxzBB5WAs2ik4ARKNQYfI4ndrdxS2nJ3+fmDiOYcyhxlOuNpRg3Z3djUNZQYQV70261GmtQr430uehjQHAQNN4= X-Received: by 2002:a02:6957:: with SMTP id e84mr229095jac.11.1576011661410; Tue, 10 Dec 2019 13:01:01 -0800 (PST) MIME-Version: 1.0 References: <1573068840-13098-1-git-send-email-agross@kernel.org> <1573068840-13098-2-git-send-email-agross@kernel.org> <20191108031854.GA12993@hector.lan> <20191210105737.GB228968@gerhold.net> <20191210181725.GD314059@yoga> In-Reply-To: <20191210181725.GD314059@yoga> From: Olof Johansson Date: Tue, 10 Dec 2019 13:00:49 -0800 Message-ID: Subject: Re: [GIT PULL] Qualcomm ARM64 DT updates for 5.5 To: Bjorn Andersson Cc: Amit Kucheria , Stephan Gerhold , Andy Gross , linux-arm-msm , lakml Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Dec 10, 2019 at 10:17 AM Bjorn Andersson wrote: > > On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote: > > > On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold wrote: > > > > > > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > > > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > > > > (Removing arm-soc) > > > > > > > > > > Hi Andy, > > > > > > > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross wrote: > > > > > > > > > > > > Arnd, Olof, and Kevin, > > > > > > > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > > > > > > > Andy > > > > > > > > > > > ---------------------------------------------------------------- > > > > > > Amit Kucheria (5): > > > > > > arm64: dts: qcs404: thermal: Add interrupt support > > > > > > arm64: dts: msm8998: thermal: Add interrupt support > > > > > > arm64: dts: msm8996: thermal: Add interrupt support > > > > > > arm64: dts: sdm845: thermal: Add interrupt support > > > > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > > > > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > > > > here. Specifically this one: > > > > > https://patchwork.kernel.org/patch/11201853/ > > > > > > > > > > Will there be a second PR this cycle? > > > > > > > > I can work up another and throw it on top. > > > > > > > > > > FYI, the patch seems to be still missing in 5.5-rc1. > > > tsens now fails to probe on MSM8916 with: > > > > > > qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found > > > > > > Can you queue up the patch as fix for 5.5? > > > > Indeed. Andy/Bjorn, let me know if you need anything from me to get > > this into -rc2. > > > > I'm pulling in some fixes for a rc-pull, so I could add it there. > > But why are we breaking backwards compatibility with existing dtbs to > add a new (optional) feature? Shouldn't there be a rc-fix in the driver > for this regression? 100% agreed. Driver shouldn't require the DT update to continue to function. It needs to fill in the previous behavior as default. As a matter of fact, based on that I don't want to see that DT patch as a fix, please queue it up for 5.6 instead. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DBEAC43603 for ; Tue, 10 Dec 2019 21:01:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69E04206EC for ; Tue, 10 Dec 2019 21:01:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="da+9/3HG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="jsdqNPAH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69E04206EC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lixom.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AV6HCID78q7zSDepkMqbOuDML3oo0AhjQL+dRup31nc=; b=da+9/3HGQCSCx4 ZIbolB6+jTeCzEc9xlUyQaTZiKHzf+h8TJXVznzrKfXEtDR1Fsa2lJd4XJe+TAElodyZN1f15SK8T NfmoiRKd1z3M13ggqKRGwmz94jS0Q0WefnqF+A4rg9bQBknRIHYJQG33MnEo6kzzASZl2VZOD9AzI r+3X5NWMK7gktvJ14rgrrrTAF3E8vw6CW7jCIAPUItqWw93AHSjBP8nvGoV6Wsg2W+Li7aQ2XvcGX xpfRSa73sty1la58HvWMzER6gGFocIZBDSpI/dAxEUcDsvWLJ16z0+gFFyFwhWZDKVehxfpQ8cwca fUEQvolgE18rS28kPQ0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iemd1-0006NV-15; Tue, 10 Dec 2019 21:01:07 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iemcw-0006Mr-WC for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2019 21:01:04 +0000 Received: by mail-io1-xd43.google.com with SMTP id t26so8894749ioi.13 for ; Tue, 10 Dec 2019 13:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VF0gTV9qdWB6cnJyQqzS/oysI3Ok/hp0ujuFEUT1g/4=; b=jsdqNPAHXsElTW1fJAS379zuHUGC1oFc2lHyUu72dO6VkV1JVCClw9ZN+rn6bAUJGB C82zcTIw8LQuDXCPKAu2QqRxsfmkZbxzScIxSv63J4vse3xkMpl7akVJoOM/Sd4Mc5iN Ghgbbj5j7YjYddfLWXRZh/smuPdg9k6YThKhn70z+FpSA79pHqjAnD4yPe709xBI7nzK l85Viv4xHrS0XF4lrF7bvcRqsrBDj0Kh/UQ9RI+03wjHkMr4VnfZ+IRVcVGuv1WvkuRg qCYpdnBbLS268d5ap1C1ge+a9210siLx0F0SkQ1txAQX5ydc17l9GW2gWasCZvdIuimj vX2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VF0gTV9qdWB6cnJyQqzS/oysI3Ok/hp0ujuFEUT1g/4=; b=KVfY+AJlTcWZ7BJUj9vKkOIsSvaXEMeQcsDZMxy7U3SuU3BonwqrM/KQX7lfMLQVrb CZ8i9krsTZpt2DF6HHGbWZEpzhDOfeDLaFRSCRVsi9VeaclRbJ884qSDc1i5XZOldpmG 90r+VjnNZKq1mDqyIjJnIHWMH18UDu07NXo9mrVZRcsSaeVTD8dP1O/Qxjwi+MOb+lJH ocWdks9sMrS8O/kTomvPnRlcpoUqP+0wmejWnOJxwqMDSqksP/9eEu1U1cO/TIUyOwds s1aXg5ebgOQGgsY6Az48J+y5Rbvic0orCMymuxlNyHEbn1kkG9sBP2ufY1dlzMIX7LMy y1Fg== X-Gm-Message-State: APjAAAXLLePe4JKpHK1BxvAM3zAvfYotuVPIbUCb40hJrkDzIz8MeVd+ sS5OPMbQF5LSNcExGoyePQDDX93BuK7w8MUzXCyLIw== X-Google-Smtp-Source: APXvYqxzBB5WAs2ik4ARKNQYfI4ndrdxS2nJ3+fmDiOYcyhxlOuNpRg3Z3djUNZQYQV70261GmtQr430uehjQHAQNN4= X-Received: by 2002:a02:6957:: with SMTP id e84mr229095jac.11.1576011661410; Tue, 10 Dec 2019 13:01:01 -0800 (PST) MIME-Version: 1.0 References: <1573068840-13098-1-git-send-email-agross@kernel.org> <1573068840-13098-2-git-send-email-agross@kernel.org> <20191108031854.GA12993@hector.lan> <20191210105737.GB228968@gerhold.net> <20191210181725.GD314059@yoga> In-Reply-To: <20191210181725.GD314059@yoga> From: Olof Johansson Date: Tue, 10 Dec 2019 13:00:49 -0800 Message-ID: Subject: Re: [GIT PULL] Qualcomm ARM64 DT updates for 5.5 To: Bjorn Andersson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_130103_082100_6A4044D7 X-CRM114-Status: GOOD ( 20.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm , Amit Kucheria , Andy Gross , lakml , Stephan Gerhold Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 10, 2019 at 10:17 AM Bjorn Andersson wrote: > > On Tue 10 Dec 09:36 PST 2019, Amit Kucheria wrote: > > > On Tue, Dec 10, 2019 at 4:27 PM Stephan Gerhold wrote: > > > > > > On Thu, Nov 07, 2019 at 09:18:54PM -0600, Andy Gross wrote: > > > > On Thu, Nov 07, 2019 at 07:36:03PM +0530, Amit Kucheria wrote: > > > > > (Removing arm-soc) > > > > > > > > > > Hi Andy, > > > > > > > > > > On Thu, Nov 7, 2019 at 1:04 AM Andy Gross wrote: > > > > > > > > > > > > Arnd, Olof, and Kevin, > > > > > > > > > > > > I have one slight faux paux in this pull request. A drivers: soc change got > > > > > > into my arm64 DTS branch and while it is innocuous, it wasn't easy to fix > > > > > > without messing up a lot of people who depend on the SHAs not changing. So I'm > > > > > > sorry for this inclusion. I'll scrub this better next time. > > > > > > > > > > > > Andy > > > > > > > > > > > ---------------------------------------------------------------- > > > > > > Amit Kucheria (5): > > > > > > arm64: dts: qcs404: thermal: Add interrupt support > > > > > > arm64: dts: msm8998: thermal: Add interrupt support > > > > > > arm64: dts: msm8996: thermal: Add interrupt support > > > > > > arm64: dts: sdm845: thermal: Add interrupt support > > > > > > arm64: dts: msm8916: thermal: Fixup HW ids for cpu sensors > > > > > > > > > > One of my patches to add interrupt support to msm8916 tsens is missing > > > > > here. Specifically this one: > > > > > https://patchwork.kernel.org/patch/11201853/ > > > > > > > > > > Will there be a second PR this cycle? > > > > > > > > I can work up another and throw it on top. > > > > > > > > > > FYI, the patch seems to be still missing in 5.5-rc1. > > > tsens now fails to probe on MSM8916 with: > > > > > > qcom-tsens 4a9000.thermal-sensor: IRQ uplow not found > > > > > > Can you queue up the patch as fix for 5.5? > > > > Indeed. Andy/Bjorn, let me know if you need anything from me to get > > this into -rc2. > > > > I'm pulling in some fixes for a rc-pull, so I could add it there. > > But why are we breaking backwards compatibility with existing dtbs to > add a new (optional) feature? Shouldn't there be a rc-fix in the driver > for this regression? 100% agreed. Driver shouldn't require the DT update to continue to function. It needs to fill in the previous behavior as default. As a matter of fact, based on that I don't want to see that DT patch as a fix, please queue it up for 5.6 instead. -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel