From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f195.google.com ([209.85.220.195]:33612 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139AbcKUQgH (ORCPT ); Mon, 21 Nov 2016 11:36:07 -0500 Received: by mail-qk0-f195.google.com with SMTP id x190so48099785qkb.0 for ; Mon, 21 Nov 2016 08:35:47 -0800 (PST) MIME-Version: 1.0 In-Reply-To: References: <20161119012836.GA2543@localhost> From: Olof Johansson Date: Mon, 21 Nov 2016 08:35:40 -0800 Message-ID: Subject: Re: [GIT PULL] Second Round of Renesas ARM Based SoC Updates for v4.10 To: Geert Uytterhoeven Cc: Simon Horman , "arm@kernel.org" , Linux-Renesas , Kevin Hilman , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , Magnus Damm Content-Type: text/plain; charset=UTF-8 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Mon, Nov 21, 2016 at 8:27 AM, Geert Uytterhoeven wrote: > Hi Olof, > > On Mon, Nov 21, 2016 at 5:19 PM, Olof Johansson wrote: >> On Mon, Nov 21, 2016 at 1:31 AM, Geert Uytterhoeven >> wrote: >>> On Sat, Nov 19, 2016 at 2:28 AM, Olof Johansson wrote: >>>> On Thu, Nov 17, 2016 at 02:34:25PM +0100, Simon Horman wrote: >>>>> Please consider these second round of Renesas ARM based SoC updates for v4.10. >>> >>>>> * Basic support for r8a7745 SoC >>>>> >>>>> ---------------------------------------------------------------- >>>>> Sergei Shtylyov (2): >>>>> ARM: shmobile: r8a7745: basic SoC support >>>>> ARM: shmobile: document SK-RZG1E board >>>> >>>> Is there a reason you're adding a config option per SoC? >>>> >>>> I think you'd be better off not adding these config options, and just adding >>>> support for the SoCs through compatibles (and adding the drivers to defconfigs, >>>> etc). >>> >>> Yes there is a reason: kernel size. >>> The main offenders are the pinctrl tables, which add ca. 20-50 KiB per >>> supported SoC. >> >> So don't turn on that pinctrl driver unless you have that SoC? > > The enablement of the pinctrl driver (and the clock driver, FWIW) is controlled > by the SoC Kconfig symbol. If you want support for the SoC, you want the > pinctrl driver, too. > Oh, that's trivial to fix! Do as almost all other SoCs do, and don't use silent options. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Mon, 21 Nov 2016 08:35:40 -0800 Subject: [GIT PULL] Second Round of Renesas ARM Based SoC Updates for v4.10 In-Reply-To: References: <20161119012836.GA2543@localhost> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Nov 21, 2016 at 8:27 AM, Geert Uytterhoeven wrote: > Hi Olof, > > On Mon, Nov 21, 2016 at 5:19 PM, Olof Johansson wrote: >> On Mon, Nov 21, 2016 at 1:31 AM, Geert Uytterhoeven >> wrote: >>> On Sat, Nov 19, 2016 at 2:28 AM, Olof Johansson wrote: >>>> On Thu, Nov 17, 2016 at 02:34:25PM +0100, Simon Horman wrote: >>>>> Please consider these second round of Renesas ARM based SoC updates for v4.10. >>> >>>>> * Basic support for r8a7745 SoC >>>>> >>>>> ---------------------------------------------------------------- >>>>> Sergei Shtylyov (2): >>>>> ARM: shmobile: r8a7745: basic SoC support >>>>> ARM: shmobile: document SK-RZG1E board >>>> >>>> Is there a reason you're adding a config option per SoC? >>>> >>>> I think you'd be better off not adding these config options, and just adding >>>> support for the SoCs through compatibles (and adding the drivers to defconfigs, >>>> etc). >>> >>> Yes there is a reason: kernel size. >>> The main offenders are the pinctrl tables, which add ca. 20-50 KiB per >>> supported SoC. >> >> So don't turn on that pinctrl driver unless you have that SoC? > > The enablement of the pinctrl driver (and the clock driver, FWIW) is controlled > by the SoC Kconfig symbol. If you want support for the SoC, you want the > pinctrl driver, too. > Oh, that's trivial to fix! Do as almost all other SoCs do, and don't use silent options. -Olof