From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4CE2C54EE9 for ; Tue, 13 Sep 2022 16:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=saPUbECBAM44jfP+toBuekaZFRX8s8dXRNCeTzJ5pyQ=; b=kQ3ZtXYDibc5uv oE9ExzbQezLZKGZSnfdZqeikSf8dKMQW4mxonW2mI7itZwwmDI/0+WYmHYqYX0uwtsAdjg/+5jkhS 4XTtiSA1IILk7kLf5z10lwGI+YFKKzhA+1j6+hqsBR/RxdYJeRV8hGy097oBlwa2bCKEp5RHfDQpe wmplW9pKuTJu1CMogYSaQr4QRJo0ziCH2mZxDZuc5Z9tBMicErpOJnd6bIMuLplttjIgvNCGSRw/5 SDtoF6WlC5ibiSEj50lF/swZvwmq9A/9Yeri8Z0N+eydvTQ+i/PzCE7j3XPC4Cg2MAvmb1V50Z6eM /5au2frZTq+jzMJIEgxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY8mG-00DJnW-59; Tue, 13 Sep 2022 16:28:48 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oY8mC-00DJil-GW for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 16:28:46 +0000 Received: by mail-ej1-x635.google.com with SMTP id w16so13412363eji.9 for ; Tue, 13 Sep 2022 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=dqfDDt++wd3GzkJu7/rH2NUyW4xMIcqqDJ6iLNC291s=; b=MEim9D3xOue14jR/Jav6bQLoZi/hNv97yMe8hqfzvPzc9lQAfsx2Zldry2NXcUbKxT /csasHK5KWlUXQAoqovKKkX2mks4iPUgvPkRYuFhZvN9tgd+BbyBQlNoYRO64IILlGaa iOkKHn2BIsp33oxArNDx9ZgvjwS7iEZi/V1/JNM9uF7pH4ujynTaDtK+FLailmDNe5RL Zch+ys2WnGEcCsPAcmPbPgFzQoioYhHAVsSD/UWuoL6i0g3zbYzuHlOqfCdpgKxDRwl2 imUO++qhtU7LBoXETJI9c15zGiOvYHQ88EFThaI+OkUlp2b4PIhhMfhvlBrM4h+KvFB8 cOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=dqfDDt++wd3GzkJu7/rH2NUyW4xMIcqqDJ6iLNC291s=; b=yvKS8DmD9Z4ayeqjtg4jIRhJPdJL2L9T8n+8q5xP5wlEa7qegjErAJVD+L+4txD2Xu sOq6nCPzj0f1qafSt2CN68lNcNd60tJOwLEAnvGtuQ+LkbfXW8x+AMLf72CxREit6ikV xXLmrOvCPz5QalBIPOXxvXArxkO01qquCX7cIA1SJu9l9mFNwQPYnMKHSQhXpsLxsB4Y NTUlbknpPU9569oK9Y2mmLv4QPTd68bA5aISUJJSTetkLUwkgpW8DTfEfHwIdx4vqirD 8pBv3IICduVf9FswoD42odp4v0scf1aAzS0xIBChMRL54gM1CNxh8b1kkYRKwBX0XbTQ QOSQ== X-Gm-Message-State: ACgBeo1UoDKIc2kO4L4ZtBUxBluSbjC2WysN8Tjw2RnWNwwHVRGEZ1lw 1mnASiy51eLJxJ+BtYgHWZ1mBRneX5+KixPgWYCvqcUO8e8= X-Google-Smtp-Source: AA6agR5yM1bjKeeAHvCSktnAT6mnMkbq12RID7XquhX+ko1fNb/oSjoWD/MnTUKF+F1U1V3XtSvugn9aiIx0aMEHN9s= X-Received: by 2002:a17:907:a0c7:b0:77f:a9d2:9be2 with SMTP id hw7-20020a170907a0c700b0077fa9d29be2mr4317058ejc.352.1663086519833; Tue, 13 Sep 2022 09:28:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Olof Johansson Date: Tue, 13 Sep 2022 09:28:27 -0700 Message-ID: Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 To: Greg KH Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Saravana Kannan , Linux ARM Mailing List , Shawn Guo , Li Yang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220913_092844_884369_73E6639B X-CRM114-Status: GOOD ( 32.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 13, 2022 at 8:15 AM Greg KH wrote: > > On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > > > Hi, > > > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > > > Saravana Kannan (11): > > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > > driver core: Add wait_for_init_devices_probe helper function > > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > > driver core: Set fw_devlink.strict=1 by default > > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > > driver core: Delete driver_deferred_probe_check_state() > > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > > the machine I do maintainer work on). It stops PCIe from probing, but > > > without a single message indicating why. > > > > > > The reason seems to be that the iommu-maps property doesn't get > > > patched up by my (older) u-boot, and thus isn't a valid reference. > > > System works fine without IOMMU, which is how I've ran it for a couple > > > of years. > > > > > > It's also extremely hard to diagnose out of the box because there are > > > *no error messages*. And there were no warnings leading up to this > > > strict enforcement. > > > > > > This "feature" seems to have been done backwards. The checks should > > > have been running (and not skipped due to the "optional" flag), but > > > also not causing errors, just warnings. That would have given users a > > > chance to know that this is something that needs to be fixed. > > > > > > And when you flip the switch, at least report what failed so that > > > people don't need to spend a whole night bisecting kernels, please. > > > > > > Greg, mind reverting just the last one? If I hit this, I presume > > > others would too. > > > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > > fw_devlink.strict=1 by default", 71066545b48e42. > > Is this still an issue in -rc5? A number of patches in the above series > was just reverted and hopefully should have resolved the issue you are > seeing. Unfortunately, I discovered this regression with -rc5 in the first place, so it's still there. -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50583C54EE9 for ; Tue, 13 Sep 2022 17:38:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233244AbiIMRiU (ORCPT ); Tue, 13 Sep 2022 13:38:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232972AbiIMRh4 (ORCPT ); Tue, 13 Sep 2022 13:37:56 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EF5665557 for ; Tue, 13 Sep 2022 09:28:41 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id lz22so28832010ejb.3 for ; Tue, 13 Sep 2022 09:28:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=dqfDDt++wd3GzkJu7/rH2NUyW4xMIcqqDJ6iLNC291s=; b=MEim9D3xOue14jR/Jav6bQLoZi/hNv97yMe8hqfzvPzc9lQAfsx2Zldry2NXcUbKxT /csasHK5KWlUXQAoqovKKkX2mks4iPUgvPkRYuFhZvN9tgd+BbyBQlNoYRO64IILlGaa iOkKHn2BIsp33oxArNDx9ZgvjwS7iEZi/V1/JNM9uF7pH4ujynTaDtK+FLailmDNe5RL Zch+ys2WnGEcCsPAcmPbPgFzQoioYhHAVsSD/UWuoL6i0g3zbYzuHlOqfCdpgKxDRwl2 imUO++qhtU7LBoXETJI9c15zGiOvYHQ88EFThaI+OkUlp2b4PIhhMfhvlBrM4h+KvFB8 cOzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=dqfDDt++wd3GzkJu7/rH2NUyW4xMIcqqDJ6iLNC291s=; b=tcjFoBiNUqc7QKTBhmW3wdZGtfGlDIM5eJGpHe5ZseRaPDZiGEIww7WzYbc9g0gLIi TPVigrjnVZJ9eXZ91alDvRkSF1hEZc6TKyThnJf3GcseGvXH+5C3zG7gvfnAil0R952p O4Am/tQta/VaG99S2HZg8r5zQxRHbUumL1cORPwe+hz9etfq5pf/VGc//WpjZn5iCOF8 HSC46h86A/B+BWiXXst0UZHGXDqkn1ov4tZHLmUo+cJimcT8H2eHWxtmkKtRA2++aZxy SVkmCvFo08jKXAGSmkPeon0IBRprwPSirczL+yYZGgt52NPKsfMwB/nQImmHqhKukuCo i1sA== X-Gm-Message-State: ACgBeo2RKv6DS5DZurs1F2hsX/UbQf1B46TOpdjLPpgEFe9XeBFy13uA BlktNn57FaI4UAV6JSWQYY4z+g3W6Wj/N4wghNiRwg== X-Google-Smtp-Source: AA6agR5yM1bjKeeAHvCSktnAT6mnMkbq12RID7XquhX+ko1fNb/oSjoWD/MnTUKF+F1U1V3XtSvugn9aiIx0aMEHN9s= X-Received: by 2002:a17:907:a0c7:b0:77f:a9d2:9be2 with SMTP id hw7-20020a170907a0c700b0077fa9d29be2mr4317058ejc.352.1663086519833; Tue, 13 Sep 2022 09:28:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Olof Johansson Date: Tue, 13 Sep 2022 09:28:27 -0700 Message-ID: Subject: Re: [GIT PULL] Driver core changes for 6.0-rc1 To: Greg KH Cc: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, Stephen Rothwell , Saravana Kannan , Linux ARM Mailing List , Shawn Guo , Li Yang Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 13, 2022 at 8:15 AM Greg KH wrote: > > On Mon, Sep 12, 2022 at 10:24:43AM -0700, Olof Johansson wrote: > > On Mon, Sep 12, 2022 at 10:23 AM Olof Johansson wrote: > > > > > > Hi, > > > > > > On Wed, Aug 3, 2022 at 7:16 AM Greg KH wrote: > > > > > > > Saravana Kannan (11): > > > > PM: domains: Delete usage of driver_deferred_probe_check_state() > > > > pinctrl: devicetree: Delete usage of driver_deferred_probe_check_state() > > > > net: mdio: Delete usage of driver_deferred_probe_check_state() > > > > driver core: Add wait_for_init_devices_probe helper function > > > > net: ipconfig: Relax fw_devlink if we need to mount a network rootfs > > > > Revert "driver core: Set default deferred_probe_timeout back to 0." > > > > driver core: Set fw_devlink.strict=1 by default > > > > iommu/of: Delete usage of driver_deferred_probe_check_state() > > > > driver core: Delete driver_deferred_probe_check_state() > > > > driver core: fw_devlink: Allow firmware to mark devices as best effort > > > > of: base: Avoid console probe delay when fw_devlink.strict=1 > > > > > > The last patch in this list regresses my HoneyComb LX2K (ironically > > > the machine I do maintainer work on). It stops PCIe from probing, but > > > without a single message indicating why. > > > > > > The reason seems to be that the iommu-maps property doesn't get > > > patched up by my (older) u-boot, and thus isn't a valid reference. > > > System works fine without IOMMU, which is how I've ran it for a couple > > > of years. > > > > > > It's also extremely hard to diagnose out of the box because there are > > > *no error messages*. And there were no warnings leading up to this > > > strict enforcement. > > > > > > This "feature" seems to have been done backwards. The checks should > > > have been running (and not skipped due to the "optional" flag), but > > > also not causing errors, just warnings. That would have given users a > > > chance to know that this is something that needs to be fixed. > > > > > > And when you flip the switch, at least report what failed so that > > > people don't need to spend a whole night bisecting kernels, please. > > > > > > Greg, mind reverting just the last one? If I hit this, I presume > > > others would too. > > > > Apologies, wrong patch pointed out. The culprit is "driver core: Set > > fw_devlink.strict=1 by default", 71066545b48e42. > > Is this still an issue in -rc5? A number of patches in the above series > was just reverted and hopefully should have resolved the issue you are > seeing. Unfortunately, I discovered this regression with -rc5 in the first place, so it's still there. -Olof