From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B274C433E2 for ; Wed, 15 Jul 2020 06:46:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2951220663 for ; Wed, 15 Jul 2020 06:46:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="D+l25n5b" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728822AbgGOGq4 (ORCPT ); Wed, 15 Jul 2020 02:46:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726971AbgGOGqz (ORCPT ); Wed, 15 Jul 2020 02:46:55 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D71B7C061755 for ; Tue, 14 Jul 2020 23:46:55 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id i18so1039672ilk.10 for ; Tue, 14 Jul 2020 23:46:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ia+M7c1s6u4QzvRmg9F+yYUkSaBCxJOCiZePFvIuDVc=; b=D+l25n5bcv1TSbCDuyiTk2BK9pkdINNUwW67aGOacRlIyk0ySLjsGWzDcPBj31btQV uDr2HcZeXtm3d3NwwZOa3vRzLezh5c0YssPAMkbS4z+ueh4VLm6jhtIsezInCY+VOLYl BWZMjKveeau7A9dBxlUHol1MsZAX4gMmGiQ22HEQSAMHuE1v8qFSSyrhqJ/IvSH0bD1O mBebeftKbgCJRjoXd4nqNPwbuhndA7VOSBCMd+m7SUzXm4ERmEfKnrRO9kPL69Dl3KM4 KsO97+80nmLk1lFqu5rINAAxsAApi+EPfJlcn8P3YWd2UyctKlIKgf7jwSTcD25f0bRS 0frg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ia+M7c1s6u4QzvRmg9F+yYUkSaBCxJOCiZePFvIuDVc=; b=cOtpgff2rF+AvYFd+byHQNLf5esscBfk0nwbO0eAYyfVlL7bNDE18o6e2VGOgBbL4N UlgOq64PWWISCnVQ7SYOG3yv8dcfcK0JKnJz/D3JnP4JoBqalIu/w7JxJNI3S/al8SRB OMv+XaovTzLviSoSU4YTxetPMkxYboXwepooDhRihVsygaIeOc4d3l6YB4wFb0mc+/70 Fp8g1o4KG1jE7qNeRn5s3/hpj85Gt8mwGEhJKFfm+k7dhWYiHCrUQwvrpPyJ4cHT9HNi Ouwbk6I++6TnvvuFReUG/gu5BMYJtAGYkXhD9geP5W8mhHUTPfBzGUumzuGsyg04IV6w PYEQ== X-Gm-Message-State: AOAM532gJ3fpwrDgiXJZjgr2IzvUh9zJd0pDOzmL2EIkGWB8m98X32cZ HdUjGxPSCrZv/61rNPDUqTqMgzHYEwfG8ha4PFhUWw== X-Google-Smtp-Source: ABdhPJyNtTQ6tjiuB0fOsiGMKDn204hJD42fgcPc/S+ZwIlU4lbiCn47FJ7HiWLEM0DrOPmZUmzgdMVyttDg+xz5UnM= X-Received: by 2002:a92:49c3:: with SMTP id k64mr7793042ilg.278.1594795615165; Tue, 14 Jul 2020 23:46:55 -0700 (PDT) MIME-Version: 1.0 References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715063311.GP1398296@dell> In-Reply-To: <20200715063311.GP1398296@dell> From: Olof Johansson Date: Tue, 14 Jul 2020 23:46:44 -0700 Message-ID: Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header To: Lee Jones Cc: "Rafael J. Wysocki" , viresh kumar , Linux ARM Mailing List , Linux Kernel Mailing List , linux-pm@vger.kernel.org, Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , linuxppc-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 11:33 PM Lee Jones wrote: > > On Tue, 14 Jul 2020, Olof Johansson wrote: > > > On Tue, Jul 14, 2020 at 7:50 AM Lee Jones wrote: > > > > > > If function callers and providers do not share the same prototypes th= e > > > compiler complains of missing prototypes. Fix this by moving the > > > already existing prototypes out to a mutually convenient location. > > > > > > Fixes the following W=3D1 kernel build warning(s): > > > > > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototy= pe for =E2=80=98check_astate=E2=80=99 [-Wmissing-prototypes] > > > 109 | int check_astate(void) > > > | ^~~~~~~~~~~~ > > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototy= pe for =E2=80=98restore_astate=E2=80=99 [-Wmissing-prototypes] > > > 114 | void restore_astate(int cpu) > > > | ^~~~~~~~~~~~~~ > > > > > > Cc: Olof Johansson > > > Cc: Michael Ellerman > > > Cc: Benjamin Herrenschmidt > > > Cc: Paul Mackerras > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Signed-off-by: Lee Jones > > > --- > > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ > > > arch/powerpc/platforms/pasemi/powersave.S | 2 ++ > > > drivers/cpufreq/pasemi-cpufreq.c | 1 + > > > include/linux/platform_data/pasemi.h | 28 +++++++++++++++++++++= ++ > > > 4 files changed, 31 insertions(+), 15 deletions(-) > > > create mode 100644 include/linux/platform_data/pasemi.h > > > > > > diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/pl= atforms/pasemi/pasemi.h > > > index 70b56048ed1be..528d81ef748ad 100644 > > > --- a/arch/powerpc/platforms/pasemi/pasemi.h > > > +++ b/arch/powerpc/platforms/pasemi/pasemi.h > > > @@ -15,21 +15,6 @@ extern void __init pasemi_map_registers(void); > > > extern void idle_spin(void); > > > extern void idle_doze(void); > > > > > > -/* Restore astate to last set */ > > > -#ifdef CONFIG_PPC_PASEMI_CPUFREQ > > > -extern int check_astate(void); > > > -extern void restore_astate(int cpu); > > > -#else > > > -static inline int check_astate(void) > > > -{ > > > - /* Always return >0 so we never power save */ > > > - return 1; > > > -} > > > -static inline void restore_astate(int cpu) > > > -{ > > > -} > > > -#endif > > > - > > > extern struct pci_controller_ops pasemi_pci_controller_ops; > > > > > > #endif /* _PASEMI_PASEMI_H */ > > > diff --git a/arch/powerpc/platforms/pasemi/powersave.S b/arch/powerpc= /platforms/pasemi/powersave.S > > > index d0215d5329ca7..7747b48963286 100644 > > > --- a/arch/powerpc/platforms/pasemi/powersave.S > > > +++ b/arch/powerpc/platforms/pasemi/powersave.S > > > @@ -5,6 +5,8 @@ > > > * Maintained by: Olof Johansson > > > */ > > > > > > +#include > > > + > > > #include > > > #include > > > #include > > > diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasem= i-cpufreq.c > > > index c66f566a854cb..c6bb3ecc90ef3 100644 > > > --- a/drivers/cpufreq/pasemi-cpufreq.c > > > +++ b/drivers/cpufreq/pasemi-cpufreq.c > > > @@ -15,6 +15,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include > > > #include > > > diff --git a/include/linux/platform_data/pasemi.h b/include/linux/pla= tform_data/pasemi.h > > > new file mode 100644 > > > index 0000000000000..3fed0687fcc9a > > > --- /dev/null > > > +++ b/include/linux/platform_data/pasemi.h > > > @@ -0,0 +1,28 @@ > > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > > +/* > > > + * Copyright (C) 2020 Linaro Ltd. > > > + * > > > + * Author: Lee Jones > > > + */ > > > > Absolutely not. It's neither your copyright, nor your authorship. > > The file was new. Anyway, the point is now moot. The contents was copied and pasted from other material, not originally produced by you. I suggest you consult with Linaro lawyers on how to handle this if you have to do something like it in the future. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E44FC433E1 for ; Wed, 15 Jul 2020 06:49:11 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF50320663 for ; Wed, 15 Jul 2020 06:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="D+l25n5b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF50320663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lixom.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4B67K00hQBzDqFB for ; Wed, 15 Jul 2020 16:49:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lixom.net (client-ip=2607:f8b0:4864:20::143; helo=mail-il1-x143.google.com; envelope-from=olof@lixom.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=lixom.net Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=D+l25n5b; dkim-atps=neutral Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4B67GV6tzdzDqg8 for ; Wed, 15 Jul 2020 16:46:58 +1000 (AEST) Received: by mail-il1-x143.google.com with SMTP id h16so1044420ilj.11 for ; Tue, 14 Jul 2020 23:46:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ia+M7c1s6u4QzvRmg9F+yYUkSaBCxJOCiZePFvIuDVc=; b=D+l25n5bcv1TSbCDuyiTk2BK9pkdINNUwW67aGOacRlIyk0ySLjsGWzDcPBj31btQV uDr2HcZeXtm3d3NwwZOa3vRzLezh5c0YssPAMkbS4z+ueh4VLm6jhtIsezInCY+VOLYl BWZMjKveeau7A9dBxlUHol1MsZAX4gMmGiQ22HEQSAMHuE1v8qFSSyrhqJ/IvSH0bD1O mBebeftKbgCJRjoXd4nqNPwbuhndA7VOSBCMd+m7SUzXm4ERmEfKnrRO9kPL69Dl3KM4 KsO97+80nmLk1lFqu5rINAAxsAApi+EPfJlcn8P3YWd2UyctKlIKgf7jwSTcD25f0bRS 0frg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ia+M7c1s6u4QzvRmg9F+yYUkSaBCxJOCiZePFvIuDVc=; b=Ooyev9+Z7KOxb1ZrQava0C4q5EZNTjJZWNe0a0pv/IiZds6HSbjAzMyLh4azXCTTeg MYQq/TLvLO3DD2B23JL53C5nN8QTQCgjuTueNPlVp9EOTCXj7orjcV4wnyXSWz7vY0Ry dzon6roFUrFPtyhWqpFDOnljYOYaJR/vkWsOnRaYh5VxTx93QtePoLXvWQJhpScsk14y VgMsXC9fPrXJuPwW5dfIpdY+1oLtGNDmKAltRUTEYWGiNP9OktYbQpuoM9rlJJ5TaxhN OOgWGbmMmDwDsPRol7SATorSRzx6CTuQwGOUb/sbVo30cGkcPlT4iSLIXV/nq3sRuV3E aWpw== X-Gm-Message-State: AOAM530qJV0UtLHuegOPkqlAuUNTWMmIXv8gLYEo6JYzXh+28T/6WpLM e8ppP57sBxShPem8Is+dGinEv0UQ4fLzZHjDwhjwcg== X-Google-Smtp-Source: ABdhPJyNtTQ6tjiuB0fOsiGMKDn204hJD42fgcPc/S+ZwIlU4lbiCn47FJ7HiWLEM0DrOPmZUmzgdMVyttDg+xz5UnM= X-Received: by 2002:a92:49c3:: with SMTP id k64mr7793042ilg.278.1594795615165; Tue, 14 Jul 2020 23:46:55 -0700 (PDT) MIME-Version: 1.0 References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715063311.GP1398296@dell> In-Reply-To: <20200715063311.GP1398296@dell> From: Olof Johansson Date: Tue, 14 Jul 2020 23:46:44 -0700 Message-ID: Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header To: Lee Jones Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" , Linux Kernel Mailing List , Paul Mackerras , viresh kumar , linuxppc-dev , Linux ARM Mailing List Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, Jul 14, 2020 at 11:33 PM Lee Jones wrote: > > On Tue, 14 Jul 2020, Olof Johansson wrote: > > > On Tue, Jul 14, 2020 at 7:50 AM Lee Jones wrote: > > > > > > If function callers and providers do not share the same prototypes th= e > > > compiler complains of missing prototypes. Fix this by moving the > > > already existing prototypes out to a mutually convenient location. > > > > > > Fixes the following W=3D1 kernel build warning(s): > > > > > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototy= pe for =E2=80=98check_astate=E2=80=99 [-Wmissing-prototypes] > > > 109 | int check_astate(void) > > > | ^~~~~~~~~~~~ > > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototy= pe for =E2=80=98restore_astate=E2=80=99 [-Wmissing-prototypes] > > > 114 | void restore_astate(int cpu) > > > | ^~~~~~~~~~~~~~ > > > > > > Cc: Olof Johansson > > > Cc: Michael Ellerman > > > Cc: Benjamin Herrenschmidt > > > Cc: Paul Mackerras > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Signed-off-by: Lee Jones > > > --- > > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------ > > > arch/powerpc/platforms/pasemi/powersave.S | 2 ++ > > > drivers/cpufreq/pasemi-cpufreq.c | 1 + > > > include/linux/platform_data/pasemi.h | 28 +++++++++++++++++++++= ++ > > > 4 files changed, 31 insertions(+), 15 deletions(-) > > > create mode 100644 include/linux/platform_data/pasemi.h > > > > > > diff --git a/arch/powerpc/platforms/pasemi/pasemi.h b/arch/powerpc/pl= atforms/pasemi/pasemi.h > > > index 70b56048ed1be..528d81ef748ad 100644 > > > --- a/arch/powerpc/platforms/pasemi/pasemi.h > > > +++ b/arch/powerpc/platforms/pasemi/pasemi.h > > > @@ -15,21 +15,6 @@ extern void __init pasemi_map_registers(void); > > > extern void idle_spin(void); > > > extern void idle_doze(void); > > > > > > -/* Restore astate to last set */ > > > -#ifdef CONFIG_PPC_PASEMI_CPUFREQ > > > -extern int check_astate(void); > > > -extern void restore_astate(int cpu); > > > -#else > > > -static inline int check_astate(void) > > > -{ > > > - /* Always return >0 so we never power save */ > > > - return 1; > > > -} > > > -static inline void restore_astate(int cpu) > > > -{ > > > -} > > > -#endif > > > - > > > extern struct pci_controller_ops pasemi_pci_controller_ops; > > > > > > #endif /* _PASEMI_PASEMI_H */ > > > diff --git a/arch/powerpc/platforms/pasemi/powersave.S b/arch/powerpc= /platforms/pasemi/powersave.S > > > index d0215d5329ca7..7747b48963286 100644 > > > --- a/arch/powerpc/platforms/pasemi/powersave.S > > > +++ b/arch/powerpc/platforms/pasemi/powersave.S > > > @@ -5,6 +5,8 @@ > > > * Maintained by: Olof Johansson > > > */ > > > > > > +#include > > > + > > > #include > > > #include > > > #include > > > diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasem= i-cpufreq.c > > > index c66f566a854cb..c6bb3ecc90ef3 100644 > > > --- a/drivers/cpufreq/pasemi-cpufreq.c > > > +++ b/drivers/cpufreq/pasemi-cpufreq.c > > > @@ -15,6 +15,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include > > > #include > > > diff --git a/include/linux/platform_data/pasemi.h b/include/linux/pla= tform_data/pasemi.h > > > new file mode 100644 > > > index 0000000000000..3fed0687fcc9a > > > --- /dev/null > > > +++ b/include/linux/platform_data/pasemi.h > > > @@ -0,0 +1,28 @@ > > > +/* SPDX-License-Identifier: GPL-2.0-only */ > > > +/* > > > + * Copyright (C) 2020 Linaro Ltd. > > > + * > > > + * Author: Lee Jones > > > + */ > > > > Absolutely not. It's neither your copyright, nor your authorship. > > The file was new. Anyway, the point is now moot. The contents was copied and pasted from other material, not originally produced by you. I suggest you consult with Linaro lawyers on how to handle this if you have to do something like it in the future. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72F0EC433DF for ; Wed, 15 Jul 2020 06:48:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3404720663 for ; Wed, 15 Jul 2020 06:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="x2zK1dr2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lixom-net.20150623.gappssmtp.com header.i=@lixom-net.20150623.gappssmtp.com header.b="D+l25n5b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3404720663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lixom.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P1ZgV/rdkTCS5LlMJVYwNtMiswvr0BzKKdarBFraDLU=; b=x2zK1dr2JNgr8VOYyXUFouQFa EtOgNOHgkFBiMNrNDtwT8iRM7xAMBDwe1No0xNhq6pvVMNyHN5DiMRLPTfDUaHX3dAUOqJ4nRyUc2 0xQa83lA2pez72zPCVhN5FDw5rCPHTDnxvQsFqvmyRBdyct3MR3y3bJq34j/gNyePOipb2NBctFMF 3J337ik7R8bkrQmAU9aarXgOUV0kXZzIYWW9hZBLumkXEow2wV3HiYcivLmaUvCrck4+GPT/lBh7n UWhbfRR1ZVtGFloYcLHF3lB4mKcQE5d7IjAETI7vzk8HWXbmemavj+ISiHHtqUajbwOpZUjlzoPTK 5CF0PuY0w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvbC0-0003ue-Jj; Wed, 15 Jul 2020 06:47:00 +0000 Received: from mail-il1-x144.google.com ([2607:f8b0:4864:20::144]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jvbBx-0003tU-Ev for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2020 06:46:58 +0000 Received: by mail-il1-x144.google.com with SMTP id s21so1067166ilk.5 for ; Tue, 14 Jul 2020 23:46:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Ia+M7c1s6u4QzvRmg9F+yYUkSaBCxJOCiZePFvIuDVc=; b=D+l25n5bcv1TSbCDuyiTk2BK9pkdINNUwW67aGOacRlIyk0ySLjsGWzDcPBj31btQV uDr2HcZeXtm3d3NwwZOa3vRzLezh5c0YssPAMkbS4z+ueh4VLm6jhtIsezInCY+VOLYl BWZMjKveeau7A9dBxlUHol1MsZAX4gMmGiQ22HEQSAMHuE1v8qFSSyrhqJ/IvSH0bD1O mBebeftKbgCJRjoXd4nqNPwbuhndA7VOSBCMd+m7SUzXm4ERmEfKnrRO9kPL69Dl3KM4 KsO97+80nmLk1lFqu5rINAAxsAApi+EPfJlcn8P3YWd2UyctKlIKgf7jwSTcD25f0bRS 0frg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Ia+M7c1s6u4QzvRmg9F+yYUkSaBCxJOCiZePFvIuDVc=; b=TSaLcLnsuNOipIhfYX480FOjZQiiF7fZZGTF6fUCZ4/Id1NiRdn3opaxPmDxXI7Egy 32Wx+6LcKl1x5674r3vgowKVypEciNjToSgRh8jse+AXLRqqVzhKnGAQ6Xsdw1Y9cYiF qXEfvnynuFX/oSb5iThh8ax8N+F/DS6vUnPpZ0l3ATMsUWW+ZNpCxECNNrbwLrybTqDj uI+2W/hEq5qk/pEQ8Wq0pBADR5pBmCXpc9uMsDuSfqzpZmnXbcZYhI6QqMZ/Dik66BBJ iBf/Q9Caq8oTYtycU1cye285H27fKH5kiXdjWtS0oi1X3pV1bDxPDEBUkznVZA8i0+F4 K6hw== X-Gm-Message-State: AOAM53009dodWwIQJAWnJP0c4IsLhe3UQjyB+YmGmVdO9fnWxTZqMXkn dbhqGrw7RWP56ERUteJNUdiT0SmiZmaE3WS6GrEBZJ0BeEQ= X-Google-Smtp-Source: ABdhPJyNtTQ6tjiuB0fOsiGMKDn204hJD42fgcPc/S+ZwIlU4lbiCn47FJ7HiWLEM0DrOPmZUmzgdMVyttDg+xz5UnM= X-Received: by 2002:a92:49c3:: with SMTP id k64mr7793042ilg.278.1594795615165; Tue, 14 Jul 2020 23:46:55 -0700 (PDT) MIME-Version: 1.0 References: <20200714145049.2496163-1-lee.jones@linaro.org> <20200714145049.2496163-6-lee.jones@linaro.org> <20200715063311.GP1398296@dell> In-Reply-To: <20200715063311.GP1398296@dell> From: Olof Johansson Date: Tue, 14 Jul 2020 23:46:44 -0700 Message-ID: Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header To: Lee Jones X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200715_024657_521398_2F8CAEBE X-CRM114-Status: GOOD ( 23.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Benjamin Herrenschmidt , linux-pm@vger.kernel.org, Michael Ellerman , "Rafael J. Wysocki" , Linux Kernel Mailing List , Paul Mackerras , viresh kumar , linuxppc-dev , Linux ARM Mailing List Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBKdWwgMTQsIDIwMjAgYXQgMTE6MzMgUE0gTGVlIEpvbmVzIDxsZWUuam9uZXNAbGlu YXJvLm9yZz4gd3JvdGU6Cj4KPiBPbiBUdWUsIDE0IEp1bCAyMDIwLCBPbG9mIEpvaGFuc3NvbiB3 cm90ZToKPgo+ID4gT24gVHVlLCBKdWwgMTQsIDIwMjAgYXQgNzo1MCBBTSBMZWUgSm9uZXMgPGxl ZS5qb25lc0BsaW5hcm8ub3JnPiB3cm90ZToKPiA+ID4KPiA+ID4gSWYgZnVuY3Rpb24gY2FsbGVy cyBhbmQgcHJvdmlkZXJzIGRvIG5vdCBzaGFyZSB0aGUgc2FtZSBwcm90b3R5cGVzIHRoZQo+ID4g PiBjb21waWxlciBjb21wbGFpbnMgb2YgbWlzc2luZyBwcm90b3R5cGVzLiAgRml4IHRoaXMgYnkg bW92aW5nIHRoZQo+ID4gPiBhbHJlYWR5IGV4aXN0aW5nIHByb3RvdHlwZXMgb3V0IHRvIGEgbXV0 dWFsbHkgY29udmVuaWVudCBsb2NhdGlvbi4KPiA+ID4KPiA+ID4gRml4ZXMgdGhlIGZvbGxvd2lu ZyBXPTEga2VybmVsIGJ1aWxkIHdhcm5pbmcocyk6Cj4gPiA+Cj4gPiA+ICBkcml2ZXJzL2NwdWZy ZXEvcGFzZW1pLWNwdWZyZXEuYzoxMDk6NTogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBl IGZvciDigJhjaGVja19hc3RhdGXigJkgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+ID4gPiAgMTA5 IHwgaW50IGNoZWNrX2FzdGF0ZSh2b2lkKQo+ID4gPiAgfCBefn5+fn5+fn5+fn4KPiA+ID4gIGRy aXZlcnMvY3B1ZnJlcS9wYXNlbWktY3B1ZnJlcS5jOjExNDo2OiB3YXJuaW5nOiBubyBwcmV2aW91 cyBwcm90b3R5cGUgZm9yIOKAmHJlc3RvcmVfYXN0YXRl4oCZIFstV21pc3NpbmctcHJvdG90eXBl c10KPiA+ID4gIDExNCB8IHZvaWQgcmVzdG9yZV9hc3RhdGUoaW50IGNwdSkKPiA+ID4gIHwgXn5+ fn5+fn5+fn5+fn4KPiA+ID4KPiA+ID4gQ2M6IE9sb2YgSm9oYW5zc29uIDxvbG9mQGxpeG9tLm5l dD4KPiA+ID4gQ2M6IE1pY2hhZWwgRWxsZXJtYW4gPG1wZUBlbGxlcm1hbi5pZC5hdT4KPiA+ID4g Q2M6IEJlbmphbWluIEhlcnJlbnNjaG1pZHQgPGJlbmhAa2VybmVsLmNyYXNoaW5nLm9yZz4KPiA+ ID4gQ2M6IFBhdWwgTWFja2VycmFzIDxwYXVsdXNAc2FtYmEub3JnPgo+ID4gPiBDYzogbGludXhw cGMtZGV2QGxpc3RzLm96bGFicy5vcmcKPiA+ID4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxs ZWUuam9uZXNAbGluYXJvLm9yZz4KPiA+ID4gLS0tCj4gPiA+ICBhcmNoL3Bvd2VycGMvcGxhdGZv cm1zL3Bhc2VtaS9wYXNlbWkuaCAgICB8IDE1IC0tLS0tLS0tLS0tLQo+ID4gPiAgYXJjaC9wb3dl cnBjL3BsYXRmb3Jtcy9wYXNlbWkvcG93ZXJzYXZlLlMgfCAgMiArKwo+ID4gPiAgZHJpdmVycy9j cHVmcmVxL3Bhc2VtaS1jcHVmcmVxLmMgICAgICAgICAgfCAgMSArCj4gPiA+ICBpbmNsdWRlL2xp bnV4L3BsYXRmb3JtX2RhdGEvcGFzZW1pLmggICAgICB8IDI4ICsrKysrKysrKysrKysrKysrKysr KysrCj4gPiA+ICA0IGZpbGVzIGNoYW5nZWQsIDMxIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9u cygtKQo+ID4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvcGxhdGZvcm1fZGF0 YS9wYXNlbWkuaAo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL3BsYXRmb3Jt cy9wYXNlbWkvcGFzZW1pLmggYi9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zL3Bhc2VtaS9wYXNlbWku aAo+ID4gPiBpbmRleCA3MGI1NjA0OGVkMWJlLi41MjhkODFlZjc0OGFkIDEwMDY0NAo+ID4gPiAt LS0gYS9hcmNoL3Bvd2VycGMvcGxhdGZvcm1zL3Bhc2VtaS9wYXNlbWkuaAo+ID4gPiArKysgYi9h cmNoL3Bvd2VycGMvcGxhdGZvcm1zL3Bhc2VtaS9wYXNlbWkuaAo+ID4gPiBAQCAtMTUsMjEgKzE1 LDYgQEAgZXh0ZXJuIHZvaWQgX19pbml0IHBhc2VtaV9tYXBfcmVnaXN0ZXJzKHZvaWQpOwo+ID4g PiAgZXh0ZXJuIHZvaWQgaWRsZV9zcGluKHZvaWQpOwo+ID4gPiAgZXh0ZXJuIHZvaWQgaWRsZV9k b3plKHZvaWQpOwo+ID4gPgo+ID4gPiAtLyogUmVzdG9yZSBhc3RhdGUgdG8gbGFzdCBzZXQgKi8K PiA+ID4gLSNpZmRlZiBDT05GSUdfUFBDX1BBU0VNSV9DUFVGUkVRCj4gPiA+IC1leHRlcm4gaW50 IGNoZWNrX2FzdGF0ZSh2b2lkKTsKPiA+ID4gLWV4dGVybiB2b2lkIHJlc3RvcmVfYXN0YXRlKGlu dCBjcHUpOwo+ID4gPiAtI2Vsc2UKPiA+ID4gLXN0YXRpYyBpbmxpbmUgaW50IGNoZWNrX2FzdGF0 ZSh2b2lkKQo+ID4gPiAtewo+ID4gPiAtICAgICAgIC8qIEFsd2F5cyByZXR1cm4gPjAgc28gd2Ug bmV2ZXIgcG93ZXIgc2F2ZSAqLwo+ID4gPiAtICAgICAgIHJldHVybiAxOwo+ID4gPiAtfQo+ID4g PiAtc3RhdGljIGlubGluZSB2b2lkIHJlc3RvcmVfYXN0YXRlKGludCBjcHUpCj4gPiA+IC17Cj4g PiA+IC19Cj4gPiA+IC0jZW5kaWYKPiA+ID4gLQo+ID4gPiAgZXh0ZXJuIHN0cnVjdCBwY2lfY29u dHJvbGxlcl9vcHMgcGFzZW1pX3BjaV9jb250cm9sbGVyX29wczsKPiA+ID4KPiA+ID4gICNlbmRp ZiAvKiBfUEFTRU1JX1BBU0VNSV9IICovCj4gPiA+IGRpZmYgLS1naXQgYS9hcmNoL3Bvd2VycGMv cGxhdGZvcm1zL3Bhc2VtaS9wb3dlcnNhdmUuUyBiL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcGFz ZW1pL3Bvd2Vyc2F2ZS5TCj4gPiA+IGluZGV4IGQwMjE1ZDUzMjljYTcuLjc3NDdiNDg5NjMyODYg MTAwNjQ0Cj4gPiA+IC0tLSBhL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcGFzZW1pL3Bvd2Vyc2F2 ZS5TCj4gPiA+ICsrKyBiL2FyY2gvcG93ZXJwYy9wbGF0Zm9ybXMvcGFzZW1pL3Bvd2Vyc2F2ZS5T Cj4gPiA+IEBAIC01LDYgKzUsOCBAQAo+ID4gPiAgICogTWFpbnRhaW5lZCBieTogT2xvZiBKb2hh bnNzb24gPG9sb2ZAbGl4b20ubmV0Pgo+ID4gPiAgICovCj4gPiA+Cj4gPiA+ICsjaW5jbHVkZSA8 bGludXgvcGxhdGZvcm1fZGF0YS9wYXNlbWkuaD4KPiA+ID4gKwo+ID4gPiAgI2luY2x1ZGUgPGFz bS9wcm9jZXNzb3IuaD4KPiA+ID4gICNpbmNsdWRlIDxhc20vcGFnZS5oPgo+ID4gPiAgI2luY2x1 ZGUgPGFzbS9wcGNfYXNtLmg+Cj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2NwdWZyZXEvcGFz ZW1pLWNwdWZyZXEuYyBiL2RyaXZlcnMvY3B1ZnJlcS9wYXNlbWktY3B1ZnJlcS5jCj4gPiA+IGlu ZGV4IGM2NmY1NjZhODU0Y2IuLmM2YmIzZWNjOTBlZjMgMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZl cnMvY3B1ZnJlcS9wYXNlbWktY3B1ZnJlcS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMvY3B1ZnJlcS9w YXNlbWktY3B1ZnJlcS5jCj4gPiA+IEBAIC0xNSw2ICsxNSw3IEBACj4gPiA+ICAjaW5jbHVkZSA8 bGludXgvdGltZXIuaD4KPiA+ID4gICNpbmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KPiA+ID4gICNp bmNsdWRlIDxsaW51eC9vZl9hZGRyZXNzLmg+Cj4gPiA+ICsjaW5jbHVkZSA8bGludXgvcGxhdGZv cm1fZGF0YS9wYXNlbWkuaD4KPiA+ID4KPiA+ID4gICNpbmNsdWRlIDxhc20vaHdfaXJxLmg+Cj4g PiA+ICAjaW5jbHVkZSA8YXNtL2lvLmg+Cj4gPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4 L3BsYXRmb3JtX2RhdGEvcGFzZW1pLmggYi9pbmNsdWRlL2xpbnV4L3BsYXRmb3JtX2RhdGEvcGFz ZW1pLmgKPiA+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ID4gaW5kZXggMDAwMDAwMDAwMDAw MC4uM2ZlZDA2ODdmY2M5YQo+ID4gPiAtLS0gL2Rldi9udWxsCj4gPiA+ICsrKyBiL2luY2x1ZGUv bGludXgvcGxhdGZvcm1fZGF0YS9wYXNlbWkuaAo+ID4gPiBAQCAtMCwwICsxLDI4IEBACj4gPiA+ ICsvKiBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1vbmx5ICovCj4gPiA+ICsvKgo+ ID4gPiArICogQ29weXJpZ2h0IChDKSAyMDIwIExpbmFybyBMdGQuCj4gPiA+ICsgKgo+ID4gPiAr ICogQXV0aG9yOiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+ID4gPiArICovCj4g Pgo+ID4gQWJzb2x1dGVseSBub3QuIEl0J3MgbmVpdGhlciB5b3VyIGNvcHlyaWdodCwgbm9yIHlv dXIgYXV0aG9yc2hpcC4KPgo+IFRoZSBmaWxlIHdhcyBuZXcuICBBbnl3YXksIHRoZSBwb2ludCBp cyBub3cgbW9vdC4KClRoZSBjb250ZW50cyB3YXMgY29waWVkIGFuZCBwYXN0ZWQgZnJvbSBvdGhl ciBtYXRlcmlhbCwgbm90IG9yaWdpbmFsbHkKcHJvZHVjZWQgYnkgeW91LgoKSSBzdWdnZXN0IHlv dSBjb25zdWx0IHdpdGggTGluYXJvIGxhd3llcnMgb24gaG93IHRvIGhhbmRsZSB0aGlzIGlmIHlv dQpoYXZlIHRvIGRvIHNvbWV0aGluZyBsaWtlIGl0IGluIHRoZSBmdXR1cmUuCgoKLU9sb2YKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK