From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Date: Wed, 29 Jan 2014 19:02:28 +0000 Subject: Re: [PATCH v2 5/6] X86: remove redundant cpuidle_idle_call() Message-Id: List-Id: References: <1391017513-12995-1-git-send-email-nicolas.pitre@linaro.org> <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> In-Reply-To: <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hi, On Wed, Jan 29, 2014 at 9:45 AM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > Acked-by: Daniel Lezcano > --- > arch/x86/kernel/process.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > index 3fb8d95ab8..4505e2a950 100644 > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void) > */ > void arch_cpu_idle(void) > { > - if (cpuidle_idle_call()) > - x86_idle(); > - else > - local_irq_enable(); > + x86_idle(); You're taking out the local_irq_enable() here but I don't see the equivalent of adding it back in the 1/6 patch that moves the cpuidle_idle_call() up to common code. It seems that one of the call paths through cpuidle_idle_call() don't re-enable it on its own. Even if this is the right thing to do, why it's OK to do so should probably be documented in the patch description. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbaA2TCc (ORCPT ); Wed, 29 Jan 2014 14:02:32 -0500 Received: from mail-qa0-f49.google.com ([209.85.216.49]:33144 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbaA2TC3 (ORCPT ); Wed, 29 Jan 2014 14:02:29 -0500 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:1b02:b13b:1c47:4c90:eb03] In-Reply-To: <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> References: <1391017513-12995-1-git-send-email-nicolas.pitre@linaro.org> <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> Date: Wed, 29 Jan 2014 11:02:28 -0800 Message-ID: Subject: Re: [PATCH v2 5/6] X86: remove redundant cpuidle_idle_call() From: Olof Johansson To: Nicolas Pitre Cc: Russell King , Benjamin Herrenschmidt , Preeti U Murthy , Paul Mundt , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" , Daniel Lezcano , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linuxppc-dev , Linux-sh list , linux-pm@vger.kernel.org, "linaro-kernel@lists.linaro.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Jan 29, 2014 at 9:45 AM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > Acked-by: Daniel Lezcano > --- > arch/x86/kernel/process.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > index 3fb8d95ab8..4505e2a950 100644 > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void) > */ > void arch_cpu_idle(void) > { > - if (cpuidle_idle_call()) > - x86_idle(); > - else > - local_irq_enable(); > + x86_idle(); You're taking out the local_irq_enable() here but I don't see the equivalent of adding it back in the 1/6 patch that moves the cpuidle_idle_call() up to common code. It seems that one of the call paths through cpuidle_idle_call() don't re-enable it on its own. Even if this is the right thing to do, why it's OK to do so should probably be documented in the patch description. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olof Johansson Subject: Re: [PATCH v2 5/6] X86: remove redundant cpuidle_idle_call() Date: Wed, 29 Jan 2014 11:02:28 -0800 Message-ID: References: <1391017513-12995-1-git-send-email-nicolas.pitre@linaro.org> <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> Sender: linux-sh-owner@vger.kernel.org To: Nicolas Pitre Cc: Russell King , Benjamin Herrenschmidt , Preeti U Murthy , Paul Mundt , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , "Rafael J. Wysocki" , Daniel Lezcano , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linuxppc-dev , Linux-sh list , linux-pm@vger.kernel.org, "linaro-kernel@lists.linaro.org" List-Id: linux-pm@vger.kernel.org Hi, On Wed, Jan 29, 2014 at 9:45 AM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > Acked-by: Daniel Lezcano > --- > arch/x86/kernel/process.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > index 3fb8d95ab8..4505e2a950 100644 > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void) > */ > void arch_cpu_idle(void) > { > - if (cpuidle_idle_call()) > - x86_idle(); > - else > - local_irq_enable(); > + x86_idle(); You're taking out the local_irq_enable() here but I don't see the equivalent of adding it back in the 1/6 patch that moves the cpuidle_idle_call() up to common code. It seems that one of the call paths through cpuidle_idle_call() don't re-enable it on its own. Even if this is the right thing to do, why it's OK to do so should probably be documented in the patch description. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f170.google.com (mail-qc0-f170.google.com [209.85.216.170]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id AF50A2C00CE for ; Thu, 30 Jan 2014 06:02:33 +1100 (EST) Received: by mail-qc0-f170.google.com with SMTP id e9so3435278qcy.15 for ; Wed, 29 Jan 2014 11:02:29 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> References: <1391017513-12995-1-git-send-email-nicolas.pitre@linaro.org> <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> Date: Wed, 29 Jan 2014 11:02:28 -0800 Message-ID: Subject: Re: [PATCH v2 5/6] X86: remove redundant cpuidle_idle_call() From: Olof Johansson To: Nicolas Pitre Content-Type: text/plain; charset=ISO-8859-1 Cc: "linaro-kernel@lists.linaro.org" , Russell King , Linux-sh list , Peter Zijlstra , linux-pm@vger.kernel.org, Daniel Lezcano , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Paul Mundt , Preeti U Murthy , Thomas Gleixner , linuxppc-dev , Ingo Molnar , "linux-arm-kernel@lists.infradead.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, On Wed, Jan 29, 2014 at 9:45 AM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > Acked-by: Daniel Lezcano > --- > arch/x86/kernel/process.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > index 3fb8d95ab8..4505e2a950 100644 > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void) > */ > void arch_cpu_idle(void) > { > - if (cpuidle_idle_call()) > - x86_idle(); > - else > - local_irq_enable(); > + x86_idle(); You're taking out the local_irq_enable() here but I don't see the equivalent of adding it back in the 1/6 patch that moves the cpuidle_idle_call() up to common code. It seems that one of the call paths through cpuidle_idle_call() don't re-enable it on its own. Even if this is the right thing to do, why it's OK to do so should probably be documented in the patch description. -Olof From mboxrd@z Thu Jan 1 00:00:00 1970 From: olof@lixom.net (Olof Johansson) Date: Wed, 29 Jan 2014 11:02:28 -0800 Subject: [PATCH v2 5/6] X86: remove redundant cpuidle_idle_call() In-Reply-To: <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> References: <1391017513-12995-1-git-send-email-nicolas.pitre@linaro.org> <1391017513-12995-6-git-send-email-nicolas.pitre@linaro.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Wed, Jan 29, 2014 at 9:45 AM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > Acked-by: Daniel Lezcano > --- > arch/x86/kernel/process.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > index 3fb8d95ab8..4505e2a950 100644 > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -298,10 +298,7 @@ void arch_cpu_idle_dead(void) > */ > void arch_cpu_idle(void) > { > - if (cpuidle_idle_call()) > - x86_idle(); > - else > - local_irq_enable(); > + x86_idle(); You're taking out the local_irq_enable() here but I don't see the equivalent of adding it back in the 1/6 patch that moves the cpuidle_idle_call() up to common code. It seems that one of the call paths through cpuidle_idle_call() don't re-enable it on its own. Even if this is the right thing to do, why it's OK to do so should probably be documented in the patch description. -Olof