From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966620AbeCAJEU (ORCPT ); Thu, 1 Mar 2018 04:04:20 -0500 Received: from mail-it0-f67.google.com ([209.85.214.67]:35745 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965281AbeCAJEM (ORCPT ); Thu, 1 Mar 2018 04:04:12 -0500 X-Google-Smtp-Source: AG47ELv8MFNYdz9KYRJEA41XpHYpWRX47Zr2AWWnt4AJmSsSwyXMpN2hjWcsZh4tStk0ODHTfVCaSqZwX/c9r5W/NpM= MIME-Version: 1.0 In-Reply-To: <20180301084315.0811f712@dell-desktop.home> References: <20180227212433.2189-1-mylene.josserand@bootlin.com> <20180227212433.2189-2-mylene.josserand@bootlin.com> <20180227225140.6f9902b8@windsurf.lan> <20180301084315.0811f712@dell-desktop.home> From: Michael Nazzareno Trimarchi Date: Thu, 1 Mar 2018 10:04:11 +0100 Message-ID: Subject: Re: [alsa-devel] [PATCH v1 1/4] ASoC: codecs: pcm179x: Add PCM1789 id To: =?UTF-8?Q?Myl=C3=A8ne_Josserand?= Cc: Thomas Petazzoni , Mark Rutland , devicetree@vger.kernel.org, Linux-ALSA , alexandre.belloni@bootlin.com, LKML , Takashi Iwai , Rob Herring , Liam Girdwood , Mark Brown Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w2194Pp5010281 Hi On Thu, Mar 1, 2018 at 8:43 AM, Mylène Josserand wrote: > Hello, > > Thank you for the review. > > On Tue, 27 Feb 2018 22:51:40 +0100 > Thomas Petazzoni wrote: > >> Hello, >> >> On Tue, 27 Feb 2018 22:24:30 +0100, Mylène Josserand wrote: >> > To prepare the support for the PCM1789, add a new compatible >> > and use the i2c_id to handle, later, the differences between >> > these two DACs even if they are pretty similar. >> > >> > Signed-off-by: Mylène Josserand >> > --- >> > Documentation/devicetree/bindings/sound/pcm179x.txt | 2 +- >> >> The DT binding change should be in a separate patch. >> >> > sound/soc/codecs/pcm179x-i2c.c | 6 ++++-- >> > sound/soc/codecs/pcm179x.c | 3 ++- >> > sound/soc/codecs/pcm179x.h | 8 +++++++- >> >> And this should be together with the PCM1789 support patch. Otherwise >> your series is not bisectable: if we apply only PATCH 1/4, the driver >> supports the new compatible string, but it doesn't have the actual code >> to handle PCM1789. Am I missing something here ? > > No, you are right, I will merge it with patch 02. > Can you please include me in next series? I have several hardware running on pcm179x family Michael >> >> > - return pcm179x_common_init(&client->dev, regmap); >> > + return pcm179x_common_init(&client->dev, regmap, id->driver_data); >> >> This can be done in a preparation patch. >> >> > } >> > >> > static const struct of_device_id pcm179x_of_match[] = { >> > { .compatible = "ti,pcm1792a", }, >> > + { .compatible = "ti,pcm1789", }, >> > { } >> > }; >> > MODULE_DEVICE_TABLE(of, pcm179x_of_match); >> > >> > static const struct i2c_device_id pcm179x_i2c_ids[] = { >> > - { "pcm179x", 0 }, >> > + { "pcm179x", PCM179X }, >> >> And also this addition. >> >> > + { "pcm1789", PCM1789 }, >> > { } >> > }; >> > MODULE_DEVICE_TABLE(i2c, pcm179x_i2c_ids); >> > diff --git a/sound/soc/codecs/pcm179x.c b/sound/soc/codecs/pcm179x.c >> > index 4b311c06f97d..81cbf09319f6 100644 >> > --- a/sound/soc/codecs/pcm179x.c >> > +++ b/sound/soc/codecs/pcm179x.c >> > @@ -218,7 +218,8 @@ static const struct snd_soc_component_driver soc_component_dev_pcm179x = { >> > .non_legacy_dai_naming = 1, >> > }; >> > >> > -int pcm179x_common_init(struct device *dev, struct regmap *regmap) >> > +int pcm179x_common_init(struct device *dev, struct regmap *regmap, >> > + enum pcm17xx_type type) >> >> And this done. >> >> > { >> > struct pcm179x_private *pcm179x; >> > >> > diff --git a/sound/soc/codecs/pcm179x.h b/sound/soc/codecs/pcm179x.h >> > index cf8681c9a373..8c08689e3b8b 100644 >> > --- a/sound/soc/codecs/pcm179x.h >> > +++ b/sound/soc/codecs/pcm179x.h >> > @@ -17,11 +17,17 @@ >> > #ifndef __PCM179X_H__ >> > #define __PCM179X_H__ >> > >> > +enum pcm17xx_type { >> > + PCM179X, >> >> And this one. >> >> > + PCM1789, >> > +}; >> > + >> > #define PCM1792A_FORMATS (SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_S24_LE | \ >> > SNDRV_PCM_FMTBIT_S16_LE) >> > >> > extern const struct regmap_config pcm179x_regmap_config; >> > >> > -int pcm179x_common_init(struct device *dev, struct regmap *regmap); >> > +int pcm179x_common_init(struct device *dev, struct regmap *regmap, >> > + enum pcm17xx_type type); >> >> And this one. Just as a "preparation patch" to support multiple codecs >> in the existing pcm179x.c driver. >> >> Thanks! >> >> Thomas > > Thanks, > > Mylène > > -- > Mylène Josserand, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > http://bootlin.com > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Nazzareno Trimarchi Subject: Re: [PATCH v1 1/4] ASoC: codecs: pcm179x: Add PCM1789 id Date: Thu, 1 Mar 2018 10:04:11 +0100 Message-ID: References: <20180227212433.2189-1-mylene.josserand@bootlin.com> <20180227212433.2189-2-mylene.josserand@bootlin.com> <20180227225140.6f9902b8@windsurf.lan> <20180301084315.0811f712@dell-desktop.home> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180301084315.0811f712@dell-desktop.home> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: =?UTF-8?Q?Myl=C3=A8ne_Josserand?= Cc: Mark Rutland , devicetree@vger.kernel.org, Linux-ALSA , Liam Girdwood , Mark Brown , Takashi Iwai , alexandre.belloni@bootlin.com, LKML , Rob Herring , Thomas Petazzoni List-Id: devicetree@vger.kernel.org SGkKCk9uIFRodSwgTWFyIDEsIDIwMTggYXQgODo0MyBBTSwgTXlsw6huZSBKb3NzZXJhbmQKPG15 bGVuZS5qb3NzZXJhbmRAYm9vdGxpbi5jb20+IHdyb3RlOgo+IEhlbGxvLAo+Cj4gVGhhbmsgeW91 IGZvciB0aGUgcmV2aWV3Lgo+Cj4gT24gVHVlLCAyNyBGZWIgMjAxOCAyMjo1MTo0MCArMDEwMAo+ IFRob21hcyBQZXRhenpvbmkgPHRob21hcy5wZXRhenpvbmlAYm9vdGxpbi5jb20+IHdyb3RlOgo+ Cj4+IEhlbGxvLAo+Pgo+PiBPbiBUdWUsIDI3IEZlYiAyMDE4IDIyOjI0OjMwICswMTAwLCBNeWzD qG5lIEpvc3NlcmFuZCB3cm90ZToKPj4gPiBUbyBwcmVwYXJlIHRoZSBzdXBwb3J0IGZvciB0aGUg UENNMTc4OSwgYWRkIGEgbmV3IGNvbXBhdGlibGUKPj4gPiBhbmQgdXNlIHRoZSBpMmNfaWQgdG8g aGFuZGxlLCBsYXRlciwgdGhlIGRpZmZlcmVuY2VzIGJldHdlZW4KPj4gPiB0aGVzZSB0d28gREFD cyBldmVuIGlmIHRoZXkgYXJlIHByZXR0eSBzaW1pbGFyLgo+PiA+Cj4+ID4gU2lnbmVkLW9mZi1i eTogTXlsw6huZSBKb3NzZXJhbmQgPG15bGVuZS5qb3NzZXJhbmRAYm9vdGxpbi5jb20+Cj4+ID4g LS0tCj4+ID4gIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9zb3VuZC9wY20xNzl4 LnR4dCB8IDIgKy0KPj4KPj4gVGhlIERUIGJpbmRpbmcgY2hhbmdlIHNob3VsZCBiZSBpbiBhIHNl cGFyYXRlIHBhdGNoLgo+Pgo+PiA+ICBzb3VuZC9zb2MvY29kZWNzL3BjbTE3OXgtaTJjLmMgICAg ICAgICAgICAgICAgICAgICAgfCA2ICsrKystLQo+PiA+ICBzb3VuZC9zb2MvY29kZWNzL3BjbTE3 OXguYyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAzICsrLQo+PiA+ICBzb3VuZC9zb2MvY29k ZWNzL3BjbTE3OXguaCAgICAgICAgICAgICAgICAgICAgICAgICAgfCA4ICsrKysrKystCj4+Cj4+ IEFuZCB0aGlzIHNob3VsZCBiZSB0b2dldGhlciB3aXRoIHRoZSBQQ00xNzg5IHN1cHBvcnQgcGF0 Y2guIE90aGVyd2lzZQo+PiB5b3VyIHNlcmllcyBpcyBub3QgYmlzZWN0YWJsZTogaWYgd2UgYXBw bHkgb25seSBQQVRDSCAxLzQsIHRoZSBkcml2ZXIKPj4gc3VwcG9ydHMgdGhlIG5ldyBjb21wYXRp YmxlIHN0cmluZywgYnV0IGl0IGRvZXNuJ3QgaGF2ZSB0aGUgYWN0dWFsIGNvZGUKPj4gdG8gaGFu ZGxlIFBDTTE3ODkuIEFtIEkgbWlzc2luZyBzb21ldGhpbmcgaGVyZSA/Cj4KPiBObywgeW91IGFy ZSByaWdodCwgSSB3aWxsIG1lcmdlIGl0IHdpdGggcGF0Y2ggMDIuCj4KCkNhbiB5b3UgcGxlYXNl IGluY2x1ZGUgbWUgaW4gbmV4dCBzZXJpZXM/CgpJIGhhdmUgc2V2ZXJhbCBoYXJkd2FyZSBydW5u aW5nIG9uIHBjbTE3OXggZmFtaWx5CgpNaWNoYWVsCgo+Pgo+PiA+IC0gICByZXR1cm4gcGNtMTc5 eF9jb21tb25faW5pdCgmY2xpZW50LT5kZXYsIHJlZ21hcCk7Cj4+ID4gKyAgIHJldHVybiBwY20x Nzl4X2NvbW1vbl9pbml0KCZjbGllbnQtPmRldiwgcmVnbWFwLCBpZC0+ZHJpdmVyX2RhdGEpOwo+ Pgo+PiBUaGlzIGNhbiBiZSBkb25lIGluIGEgcHJlcGFyYXRpb24gcGF0Y2guCj4+Cj4+ID4gIH0K Pj4gPgo+PiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBwY20xNzl4X29mX21h dGNoW10gPSB7Cj4+ID4gICAgIHsgLmNvbXBhdGlibGUgPSAidGkscGNtMTc5MmEiLCB9LAo+PiA+ ICsgICB7IC5jb21wYXRpYmxlID0gInRpLHBjbTE3ODkiLCB9LAo+PiA+ICAgICB7IH0KPj4gPiAg fTsKPj4gPiAgTU9EVUxFX0RFVklDRV9UQUJMRShvZiwgcGNtMTc5eF9vZl9tYXRjaCk7Cj4+ID4K Pj4gPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBpMmNfZGV2aWNlX2lkIHBjbTE3OXhfaTJjX2lkc1td ID0gewo+PiA+IC0gICB7ICJwY20xNzl4IiwgMCB9LAo+PiA+ICsgICB7ICJwY20xNzl4IiwgUENN MTc5WCB9LAo+Pgo+PiBBbmQgYWxzbyB0aGlzIGFkZGl0aW9uLgo+Pgo+PiA+ICsgICB7ICJwY20x Nzg5IiwgUENNMTc4OSB9LAo+PiA+ICAgICB7IH0KPj4gPiAgfTsKPj4gPiAgTU9EVUxFX0RFVklD RV9UQUJMRShpMmMsIHBjbTE3OXhfaTJjX2lkcyk7Cj4+ID4gZGlmZiAtLWdpdCBhL3NvdW5kL3Nv Yy9jb2RlY3MvcGNtMTc5eC5jIGIvc291bmQvc29jL2NvZGVjcy9wY20xNzl4LmMKPj4gPiBpbmRl eCA0YjMxMWMwNmY5N2QuLjgxY2JmMDkzMTlmNiAxMDA2NDQKPj4gPiAtLS0gYS9zb3VuZC9zb2Mv Y29kZWNzL3BjbTE3OXguYwo+PiA+ICsrKyBiL3NvdW5kL3NvYy9jb2RlY3MvcGNtMTc5eC5jCj4+ ID4gQEAgLTIxOCw3ICsyMTgsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IHNuZF9zb2NfY29tcG9u ZW50X2RyaXZlciBzb2NfY29tcG9uZW50X2Rldl9wY20xNzl4ID0gewo+PiA+ICAgICAubm9uX2xl Z2FjeV9kYWlfbmFtaW5nICA9IDEsCj4+ID4gIH07Cj4+ID4KPj4gPiAtaW50IHBjbTE3OXhfY29t bW9uX2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgcmVnbWFwICpyZWdtYXApCj4+ID4g K2ludCBwY20xNzl4X2NvbW1vbl9pbml0KHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0IHJlZ21h cCAqcmVnbWFwLAo+PiA+ICsgICAgICAgICAgICAgICAgICAgZW51bSBwY20xN3h4X3R5cGUgdHlw ZSkKPj4KPj4gQW5kIHRoaXMgZG9uZS4KPj4KPj4gPiAgewo+PiA+ICAgICBzdHJ1Y3QgcGNtMTc5 eF9wcml2YXRlICpwY20xNzl4Owo+PiA+Cj4+ID4gZGlmZiAtLWdpdCBhL3NvdW5kL3NvYy9jb2Rl Y3MvcGNtMTc5eC5oIGIvc291bmQvc29jL2NvZGVjcy9wY20xNzl4LmgKPj4gPiBpbmRleCBjZjg2 ODFjOWEzNzMuLjhjMDg2ODllM2I4YiAxMDA2NDQKPj4gPiAtLS0gYS9zb3VuZC9zb2MvY29kZWNz L3BjbTE3OXguaAo+PiA+ICsrKyBiL3NvdW5kL3NvYy9jb2RlY3MvcGNtMTc5eC5oCj4+ID4gQEAg LTE3LDExICsxNywxNyBAQAo+PiA+ICAjaWZuZGVmIF9fUENNMTc5WF9IX18KPj4gPiAgI2RlZmlu ZSBfX1BDTTE3OVhfSF9fCj4+ID4KPj4gPiArZW51bSBwY20xN3h4X3R5cGUgewo+PiA+ICsgICBQ Q00xNzlYLAo+Pgo+PiBBbmQgdGhpcyBvbmUuCj4+Cj4+ID4gKyAgIFBDTTE3ODksCj4+ID4gK307 Cj4+ID4gKwo+PiA+ICAjZGVmaW5lIFBDTTE3OTJBX0ZPUk1BVFMgKFNORFJWX1BDTV9GTVRCSVRf UzMyX0xFIHwgU05EUlZfUENNX0ZNVEJJVF9TMjRfTEUgfCBcCj4+ID4gICAgICAgICAgICAgICAg ICAgICAgIFNORFJWX1BDTV9GTVRCSVRfUzE2X0xFKQo+PiA+Cj4+ID4gIGV4dGVybiBjb25zdCBz dHJ1Y3QgcmVnbWFwX2NvbmZpZyBwY20xNzl4X3JlZ21hcF9jb25maWc7Cj4+ID4KPj4gPiAtaW50 IHBjbTE3OXhfY29tbW9uX2luaXQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgcmVnbWFwICpy ZWdtYXApOwo+PiA+ICtpbnQgcGNtMTc5eF9jb21tb25faW5pdChzdHJ1Y3QgZGV2aWNlICpkZXYs IHN0cnVjdCByZWdtYXAgKnJlZ21hcCwKPj4gPiArICAgICAgICAgICAgICAgICAgIGVudW0gcGNt MTd4eF90eXBlIHR5cGUpOwo+Pgo+PiBBbmQgdGhpcyBvbmUuIEp1c3QgYXMgYSAicHJlcGFyYXRp b24gcGF0Y2giIHRvIHN1cHBvcnQgbXVsdGlwbGUgY29kZWNzCj4+IGluIHRoZSBleGlzdGluZyBw Y20xNzl4LmMgZHJpdmVyLgo+Pgo+PiBUaGFua3MhCj4+Cj4+IFRob21hcwo+Cj4gVGhhbmtzLAo+ Cj4gTXlsw6huZQo+Cj4gLS0KPiBNeWzDqG5lIEpvc3NlcmFuZCwgQm9vdGxpbiAoZm9ybWVybHkg RnJlZSBFbGVjdHJvbnMpCj4gRW1iZWRkZWQgTGludXggYW5kIEtlcm5lbCBlbmdpbmVlcmluZwo+ IGh0dHA6Ly9ib290bGluLmNvbQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gQWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBBbHNhLWRldmVsQGFsc2Et cHJvamVjdC5vcmcKPiBodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8vYWxzYS1kZXZlbAoKCgotLSAKfCBNaWNoYWVsIE5henphcmVubyBUcmltYXJjaGkgICAg ICAgICAgICAgICAgICAgICBBbWFydWxhIFNvbHV0aW9ucyBCViB8CnwgQ09PICAtICBGb3VuZGVy ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBDcnVxdWl1c2thZGUgNDcgfAp8 ICszMSgwKTg1MTExOTE3MiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEFtc3RlcmRh bSAxMDE4IEFNIE5MIHwKfCAgICAgICAgICAgICAgICAgIFtgYXNdIGh0dHA6Ly93d3cuYW1hcnVs YXNvbHV0aW9ucy5jb20gICAgICAgICAgICAgICB8Cl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxA YWxzYS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4v bGlzdGluZm8vYWxzYS1kZXZlbAo=