Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description

From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: mikhail.kshevetskiy@iopsys.eu, Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de,
	 Dario Binacchi <dario.binacchi@amarulasolutions.com>,
	Stefan Roese <sr@denx.de>,
	agnau@iopsys.eu
Subject: Re: [PATCH 1/7] mtd: replace name of 'rfree' field with 'free' in struct mtd_ooblayout_ops to better match it's description
Date: Fri, 7 Oct 2022 16:01:38 +0200	[thread overview]
Message-ID: <CAOf5uw=A6Jh9VbiOeaqh3c_EC0gE1ZjSj3L39Mite4XnaV7_xw@mail.gmail.com> (raw)
In-Reply-To: <CAOf5uwm77ZM1rxZq9ub50KzQoi2Z42QVS5xTuPL_5-Qm-GuB=g@mail.gmail.com>

Hi Fabio

If you send the change of the comment, I will queue it

Michael

On Fri, Oct 7, 2022 at 1:59 PM Michael Nazzareno Trimarchi
<michael@amarulasolutions.com> wrote:
>
> Hi
>
> On Fri, Oct 7, 2022 at 1:58 PM Fabio Estevam <festevam@gmail.com> wrote:
> >
> > On Fri, Oct 7, 2022 at 8:34 AM Michael Nazzareno Trimarchi
> > <michael@amarulasolutions.com> wrote:
> >
> > > About this change, there was a commit from Simon 8d38a8459b0
> > > that was renamed. You ask basically to revert it
> >
> > Correct, what about fixing it like this?
> >
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index ff635bd716..09f5269887 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -122,7 +122,7 @@ struct mtd_oob_region {
> >   * @ecc: function returning an ECC region in the OOB area.
> >   *      Should return -ERANGE if %section exceeds the total number of
> >   *      ECC sections.
> > - * @free: function returning a free region in the OOB area.
> > + * @rfree: function returning a free region in the OOB area.
> >   *       Should return -ERANGE if %section exceeds the total number of
> >   *       free sections.
> >   */
>
> That's is anyway a fix
>
> Michael
>
>
> --
> Michael Nazzareno Trimarchi
> Co-Founder & Chief Executive Officer
> M. +39 347 913 2170
> michael@amarulasolutions.com
> __________________________________
>
> Amarula Solutions BV
> Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
> T. +31 (0)85 111 9172
> info@amarulasolutions.com
> www.amarulasolutions.com


-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com