From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C17AC77B76 for ; Tue, 18 Apr 2023 13:50:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 070B286085; Tue, 18 Apr 2023 15:48:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="Id4jv448"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0524E86085; Tue, 18 Apr 2023 15:48:46 +0200 (CEST) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B07128606F for ; Tue, 18 Apr 2023 15:48:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@amarulasolutions.com Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-506bf1461d7so330965a12.3 for ; Tue, 18 Apr 2023 06:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1681825723; x=1684417723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fBMFuV5OptCay2p4VdutZV2ZJ+uA2cuymu5CGVUd/TI=; b=Id4jv448dNi6WHGsJYgBcGzuMBWqHu5y14wnP1896DVk0ZnXHC2EJwzsVraTelLuFW 8RMzaPg73u4AdBxI1c87Xss/eIVii6ReUfaiAnGxv3fj/0c9HU9OJV4J06pzD7d4jO0U GyV8i35BRSRwB5DOgEyduzIL8rN+aum9EtZrg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681825723; x=1684417723; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fBMFuV5OptCay2p4VdutZV2ZJ+uA2cuymu5CGVUd/TI=; b=ictW1dXYKK5yJA2AtOHn/KK49YvtDz4bTFoQrQeyoKKbunOkMz5EcVZTxCf+rJvBOq xgv+HWewyQlDWMB6vCVDZXTnYEM1mMeKvXX+0kuOjFCwPW46aKl8ow1ra1v/0Jz7xVGd 3noVxWPWvn3kWrwHNNmhim0SrJcQOzS/hm8me2xN60iRdEWjFDvYNnYonYv6MI3aVqkw oXSI8hrJ+lnYAj3HqcaX17HwK7mn20b3FRz1dazG/aEizKiBKlyOylD1TmIuNVZwOxJB 4aqu+GJYHRy8Lss1MQKyK6K7wIL/rRT6u6pWWNFZOPwLuxVDYTN4JvDffHPeQJudMgpw ksWg== X-Gm-Message-State: AAQBX9fxX728mXwajbFrAUz45iZvbjtL0DPwn3opvinAQR0pYm5aVOXy LJFeIOmkqraGu4bRr/Oox0M4UOOE15LTdpLJLty/Rw== X-Google-Smtp-Source: AKy350Z4VhoUQwORiejXVN44hqWZTGjkxV1ApJxA0cabqUodxsJBNO2fphKTkg8defflqYpu5lTHx0cnwNgNIvIPknU= X-Received: by 2002:a50:fb0a:0:b0:4fc:c6fe:1d3a with SMTP id d10-20020a50fb0a000000b004fcc6fe1d3amr2455646edq.22.1681825723053; Tue, 18 Apr 2023 06:48:43 -0700 (PDT) MIME-Version: 1.0 References: <20230110115843.391630-1-frieder@fris.de> In-Reply-To: From: Michael Nazzareno Trimarchi Date: Tue, 18 Apr 2023 15:48:32 +0200 Message-ID: Subject: Re: [PATCH 1/5] mtd/spinand: rework detect procedure for different READ_ID operation To: Frieder Schrempf Cc: Dario Binacchi , Frieder Schrempf , u-boot@lists.denx.de, Jagan Teki , Mikhail Kshevetskiy , Miquel Raynal , Simon Glass , Stefan Roese , Tom Rini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Frieder On Tue, Apr 18, 2023 at 3:46=E2=80=AFPM Frieder Schrempf wrote: > > Hi Michael, Dario, > > On 28.03.23 09:57, Frieder Schrempf wrote: > > Hi Michael, > > > > On 10.02.23 12:57, Michael Nazzareno Trimarchi wrote: > >> Hi > >> > >> I will review > >> > >> On Thu, Feb 9, 2023 at 5:52 PM Tom Rini wrote: > >>> > >>> On Thu, Feb 09, 2023 at 10:24:47AM +0100, Frieder Schrempf wrote: > >>>> Hi, > >>>> > >>>> On 10.01.23 12:58, Frieder Schrempf wrote: > >>>>> From: Mikhail Kshevetskiy > >>>>> > >>>>> Currently there are 3 different variants of read_id implementation: > >>>>> 1. opcode only. Found in GD5FxGQ4xF. > >>>>> 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > >>>>> 3. opcode + 1 dummy byte. Found in other currently supported chips. > >>>>> > >>>>> Original implementation was for variant 1 and let detect function > >>>>> of chips with variant 2 and 3 to ignore the first byte. This isn't > >>>>> robust: > >>>>> > >>>>> 1. For chips of variant 2, if SPI master doesn't keep MOSI low > >>>>> during read, chip will get a random id offset, and the entire id > >>>>> buffer will shift by that offset, causing detect failure. > >>>>> > >>>>> 2. For chips of variant 1, if it happens to get a devid that equals > >>>>> to manufacture id of variant 2 or 3 chips, it'll get incorrectly > >>>>> detected. > >>>>> > >>>>> This patch reworks detect procedure to address problems above. New > >>>>> logic do detection for all variants separatedly, in 1-2-3 order. > >>>>> Since all current detect methods do exactly the same id matching > >>>>> procedure, unify them into core.c and remove detect method from > >>>>> manufacture_ops. > >>>>> > >>>>> This is a rework of Chuanhong Guo patch > >>>>> submitted to linux kernel > >>>>> > >>>>> Signed-off-by: Mikhail Kshevetskiy > >>>>> Signed-off-by: Frieder Schrempf > >>>> > >>>> +Cc: Jagan, Tom > >>>> > >>>> Who is supposed to pick up these patches? Some of them have been aro= und > >>>> for some months (before I resent them). > >>>> > >>>> There is no maintainer for drivers/mtd/spinand/ and no maintainer fo= r > >>>> drivers/mtd/ in general. > >>>> > >>>> In Patchwork Jagan got assigned, but the get_maintainer.pl script di= dn't > >>>> even add him to Cc, of course. > >>>> > >>>> Any ideas how to proceed? > >>> > >>> We don't have anyone dedicated to that area, yes, sadly. I've added > >>> Michael and Dario as they've also been doing mtd-but-not-spi work of > >>> late to see if they're interested. Or since you've long been working > >>> here, would you like to more formally maintain the area? Thanks! > >> > >> They can come from our tree. I will try to sort out all my duties week= ed > > > > Any news regarding reviewing/picking these patches? > > Ping! > > Can you please apply these patches, that have been waiting for so long? > > Thanks > Frieder Yes, waiting for Jagan, please way 1 day more Michael