From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39615C636CD for ; Fri, 10 Feb 2023 11:58:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B56B485F84; Fri, 10 Feb 2023 12:58:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="XF1fga8n"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 251FA85FA4; Fri, 10 Feb 2023 12:58:14 +0100 (CET) Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5DE6985F84 for ; Fri, 10 Feb 2023 12:58:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@amarulasolutions.com Received: by mail-ed1-x534.google.com with SMTP id eq11so4548837edb.6 for ; Fri, 10 Feb 2023 03:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nk8aC7NVUL63xYFPzQ1aTRlGw6oCp9y7WYiBrYbW9aE=; b=XF1fga8n6MD+8DXokfC4e71bLhqtVLSMci2SuY6eOWxfv9fa81jw1wsIEi8tdea0y3 vvXLBcZxohfU2QyrkpPPHUkUkUTP2wRKPWqGjKL9C1zSWtJ/SQZHQklzUKikxRxfQcSc L3AOpmIvi5V6N0p8DzQB8M6DLIjVQ/a8Zqg7A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nk8aC7NVUL63xYFPzQ1aTRlGw6oCp9y7WYiBrYbW9aE=; b=tUQXymi0jU1+qjscAUy+hA04ZoBmNhT06HJKryStSypemYb1h4RWoYCr8VRhbKt1je 7NLSgSKCnpFXJzLjVpCybnncAhtsijoCCxz8keInnbu6pudDtQHHuaRhq4MvAEv6DseQ OQilqbGmpbNy/f0S5DQ9Eltua8s06Y8OXKKiYKkydM9gbho9efb5lfEsSx7BIkX7NuMm YMUNfDxohSgV15krK1OkaXu0DjOzGrSuDCwM+j5m+iKcUWRai5V26zz/YmDIGBRyt/yG OXhjNLAhHxLg66hkkflFc9liYtiHr//FCfFqCK83bugySBRRJZftZ0W58hHsLR2c4N+7 5wjw== X-Gm-Message-State: AO0yUKWqYY3HbngOJaxpQ8j9XK+CPdCLOsw19oB7N0qbSx26gQ9Gw/pW YWrBBL8wdP6URPZyqaF5BaGZI5btbVyUHQQQ0k7QjQ== X-Google-Smtp-Source: AK7set+Ms9lRcVUOTCmA0Ys71hrIN+d3x8x6K6KSN+FKl6UYWOdb/lBpk/ipzOOy+DuF9jZZttienVIa9gsdSIMj9/E= X-Received: by 2002:a05:6402:50d:b0:4a3:43a2:f408 with SMTP id m13-20020a056402050d00b004a343a2f408mr2700244edv.1.1676030281914; Fri, 10 Feb 2023 03:58:01 -0800 (PST) MIME-Version: 1.0 References: <20230110115843.391630-1-frieder@fris.de> In-Reply-To: From: Michael Nazzareno Trimarchi Date: Fri, 10 Feb 2023 12:57:50 +0100 Message-ID: Subject: Re: [PATCH 1/5] mtd/spinand: rework detect procedure for different READ_ID operation To: Tom Rini Cc: Frieder Schrempf , Frieder Schrempf , u-boot@lists.denx.de, Jagan Teki , Mikhail Kshevetskiy , Miquel Raynal , Simon Glass , Stefan Roese , Dario Binacchi Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi I will review On Thu, Feb 9, 2023 at 5:52 PM Tom Rini wrote: > > On Thu, Feb 09, 2023 at 10:24:47AM +0100, Frieder Schrempf wrote: > > Hi, > > > > On 10.01.23 12:58, Frieder Schrempf wrote: > > > From: Mikhail Kshevetskiy > > > > > > Currently there are 3 different variants of read_id implementation: > > > 1. opcode only. Found in GD5FxGQ4xF. > > > 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > > > 3. opcode + 1 dummy byte. Found in other currently supported chips. > > > > > > Original implementation was for variant 1 and let detect function > > > of chips with variant 2 and 3 to ignore the first byte. This isn't > > > robust: > > > > > > 1. For chips of variant 2, if SPI master doesn't keep MOSI low > > > during read, chip will get a random id offset, and the entire id > > > buffer will shift by that offset, causing detect failure. > > > > > > 2. For chips of variant 1, if it happens to get a devid that equals > > > to manufacture id of variant 2 or 3 chips, it'll get incorrectly > > > detected. > > > > > > This patch reworks detect procedure to address problems above. New > > > logic do detection for all variants separatedly, in 1-2-3 order. > > > Since all current detect methods do exactly the same id matching > > > procedure, unify them into core.c and remove detect method from > > > manufacture_ops. > > > > > > This is a rework of Chuanhong Guo patch > > > submitted to linux kernel > > > > > > Signed-off-by: Mikhail Kshevetskiy > > > Signed-off-by: Frieder Schrempf > > > > +Cc: Jagan, Tom > > > > Who is supposed to pick up these patches? Some of them have been around > > for some months (before I resent them). > > > > There is no maintainer for drivers/mtd/spinand/ and no maintainer for > > drivers/mtd/ in general. > > > > In Patchwork Jagan got assigned, but the get_maintainer.pl script didn't > > even add him to Cc, of course. > > > > Any ideas how to proceed? > > We don't have anyone dedicated to that area, yes, sadly. I've added > Michael and Dario as they've also been doing mtd-but-not-spi work of > late to see if they're interested. Or since you've long been working > here, would you like to more formally maintain the area? Thanks! They can come from our tree. I will try to sort out all my duties weeked Michael > > -- > Tom -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com