Re: [PATCH 2/2] imx8mn/8mp: Select ENV_IS_NOWHERE

[Michael Nazzareno Trimarchi <michael@amarulasolutions.com>]

Hi Fabio

On Thu, Apr 21, 2022 at 6:19 PM Fabio Estevam <festevam@denx.de> wrote:
>
> Hi Michael,
>
> On 21/04/2022 11:34, Michael Nazzareno Trimarchi wrote:
>
> > You need only add USB_ case in MMC and NAND
> > #ifdef CONFIG_ENV_IS_IN_NAND
> >         /* add */
> >         case USB_BOOT:
> >         case NAND_BOOT:
> >                 env_loc = ENVL_NAND;
> >                 break;
> > #endif
> > #ifdef CONFIG_ENV_IS_IN_MMC
> >         /* add */
> >         case USB_BOOT:
> >         case SD1_BOOT:
> >         case SD2_BOOT:
> >         case SD3_BOOT:
> >         case MMC1_BOOT:
> >         case MMC2_BOOT:
> >         case MMC3_BOOT:
> >                 env_loc =  ENVL_MMC;
> >                 break;
> > #endif
>
> Your suggestion works, thanks.
>
> I will prepare v2.

That function should drop. There is not other architecture that does
it. What about:

register_enviroment_hook()
deregister_enviroment_hook()

This can replace the one default with board/arch etc

Michael

>
> Thanks,
>
> Fabio Estevam
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-60 Fax: (+49)-8142-66989-80 Email:
> festevam@denx.de



-- 
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@amarulasolutions.com
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@amarulasolutions.com
www.amarulasolutions.com