From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760395AbbKTPEi (ORCPT ); Fri, 20 Nov 2015 10:04:38 -0500 Received: from mail-io0-f175.google.com ([209.85.223.175]:33015 "EHLO mail-io0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760336AbbKTPEd (ORCPT ); Fri, 20 Nov 2015 10:04:33 -0500 MIME-Version: 1.0 In-Reply-To: <20151120144245.GA12767@rob-hp-laptop> References: <1448014157-36526-1-git-send-email-raphael.poggi@avalun.com> <1448014157-36526-4-git-send-email-raphael.poggi@avalun.com> <20151120144245.GA12767@rob-hp-laptop> Date: Fri, 20 Nov 2015 16:04:32 +0100 Message-ID: Subject: Re: [alsa-devel] [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a From: Michael Trimarchi To: Rob Herring Cc: Raphael Poggi , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , tiwai@suse.com, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Raphael On Fri, Nov 20, 2015 at 3:42 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 11:09:16AM +0100, Raphael Poggi wrote: >> From: Raphael Poggi >> >> Add a binding for specify channel selection. >> >> Signed-off-by: Raphael Poggi >> --- >> Documentation/devicetree/bindings/sound/pcm1792a.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> can you add me in the patch-set? Michael >> diff --git a/Documentation/devicetree/bindings/sound/pcm1792a.txt b/Documentation/devicetree/bindings/sound/pcm1792a.txt >> index 970ba1e..6e87a3a 100644 >> --- a/Documentation/devicetree/bindings/sound/pcm1792a.txt >> +++ b/Documentation/devicetree/bindings/sound/pcm1792a.txt >> @@ -9,10 +9,15 @@ Required properties: >> For required properties on SPI, please consult >> Documentation/devicetree/bindings/spi/spi-bus.txt >> >> +Optional properties: >> +- ti,side: specifie the channel side > > typo > >> + insertion, removal. > > why the line wrap? > > I don't understand what this property is/does. Both the name and > description are a bit terse. > >> + >> Examples: >> >> codec_spi: 1792a@0 { >> compatible = "ti,pcm1792a"; >> spi-max-frequency = <600000>; >> + ti,side = > ^ > missing ; > >> }; >> >> -- >> 2.1.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Subject: Re: [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a Date: Fri, 20 Nov 2015 16:04:32 +0100 Message-ID: References: <1448014157-36526-1-git-send-email-raphael.poggi@avalun.com> <1448014157-36526-4-git-send-email-raphael.poggi@avalun.com> <20151120144245.GA12767@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151120144245.GA12767@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rob Herring Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Raphael Poggi , tiwai@suse.com, LKML List-Id: devicetree@vger.kernel.org Hi Raphael On Fri, Nov 20, 2015 at 3:42 PM, Rob Herring wrote: > On Fri, Nov 20, 2015 at 11:09:16AM +0100, Raphael Poggi wrote: >> From: Raphael Poggi >> >> Add a binding for specify channel selection. >> >> Signed-off-by: Raphael Poggi >> --- >> Documentation/devicetree/bindings/sound/pcm1792a.txt | 5 +++++ >> 1 file changed, 5 insertions(+) >> can you add me in the patch-set? Michael >> diff --git a/Documentation/devicetree/bindings/sound/pcm1792a.txt b/Documentation/devicetree/bindings/sound/pcm1792a.txt >> index 970ba1e..6e87a3a 100644 >> --- a/Documentation/devicetree/bindings/sound/pcm1792a.txt >> +++ b/Documentation/devicetree/bindings/sound/pcm1792a.txt >> @@ -9,10 +9,15 @@ Required properties: >> For required properties on SPI, please consult >> Documentation/devicetree/bindings/spi/spi-bus.txt >> >> +Optional properties: >> +- ti,side: specifie the channel side > > typo > >> + insertion, removal. > > why the line wrap? > > I don't understand what this property is/does. Both the name and > description are a bit terse. > >> + >> Examples: >> >> codec_spi: 1792a@0 { >> compatible = "ti,pcm1792a"; >> spi-max-frequency = <600000>; >> + ti,side = > ^ > missing ; > >> }; >> >> -- >> 2.1.0 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com |