From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: imx: mx25: Remove SION bit in all pin-mux From: Michael Trimarchi Message-Id: Date: Wed, 24 Jan 2018 17:17:51 +0100 To: =?UTF-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= Cc: Fabio Estevam , Fabio Estevam , Peter Chen , U-Boot-Denx , USB list List-ID: SGkKCk9uIFdlZCwgSmFuIDI0LCAyMDE4IGF0IDU6MDMgUE0sIEJlbm/DrnQgVGjDqWJhdWRlYXUg PGJlbm9pdEB3c3lzdGVtLmNvbT4gd3JvdGU6Cj4gT24gMjQvMDEvMjAxOCBhdCAxNjo0MywgTWlj aGFlbCBOYXp6YXJlbm8gVHJpbWFyY2hpIHdyb3RlOgo+PiBPbiBXZWQsIEphbiAyNCwgMjAxOCBh dCA0OjM5IFBNLCBCZW5vw650IFRow6liYXVkZWF1IDxiZW5vaXRAd3N5c3RlbS5jb20+IHdyb3Rl Ogo+Pj4gT24gMjQvMDEvMjAxOCBhdCAxNjozNCwgQmVub8OudCBUaMOpYmF1ZGVhdSB3cm90ZToK Pj4+PiBPbiAyNC8wMS8yMDE4IGF0IDE2OjI2LCBNaWNoYWVsIE5henphcmVubyBUcmltYXJjaGkg d3JvdGU6Cj4+Pj4+IE9uIFdlZCwgSmFuIDI0LCAyMDE4IGF0IDQ6MTQgUE0sIEZhYmlvIEVzdGV2 YW0gPGZlc3RldmFtQGdtYWlsLmNvbT4gd3JvdGU6Cj4+Pj4+PiBPbiBXZWQsIEphbiAyNCwgMjAx OCBhdCAxMjo1NiBQTSwgTWljaGFlbCBUcmltYXJjaGkKPj4+Pj4+IDxtaWNoYWVsQGFtYXJ1bGFz b2x1dGlvbnMuY29tPiB3cm90ZToKPj4+Pj4+PiBTSU9OIGJpdCBzaG91bGQgYmUgdXNlZCBpbiB0 aGUgc2l0dWF0aW9uIHRoYXQgd2UgbmVlZAo+Pj4+Pj4+IHRvIHJlYWQgYmFjayB0aGUgdmFsdWUg b2YgYSBwaW4gYW5kIHNob3VsZCBiZSBzZXQgYnkKPj4+Pj4+PiBkZWZhdWx0Lgo+Pj4+Cj4+Pj4g WW91IHJlbW92ZSB0aGlzIGJpdCBiZWNhdXNlIGl0IHNob3VsZCBiZSBzZXQgYnkgZGVmYXVsdD8g VGhpcyBzZW50ZW5jZSBpcwo+Pj4+IGNvbmZ1c2luZy4KPj4KPj4gRW5nbGlzaCBpcyB3cm9uZyA7 KQo+Pgo+PiBTSU9OIGJpdCBhcyBhIHNwZWNpZmljIHB1cnBvc2UgdG8gcmVhZCBiYWNrIHZhbHVl IHRoYXQgaXMgc2V0IGluCj4+IG91dHB1dC4gWW91IGRvbid0IG5lZWQKPj4gYW5kIGl0J3Mgbm90 IHNldCBpbiBhbnkgZnJlZXNjYWxlIGJvYXJkLiBJZiB5b3UgbmVlZCB0byBzZXQgeW91IG5lZWQK Pj4gdG8gYWRkIHRvIHlvdXIgcGVyaXBoZXJhbC4KPgo+IFVubGVzcyB0aGVyZSBpcyBhIE5FV19Q QURfQ1RSTCgpLWxpa2UgbWVjaGFuaXNtIGZvciBTSU9OLCBhbGwgdGhlc2UgZGVmaW5pdGlvbnMK PiBzaG91bGQgYmUga2VwdCBpbiBpb211eC1teDI1LmggaW4gb3JkZXIgbm90IHRvIHJlZGVmaW5l IHRoZSByZWdpc3RlciBvZmZzZXRzCj4gZXZlcnl3aGVyZS4gQUZBSUssIGFsbCB0aGUgRnJlZXNj YWxlIGJvYXJkcyB1c2UgdGhlIGRlZmluaXRpb25zIGZyb20KPiBpb211eC1teDI1LmggdG9vLgo+ Cj4+IFRoZSBvbmx5IGNhc2UgeW91IG5lZWQgbWF5YmUgaXMgdGhlIGRhdGFbMF0gb2Ygc2RjYXJk Lgo+Cj4gQW5kIGVTREhDIENNRCwgYW5kIEnCskMgcHJvYmFibHkgdG9vLiBZZXQsIHlvdSBhcmUg YWxzbyByZW1vdmluZyBTSU9OIGluIHRoZXNlCj4gY2FzZXMuIEkgaGF2ZSAzIGkuTTI1LWJhc2Vk IGJvYXJkcyB3b3JraW5nIGZpbmUgd2l0aCBTSU9OLiA7KSBDYW4geW91IGV4cGxhaW4KPiB0aGUg cHJlY2lzZSBpc3N1ZSB0aGF0IHlvdSBhcmUgdHJ5aW5nIHRvIGZpeCAod2hpY2ggcGluKT8KPgoK TGV0IG1lIHN1bW1hcml6ZSBmb3IgeW91OgotIHdhcyBoYXZpbmcgYSBib2FyZCB3aXRoIGxpbnV4 IDIuNi54IGFuZCB1Ym9vdCBmcm9tIDIwMDkgd29ya2luZyBmaW5lCm9uIGEgdXNiIHBlbiBkcml2 ZXIgKGxvb2sgb24gdGhyZWFkIGluIGxpbnV4LXVzYikKLSB3YXMgaGF2aW5nIHRoZSBzYW1lIGJv YXJkIHdpdGggYW55IHZlcnNpb24gb2YgbGludXggZnJvbSAzLjE4IHRvCjQuMTUgYW5kIGZhaWwg d2l0aCB0aGlzIHBlbiBkcml2ZQotIGNoZWNrIGJhY2sgYWxsIHRoZSBjaGFuZ2VzIGZyb20gbGlu dXggMi42LnggIHRvIGxpbnV4IDQuMTUueCBhbmQKY29tcGFyZSBldmVyeSBzaW5nbGUgcmVnaXN0 ZXIgYW5kIGFsbCB0aGUgdXNiIGNvZGUgYW5kIHdhcyBqdXN0CmNvbmZpcm0gYSBiZXR0ZXIgaW1w bGVtZW50YXRpb24gb2YgbmV3IGtlcm5lbC4KICBidXQgd2l0aCBhIHJlc3VsdCBvZiBhIHVzYiBz dHVjayBvbiB0aGUgaG9zdCBwb3J0Ci0gc3dhcCB0aGUgYm9vdC1sb2FkZXIgYW5kIGhhdmluZyBh IHdvcmtpbmcgYm9hcmQKLSBnbyBpbiBkZWVwIGluIGJvb3QtbG9hZGVyIGFuZCBjb21wYXJlIGV2 ZXJ5dGhpbmcKLSBVbmRlcnN0YW5kIHRoZSBkaWZmZXJlbmNlIHdhcyB0aGUgU0lPTiBiaXQgdGhh dCB3YXMgZW5hYmxlIG9uIGFsbCB0aGUgbXV4CgpJbiBnZW5lcmFsIHdoZW4gYSBib2FyZCBzdGFy dCBmcm9tIHJlc2V0IGl0IGhhcyBkZWZhdWx0IHBpbiBtdXhpbmcuCkVhY2ggcGVyaXBoZXJhbCBu ZWVkIHRvIHNldHVwIHRoZSBwaW4gbXV4aW5nIGFjY29yZGluZyB0byB0aGUgcmVhbAp1c2FnZS4K U0lPTiBieSBkZWZhdWx0IGlzIG5vdCB0aGUgcmlnaHQgd2F5IHRvIGRvIGl0LiBXaGF0IGlzIHRo ZSBjb25jZXB0IG9mCndvcmtpbmcgYm9hcmQgaW4geW91ciBzaWRlPyBKdXN0IHBhc3MgeW91ciB0 ZXN0Y2FzZT8gT2sgZXZlbiB0aGlzCmJvYXJkCndhcyBwYXNzaW5nIGFsbCB0ZXN0IGNhc2VzIGFw YXJ0IHRoaXMgdXNiIHBlbiBkcml2ZS4gV2Ugd2FzIGhhdmluZyBpbgp0aGUgZmllbGQgc29tZSBj dXN0b21lciB3aXRoIHVzYiBpc3N1ZSB0aW1lIHRvIHRpbWUgYW5kIG9ubHkgdGhpcwpwcm9vZiB0 aGF0IHNvbWVudGhpbmcgd2FzIG5vdCByZWFsIG9rLgoKTWljaGFlbAoKCgo+IEJlc3QgcmVnYXJk cywKPiBCZW5vw650Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Nazzareno Trimarchi Date: Wed, 24 Jan 2018 17:17:51 +0100 Subject: [U-Boot] [PATCH] imx: mx25: Remove SION bit in all pin-mux In-Reply-To: <72f8d88e-5f6d-1412-e790-c53b35e8b100@wsystem.com> References: <1516805770-6712-1-git-send-email-michael@amarulasolutions.com> <66f3fcba-001d-8b82-3e4e-5a4e1c42f9a9@wsystem.com> <72f8d88e-5f6d-1412-e790-c53b35e8b100@wsystem.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: u-boot@lists.denx.de Hi On Wed, Jan 24, 2018 at 5:03 PM, Benoît Thébaudeau wrote: > On 24/01/2018 at 16:43, Michael Nazzareno Trimarchi wrote: >> On Wed, Jan 24, 2018 at 4:39 PM, Benoît Thébaudeau wrote: >>> On 24/01/2018 at 16:34, Benoît Thébaudeau wrote: >>>> On 24/01/2018 at 16:26, Michael Nazzareno Trimarchi wrote: >>>>> On Wed, Jan 24, 2018 at 4:14 PM, Fabio Estevam wrote: >>>>>> On Wed, Jan 24, 2018 at 12:56 PM, Michael Trimarchi >>>>>> wrote: >>>>>>> SION bit should be used in the situation that we need >>>>>>> to read back the value of a pin and should be set by >>>>>>> default. >>>> >>>> You remove this bit because it should be set by default? This sentence is >>>> confusing. >> >> English is wrong ;) >> >> SION bit as a specific purpose to read back value that is set in >> output. You don't need >> and it's not set in any freescale board. If you need to set you need >> to add to your peripheral. > > Unless there is a NEW_PAD_CTRL()-like mechanism for SION, all these definitions > should be kept in iomux-mx25.h in order not to redefine the register offsets > everywhere. AFAIK, all the Freescale boards use the definitions from > iomux-mx25.h too. > >> The only case you need maybe is the data[0] of sdcard. > > And eSDHC CMD, and I²C probably too. Yet, you are also removing SION in these > cases. I have 3 i.M25-based boards working fine with SION. ;) Can you explain > the precise issue that you are trying to fix (which pin)? > Let me summarize for you: - was having a board with linux 2.6.x and uboot from 2009 working fine on a usb pen driver (look on thread in linux-usb) - was having the same board with any version of linux from 3.18 to 4.15 and fail with this pen drive - check back all the changes from linux 2.6.x to linux 4.15.x and compare every single register and all the usb code and was just confirm a better implementation of new kernel. but with a result of a usb stuck on the host port - swap the boot-loader and having a working board - go in deep in boot-loader and compare everything - Understand the difference was the SION bit that was enable on all the mux In general when a board start from reset it has default pin muxing. Each peripheral need to setup the pin muxing according to the real usage. SION by default is not the right way to do it. What is the concept of working board in your side? Just pass your testcase? Ok even this board was passing all test cases apart this usb pen drive. We was having in the field some customer with usb issue time to time and only this proof that somenthing was not real ok. Michael > Best regards, > Benoît -- | Michael Nazzareno Trimarchi Amarula Solutions BV | | COO - Founder Cruquiuskade 47 | | +31(0)851119172 Amsterdam 1018 AM NL | | [`as] http://www.amarulasolutions.com |