From: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/qt5base: fix qmake parallel build
Date: Mon, 22 Apr 2019 19:14:08 +0200 [thread overview]
Message-ID: <CAOf5uwmv=+tLL2g=L+VNa24BG1esHmANm0OgTGDzn2MwBeJKZA@mail.gmail.com> (raw)
In-Reply-To: <20190422095842.61772-1-giulio.benetti@micronovasrl.com>
Hi
On Mon, Apr 22, 2019 at 11:59 AM Giulio Benetti
<giulio.benetti@micronovasrl.com> wrote:
>
> When configuring qt5base, qmake is built, but it's not built in parallel
> mode. This is due to MAKEFLAGS having 2 dashes on its tail, so this:
> MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)"
> expands in this(i.e. 5 njobs):
> MAKEFLAGS="--no-print-directory -- -j5"
> and -j5 gets ignored due to "--" preceeding -j5.
> Double dashes are part of $(MAKEFLAGS) only when evaluated by shell.
>
> Swap $(MAKEFLAGS) and -j$(PARALLEL_JOBS) to avoid having "--" before
> -j$(PARALLEL_JOBS), this way -j$(PARALLEL_JOBS) won't be ignored by
> ./configure.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
Tested-by: Michael Trimarchi <michael@amarulasolutions.com>
Thank you
Michael
> package/qt5/qt5base/qt5base.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
> index 0b45c50a66..e73b8931aa 100644
> --- a/package/qt5/qt5base/qt5base.mk
> +++ b/package/qt5/qt5base/qt5base.mk
> @@ -324,7 +324,7 @@ define QT5BASE_CONFIGURE_CMDS
> (cd $(@D); \
> $(TARGET_MAKE_ENV) \
> PKG_CONFIG="$(PKG_CONFIG_HOST_BINARY)" \
> - MAKEFLAGS="$(MAKEFLAGS) -j$(PARALLEL_JOBS)" \
> + MAKEFLAGS="-j$(PARALLEL_JOBS) $(MAKEFLAGS)" \
> ./configure \
> -v \
> -prefix /usr \
> --
> 2.17.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
| Michael Nazzareno Trimarchi Amarula Solutions BV |
| COO - Founder Cruquiuskade 47 |
| +31(0)851119172 Amsterdam 1018 AM NL |
| [`as] http://www.amarulasolutions.com |
next prev parent reply other threads:[~2019-04-22 17:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 22:16 [Buildroot] Qt5 parallel build of qmake Arnout Vandecappelle
2019-04-17 22:53 ` Giulio Benetti
2019-04-21 7:08 ` Arnout Vandecappelle
2019-04-21 22:43 ` Giulio Benetti
2019-04-22 7:56 ` Arnout Vandecappelle
2019-04-22 9:46 ` Giulio Benetti
2019-04-22 9:58 ` [Buildroot] [PATCH] package/qt5base: fix qmake parallel build Giulio Benetti
2019-04-22 17:14 ` Michael Nazzareno Trimarchi [this message]
2019-04-22 20:25 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOf5uwmv=+tLL2g=L+VNa24BG1esHmANm0OgTGDzn2MwBeJKZA@mail.gmail.com' \
--to=michael@amarulasolutions.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.