From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F501C433FE for ; Tue, 8 Nov 2022 09:25:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 75CBC84DEB; Tue, 8 Nov 2022 10:25:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="m1lhI6KG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E308484F4D; Tue, 8 Nov 2022 10:25:24 +0100 (CET) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A18AC84F1C for ; Tue, 8 Nov 2022 10:25:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@amarulasolutions.com Received: by mail-ej1-x62f.google.com with SMTP id kt23so36910594ejc.7 for ; Tue, 08 Nov 2022 01:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nbbqjeIoq0d3sV72t4vlgls8HqZKMYY72SU27bm2ijA=; b=m1lhI6KGgl1UMld/jrxCakd+M4c1Mx1ZlFffGsgn7duJTzcvbIwioD4JHFCFNwgis0 MFfmMh1kYRZzTTuA7viKxPiaYNxaYK4TpvVRqPpVFxe/nTG4UuQDCIhFwPVR6JPMlMvA dxaRXpjmVdddSejHKFGV1IpSXfHo7vVYIKgpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nbbqjeIoq0d3sV72t4vlgls8HqZKMYY72SU27bm2ijA=; b=j9JRJvPUJfjNO7ZFzdt3SeUCg3Jr2z2qwkx9ln4QSuT/1bP5J68QQlUF3fYqyvw4L7 0Ei8GBXWBOtFoPf+b/yDliO7tUlzoxwH6PRZksb05rziRKBTPzTlj3SGTBgu/tzxZfpR c+4dJVRBEXasnXXSLpGNvqbXuIOkNKgzUrA2qOGI60sLDHIOqazXbknvMGuQVIkeVpGB aILMrK3/yQESbn5DRiavsc17Fj4GzoAmExNQM82P1wp1ETYZy6dTy36hgPMvPEtmDGbw USoluZkqR4pzSHNMRns8WXTJnjbQvuYOscKPmHw5Cy4fq/oavK3YiCqWCPY2VG5SgcJR 7ZCg== X-Gm-Message-State: ACrzQf0edwD25lNRvS70M1Oyur+Z9ar+3qV/zrZ9P6Fv8Vuv/vGOirJ2 u3024I4ManTLqEq65xMjEZLaYdp3ZaGtYoWsMYfpRA== X-Google-Smtp-Source: AMsMyM66afd1kxdldkHCIuoHrog3cHLu6Z1VvIBsXi2gcvYiKFTKtyXmi8qXxjSo+5V4XzsMDdIyxPIeNsGOiWewPdo= X-Received: by 2002:a17:906:b08d:b0:782:d526:3e36 with SMTP id x13-20020a170906b08d00b00782d5263e36mr51417898ejy.358.1667899521079; Tue, 08 Nov 2022 01:25:21 -0800 (PST) MIME-Version: 1.0 References: <20221108090719.3631621-1-dario.binacchi@amarulasolutions.com> In-Reply-To: <20221108090719.3631621-1-dario.binacchi@amarulasolutions.com> From: Michael Nazzareno Trimarchi Date: Tue, 8 Nov 2022 10:25:09 +0100 Message-ID: Subject: Re: [PATCH] mtd: nand: drop EXPORT_SYMBOL_GPL for nanddev_erase() To: Dario Binacchi Cc: u-boot@lists.denx.de, linux-amarula@amarulasolutions.com, Simon Glass , Stefan Roese Content-Type: text/plain; charset="UTF-8" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Nov 8, 2022 at 10:07 AM Dario Binacchi wrote: > > This function is only used within this module, so it is no longer > necessary to use EXPORT_SYMBOL_GPL(). > > This patch parallels the work done in the following patch: > https://lore.kernel.org/linux-mtd/20221018170205.1733958-1-dario.binacchi@amarulasolutions.com > > Signed-off-by: Dario Binacchi Reviewed-By: Michael Trimarchi > > --- > > drivers/mtd/nand/core.c | 3 +-- > include/linux/mtd/nand.h | 1 - > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/core.c b/drivers/mtd/nand/core.c > index 99c29670c75e..4b9dd6a92694 100644 > --- a/drivers/mtd/nand/core.c > +++ b/drivers/mtd/nand/core.c > @@ -129,7 +129,7 @@ EXPORT_SYMBOL_GPL(nanddev_isreserved); > * > * Return: 0 in case of success, a negative error code otherwise. > */ > -int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos) > +static int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos) > { > unsigned int entry; > > @@ -147,7 +147,6 @@ int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos) > > return nand->ops->erase(nand, pos); > } > -EXPORT_SYMBOL_GPL(nanddev_erase); > > /** > * nanddev_mtd_erase() - Generic mtd->_erase() implementation for NAND devices > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h > index 7774c17ad5d5..aeb38dec2e03 100644 > --- a/include/linux/mtd/nand.h > +++ b/include/linux/mtd/nand.h > @@ -691,7 +691,6 @@ static inline bool nanddev_io_iter_end(struct nand_device *nand, > > bool nanddev_isbad(struct nand_device *nand, const struct nand_pos *pos); > bool nanddev_isreserved(struct nand_device *nand, const struct nand_pos *pos); > -int nanddev_erase(struct nand_device *nand, const struct nand_pos *pos); > int nanddev_markbad(struct nand_device *nand, const struct nand_pos *pos); > > /* BBT related functions */ > -- > 2.32.0 > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com