From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EA1EC77B75 for ; Tue, 18 Apr 2023 18:24:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1A65886155; Tue, 18 Apr 2023 20:24:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="S5JX9JPJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A17B086167; Tue, 18 Apr 2023 20:24:46 +0200 (CEST) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2FB378614F for ; Tue, 18 Apr 2023 20:24:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=michael@amarulasolutions.com Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9514ac7c8cfso79287566b.0 for ; Tue, 18 Apr 2023 11:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1681842283; x=1684434283; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TlsG/aNVP2pAuy/IbrllMlnqmd7VK2oCXdyW0Oy1R3I=; b=S5JX9JPJVuQYqrUTda30Okz15bjP/czmDAfUPO1c5x9KUmJEgdxfl8M3n5vAei56fo EbpOXQLY8vadqEx+HlWsmF12CU8RTaKaorDA5+y0rZIFWFPbgy5MO54ohPuVl6QPUS+w 3UDnhXLJ3sb66EPQOQ6FKUelnvww3GCrmXLZI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681842283; x=1684434283; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TlsG/aNVP2pAuy/IbrllMlnqmd7VK2oCXdyW0Oy1R3I=; b=QLSNgHFHKndxtHkLRZeuvAJYAg7f5ix8ilNIQxfpGIxsaOW8UpWHwK/J0e/FciZGv/ q5kieb5sQunZmrFi60B5h7dOwzw4LfCakaVe0q/7cWoxUIjIDO9mxTbbxD1EzY8VvTAJ pkikLKKQ3Wg3V64r7h7kaCyodgwdwg6pZHcWWF+Y+NtlnqpitoNG7AErNdhwIivrxiPH cfPhwgoqOWQCTzdpy04gMZ/ppITqynD5MMlXF5i6LACyFncieSrxGu6Trgko81latwJF Tu12XtgW2CjFXfZISXWCJDYsKVjWtv8dkPQ4Svql8d0Mzj5avfmUmwYmCFj8UXKyPWhE GKKQ== X-Gm-Message-State: AAQBX9dX1J2BCurqTecBxpYAsNsiDEGWU14Bjlx56XsblA9CJEK7ezGD Qq0tFb58QNeDtfXo5AOxlEn8ZcRQ+Ew+fxDXgCIPzA== X-Google-Smtp-Source: AKy350ayhNXnYlRA0RMiDK8TMzmNUKiT8xq8A/H8txcNn9hef9V/TqjW7nCKJ4jOlBKkiFwBNwepgCxb1sQuNaVKSmE= X-Received: by 2002:aa7:c758:0:b0:506:a192:d739 with SMTP id c24-20020aa7c758000000b00506a192d739mr3044417eds.41.1681842283086; Tue, 18 Apr 2023 11:24:43 -0700 (PDT) MIME-Version: 1.0 References: <20230110115843.391630-1-frieder@fris.de> <5224ad8f-18bc-b55f-c11d-3d9b03924bea@iopsys.eu> In-Reply-To: <5224ad8f-18bc-b55f-c11d-3d9b03924bea@iopsys.eu> From: Michael Nazzareno Trimarchi Date: Tue, 18 Apr 2023 20:24:31 +0200 Message-ID: Subject: Re: [PATCH 1/5] mtd/spinand: rework detect procedure for different READ_ID operation To: Mikhail Kshevetskiy Cc: Frieder Schrempf , Dario Binacchi , Frieder Schrempf , u-boot@lists.denx.de, Jagan Teki , Miquel Raynal , Simon Glass , Stefan Roese , Tom Rini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi On Tue, Apr 18, 2023 at 8:20=E2=80=AFPM Mikhail Kshevetskiy wrote: > > I can try to resend patches (flash drivers synced with linux-6.1). > Unfortunately I am not sure I will be able to do it after changes in our > mail system. I don't think that re-sync now is what we want to do. The idea here is to have easy patch that we can review. We should go for this for now Michael > > Mikhail Kshevetskiy > > On 18.04.2023 16:48, Michael Nazzareno Trimarchi wrote: > > [External email] > > > > > > > > > > > > Hi Frieder > > > > On Tue, Apr 18, 2023 at 3:46=E2=80=AFPM Frieder Schrempf > > wrote: > >> Hi Michael, Dario, > >> > >> On 28.03.23 09:57, Frieder Schrempf wrote: > >>> Hi Michael, > >>> > >>> On 10.02.23 12:57, Michael Nazzareno Trimarchi wrote: > >>>> Hi > >>>> > >>>> I will review > >>>> > >>>> On Thu, Feb 9, 2023 at 5:52 PM Tom Rini wrote: > >>>>> On Thu, Feb 09, 2023 at 10:24:47AM +0100, Frieder Schrempf wrote: > >>>>>> Hi, > >>>>>> > >>>>>> On 10.01.23 12:58, Frieder Schrempf wrote: > >>>>>>> From: Mikhail Kshevetskiy > >>>>>>> > >>>>>>> Currently there are 3 different variants of read_id implementatio= n: > >>>>>>> 1. opcode only. Found in GD5FxGQ4xF. > >>>>>>> 2. opcode + 1 addr byte. Found in GD5GxGQ4xA/E > >>>>>>> 3. opcode + 1 dummy byte. Found in other currently supported chip= s. > >>>>>>> > >>>>>>> Original implementation was for variant 1 and let detect function > >>>>>>> of chips with variant 2 and 3 to ignore the first byte. This isn'= t > >>>>>>> robust: > >>>>>>> > >>>>>>> 1. For chips of variant 2, if SPI master doesn't keep MOSI low > >>>>>>> during read, chip will get a random id offset, and the entire id > >>>>>>> buffer will shift by that offset, causing detect failure. > >>>>>>> > >>>>>>> 2. For chips of variant 1, if it happens to get a devid that equa= ls > >>>>>>> to manufacture id of variant 2 or 3 chips, it'll get incorrectly > >>>>>>> detected. > >>>>>>> > >>>>>>> This patch reworks detect procedure to address problems above. Ne= w > >>>>>>> logic do detection for all variants separatedly, in 1-2-3 order. > >>>>>>> Since all current detect methods do exactly the same id matching > >>>>>>> procedure, unify them into core.c and remove detect method from > >>>>>>> manufacture_ops. > >>>>>>> > >>>>>>> This is a rework of Chuanhong Guo patch > >>>>>>> submitted to linux kernel > >>>>>>> > >>>>>>> Signed-off-by: Mikhail Kshevetskiy > >>>>>>> Signed-off-by: Frieder Schrempf > >>>>>> +Cc: Jagan, Tom > >>>>>> > >>>>>> Who is supposed to pick up these patches? Some of them have been a= round > >>>>>> for some months (before I resent them). > >>>>>> > >>>>>> There is no maintainer for drivers/mtd/spinand/ and no maintainer = for > >>>>>> drivers/mtd/ in general. > >>>>>> > >>>>>> In Patchwork Jagan got assigned, but the get_maintainer.pl script = didn't > >>>>>> even add him to Cc, of course. > >>>>>> > >>>>>> Any ideas how to proceed? > >>>>> We don't have anyone dedicated to that area, yes, sadly. I've added > >>>>> Michael and Dario as they've also been doing mtd-but-not-spi work o= f > >>>>> late to see if they're interested. Or since you've long been workin= g > >>>>> here, would you like to more formally maintain the area? Thanks! > >>>> They can come from our tree. I will try to sort out all my duties we= eked > >>> Any news regarding reviewing/picking these patches? > >> Ping! > >> > >> Can you please apply these patches, that have been waiting for so long= ? > >> > >> Thanks > >> Frieder > > Yes, waiting for Jagan, please way 1 day more > > > > Michael --=20 Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 michael@amarulasolutions.com __________________________________ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 info@amarulasolutions.com www.amarulasolutions.com